[8u] RFR: 8061777: (zipfs) IllegalArgumentException in ZipCoder.toString when using Shitft_JIS

Severin Gehwolf sgehwolf at redhat.com
Tue Feb 16 16:04:38 UTC 2021


Hi,

Please review this zip fs fix. It's a fix Oracle did to their JDK 8
too. The JDK 11u patch didn't apply cleanly and required some manual
work. Mostly because:

a) The implementation of ZipFileSystem.getPath() is slightly
different in 8u. It uses a local String variable 'path' over
JDK 11's short return approach if more.length == 0. Either way,
changes shoudl be equivalent.
b) ZFSTests.java doesn't have JDK-8153248 changes which is not
in OpenJDK 8u. Also context was different enough for hunks to
not apply cleanly. I've ported them over manually.

Bug: https://bugs.openjdk.java.net/browse/JDK-8061777
webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8061777/01/webrev/

Testing: Added regression test (fails prior; passes after).
 zipfs/java.util.zip tests.

Thoughts?

Thanks,
Severin

 * 



More information about the jdk8u-dev mailing list