[8u] RFR: 8061777: (zipfs) IllegalArgumentException in ZipCoder.toString when using Shitft_JIS

[Severin Gehwolf]

On Wed, 2021-02-17 at 04:00 +0000, Andrew Hughes wrote:
> On 17:04 Tue 16 Feb     , Severin Gehwolf wrote:
> > Hi,
> > 
> > Please review this zip fs fix. It's a fix Oracle did to their JDK 8
> > too. The JDK 11u patch didn't apply cleanly and required some
> > manual
> > work. Mostly because:
> > 
> > a) The implementation of ZipFileSystem.getPath() is slightly
> > different in 8u. It uses a local String variable 'path' over
> > JDK 11's short return approach if more.length == 0. Either way,
> > changes shoudl be equivalent.
> 
> I assume you mean JDK 9's, as that is where the patch is from.

Ah, yes. Thanks!

> The code was changed by JDK-8150496 as an optimisation:
> 
> https://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/b9ed1a4feefb#l3.82

Nice find.

> Please flag for approval.

Thanks for the review! It should be ready for approval now.

Thanks,
Severin