RFR(s): backport of 8031126: java/lang/management/ThreadMXBean/ThreadUserTime.java fails intermittently

Volker Simonis volker.simonis at gmail.com
Mon Jan 11 14:30:20 UTC 2021


Looks good to me and pretty trivial.

Reviewed.

Best regards,
Volker

On Tue, Dec 8, 2020 at 5:02 PM Hohensee, Paul <hohensee at amazon.com> wrote:
>
> Ping. :)
>
> -----Original Message-----
> From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of "Hohensee, Paul" <hohensee at amazon.com>
> Date: Wednesday, November 25, 2020 at 1:43 PM
> To: Andrew Hughes <gnu.andrew at redhat.com>, Andrey Petushkov <andrey at azul.com>, Aleksey Shipilev <shade at redhat.com>
> Cc: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
> Subject: RE: RFR(s): backport of 8031126: java/lang/management/ThreadMXBean/ThreadUserTime.java fails intermittently
>
> I've taken the liberty of re-doing the backport. It's clean except for a context diff at the start of hunk #1.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8031126
> Patch: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/af53a220ea60
> Webrev: http://cr.openjdk.java.net/~phh/8031126/webrev.8u.00/
>
> Thanks,
> Paul
>
> On 2/19/20, 8:45 PM, "jdk8u-dev on behalf of Andrew Hughes" <jdk8u-dev-bounces at openjdk.java.net on behalf of gnu.andrew at redhat.com> wrote:
>
>     On 19/02/2020 13:00, Andrey Petushkov wrote:
>     > Hi Andrew,
>     >
>     > Uploaded webrev at https://cr.openjdk.java.net/~fijiol/8031126/webrev.00/
>     >
>     > Thanks,
>     > Andrey
>     >
>     > On 19.02.2020 07:20, Andrew Hughes wrote:
>     >>
>     >> On 31/07/2019 16:23, Andrey Petushkov wrote:
>     >>> Hi Aleksey,
>     >>>
>     >>> I'll do
>     >>>
>     >>> Thanks,
>     >>> Andrey
>     >>>
>     >>>> On 31 Jul 2019, at 15:54, Aleksey Shipilev <shade at redhat.com> wrote:
>     >>>>
>     >>>> On 7/16/19 7:42 PM, Fedor Burdun wrote:
>     >>>>> The issue described in bugs 8031126/8030631 is still reproducible on java8.
>     >>>>> May I request a backport of the changeset http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/af53a220ea60 to java8?
>     >>>> This makes sense. Is there anyone from Azul to assist you with following this checklist?
>     >>>>  https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix
>     >>>>
>     >>>> Thanks,
>     >>>> -Aleksey
>     >> Is there a webrev for this backport?
>     >>
>     >> Thanks,
>     >
>
>     Thanks.
>
>     Backport looks right, but I think we should probably backport
>     JDK-8036122 first (which includes the changes to proc_stat_path).
>     That should then make this change a clean backport.
>
>     I take a look at this and get back to you.
>
>     Thanks,
>     --
>     Andrew :)
>
>     Senior Free Java Software Engineer
>     Red Hat, Inc. (http://www.redhat.com)
>
>     PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
>     Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
>
>
>


More information about the jdk8u-dev mailing list