[8u] RFR 8242141: New System Properties to configure the TLS signature schemes

[Andrew Hughes]

On 16:57 Mon 18 Jan     , Martin Balao wrote:
> Hi,
> 
> I'd like to propose an 8u backport of JDK-8242141 [1].
> 
> Webrev.00:
> 
>  *
> http://cr.openjdk.java.net/~mbalao/webrevs/8242141/8242141.webrev.8u.jdk.00/
> 
> The 11u backport does not apply cleanly to 8u because of the following
> conflicts:
> 
>  * src/share/classes/sun/security/ssl/CertSignAlgsExtension.java
>   * In 8u, JDK-8245470 [2] was applied changing the context on line 244.
> This was to substitute a List::of call. Manually added shc.sslConfig
> parameter and rearranged the list of parameters to look similar to 11u.
> 
>  * src/share/classes/sun/security/ssl/SSLConfiguration.java
>   * In 8u there is JDK-8245417 [3] which changes the context by adding
> an import. Manually added the import for JDK-8242141.
> 
>  * src/share/classes/sun/security/ssl/SignatureAlgorithmsExtension.java
>   * In 8u, JDK-8245470 [2] was applied changing the context on line 410.
> This was to substitute a List::of call. Manually added shc.sslConfig
> parameter and rearranged the list of parameters to look similar to 11u.
> 
> No regressions found in jdk/sun/security/ssl.
> 
> Once I have a review-approval, I'll create a CSR and ask for maintainers
> approval.
> 
> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.java.net/browse/JDK-8242141
> [2] - https://bugs.openjdk.java.net/browse/JDK-8245470
> [3] - https://bugs.openjdk.java.net/browse/JDK-8245417
> 

This looks fine to me. Thanks for the very detailed account of the changes
for 8u.

I wasn't aware of JDK-8245470 before this. I assume that was part of the
TLSv1.3 forest work?

Please flag for approval.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222