[8u] RFR: 8185934: keytool shows "Signature algorithm: SHA1withECDSA, -1-bit key"

Severin Gehwolf sgehwolf at redhat.com
Thu Jan 21 09:04:21 UTC 2021


On Wed, 2021-01-20 at 17:01 +0000, Andrew Hughes wrote:
> On 11:57 Mon 11 Jan     , Severin Gehwolf wrote:
> > Hi,
> > 
> > I'd like to backport this simple fix to OpenJDK 8u as it simplifies the
> > backport of JDK-8172404 to 8u and the patch at hand is low risk. The
> > JDK 8u patch is the same as the one for JDK 10, except for one context
> > difference in keytool/Resources.java. The reason for this is that JDK-
> > 8191137 got fixed in JDK 10 *after* JDK-8185934 and in JDK 8u it's the
> > other way around. Other than that, the patch is identical. Please
> > review.
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8185934
> > webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8185934/jdk8/01/webrev/
> > 
> > Thoughts?
> > 
> > Thanks,
> > Severin
> > 
> 
> Looks fine (after moving the jarsigner parts of the patch to the end to compare
> with the 11u version).

Thanks for the review!

> Anyway, please flag for approval.

Done now.

Thanks,
Severin



More information about the jdk8u-dev mailing list