[8u] RFR: 8238164: Update Apache Xerces to version 2.12.0

[Andrew Hughes]

On 17:35 Mon 19 Jul     , Elliott Baron wrote:
> Hi,
> 
> I'd like to request a review of 8238164 for 8u for parity with Oracle JDK
> 8u261.
> 
> 8238164 is an 8-only bug, but has an extensive "relates to" list that I used
> as a guide for what to backport. I had considered copying over Xerces 2.12.0
> en masse from JDK 11, but many of the related changes in 8238164 extend
> beyond the Xerces package (e.g. Xalan, XML).
> 
> The chief concern I have with this backport is the lack of unit tests in the
> JAXP repo in 8u. Some of the referenced fixes below include new tests or
> changes to tests that were added in JDK 9 beginning with "8043084: XML JAXP
> unittest co-location".
> 
> I'd also like to note that there are minor changes to
> javax/xml/stream/XMLEventReader and javax/xml/stream/XMLStreamReader. The
> former adds an @Override tag, the other changes are all to documentation.
> I'm not sure if the override tag poses a problem to API compatibility.
> 
> One other minor issue is the @deprecated tag added to Xerces' internal
> serializer. This is not public API, but I was unsure whether to change the
> version from JDK 1.9 to JDK 1.8. I've just left it alone in this initial
> webrev. See:
> com/sun/org/apache/xml/internal/serialize/BaseMarkupSerializer.java.
> 
> The end of this mail contains a detailed list of related fixes mentioned in
> 8238164 that are included in this webrev, along with what modifications I
> made for them to apply to the 8u tree. The list also covers which of related
> fixes are not included in this webrev, and why not.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8238164
> Webrev: https://cr.openjdk.java.net/~ebaron/jdk8u/JDK-8238164/webrev.00/
> 
> Testing: x86_64 build, jdk_tier1, jdk_other (includes javax/xml) tests
> 
> Thanks,
> Elliott
> 
> ---

Are you saying this webrev is all (or most of) the fixes you listed merged
together?

I don't know how to even begin reviewing such a thing. Can we not just
backport the fixes individually, so they can be easily reviewed?

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222