[8u] RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files

Jonathan Dowland jdowland at redhat.com
Thu Jul 29 13:29:26 UTC 2021


Hi there,

Please consider this backport to jdk8u for parity with Oracle 8u291.

The unshuffled 11u patch does not apply cleanly to 8u:

 * License file pkcs11cryptotoken.md does not exist in 8u. pre-Jigsaw
   it's bundled into THIRD_PARTY_README. The below webrev URI includes
   updates to THIRD_PARTY_README for all 8 jdk8u repositories.

 * 11u patch fails to apply 1 out of 52 hunks to pkcs11t.h: this is
   partly due to out-of-order backporting (8265462 brought forward
   one line of changes from this patch). The failed hunk was largely
   (but not entirely) whitespace changes and the introduction of brand
   new code.

   After resolving it by hand, the result is identical to the version of
   the file in jdk11u.

Tests: I ran jdk_tier1 before and after and got the same results
(1135 passed, 196 failed, 10 not run). I'd appreciate any advice on good
tests to run to exercise these changes.

Bug: https://bugs.openjdk.java.net/browse/JDK-8244154
webrev: https://cr.openjdk.java.net/~jdowland/webrevs/JDK-8244154/webrev.00/
zipped webrev: https://cr.openjdk.java.net/~jdowland/webrevs/JDK-8244154/webrev.00.zip


Thanks,

-- 
���� Jonathan Dowland <jdowland at redhat.com>
Senior Software Engineer, OpenJDK, Red Hat



More information about the jdk8u-dev mailing list