[8u] RFR: 8267545: [8u] Enable Xcode 12 builds on macOS
Andrew Hughes
gnu.andrew at redhat.com
Fri Jun 4 04:35:03 UTC 2021
On 22:45 Thu 27 May , Hohensee, Paul wrote:
> And the webrev with the correct URLClassPath.c patch:
>
> https://cr.openjdk.java.net/~phh/8267545/webrev.8u.jdk.03/
>
This only seems to have the AWTWindow.m changes:
https://cr.openjdk.java.net/~phh/8267545/webrev.8u.jdk.03/jdk.changeset
Looking at:
https://cr.openjdk.java.net/~phh/8267545/webrev.8u.jdk.02/jdk.patch
instead, apart from the URLClassPath.c duplication, I'm concerned
about the j2secmod.h changes. Are these necessary? The j2secmod.h
in trunk is identical to that in 8u.
The addition does make sense, so it seems like it should go to trunk
first under its own bug and then be backported, unless there is a good
reason 8u should diverge here.
The rest looks fine and I see no issue with including this as a late
addition to 8u302, so the other changes for Mac OS can be utilised.
As I understand Mac OS builds were broken prior to this anyway, the
risk seems low.
Thanks,
--
Andrew :)
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
More information about the jdk8u-dev
mailing list