[8u] RFR: 8202837: PBES2 AlgorithmId encoding error in PKCS12 KeyStore

[Alexey Bakhtin]

Hello Andrew,

Thank you for review.
The diff between 11u and 8u patches generated by “hg diff” is here : http://cr.openjdk.java.net/~abakhtin/8202837/webrev.v0/8202837.11to8.diff
11u and 8u versions are almost identical.
11u patch : http://cr.openjdk.java.net/~abakhtin/8202837/webrev.v0/8202837.11u.diff
8u patch: http://cr.openjdk.java.net/~abakhtin/8202837/webrev.v0/8202837.8u.diff

Regards
Alexey

> On 9 Jun 2021, at 07:15, Andrew Hughes <gnu.andrew at redhat.com> wrote:
> 
> On 10:20 Mon 17 May     , Alexey Bakhtin wrote:
>> Hello,
>> 
>> Please review the backport of DK-8202837 to 8u
>> This is the third backport in the series required for JDK-8076190 [1]
>> 
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8202837
>> Original patch: http://hg.openjdk.java.net/jdk/jdk11/rev/69dc9ea17b33
>> 8u webrev: http://cr.openjdk.java.net/~abakhtin/8202837/webrev.v0/
>> 
>> Original patch applied almost clean except HexDumpEncoder class namespace in the com/sun/crypto/provider/PBES2Parameters.java
>> 
>> The initial review has been posted on [2]
>> 
>> [1] https://bugs.openjdk.java.net/browse/JDK-8076190
>> [2] https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-May/013799.html
>> 
>> Regards
>> Alexey
> 
> There's some oddity with the whitespace on this one too.
> Would you be able to share the hg diff output for it as well?
> 
> Thanks,
> --
> Andrew :)
> 
> Senior Free Java Software Engineer
> OpenJDK Package Owner
> Red Hat, Inc. (http://www.redhat.com)
> 
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222