[8u] RFR 8248901: Signed immediate support in .../share/assembler.hpp is broken.

Andrew Haley aph at redhat.com
Wed Jun 23 11:30:27 UTC 2021


On 6/23/21 12:15 PM, Andrew Haley wrote:
> I'm not convinced we need this backport at all. It doesn't fix any bugs,
> and is only used for the one-liner is_uimm12 in the fix for 8247766. This
> patch is harmless, but we should at least think about the churn in 8u.

For avoidance of doubt, that is_uimm12(offset >> shift) could be

    (offset >> shift) < ((int64_t)1 << 12)

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671




More information about the jdk8u-dev mailing list