[8u] RFR 8248901: Signed immediate support in .../share/assembler.hpp is broken.

[Andrew Dinn]

On 23/06/2021 13:16, Zhengyu Gu wrote:
>>> 8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8248901-8u/webrev.00/
>> The webrev above still includes two occurrences of precond.
> 
> Oops, uploaded webrev from wrong machine.
> 
> Updated: https://cr.openjdk.java.net/~zgu/JDK-8248901-8u/webrev.01/
Ok, this looks good now. Consider it reviewed.

As you say this backport is needed for to enable backport of 
JDK-8247766. The latter does fix a bug whereas the bug that this 
originally fixed does not exist in jdk8u.

I believe that is a good reason to backport this fix but that's not my 
decision to make. You will  need to get agreement from an actual 
maintainer before you can push this.

regards,


Andrew Dinn
-----------
Red Hat Distinguished Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill