[8u] RFR 8248901: Signed immediate support in .../share/assembler.hpp is broken.

[Andrew Hughes]

On 08:16 Wed 23 Jun     , Zhengyu Gu wrote:
> Hi Andrew,
> 
> > > 
> > > 8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8248901-8u/webrev.00/
> > The webrev above still includes two occurrences of precond.
> 
> Oops, uploaded webrev from wrong machine.
> 
> Updated: https://cr.openjdk.java.net/~zgu/JDK-8248901-8u/webrev.01/
> 
> Thanks,
> 
> -Zhengyu
> 

This seems to be missing changes that were made for 11u. With backports,
we should work from the closest version that has the fix, so to try and
avoid repeating analysis that has already been done in earlier reviews.
For 8u, this should mean working from 11u, unless there is a good reason
why the fix is not applicable there.

In the 11u changeset:

https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/d21f0f95e6b4

the precond macros are introduced from JDK-8223140, which, given their
simplicity, I think makes sense and will help any future backports that
use these macros.

It also includes the ppc64 fix, JDK-8215144, though uncredited, and some
sparc changes (there is no sparc port in trunk).

If we're going to backport this to 8u, I'd like to see the backport based
on 11u rather than diverging. It should also credit both JDK-8248901 and
JDK-8215144 (I've fixed the missing backport bug for 11u there).

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222