[8u] RFR: JDK-8269468: JDK-8269388 breaks the build on older GCCs

[Andrew Haley]

On 6/28/21 2:36 PM, Andrew Hughes wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8269468
> Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8269468/webrev.01/
> 
> In trying to promote 8u302-b07, I found the addition of -Werror=format-overflow
> broke the build on older GCCs (specifically building on RHEL 7).
> 
> The option is fairly new, only introduced in GCC 7:
> 
> https://gcc.gnu.org/gcc-7/changes.html
> 
> Adding a version conditional similar to others in that file fixes the
> build.
> 
> A quick review and critical-ack of this would be appreciated so we
> can promote 8u302-b07.

I will do that if you like, but wouldn't this be better as an autoconf check
FLAGS_CXX_COMPILER_CHECK_ARGUMENTS ?

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671