[8u] RFR: JDK-8269468: JDK-8269388 breaks the build on older GCCs

[Andrew Haley]

On 6/28/21 5:58 PM, Andrew Hughes wrote:
> Good point. A compiler check rather than a version test would be better.
> I'd forgotten we had both ways in 8u, as it still has the old HotSpot build
> with lots of version tests.
> 
> This is my revised version:
> 
> https://cr.openjdk.java.net/~andrew/openjdk8/8269468/webrev.02/
> 
> It works fine locally with GCC 8:
> 
> checking if the C compiler supports "-Wformat-overflow -Werror"... yes
> checking if the C++ compiler supports "-Wformat-overflow -Werror"... yes
> checking if both compilers support "-Wformat-overflow -Werror"... yes
> 
> and on RHEL 7 with GCC 4:
> 
> checking if the C compiler supports "-Wformat-overflow -Werror"... no
> checking if the C++ compiler supports "-Wformat-overflow -Werror"... no
> checking if both compilers support "-Wformat-overflow -Werror"... no
> 
> with both compiling os_linux.o.

Perfect, thanks.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671