[PING] RE: [PING] RE: 8180478: tools/launcher/MultipleJRE.sh fails on Windows because of extra-''

[Severin Gehwolf]

Hi,

On Wed, 2021-03-03 at 07:23 +0000, yano-masanori at fujitsu.com wrote:
> Hello,
> 
> Please reply if anyone can be a sponsor.

I'll sponsor this for you. Patch looks fine.

Thanks,
Severin

> Regards,
> Masanori Yano
> 
> > -----Original Message-----
> > From: Yano, Masanori 
> > Sent: Tuesday, January 12, 2021 4:30 PM
> > To: 'jdk8u-dev at openjdk.java.net' <jdk8u-dev at openjdk.java.net>
> > Subject: RE: [PING] RE: 8180478: tools/launcher/MultipleJRE.sh
> > fails on Windows
> > because of extra-''
> > 
> > Hello,
> > 
> > Please reply if anyone can be a sponsor.
> > 
> > Regards,
> > Masanori Yano
> > 
> > > -----Original Message-----
> > > From: Yano, Masanori
> > > Sent: Wednesday, December 23, 2020 4:58 PM
> > > To: 'jdk8u-dev at openjdk.java.net' <jdk8u-dev at openjdk.java.net>
> > > Subject: [PING] RE: 8180478: tools/launcher/MultipleJRE.sh fails
> > > on
> > > Windows because of extra-''
> > > 
> > > Hello,
> > > 
> > > Please reply if anyone can be a sponsor.
> > > 
> > > Regards,
> > > Masanori Yano
> > > 
> > > > -----Original Message-----
> > > > From: Yano, Masanori/矢野 公規
> > > > Sent: Wednesday, November 11, 2020 4:06 PM
> > > > To: 'jdk8u-dev at openjdk.java.net' <jdk8u-dev at openjdk.java.net>
> > > > Subject: 8180478: tools/launcher/MultipleJRE.sh fails on
> > > > Windows
> > > > because of extra-''
> > > > 
> > > > Hello.
> > > > 
> > > > I would like to contribute for JDK-8180478.
> > > > 
> > > > The test of tools/launcher/MultipleJRE.sh fails on the JDK8 for
> > > > the
> > > > Windows because the 'RELEASE' variable contains the carriage
> > > > return.
> > > > 
> > > > The 'RELEASE' variable is created from the third word in the
> > > > first
> > > > line of the "java -version" command.
> > > > But this is a last word of the line, so the 'RELEASE' variable
> > > > contains the carriage return.
> > > > The 'RELEASE' variable is compared to the actual java version,
> > > > but
> > > > does not match because of the carriage return difference.
> > > > 
> > > > Since JDK 11, this is no longer a problem because the date has
> > > > been
> > > > added as a fourth word.
> > > > Therefore, the test for JDK8 should be fixed to remove the
> > > > carriage returns.
> > > > 
> > > > Please sponsor the following change.
> > > > 
> > > > diff -r 4c5dceabd4c6 test/tools/launcher/MultipleJRE.sh
> > > > --- a/test/tools/launcher/MultipleJRE.sh        Mon Apr 21
> > > > 14:35:14 2014
> > > +0400
> > > > +++ b/test/tools/launcher/MultipleJRE.sh        Tue Nov 10
> > > > 20:08:05 2020
> > > > +0900
> > > > @@ -308,7 +308,7 @@
> > > >  # Main test sequence starts here
> > > >  #
> > > >  RELEASE=`$JAVA -version 2>&1 | head -n 1 | cut -d ' ' -f 3 | \
> > > > -  sed -e "s/\"//g"`
> > > > +  sed -e "s/\"//g" | sed -e "s/\r//g"`
> > > >  BASE_RELEASE=`echo $RELEASE | sed -e "s/-.*//g"`
> > > > 
> > > >  #
> > > > 
> > > > Regards,
> > > > Masanori Yano
>