[8u] RFR: 8262864: No debug symbols in image for Windows --with-native-debug-symbols=external

[Severin Gehwolf]

Hi Andrew,

On Tue, 2021-03-02 at 18:50 +0000, Andrew Leonard wrote:
> Hi,
> Please can I get reviews for this patch to fix the creation of jdk8u
> Windows debug files (.map, .pdb) when using
> --with-native-debug-symbols=external. A recent fix resolved this for
> non-Windows (https://bugs.openjdk.java.net/browse/JDK-8252395), this fixes
> Windows and also a minor issue with the other platforms that
> JDK-8252395 didn't quite fix.

Can you be more specific what this "minor issue" is that you fixed
here?

> webrev: https://cr.openjdk.java.net/~aleonard/8262864/webrev.00/

-ifeq ($(OPENJDK_TARGET_OS), windows)
-  # On windows, the libraries are in the bin dir, only filter out debuginfo files
-  # for executables. "java" is both a library and executable.
-  ALL_BIN_EXEC_FILES := $(filter-out java.exe, $(notdir $(filter %.exe, $(ALL_BIN_LIST))))
-  ALL_BIN_DEBUG_FILTER := $(addprefix %, $(patsubst %.exe, %.debuginfo, $(ALL_BIN_EXEC_FILES)) \
-      $(patsubst %.exe, %.diz, $(ALL_BIN_EXEC_FILES))) %.pdb
-  ALL_BIN_LIST := $(filter-out $(ALL_BIN_DEBUG_FILTER), $(ALL_BIN_LIST))
-endif

If I understand Simon correctly then by removing these bits it doesn't
change the fact that debuginfo for only one of the files, java.exe OR
java.dll, end up in the image. In his case it seemed to be debuginfo
for java.dll, but I wonder how predictable is? Isn't that a reason to
keep this part of the patch as it makes it more explicit that we prefer
debuginfo for java.dll over java.exe as we cannot have both.

Thoughts?

Thanks,
Severin