[8u] RFR (S) 8042891: Format issues embedded in macros for two g1 source files

[Aleksey Shipilev]

Thanks, I tagged this for approval.

On 3/3/21 11:22 PM, Hohensee, Paul wrote:
> Lgtm.
> 
> Thanks,
> Paul
> 
> -----Original Message-----
> From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of Aleksey Shipilev <shade at redhat.com>
> Date: Monday, March 1, 2021 at 10:33 AM
> To: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
> Subject: [8u] RFR (S) 8042891: Format issues embedded in macros for two g1 source files
> 
> Original issue:
>     https://bugs.openjdk.java.net/browse/JDK-8042891
>     https://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/2e360934b0cf
> 
> In our testing, we have seen G1 crashes when it tries to log something, the stack traces leading
> into vnsprintf. I suspect the cause is formatting problems, which are supposed to be resolved by
> this backport.
> 
> There are lots of conflicts when applying the patch, all resolved by hand. Additionally, I built
> with x86_32 and x86_64 with GCC 9, and fixed up a few more formatting warnings. The changes are
> mostly putting p2i() where PTR_FORMAT is expected, matching %u or UINTX_FORMAT where needed, etc.
> 
> 8u variant:
>     https://cr.openjdk.java.net/~shade/8042891/webrev.8u.01/
> 
> Testing: tier1

-- 
Thanks,
-Aleksey