[8u] RFR: 8262864: No debug symbols in image for Windows --with-native-debug-symbols=external

[Simon Tooke]

(usual disclaimer; I am not a reviewer)

 From a comment by Magnus Ihse Bursie on the new issue (8263356), [1] 
this PR (8262864) should not delete the following lines:

-  # for executables. "java" is both a library and executable.
-  ALL_BIN_EXEC_FILES := $(filter-out java.exe, $(notdir $(filter %.exe, 
$(ALL_BIN_LIST))))

As this ensure the debug info for the DLL is copied, by removing 
java.exe from the potential list of debug executables.

I suggest this PR be reworked, and I will also look at closing 8263356 
with an explanation "working as intended"; the proper solutions would 
have been to prefix all JDK DLLs with 'lib' similar to Posix systems, 
but that ship sailed decades ago.

[1] 
https://bugs.openjdk.java.net/browse/JDK-8263356?focusedCommentId=14406720&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14406720

On 2021-03-11 5:27 p.m., Simon Tooke wrote:
>
> On 2021-03-10 5:45 a.m., Andrew Leonard wrote:
>> The issue Simon is referring to I think is at the source of the .pdb
>> generation for java.exe/dll (probably in
>> make/common/NativeCompilation.gmk), since they have the same basename 
>> one
>> is going to overwrite the other...this behavior is separate to this 
>> Image
>> creation copy rules. I've raised a new issue to cover that:
>> https://bugs.openjdk.java.net/browse/JDK-8263356
>
> I have clarified in JBS that this issue is still present in later 
> JDKs, although I've only tested 11u and head.
>
> -Simon
>
> -- 
> Simon Tooke
> Principal developer, Java Platform
> Red Hat Canada, Inc.<https://www.redhat.com>
>