RFR: 8191915: JCK tests produce incorrect results with C2

[Andrew Hughes]

On 08:37 Mon 15 Mar     , Yangfei (Felix) wrote:
> Hi,
> 
>   Please review this 8u backport fixing a compatibility issue:
> 
>   Original bug: https://bugs.openjdk.java.net/browse/JDK-8191915 
>   Original patch: http://hg.openjdk.java.net/jdk/jdk10/rev/4162f740b7bd 
>   Webrev for 8u: http://cr.openjdk.java.net/~fyang/8191915-8u/webrev.00/ 
> 
>   I am using gcc-7.5 and I find this issue can always be reproduced on both aarch64 and x84_64 linux with the provided jtreg test. 
>   Original patch does not apply cleanly after path shuffling, three adaptations for 8u:
>   1. Adjusted copyright year update for both mathexactnode.cpp and mathexactnode.hpp;
>   2. Adjusted the test command for the jtreg test in the original patch: LongMulOverflowTest.java;
>   3. Removed test_mathexact.cpp in the original patch.
> 
>   Performed full jtreg test on both aarch64 and x84_64 linux. OK?
> 
> Thanks,
> Felix

Looks good to me. Test fails without the patch and passes with here too.
No GTest for the test_mathexact.cpp patch in 8u.

As this apparently affects a JCK test, I think it may be a candidate
for inclusion in 8u292 during rampdown. Please flag with
jdk8u-critical-request if you agree.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222