[8u]: 8136592: [TEST_BUG] Fix 2 platform-specific closed regtests for jigsaw

Volker Simonis volker.simonis at gmail.com
Fri Mar 19 16:27:18 UTC 2021


Hi Paul,

the downport looks good to me, but I somehow doubt if we should really
downport test/java/awt/EmbeddedFrame/GraphicsConfigTest/GraphicsConfigTest.java.
The summary mentions that the test is for verifying correct behavior
in multi-screen environments but it fails about 50% of times in
multi-screen environments (Ubuntu 18.04 / Gnome 3.28.2). I could
actually still see the same number of failures with the latest version
of jdk17 but didn't do more research to see if the failure is related
to the test being unstable or if this is a real problem with the
implementation.

But we probably shouldn't downport unstable tests to jdk8u?

Best regards,
Volker

On Thu, Mar 18, 2021 at 9:24 PM Hohensee, Paul <hohensee at amazon.com> wrote:
>
> Ping. :)
>
> Thanks,
> Paul
>
> -----Original Message-----
> From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of "Hohensee, Paul" <hohensee at amazon.com>
> Date: Wednesday, February 24, 2021 at 1:42 PM
> To: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
> Subject: [8u]: 8136592: [TEST_BUG] Fix 2 platform-specific closed regtests for jigsaw
>
> Please review this test-only backport. The JBS issue is private, so I can’t create a backport issue. We’ll have to rely on hg-updater when pushed, and maintainer approval will have to be on the list.
>
> Original patch: http://hg.openjdk.java.net/jdk-updates/jdk9u/jdk/rev/ddc8bbf88d36
> 8u webrev: http://cr.openjdk.java.net/~phh/8136592/webrev.8u.jdk.02/
>
> The @modules attributes have been removed, and implicit casts have been replaced by explicit ones to XEmbedCanvasPeer, FramePeer, and ListPeer. The first two required importing sun.awt.X11.*.
>
> The two new tests pass.
>
> Thanks,
> Paul
>
>


More information about the jdk8u-dev mailing list