RFR [8u] JDK-8239798 : SSLSocket closes socket both socket endpoints on a SocketTimeoutException

[Hohensee, Paul]

Webrev with fixed copyright header (and copyright dates): https://cr.openjdk.java.net/~phh/8239798/webrev.8u.jdk.01/

Thanks,
Paul

-----Original Message-----
From: Andrew Hughes <gnu.andrew at redhat.com>
Date: Wednesday, March 24, 2021 at 9:00 AM
To: "Hohensee, Paul" <hohensee at amazon.com>
Cc: "Alvarez, David" <alvdavi at amazon.com>, "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
Subject: RE: RFR [8u] JDK-8239798 : SSLSocket closes socket both socket endpoints on a SocketTimeoutException

On 02:30 Wed 17 Mar     , Hohensee, Paul wrote:
> Lgtm.
> 
> Thanks,
> Paul
> 
> -----Original Message-----
> From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of "Alvarez, David" <alvdavi at amazon.com>
> Date: Monday, February 15, 2021 at 9:58 PM
> To: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
> Subject: RFR [8u] JDK-8239798 : SSLSocket closes socket both socket endpoints on a SocketTimeoutException
> 
> Hi,
> 
> I would like to request a review for JDK-8239798
> 
> Original bug: https://bugs.openjdk.java.net/browse/JDK-8239798
> Webrev:
> http://cr.openjdk.java.net/~alvdavi/webrevs/8239798/webrev.8u.jdk.00/
> 
> The backport is mostly clean, except for some changes in
> SSLSocketInputRecord.java to account for DTLS removal in 8u [1]
> 
> This is one of a set of multiple patches TLS1.3 patches that were added
> to 11u after 11.0.7 that did not make it into 8u.
> 
> All jdk tier1 test pass.
> 
> Thanks,
> 
> David
> 
> --
> [1] https://bugs.openjdk.java.net/browse/JDK-8245469
> 
> 

Only minor thing is the copyright header is not added to
SSLSocketInputRecord.java.  It's an addition of a different copyright
holder, so should be added despite the Oracle copyright including
2020.

Part of the SSLSocketInputRecord.java diff was a little hard to
compare with the 11u version, presumably due to whitespace issues.
However, the patched version looks the same as 11u, but without the
copyright header, JDK-8171279: "Support X25519 and X448 in TLS" and
JDK-8228757: "Fail fast if the handshake type is unknown".

Is JDK-8228757 on your todo list? It's marked as resolved in Oracle's
8u261. If not, I can take a look.

As to this patch, should be good to go once the copyright header is
added.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222