[8u] RFR 8072767: DefaultCellEditor for comboBox creates ActionEvent with wrong source object

[Andrew Hughes]

On 10:18 Mon 18 Jan     , Zhengyu Gu wrote:
> Hi,
> 
> I would like to backport this patch to openjdk8u, for parity with Oracle
> 8u291.
> 
> The original patch applies cleanly. However, the test failed on Fedora due
> to component layout issue. Please see comments in bug for details.
> 
> I added a delay to ensure that layout is stable before test starts to
> execute.
> 
> diff -r 15ca08c8faf5 test/javax/swing/JComboBox/8072767/bug8072767.java
> --- a/test/javax/swing/JComboBox/8072767/bug8072767.java        Wed Apr 15
> 14:38:13 2015 +0400
> +++ b/test/javax/swing/JComboBox/8072767/bug8072767.java        Mon Jan 18
> 10:11:16 2021 -0500
> @@ -59,12 +59,12 @@
>          robot.setAutoDelay(50);
>          SwingUtilities.invokeAndWait(bug8072767::createAndShowGUI);
>          robot.waitForIdle();
> +        robot.delay(500);
>          SwingUtilities.invokeAndWait(() -> {
>              point = table.getLocationOnScreen();
>              Rectangle rect = table.getCellRect(0, 0, true);
>              point.translate(rect.width / 2, rect.height / 2);
>          });
> 
> 
> 
> Original bug: https://bugs.openjdk.java.net/browse/JDK-8072767
> Original patch: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/2ca1d772b1f1
> 
> 8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8072767-8u/webrev.00/
> 
> Test:
>  Test passed on Fedora/Ubuntu Linux x86_64
> 
> Thanks,
> 
> -Zhengyu
> 

Does this issue with the test exist with the original or just with the
8u backport?

If the former, the delay fix should be added in trunk first and backported
under its own bug ID. 8072767 should then be applied cleanly, followed by
the new fix.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222