[8u] RFR 8242565: Policy initialization issues when the denyAfter constraint is enabled

[Andrew Hughes]

On 08:47 Thu 06 May     , Alexey Bakhtin wrote:
> Hi,
> 
> Please review the backport of JDK-8242565 to 8u:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8242565
> Original change: https://hg.openjdk.java.net/jdk/jdk/rev/8d34198a0e26
> 8u webrev: http://cr.openjdk.java.net/~abakhtin/8242565/webrev.v0/
> 
> Original patch applies almost clean except for copyright years and SunJCE provider class name in the Providers.java class. All related jtreg tests in the :jdk_security group passed.
> 
> Please note: this patch also fixes issues [1] [2] [3] in the latest 8u292 release because of adds “SunJCE” provider to the list of thread local jar verification providers. Test from the bug report with BC provider passed.
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8266279
> [2] https://bugs.openjdk.java.net/browse/JDK-8266261
> [3] https://bugs.openjdk.java.net/browse/JDK-8266290
> 
> 
> Regards
> Alexey

There's something odd with the copyright header in the test case:

+--- old/test/java/security/Policy/SignedJar/SignedJarTest.java 2021-05-06 11:16:47.000000000 +0300
++++ new/test/java/security/Policy/SignedJar/SignedJarTest.java 2021-05-06 11:16:47.000000000 +0300
 @@ -1,5 +1,5 @@
  /*
 - * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
-+ * Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights reserved.
++ * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.

The 2015 seems to have been dropped from the 8u version. Please
correct this to match the 11u backport.

Otherwise, this looks good.

Please note that, in future, bugs should not be flagged with jdk8u-fix-request
until the review is complete.  I'll leave the label there now in this case, so
all you need to supply is the fixed webrev.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222