[8u] RFR: 8206189: sun/security/pkcs12/EmptyPassword.java fails with Sequence tag error

[Andrew Hughes]

On 10:15 Mon 17 May     , Alexey Bakhtin wrote:
> Hello,
> 
> Please review the backport of DK-8206189 to 8u
> This is the second backport in the series required for JDK-8076190 [1]
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8206189
> Original patch: http://hg.openjdk.java.net/jdk/jdk11/rev/038688fa32d0
> 8u webrev: http://cr.openjdk.java.net/~abakhtin/8206189/webrev.v0/
> 
> Original patch applied almost clean except for two differences:
> - one of the blocks is not applied cleanly because JDK-8234042 [1] already applied and JDK8 already verifies certValues length
> - JDK8 has a strict class cast to Object which is not necessary for JDK11
> 
> The initial review has been posted on [2]
> 
> [1] https://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/3054a00b5333
> [2] https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-May/013799.html
> 
> Regards
> Alexey

There seems to be something odd going on with the whitespace in this patch,
regarding the block that didn't apply cleanly.

The 11u patch has a single addition block and a single removal block for
the large hunk beginning "Parse the key algorithm and then use a JCA key factory".

The 8u patch seems to be broken up between the two, which makes them hard
to compare. In particular, there is the removal:

-            }, password);

and then subsequent re-addition of:

+            }, password);

Do the 11u & 8u versions of the file look the same after patching?

The 8u-only block from JDK-8234042 is:

+                if (value.length < 1 || value.length > 2) {
+                    throw new IOException("Invalid length for AlgorithmIdentifier");
+                }

I determined this by comparing the two patches line by line, but
it should really be clearer from the patch.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222