[8u] RFR (S): 8239400: [8u] clean up delete-non-virtual-dtor warnings in HotSpot

[Hohensee, Paul]

Thanks, Volker. Tagged.

-----Original Message-----
From: Volker Simonis <volker.simonis at gmail.com>
Date: Thursday, May 20, 2021 at 9:43 AM
To: "Hohensee, Paul" <hohensee at amazon.com>
Cc: jdk8u-dev <jdk8u-dev at openjdk.java.net>
Subject: RE: [8u] RFR (S): 8239400: [8u] clean up delete-non-virtual-dtor warnings in HotSpot

Looks good now.

Thanks,
Volker

On Thu, May 20, 2021 at 5:31 PM Hohensee, Paul <hohensee at amazon.com> wrote:
>
> New webrev: https://cr.openjdk.java.net/~phh/8239400/webrev.8u.hotspot.01/.
>
> I removed making ~MetaIndex virtual.
>
> Thanks,
> Paul
>
> -----Original Message-----
> From: Volker Simonis <volker.simonis at gmail.com>
> Date: Thursday, May 20, 2021 at 1:51 AM
> To: "Hohensee, Paul" <hohensee at amazon.com>
> Cc: jdk8u-dev <jdk8u-dev at openjdk.java.net>
> Subject: RE: [8u] RFR (S): 8239400: [8u] clean up delete-non-virtual-dtor warnings in HotSpot
>
> Hi Paul,
>
> I've tried to review this relatively to the original patch of 8182299
> (http://hg.openjdk.java.net/jdk10/jdk10/hotspot/rev/c044f8d03932).
>
> src/share/vm/classfile/classLoader.hpp
> ---------------------------------------------------
> - I don't think it's necessary to make "~MetaIndex()" virtual because
> "MetaIndex" is not polymorphic and there exist no other classes
> derived from "MetaIndex". Also, as a side note, I don't think
> "~MetaIndex()" gets ever called in the current code anyway but that's
> not something you want to fix with this backport :)
>
> Other than that, the downport looks good to me.
>
> Thank you and best regards,
> Volker
>
> On Fri, May 14, 2021 at 6:47 PM Hohensee, Paul <hohensee at amazon.com> wrote:
> >
> > My bad, I used links from my 8239053 review request. Corrected.
> >
> > Original JBS issue: https://bugs.openjdk.java.net/browse/JDK-8239400
> > 8u webrev: https://cr.openjdk.java.net/~phh/8239400/webrev.8u.hotspot.00/
> >
> > -----Original Message-----
> > From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of "Hohensee, Paul" <hohensee at amazon.com>
> > Date: Friday, May 14, 2021 at 9:45 AM
> > To: jdk8u-dev <jdk8u-dev at openjdk.java.net>
> > Subject: [UNVERIFIED SENDER] [8u] RFR (S): 8239400: [8u] clean up delete-non-virtual-dtor warnings in HotSpot
> >
> > Please review this backport to 8u to enable Xcode 12 builds. The patch is a subset of the large Xcode cleanup patch for 8182299.
> >
> > Original JBS issue: https://bugs.openjdk.java.net/browse/JDK-8239053
> > 8u webrev: https://cr.openjdk.java.net/~phh/8239053/webrev.8u.hotspot.00/
> >
> > The patch was written by Simon Tooke, see
> >
> > https://github.com/stooke/jdk8u-xcode10/blob/master/jdk8u-patch/jdk8u-hotspot-8244878.patch
> >
> > This is a private Oracle 8u261 issue, so there is no visible commit to use as a basis for the patch. There are no semantic changes, so very low risk.
> >
> > Thanks,
> > Paul
> >
> >
> >
>