[8u] RFR: 8250876: Fix issues with cross-compile on macos

[Hohensee, Paul]

Thanks, Volker! Tagged.

-----Original Message-----
From: Volker Simonis <volker.simonis at gmail.com>
Date: Tuesday, May 25, 2021 at 12:30 PM
To: "Hohensee, Paul" <hohensee at amazon.com>
Cc: jdk8u-dev <jdk8u-dev at openjdk.java.net>
Subject: RE: [8u] RFR: 8250876: Fix issues with cross-compile on macos

Hi Paul,

in general the backport looks fine. I'm just wondering why we need to
use the "$(wildcard ..)" function in saproc.make. From my
understanding that only makes sense if it's arguments contains
wildcard symbols like "*" or "?" but in this case it seems to be just
a simple path. So wouldn't it be enough to simply write:

+    ifneq ("$(SDKPATH)/System/Library/Frameworks/JavaVM.framework/Frameworks",
"").

No, I think I got it now. "$(wildcard ..)" will expand to an empty
string if the path does not exist and that's exactly what's intended
here. It's a trick for checking the existence of a  directory without
resorting to the shell.

Looks good to me. Reviewed.
Volker

On Tue, May 25, 2021 at 8:46 PM Hohensee, Paul <hohensee at amazon.com> wrote:
>
> The webrev doesn’t include generated-configure.sh. I'll regenerate it as part of the push.
>
> -----Original Message-----
> From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of "Hohensee, Paul" <hohensee at amazon.com>
> Date: Tuesday, May 25, 2021 at 11:31 AM
> To: jdk8u-dev <jdk8u-dev at openjdk.java.net>
> Subject: [8u] RFR: 8250876: Fix issues with cross-compile on macos
>
> Please review this backport. It’s part of enabling Xcode 12 builds and has been backported to 11.
>
> Original JBS: https://bugs.openjdk.java.net/browse/JDK-8250876
> Original patch: https://hg.openjdk.java.net/jdk/jdk/rev/64490f533d62
> 11u patch: https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/fbd5d019357b
>
> 8u root webrev: https://cr.openjdk.java.net/~phh/8250876/webrev.8u.root.00/
> 8u hotspot webrev: https://cr.openjdk.java.net/~phh/8250876/webrev.8u.hotspot.00/
>
>
> The issue title doesn’t accurately describe the problem. What the patch fixes is that the latest versions of Xcode 12 no longer automatically check the Xcode SDK libraries under /System/Library/Frameworks/JavaVM.framework, but only those under /System/Library/Frameworks. JavaVM.framework has been replaced by JavaNativeFoundation, so in order to be backward compatible with earlier versions of Xcode 12 (and earlier major versions of Xcode) we must explicitly check for JavaVM.framework . See https://developer.apple.com/forums/thread/666686.
>
>
>
> Tested using Xcode 6 (which has only JavaVM.framework) and 12.4 (which has only JavaNativeFoundation). No effect on non-osx builds.
>
>
>
> Thanks,
>
> Paul
>
>
>
>
>