[8u] RFR 8265462: Handle multiple slots in the NSS Internal Module from SunPKCS11's Secmod

Martin Balao mbalao at redhat.com
Wed May 26 15:41:26 UTC 2021


Hi Severin,

I'd like to request a review for the 8u backport of 8265462 [1].

Webrev.00:

 *
http://cr.openjdk.java.net/~mbalao/webrevs/8265462/8265462.webrev.8u.jdk.00/

The 11u backport applies cleanly to 8u (after paths conversion) but it's
not enough to work because of the following reasons:

 * src/share/native/sun/security/pkcs11/wrapper/pkcs11t.h
  * 8u does not have the 8244154 enhancement, which is about updating
NSS PKCS11 header files from 2.40 to 3.0 (major change). The 8u backport
of 8265462 needs the typedef for CK_PROFILE_ID introduced there.
However, CK_PROFILE_ID is not new from PKCS 3.0: it is anecdotal that it
came with 8244154. I strongly believe that 8244154 should not be
considered a dependency for 8265462.

Testing:

 * I initially thought there were regressions because I recalled some of
the tests failing in jdk/sun/security/sunpkcs11 to be passing. Turns out
that these regressions are not caused by 8265462, they are a bit older.
I still went through the ones I thought that were regressions and they
don't seem to be related to 8265462 in any sense.
  * I'll need to spend some time fixing these tests but I wouldn't block
the 8u backport of 8265462.

Thanks,
Martin.-

--
[1] - https://bugs.openjdk.java.net/browse/JDK-8265462



More information about the jdk8u-dev mailing list