[8u] RFR (XS): 8265238: [8u] [macos] build failure in OpenJDK8u after JDK-8211301 in older xcode

[Hohensee, Paul]

Thanks, Volker. Tagged.

-----Original Message-----
From: Volker Simonis <volker.simonis at gmail.com>
Date: Thursday, May 27, 2021 at 12:27 PM
To: "Hohensee, Paul" <hohensee at amazon.com>
Cc: jdk8u-dev <jdk8u-dev at openjdk.java.net>
Subject: RE: [8u] RFR (XS): 8265238: [8u] [macos] build failure in OpenJDK8u after JDK-8211301 in older xcode

Hi Paul,
Thanks for updating it.

Approved.

With best regards,
Volker

On Thu, May 27, 2021 at 6:25 PM Hohensee, Paul <hohensee at amazon.com> wrote:
>
> Thanks for the quick review, Volker.
>
> I guess it's a matter of style because Objective C does automatic conversions. Here's a new webrev with an explicit cast.
>
> https://cr.openjdk.java.net/~phh/8265238/webrev.8u.jdk.02/
>
> -----Original Message-----
> From: Volker Simonis <volker.simonis at gmail.com>
> Date: Thursday, May 27, 2021 at 8:56 AM
> To: "Hohensee, Paul" <hohensee at amazon.com>
> Cc: jdk8u-dev <jdk8u-dev at openjdk.java.net>
> Subject: RE: [EXTERNAL] [8u] RFR (XS): 8265238: [8u] [macos] build failure in OpenJDK8u after JDK-8211301 in older xcode
>
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
> Not an Objective-C expert but shouldn't we make this cast explicit, e.g.:
>
> 1040                 NSView* view = (NSView*)nsWindow.contentView;
> 1041                 view.frame = contentFrame;
>
> Otherwise looks good.
>
> On Wed, May 26, 2021 at 10:28 PM Hohensee, Paul <hohensee at amazon.com> wrote:
> >
> > Please review this syntax-only fix.
> >
> > JBS: https://bugs.openjdk.java.net/browse/JDK-8265238
> > 8u webrev: https://cr.openjdk.java.net/~phh/8265238/webrev.8u.jdk.01/
> >
> > Thanks,
> > Paul
> >
>