[8u] RFR 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST

Hohensee, Paul hohensee at amazon.com
Tue Nov 2 19:16:17 UTC 2021


Looks good, except I'd use "@library /lib/testlibrary" instead of "@library ../../../../../lib/testlibrary" so that the test is independent of its file system location. I know there are a lot of tests that use the latter, but we don't need to make things worse than they are. :)

Thanks,
Paul

-----Original Message-----
From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of Zhengyu Gu <zgu at redhat.com>
Date: Tuesday, November 2, 2021 at 10:46 AM
To: jdk8u-dev <jdk8u-dev at openjdk.java.net>
Subject: [8u] RFR 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST

Bug: https://bugs.openjdk.java.net/browse/JDK-8274779
Patch:
https://github.com/openjdk/jdk/commit/45ce06c9f3e9bee7d4bda313c38f0f0e8786a4db

I would like to backport this patch to openjdk8u for parity with Oracle
8u331.

The original patch applies cleanly, but new test needs to be modified
for 8u.

1) Adjust test library path and name
2) Removed modules
3) Use ClassFileInstaller to build injection class into inject.jar and
append it to bootclasspath

8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8274779-8u/webrev.00/

Test:
   jdk_net (including the new test)


Thanks,

-Zhengyu




More information about the jdk8u-dev mailing list