[8u] PRF:8167014 :jdeps: Missing message: warn.skipped.entry

hedongbo hedongbo at huawei.com
Mon Nov 15 01:34:42 UTC 2021


Thank you for your review, Paul.  Tagged.

Thanks,
hedongbo

-----Original Message-----
From: Hohensee, Paul <hohensee at amazon.com> 
Sent: Sunday, November 14, 2021 6:27 AM
To: hedongbo <hedongbo at huawei.com>; jdk8u-dev <jdk8u-dev at openjdk.java.net>
Subject: Re: [8u] PRF:8167014 :jdeps: Missing message: warn.skipped.entry

Lgtm.

Thanks,
Paul

-----Original Message-----
From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of hedongbo <hedongbo at huawei.com>
Date: Friday, November 12, 2021 at 6:31 PM
To: jdk8u-dev <jdk8u-dev at openjdk.java.net>
Subject: [8u] PRF:8167014 :jdeps: Missing message: warn.skipped.entry

Hi,

    Please review the backport of JDK-8167014 to 8u.
    Bug: https://bugs.openjdk.java.net/browse/JDK-8167014
    Original commit: http://hg.openjdk.java.net/jdk9/jdk9/langtools/rev/d7c3ad383ed5
    8u webrev: http://cr.openjdk.java.net/~dongbohe/8167014/webrev.00/

    This patch doesn't apply cleanly but is trivial. For JepsTask.java, the lambda expression is used in JDK9,
    and the for loop is used in JDK8. For jdeps.properties, it is only a different context

    Before patch:
    jdeps: tomcat-embed-websocket-10.0.8.jar (https://repo1.maven.org/maven2/org/apache/tomcat/embed/tomcat-embed-websocket/10.0.8/tomcat-embed-websocket-10.0.8.jar)
    ````java
    Exception in thread "main" java.lang.InternalError: Missing message: warn.skipped.entry
        at com.sun.tools.jdeps.JdepsTask.getMessage(JdepsTask.java:709)
        at com.sun.tools.jdeps.JdepsTask.warning(JdepsTask.java:673)
        at com.sun.tools.jdeps.JdepsTask.findDependencies(JdepsTask.java:563)
        at com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:324)
        at com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:306)
        at com.sun.tools.jdeps.Main.main(Main.java:48)
    ````

    After Patch:
    worked correctly.

    Tested with tier1. No regression in tests.


Thanks,
hedongbo



More information about the jdk8u-dev mailing list