[8u] RFR: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests.

Alex Kashchenko akashche at redhat.com
Tue Oct 5 10:59:03 UTC 2021 

Hi,

On 9/1/20, Alex Kashchenko <akashche at redhat.com> wrote:
> Hi,
>
> On 7/6/20, Alex Kashchenko <akashche at redhat.com> wrote:
>> Hi,
>>
>> Please review the backport of JDK-8185500 to 8u:
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8185500
>>
>> 10 change: https://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/b762aafa34e3
>>
>> 8u webrev: https://cr.openjdk.java.net/~akasko/jdk8u/8185500/webrev.00
>>
>> This change adds "headful" and "printer" keywords to a number of client
>> test, 129 tests are changed in jdk10, 63 of them are present in 8u.
>>
>> Patch is altered for 8u leaving only the tests that are present, some
>> tests also have required changes to jtreg tags section and copyright
>> year. There are no changes to test code itself.
>>
>> Testing: checked that modified tests can be selected correctly with
>> "headful" and "printer" keywords:
>>
>> Before:
>>
>> $ jtreg [...] -l @list.txt
>>
>> Tests found: 63
>>
>> After:
>>
>> $ jtreg [...] -l -k:headful @list.txt
>>
>> Tests found: 53
>>
>> $ jtreg [...] -l -k:printer @list.txt
>>
>> Tests found: 10
>>
>> $ jtreg [...] -l -k:"(headful|printer)" @list.txt
>>
>> Tests found: 63
>>
>> Note, some tests include "os.family" requirement, so the numbers above
>> may differ.
>
> Adding Jira traces for the tests, that were excluded from this backport:
>
> test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java
> 8144594: HiDPI: awt.Choice looks improperly (Win 8)
>
> test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java
> test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java
> 8160266: [macosx] NestedModalDialogTest.java and
> NestedModelessDialogTest.java tests does not run with current JDK
> codebase after taking the files from MACOSX_PORT
>
> test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java
> 8157163: AWT FileDialog does not inherit icon image from parent Frame
>
> test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java
> 8154043: Fields not reachable anymore by tab-key, because of new
> tabbing behaviour of radio button groups.
>
> test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java
> 8154434: Open the request focus methods of the java.awt.Component
> which accept FocusEvent.Cause
>
> test/java/awt/Frame/8158918/SetExtendedState.java
> 8158918: setExtendedState(1) for maximized Frame results in state==7
>
> test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java
> 8165619: Frame is not repainted if created in state=MAXIMIZED_BOTH on Unity
>
> test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java
> 8065739: [macosx] Frame warps to lower left of screen when displayed
>
> test/java/awt/Frame/SetMaximizedBounds/SetMaximizedBounds.java
> 8039279: Move awt tests to openjdk repository
>
> test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java
> 8167486: Device.getDisplayMode() doesn't report refresh rate on Linux
> in case of dual screen
>
> test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java
> 8022810: Cannot list all the available display modes on Ubuntu linux
> in case of two screen devices
>
> test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java
> test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java
> 8073320:  Windows HiDPI Graphics support
>
> test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java
> 8015900: [TEST_BUG] ScrollbarMouseWheelTest failed on ubuntu 12 with
> unity and unity 2D
>
> test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
> 8145174: HiDPI splash screen support on Linux
>
> test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java
> 8151588: Press the button first two times, the 'First' and 'Next' didn't
> show
>
> test/java/awt/TextArea/OverScrollTest/OverScrollTest.java
> 8149636: TextField flicker & over scroll when selection scrolls beyond
> the bounds of TextField
>
> test/java/awt/TextField/OverScrollTest/OverScrollTest.java
> 8149636: TextField flicker & over scroll when selection scrolls beyond
> the bounds of TextField
>
> test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java
> 8036915: setLocationRelativeTo stopped working in Ubuntu 13.10 (Unity)
>
> test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java
> 8025130: [macosx] Frame setLocationByPlatform has no effect under Mac OS X
>
> test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java
> 8073320: Windows HiDPI Graphics support
>
> test/java/awt/image/multiresolution/Corrupted2XImageTest.java
> 8142406: [TEST] MultiResolution image: need test to cover the case
> when @2x image is corrupted
>
> test/java/awt/keyboard/AllKeyCode/AllKeyCode.java
> 8149456: [macosx] robot.keyPress do not generate key events
> (keyPressed and keyReleased) for function keys F13 to F19
>
> test/java/awt/keyboard/AltPlusNumberKeyCombinationsTest/AltPlusNumberKeyCombinationsTest.java
> 8044172: [TEST_BUG] Move regtests for 4523758 and
> AltPlusNumberKeyCombinationsTest to jdk
>
> test/java/awt/print/PrinterJob/CheckPrivilege.java
> test/java/awt/print/PrinterJob/PaintText.java
> test/java/awt/print/PrinterJob/PrintTextPane.java
> 8038723: Openup some PrinterJob tests
>
> test/javax/swing/JButton/8151303/PressedIconTest.java
> 8151303: [macosx] [hidpi] JButton's low-res. icon is visible when clicking
> on it
>
> test/javax/swing/JComboBox/6567433/UpdateUIRecursionTest.java
> 6567433: JComponent.updateUI() may create StackOverflowError
>
> test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java
> 8041909: Uncaught exceptions in JComboBox listeners cause listener not
> to receive events
>
> test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java
> 8179027: JComboBox too small under Windows LAF
>
> test/javax/swing/JFileChooser/8010718/bug8010718.java
> 8010718: javax/swing/JFileChooser/8013442/Test8013442.java fails
>
> test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java
> 8152677: [macosx] All files filter can't be selected in JFileChooser
>
> test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java
> 6288609: JInternalFrame.setDefaultCloseOperation() interferes with
> "close" behavior
>
> test/javax/swing/JInternalFrame/8075314/bug8075314.java
> 8075314: All the InternalFrames will be maximized after maximizing
> only one of the InternalFrame with WindowsLookAndFeel
>
> test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java
> 8145060: Minimizing a JInternal frame not shifting focus to frame below it
>
> test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java
> 8160248: Dragged internal frame leaves artifacts for floating point ui
> scale
>
> test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java
> 8144166: [macosx] Test
> java/awt/Component/CompEventOnHiddenComponent/CompEventOnHiddenComponent.java
> fails
>
> test/javax/swing/JList/6567433/UpdateUIRecursionTest.java
> 6567433: JComponent.updateUI() may create StackOverflowError
>
> test/javax/swing/JList/8161483/Bug8161483.java
> 8161483: Implement AccessibleAction interface in
> JList.AccessibleJList.AccessibleJListChild
>
> test/javax/swing/JMenu/6538132/bug6538132.java
> 8063107: Change open swing regression tests to avoid
> sun.awt.SunToolkit.realSync, part 2
>
> test/javax/swing/JMenu/8067346/bug8067346.java
> 8067346: Swing submenu has a changed starting offset
>
> test/javax/swing/JMenuItem/8139169/ScreenMenuBarInputTwice.java
> 8139169: [macosx] Action registered for keyboard shortcut is called twice
>
> test/javax/swing/JMenuItem/8158566/CloseOnMouseClickPropertyTest.java
> 8158566: Provide a Swing property to not close toggle menu items on mouse
> click
>
> test/javax/swing/JMenuItem/ClickMenuTestManual/ClickMenuTestManual.java
> 8158230: [macosx] ActionEvent is not fired for menu item with option
> apple.laf.useScreenMenuBar
>
> test/javax/swing/JOptionPane/8081019/bug8081019.java
> 8081019: Check peer to null in CPlatformWindow.checkZoom()
>
> test/javax/swing/JPopupMenu/6217905/bug6217905.java
> 8063107: Change open swing regression tests to avoid
> sun.awt.SunToolkit.realSync, part 2
>
> test/javax/swing/JTable/6567433/UpdateUIRecursionTest.java
> test/javax/swing/JTableHeader/6567433/UpdateUIRecursionTest.java
> 6567433: JComponent.updateUI() may create StackOverflowError
>
> test/javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java
> 8160246: Regression: 4410243 reproducible with GTK LaF
>
> test/javax/swing/JTree/6567433/UpdateUIRecursionTest.java
> 6567433: JComponent.updateUI() may create StackOverflowError
>
> test/javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java
> 8065861: Pressing Esc does not set 'canceled' property of ProgressMonitor
>
> test/javax/swing/UI/UnninstallUIMemoryLeaks/UnninstallUIMemoryLeaks.java
> 8134947: [macosx] Various memory leaks in Aqua look and feel
>
> test/javax/swing/plaf/basic/6866751/bug6866751.java
> 6866751: J2SE_Swing_Reg: the caret disappears when moving to the end
> of the line.
>
> test/javax/swing/plaf/basic/BasicHTML/4960629/bug4960629.java
> 8135176: Moving test from javax/swing/plaf/basic/BasicHTML/4960629 to
> test/javax/swing/plaf/basic/BasicHTML/4960629
>
> test/javax/swing/plaf/windows/6921687/bug6921687.java
> 6921687: Mnemonic disappears after repeated attempts to open menu
> items using mnemonics
>
> test/javax/swing/text/GlyphPainter2/6427244/bug6427244.java
> 8144015: [PIT] failures of text layout font tests
>
> test/javax/swing/text/Utilities/8142966/SwingFontMetricsTest.java
> 8142966: Wrong cursor position in text components on HiDPI display
>
> test/sun/awt/image/OffScreenImageSource/ImageConsumerUnregisterTest.java
> 8160421: Regression: JDK-8139192 causes NPE in
> java.awt.Toolkit.createCustomCursor()
>
> test/sun/java2d/xrender/HugeGradientTest.java
> 8162591: All existing gradient paint implementations have issues with
> coordinates/sizes larger than Short.MAX_VALUE (exactly) on any Linux
> systems

I would like to return to this change because it blocks a number of
other parity changes. I've updated the patch accommodating to more
recent 8u changes that were pushed with JDK-8063104, 8063106, 8063107
and 8081764:

https://cr.openjdk.java.net/~akasko/jdk8u/8185500/webrev.02/

The following tests were updated:

test/java/awt/Focus/FocusEmbeddedFrameTest/FocusEmbeddedFrameTest.java
test/java/awt/event/KeyEvent/DeadKey/DeadKeyMacOSXInputText.java
test/javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java
test/javax/swing/JPopupMenu/7154841/bug7154841.java
test/javax/swing/JTabbedPane/7170310/bug7170310.java
test/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java


Note, review email for the previous version of this patch:
https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-November/013061.html

-- 
-Alex

More information about the jdk8u-dev mailing list