[8u] RFR(S): 8077590: windows_i586_6.2-product-c2-runThese8_Xcomp_vm failing after win compiler upgrade

[Liu, Xin]

hi, Paul & Severin,

Thank you for reviewing this patch.

I just found VS2010 and older don't support /arch:IA32. Here is the
archived documentation of VS2010.
https://docs.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-2010/7t5yh4fd(v=vs.100)?redirectedfrom=MSDN

My concern is that patch may break users who are still using vs2010 or
older. VS2010 has been end of life.
https://docs.microsoft.com/en-us/lifecycle/products/visual-studio-2010

This contradicts jdk8u's build instructions. Should we update
README-builds.html as well? That would be a separate issue for sure. or
I am paranoid. we're all using vs2013 as the minimal toolchain Windows.

https://hg.openjdk.java.net/jdk8u/jdk8u-dev/raw-file/2c60e3009d12/README-builds.html#vs2010

thanks,
--lx



On 10/27/21 10:07 AM, Hohensee, Paul wrote:
> Thanks, Severin. Pushed.
> 
> Paul
> 
> -----Original Message-----
> From: Severin Gehwolf <sgehwolf at redhat.com>
> Date: Wednesday, October 27, 2021 at 3:11 AM
> To: "Hohensee, Paul" <hohensee at amazon.com>, "Liu, Xin" <xxinliu at amazon.com>, "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
> Subject: RE: [8u] RFR(S): 8077590: windows_i586_6.2-product-c2-runThese8_Xcomp_vm failing after win compiler upgrade
> 
> On Tue, 2021-10-26 at 16:21 +0000, Hohensee, Paul wrote:
>> Also, approval by a Maintainer (Severin or Andrew) on the list is
>> needed because the JBS issue is private.
>>
>> Thanks
>> Paul
>>
> 
> [...]
> 
>> -----Original Message-----
>> From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of "Liu,
>> Xin" <xxinliu at amazon.com>
>> Date: Friday, October 22, 2021 at 4:43 PM
>> To: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
>> Cc: Nils Eliasson <nils.eliasson at oracle.com>
>> Subject: [8u] RFR(S): 8077590: windows_i586_6.2-product-c2-
>> runThese8_Xcomp_vm failing after win compiler upgrade
>>
>> Hi,
>>
>> Please review the backport of JDK-8077590 to jdk8u:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8077590
>> Webrev: https://cr.openjdk.java.net/~xliu/8077590/webrev/
> 
> This looks fine. Approved for jdk8u-dev.
> 
> Thanks,
> Severin
> 
>