[jdk8u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v20]

[Andrew John Hughes]

On Mon, 4 Apr 2022 15:08:26 GMT, Alex Kasko <akasko at openjdk.org> wrote:

> > > This seems good enough for an initial integration. Better to have some (build) tests prior integration than nothing :)
> > > One question: Do we really need file `.github/workflows/freetype.vcxproj`? If not, please remove.
> > 
> > 
> > It was provided by Alex for the Windows build: [#3 (comment)](https://github.com/openjdk/jdk8u-dev/pull/3#issuecomment-1066169712)
> 
> OK. No expert on this either, so fine with me going in either way :-) It's certainly better than what we have currently.

Thanks. I've flagged the main bug for 8u approval now (I presume we can infer the others from that one).

> > > > This seems good enough for an initial integration. Better to have some (build) tests prior integration than nothing :)
> > > > One question: Do we really need file `.github/workflows/freetype.vcxproj`? If not, please remove.
> > > 
> > > 
> > > It was provided by Alex for the Windows build: [#3 (comment)](https://github.com/openjdk/jdk8u-dev/pull/3#issuecomment-1066169712)
> > 
> > 
> > OK. No expert on this either, so fine with me going in either way :-) It's certainly better than what we have currently.
> 
> This `freetype.vcxproj` file is used to replace the default FreeType build file. It has modifications to be buildable with VS2017. It is necessary for `--with-freetype-src` to work, with this flag FreeType is being built with msbuild (that used this build file) at configure time. We can avoid it by building FreeType by some other means (before running configure) and using `--with-freetype-lib` and `--with-freetype-include` instead. Just this `--with-freetype-src` seems to be "the most vanilla" way to build FreeType for 8u, so I suggest to continue using it.

Thanks for the explanation. That does make things a lot clearer for me.

A couple of questions: 

1. Does this mean the file is not needed for the VS2010 build? I duplicated your changes in that build and it seems to work at present.
2. Any idea why 11u (which this is backported from) works without this? Does it build FreeType in a different way?

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3