[jdk8u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v20]

[Andrew John Hughes]

On Tue, 5 Apr 2022 21:51:07 GMT, Alex Kasko <akasko at openjdk.org> wrote:

> > A couple of questions:
> > 
> > 1. Does this mean the file is not needed for the VS2010 build? I duplicated your changes in that build and it seems to work at present.
> 
> Yes, I believe it is not needed for VS2010. I haven't tried it with 32-bit VS2010 myself, but IIRC it worked out of the box with 64-bit VS2013 (freeware version of VS2010 doesn't support 64-bit, setup is possible with WinSDK7.1 toolchain, but it is complicated). Modified file was intended to change only 64-bit config (to make it working with 64-bit VS2017) so 32-bit config remained the same there. Thus `Copy FreeType project file` step on 32-bit most probably can be removed.
> 

Thanks. We can maybe try that in a follow-up PR.

> > 2. Any idea why 11u (which this is backported from) works without this? Does it build FreeType in a different way?
> 
> Yes, in 8u FreeType is not included in-tree, it was always used as an external dependency and for "open" jdk only (Oracle JDK didn't use it). `--with-freetype-src` flag is relatively recent, it was added in [JDK-8057538](https://bugs.openjdk.java.net/browse/JDK-8057538). In 11u FreeType is [included in-tree](https://github.com/openjdk/jdk11u/tree/master/src/java.desktop/share/native/libfreetype) and is built the same way as other in-tree dep libs.

Interesting, thanks. It may be worth considering whether to bring the FreeType sources into 8u as well.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3