[jdk8u-dev] RFR: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream [v3]

Alexey Pavlyutkin duke at openjdk.java.net
Thu Apr 7 05:17:26 UTC 2022


> Hi!
> 
> Please review the backport of JDK-8190753 to 8u. The patch fixes IllegalArgumentException that takes place on accessing large (>2^31 bytes) entries in zipfs.
> 
> The original patch
> 
> https://github.com/openjdk/jdk11u-dev/pull/545
> 
> was applied with the following changes:
> 
> - changes to absent DeflatingEntryOutputStream class were skipped (in 8u EntryOutputStream handles both RAW and deflating streaming);
> - the tests were updated to not use unsupported APIs like Path.of() and Map.of()
> - timeout value for ZipFSOutputStreamTest was increased because the test is too greedy and may fail by timeout on low performance hosts
> 
> The changes were previously reviewed: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-December/014479.html
> 
> Verification/regression: jdk_other (20.04/amd64)

Alexey Pavlyutkin has updated the pull request incrementally with three additional commits since the last revision:

 - eliminating unwanted delta with 11u
 - eliminating unwanted delta with 11u
 - eliminating unwanted delta with 11u

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/17/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/17/files/f09b849c..8911a600

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=17&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=17&range=01-02

  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/17.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/17/head:pull/17

PR: https://git.openjdk.java.net/jdk8u-dev/pull/17


More information about the jdk8u-dev mailing list