OpenJDK 8u332 Released

[Thorsten Glaser]

On Sun, 24 Apr 2022, Andrew Hughes wrote:

> > - if [ -d $(SCM_DIR) -a "$(SCM_VERSION)" != "" ] ; then \
> > + if [ -d "$(SCM_DIR)" -a "$(SCM_VERSION)" != "" ] ; then \

> The fix above suggests a problem with spaces in the filenames.

No, it’s just mixing shell and make.

If SCM_DIR and SCM_VERSION are unset/empty, the shell gets:

	if [ -d -a "" != "" ]; then

This is an invalid construct. I’d personally even single-quote
make variable expansions to avoid problems with $, `, \ in paths:

	if test -d '$(SCM_DIR)' && test -n '$(SCM_VERSION)'; then

This also fixes the -a issue (-a is not POSIX) and issues with
empty comparisons (while POSIX, still not portable).

bye,
//mirabilos

PS: I’m experimenting with switching Debian/arm64 away from
    Shenandoah, to get on with the update.
-- 
Infrastrukturexperte • tarent solutions GmbH
Am Dickobskreuz 10, D-53121 Bonn • http://www.tarent.de/
Telephon +49 228 54881-393 • Fax: +49 228 54881-235
HRB AG Bonn 5168 • USt-ID (VAT): DE122264941
Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg

                        ****************************************************
/⁀\ The UTF-8 Ribbon
╲ ╱ Campaign against      Mit dem tarent-Newsletter nichts mehr verpassen:
 ╳  HTML eMail! Also,     https://www.tarent.de/newsletter
╱ ╲ header encryption!
                        ****************************************************