[jdk8u-dev] RFR: 8071507: (ref) Clear phantom reference as soft and weak references do [v2]

Andrew John Hughes andrew at openjdk.org
Thu Aug 11 03:04:40 UTC 2022


On Tue, 9 Aug 2022 03:47:45 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> > Is there a reason for backporting two changes in one PR? I see this was done in 8u42 as well. It makes it harder to review than necessary, notably where the two change the same code in `referenceProcessor.cpp`.
> 
> There was a change before 8071507 in mainline (and backported to jdk8u) that wasn’t in the RI. That change was rendered moot (the changed code was entirely removed) by 8143847. So if we’d separated 8071507 and 8143847 in the RI we would have needed to first apply that other change to the RI (8071507 without that earlier change would have been wrong), only to have it disappear with 8143847.

Thanks. Having reviewed the code, that makes sense.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/94


More information about the jdk8u-dev mailing list