[jdk8u-dev] RFR: JDK-8245263: Enable TLSv1.3 by default on JDK 8u for Client roles

[Martin Balao]

On Tue, 9 Aug 2022 19:30:22 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Please review a patch to enable TLSv1.3 by default on JDK 8u for Client roles
> I'd like to add this functionality for parity with Oracle JavaSE8
> 
> The patch rolls back the JDK-8245476 and updates JTREG tests
> 
> All sun/security/ssl and javax/net/ssl jtreg tests are passed

Hi @alexeybakhtin ,

Thanks for proposing this backport. Just for the record, the non-tests part of this change is the revert of https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/ad16e2ef963c

Looks good to me overall, just a couple of minor comments related to tests:

1) During the 8u backport of several TLS 1.3 related tests, a system property had to be passed so TLS 1.3 was used by the client: -Djdk.tls.client.protocols. Can we now remove this and leave the tests aligned to newer releases? This would also be an additional check for the new defaults.

2) The test TLSClientPropertyTest.java requires some TLS 1.3 removal undoing too.

For reference, this is the changeset that introduced the TLS 1.3 tests adaptation in 8u: https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/ed0d638da09f

Thanks,
Martin.-

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/96