[jdk8u-dev] RFR: JDK-8245263: Enable TLSv1.3 by default on JDK 8u for Client roles

[Martin Balao]

On Mon, 15 Aug 2022 20:41:57 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Hi @alexeybakhtin ,
>> 
>> Thanks for proposing this backport. Just for the record, the non-tests part of this change is the revert of https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/ad16e2ef963c
>> 
>> Looks good to me overall, just a couple of minor comments related to tests:
>> 
>> 1) During the 8u backport of several TLS 1.3 related tests, a system property had to be passed so TLS 1.3 was used by the client: -Djdk.tls.client.protocols. Can we now remove this and leave the tests aligned to newer releases? This would also be an additional check for the new defaults.
>> 
>> 2) The test TLSClientPropertyTest.java requires some TLS 1.3 removal undoing too.
>> 
>> For reference, this is the changeset that introduced the TLS 1.3 tests adaptation in 8u: https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/ed0d638da09f
>> 
>> Thanks,
>> Martin.-
>
> Hi @martinuy 
> Thank you a lot for the review and your comments
> Please find updates for the TLSv1.3 related tests. As you said most of the changes are revert of the tests adaptation  https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/ed0d638da09f
> Also, I have updated tests from the https://github.com/openjdk/jdk8u-dev/commit/99f78de325c864875b348e66e1c6bc9b357e899e and https://github.com/openjdk/jdk8u-dev/commit/ce0307b965040e1e3ee7cd34c0ef7da02f344f81

Hi @alexeybakhtin ,

Changes look good. Any new test failure? (I don't think but just wanted to check)

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/96