[jdk8u-dev] RFR: 8195607: sun/security/pkcs11/Secmod/TestNssDbSqlite.java failed with "NSS initialization failed" on NSS 3.34.1

Martin Balao mbalao at openjdk.org
Fri Aug 26 22:16:06 UTC 2022


On Fri, 26 Aug 2022 09:05:54 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Hi @jerboaa ,
>> 
>> Thanks for your review.
>> 
>> Let me clarify the jtreg issue. It's not that the test fails because it's run with an old jtreg. In fact, I'm running with jtreg 5 and it's failing. The problem is that the TEST.ROOT in JDK-8 does not set a "minimum jtreg required" (probably because it's a newer feature than JDK-8). In these cases, jtreg takes a conservative approach and does not split the text execution into different directories. Setting a "minimum jtreg required" in JDK-8 would be a high risk as we don't know the impact of other tests in newer or older jtreg releases. Having this test broken would be a regression. I hope we can have this fix, or you might come up with a different one. Let me know if that helps for a better understanding.
>> 
>> Martin.-
>
>> Let me clarify the jtreg issue. It's not that the test fails because it's run with an old jtreg. In fact, I'm running with jtreg 5 and it's failing. The problem is that the TEST.ROOT in JDK-8 does not set a "minimum jtreg required" (probably because it's a newer feature than JDK-8). In these cases, jtreg takes a conservative approach and does not split the text execution into different directories. Setting a "minimum jtreg required" in JDK-8 would be a high risk as we don't know the impact of other tests in newer or older jtreg releases. Having this test broken would be a regression. I hope we can have this fix, or you might come up with a different one. Let me know if that helps for a better understanding.
> 
> Thanks for the clarification. I'm fine with your approach, but https://github.com/openjdk/jdk8u-dev/commit/22c1df05d2ab51a400ebdc69566e84fdaf32efec should go in as a separate 8u-specific patch. Or we could take this as an opportunity to require jtreg 5+ (which should be fine IMHO, I don't agree it's a high risk change). Either way this should be a separate discussion with a separate bug.

Hi @jerboaa ,

Thanks for your comment.

I've committed a revert for https://github.com/openjdk/jdk8u-dev/commit/22c1df05d2ab51a400ebdc69566e84fdaf32efec and opened a new ticket for it: https://bugs.openjdk.org/browse/JDK-8292998

I'll not propose this backport to 8u until I have JDK-8292998 integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/106


More information about the jdk8u-dev mailing list