[jdk8u-dev] RFR: JDK-8292998: Clean Secmod temporary NSS DB directory before test execution

[zzambers]

On Mon, 29 Aug 2022 20:59:32 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> I wonder why "DBDIR" is created inside of "test.classes" dir. Apart from not being cleaned up this also seems like potential source of problems when tests are run concurrently. Couldn't "DBDIR" just be placed in "scratch" [1] directory? Or is there something I am missing here?
>> 
>> [1] https://openjdk.org/jtreg/faq.html#scratch-directory
>
> Hi @zzambers ,
> 
> It's a good point. I think that Secmod tests are not and have never been ready to run in parallel, at least not in 8u. As an example, they copy entire files to the same location without any file system synchronization scheme, which can potentially lead to inconsistencies. What we have fixed here is the sequential run of these tests, which was working before JDK-8195607.

@martinuy I was just thinking if just turning this line
`DBDIR = System.getProperty("test.classes", ".") + SEP + "tmpdb";`
into
`DBDIR = "." + SEP + "tmpdb";`
instead of doing manual cleanup wouldn't be simpler and more robust solution (using "scratch" dir). But I have not actually tested that...

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/115