From abakhtin at openjdk.org  Thu Dec  1 06:21:40 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Thu, 1 Dec 2022 06:21:40 GMT
Subject: [jdk8u] Integrated: 8275887: jarsigner prints invalid digest/signature
 algorithm warnings if keysize is weak/disabled
In-Reply-To: <BSQjXPQheDPTTG00DezXj_kuj1TEq9-6Me-dngya8bE=.b1b0875e-134a-4a9d-8e32-ff5e42b3f6c7@github.com>
References: <BSQjXPQheDPTTG00DezXj_kuj1TEq9-6Me-dngya8bE=.b1b0875e-134a-4a9d-8e32-ff5e42b3f6c7@github.com>
Message-ID: <73-8D9u9DlnO95ENaV645y-RS471uNLN06W6XN879p0=.3128e5c7-474f-43e2-9364-43289103272a@github.com>

On Tue, 29 Nov 2022 07:10:58 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Backported as a follow-on issue for JDK-8269039
> 
> Based on the JDK11u patch
> I had to resolve some merge issues in a few places:
> 
> TimestampCheck.java - simple merge because of no JDK-8171319 in JDK8
> ManifestEntryVerifier.java - Manually updated because of different arguments of the permits() method
> DisabledAlgorithmConstraints.java - permits() method manually updated because of no JDK-8285398
> SignerInfo.java - use explicit type instead of var
> All corresponding tests passed

This pull request has now been integrated.

Changeset: 53620b38
Author:    Alexey Bakhtin <abakhtin at openjdk.org>
URL:       https://git.openjdk.org/jdk8u/commit/53620b38d3d46344b5d5e9deb017a234828ead28
Stats:     125 lines in 9 files changed: 42 ins; 30 del; 53 mod

8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled

Reviewed-by: phh, andrew
Backport-of: 03f8c0fb9363dc1bb07bed1ae0359c029caa0130

-------------

PR: https://git.openjdk.org/jdk8u/pull/24

From abakhtin at openjdk.org  Thu Dec  1 06:25:30 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Thu, 1 Dec 2022 06:25:30 GMT
Subject: [jdk8u] RFR: 8275887: jarsigner prints invalid digest/signature
 algorithm warnings if keysize is weak/disabled
In-Reply-To: <iLBqf8xbCnPLHRYOaq7PPksziEBWKBsnx58nuI48P4o=.efcd9f4a-6089-4f3a-a04c-26d574f183c1@github.com>
References: <BSQjXPQheDPTTG00DezXj_kuj1TEq9-6Me-dngya8bE=.b1b0875e-134a-4a9d-8e32-ff5e42b3f6c7@github.com>
 <iLBqf8xbCnPLHRYOaq7PPksziEBWKBsnx58nuI48P4o=.efcd9f4a-6089-4f3a-a04c-26d574f183c1@github.com>
Message-ID: <DFQJHgfmg2baQtHxsi18f_LFHxZWrTU1SPU-qK11_E4=.2003c372-e379-4de8-855f-1c87c477a5a1@github.com>

On Wed, 30 Nov 2022 15:15:45 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Backported as a follow-on issue for JDK-8269039
>> 
>> Based on the JDK11u patch
>> I had to resolve some merge issues in a few places:
>> 
>> TimestampCheck.java - simple merge because of no JDK-8171319 in JDK8
>> ManifestEntryVerifier.java - Manually updated because of different arguments of the permits() method
>> DisabledAlgorithmConstraints.java - permits() method manually updated because of no JDK-8285398
>> SignerInfo.java - use explicit type instead of var
>> All corresponding tests passed
>
> Added `jdk8u-critical-yes` for approval.

@gnu-andrew Thank you for the review.
Should I close the [PR](https://github.com/openjdk/jdk8u-dev/pull/197) for the jdk8u-dev repo without committing? 
Or it should be completed as usual with jdk8u-fix-request label?

-------------

PR: https://git.openjdk.org/jdk8u/pull/24

From sgehwolf at openjdk.org  Thu Dec  1 09:17:33 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 1 Dec 2022 09:17:33 GMT
Subject: [jdk8u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base
 so as to recognize unified hierarchy [v3]
In-Reply-To: <BERoIfV4c8ow65YeFhL1eNJBSChUFJrYmpYe0ZZO8a4=.88dfc752-7b52-4745-92cd-42161c6c5d02@github.com>
References: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
 <FLlA7PrspxFAfPK8MEPaC8zxm4jAtcVJbDJe-rW81_E=.4fdd32af-f73c-42e3-884d-eb20ac8f3c9d@github.com>
 <BERoIfV4c8ow65YeFhL1eNJBSChUFJrYmpYe0ZZO8a4=.88dfc752-7b52-4745-92cd-42161c6c5d02@github.com>
Message-ID: <Fg4obIPQy3koK9T_X1qriY32BsOoJ2I3bdTdRqPF_Uc=.0373e6f2-b7fe-41b8-b942-49b1c3beee4d@github.com>

On Tue, 27 Sep 2022 08:10:39 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - TestCgroupSubsystemController: rework use of Files.writeString
>>  - CgroupSubsystemController: fix library paths
>>    
>>    We need the testlibrary copy of FileUtils but the test.lib.util copy of
>>    Utils (method createTempDirectory is missing from the testlib copy)
>>  - TestCgroupSubsystemController: fix jtreg @library path
>>  - Replace Arrays.compare with Arrays.equals
>>    
>>    jdk8u does not have Arrays.compare()
>>  - incorporate (part of) 8275713: TestDockerMemoryMetrics test fails on recent runc
>>    
>>    The main hunk from 8275713 was rolled up in the changes for 8231111.
>>    This line is also necessary.
>>  - update mapfile for new JNI method name
>>  - tests for the backport
>>    
>>    two files had fairly significant merge conflicts, eyeball only to resolve
>>    
>>    haven't run any of them yet -- will depend on the rest of the patch
>>  - CgroupSubsystemFactory: remove logging lines
>>    
>>    jdk8u doesn't have java.lang.System.Logger. There's no existing logging
>>    in place for other classes in the Metrics/platform/etc family that I can
>>    see, so remove it.
>>  - Metrics => CgroupV1Subsystem.java
>>    
>>    unshuffle, rename, resolve unclean hunks although I'm not sure why they
>>    didn't apply, they look trivial and the context is the same, will look
>>    closer
>>  - Metrics.java: easy commit, mostly doc-only hunks
>>  - ... and 5 more: https://git.openjdk.org/jdk8u-dev/compare/91dc4a09...0ea3c608
>
> I have ended up (artificially) making this PR depend upon pr/123, so that another PR, https://github.com/openjdk/jdk8u-dev/pull/124, can depend upon this one and get both - it depends upon both.

@jmtd Please rebase this onto latest master. Right now it looks like changes from #127 are included here, which shouldn't be?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/121

From jdowland at openjdk.org  Thu Dec  1 10:23:58 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 1 Dec 2022 10:23:58 GMT
Subject: [jdk8u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base
 so as to recognize unified hierarchy [v8]
In-Reply-To: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
References: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
Message-ID: <EyYFUu2CT6ziWeFjNjxy_iuMdDOQKYgO_tUIDN2GgrA=.251461c5-fd06-41d9-93b7-812a236e99ba@github.com>

> This is a backport of [4def210a22faaec6b47912dd314e6365ea48d28f](https://github.com/openjdk/jdk/commit/4def210a22faaec6b47912dd314e6365ea48d28f) for jdk8u-dev as part of an effort to backport cgroups v2 support.
> 
> It does not apply clean. Paths need unshuffling. A number of changes were needed for 8u support. I've structured the PR as separate commits, with each change made in a separate commit for (hopefully) ease of review.
> 
> Not all the new tests pass:     TestDockerMemoryMetrics  failing one, specifically:
> 
>     Exception in thread "main" java.lang.RuntimeException: Memory and swap limit not equal, expected : [209715200, 1073741824], got : [209715200, 864026624]
> 
> I think this is fixed in a further patch to backport, and will confirm.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:

 - Address style nit
 - TestCgroupSubsystemController: rework use of Files.writeString
 - CgroupSubsystemController: fix library paths
   
   We need the testlibrary copy of FileUtils but the test.lib.util copy of
   Utils (method createTempDirectory is missing from the testlib copy)
 - TestCgroupSubsystemController: fix jtreg @library path
 - Replace Arrays.compare with Arrays.equals
   
   jdk8u does not have Arrays.compare()
 - incorporate (part of) 8275713: TestDockerMemoryMetrics test fails on recent runc
   
   The main hunk from 8275713 was rolled up in the changes for 8231111.
   This line is also necessary.
 - update mapfile for new JNI method name
 - tests for the backport
   
   two files had fairly significant merge conflicts, eyeball only to resolve
   
   haven't run any of them yet -- will depend on the rest of the patch
 - CgroupSubsystemFactory: remove logging lines
   
   jdk8u doesn't have java.lang.System.Logger. There's no existing logging
   in place for other classes in the Metrics/platform/etc family that I can
   see, so remove it.
 - Metrics => CgroupV1Subsystem.java
   
   unshuffle, rename, resolve unclean hunks although I'm not sure why they
   didn't apply, they look trivial and the context is the same, will look
   closer
 - ... and 6 more: https://git.openjdk.org/jdk8u-dev/compare/7eb2803b...831ee9c1

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/121/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=121&range=07
  Stats: 5335 lines in 33 files changed: 3621 ins; 1582 del; 132 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/121.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/121/head:pull/121

PR: https://git.openjdk.org/jdk8u-dev/pull/121

From jdowland at openjdk.org  Thu Dec  1 10:24:00 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 1 Dec 2022 10:24:00 GMT
Subject: [jdk8u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base
 so as to recognize unified hierarchy [v3]
In-Reply-To: <BERoIfV4c8ow65YeFhL1eNJBSChUFJrYmpYe0ZZO8a4=.88dfc752-7b52-4745-92cd-42161c6c5d02@github.com>
References: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
 <FLlA7PrspxFAfPK8MEPaC8zxm4jAtcVJbDJe-rW81_E=.4fdd32af-f73c-42e3-884d-eb20ac8f3c9d@github.com>
 <BERoIfV4c8ow65YeFhL1eNJBSChUFJrYmpYe0ZZO8a4=.88dfc752-7b52-4745-92cd-42161c6c5d02@github.com>
Message-ID: <FWPVnLFWyO8_qsQrHy80_xeCB0wFFY5zxn73f4gwLtA=.459f41f7-b937-4d2b-8852-ac9d367eedb9@github.com>

On Tue, 27 Sep 2022 08:10:39 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - TestCgroupSubsystemController: rework use of Files.writeString
>>  - CgroupSubsystemController: fix library paths
>>    
>>    We need the testlibrary copy of FileUtils but the test.lib.util copy of
>>    Utils (method createTempDirectory is missing from the testlib copy)
>>  - TestCgroupSubsystemController: fix jtreg @library path
>>  - Replace Arrays.compare with Arrays.equals
>>    
>>    jdk8u does not have Arrays.compare()
>>  - incorporate (part of) 8275713: TestDockerMemoryMetrics test fails on recent runc
>>    
>>    The main hunk from 8275713 was rolled up in the changes for 8231111.
>>    This line is also necessary.
>>  - update mapfile for new JNI method name
>>  - tests for the backport
>>    
>>    two files had fairly significant merge conflicts, eyeball only to resolve
>>    
>>    haven't run any of them yet -- will depend on the rest of the patch
>>  - CgroupSubsystemFactory: remove logging lines
>>    
>>    jdk8u doesn't have java.lang.System.Logger. There's no existing logging
>>    in place for other classes in the Metrics/platform/etc family that I can
>>    see, so remove it.
>>  - Metrics => CgroupV1Subsystem.java
>>    
>>    unshuffle, rename, resolve unclean hunks although I'm not sure why they
>>    didn't apply, they look trivial and the context is the same, will look
>>    closer
>>  - Metrics.java: easy commit, mostly doc-only hunks
>>  - ... and 5 more: https://git.openjdk.org/jdk8u-dev/compare/91dc4a09...0ea3c608
>
> I have ended up (artificially) making this PR depend upon pr/123, so that another PR, https://github.com/openjdk/jdk8u-dev/pull/124, can depend upon this one and get both - it depends upon both.

> @jmtd Please rebase this onto latest master. Right now it looks like changes from https://github.com/openjdk/jdk8u-dev/pull/127 are included here, which shouldn't be?

Done.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/121

From duke at openjdk.org  Thu Dec  1 10:27:43 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Thu, 1 Dec 2022 10:27:43 GMT
Subject: [jdk8u-dev] Integrated: 8295322: Tests for JDK-8271459 were not
 backported to 11u
In-Reply-To: <RRg_ifc6dYFqJGJsAO4i7NFiyPELsvEPTQCzVRDXS44=.d092be68-b44c-4a5c-83d9-b896c9d5805e@github.com>
References: <RRg_ifc6dYFqJGJsAO4i7NFiyPELsvEPTQCzVRDXS44=.d092be68-b44c-4a5c-83d9-b896c9d5805e@github.com>
Message-ID: <39Zon0wDLX7rbgu9swvshUFF5qteqytjogebU8WdgVU=.c0f51296-2ac0-47a6-bb55-edd19533b501@github.com>

On Tue, 1 Nov 2022 07:31:19 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Here is the backport of [JDK-8295322](https://bugs.openjdk.org/browse/JDK-8295322) that adds missed tests for [JDK-8271459](https://bugs.openjdk.org/browse/JDK-8271459). Except the path shuffling the following changes were done to the original https://github.com/openjdk/jdk11u-dev/commit/70ddb1b025ce3b8eed4d8ad5af1b1fa4d0e0b015
> 
> - visibility of test class and methods was changed to `public` to support older JTReg
> - `requires` annotation was removed to support older JTReg
> 
> Verification (amd64/20.04 LTS): running new `hotspot/test/compiler/c2/TestNegativeStringBuilderCapacity.java`
> 
> 7 of 7 PASS on https://github.com/openjdk/jdk8u-dev/commit/dfeeceb224a62bd7ffbe5adfd36eebe6c853935a (integration of [JDK-8271459](https://bugs.openjdk.org/browse/JDK-8271459))
> 4 of 7 FAIL on the previous https://github.com/openjdk/jdk8u-dev/commit/43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b

This pull request has now been integrated.

Changeset: e9acfceb
Author:    Alexey Pavlyutkin <apavlyutkin at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/e9acfceb354b49a00388a46f7f3172b2d90f0680
Stats:     186 lines in 1 file changed: 186 ins; 0 del; 0 mod

8295322: Tests for JDK-8271459 were not backported to 11u

Reviewed-by: phh
Backport-of: 70ddb1b025ce3b8eed4d8ad5af1b1fa4d0e0b015

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/152

From duke at openjdk.org  Thu Dec  1 10:30:47 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Thu, 1 Dec 2022 10:30:47 GMT
Subject: [jdk8u-dev] Integrated: 8297329: [8u] hotspot needs to recognise
 VS2019
In-Reply-To: <HpPvyLcF630QeKaVLvQSOK7GL9izaIXtPR4H_ZJWETE=.525d0fa4-5e13-4df3-9f0c-7089f036821b@github.com>
References: <HpPvyLcF630QeKaVLvQSOK7GL9izaIXtPR4H_ZJWETE=.525d0fa4-5e13-4df3-9f0c-7089f036821b@github.com>
Message-ID: <JQz5O2XDwE1KPFoIR5xwRXWy5AmFdMnq9QdGxLbWcQg=.4a76a612-284f-41e7-901d-4cf89f7e9e59@github.com>

On Mon, 21 Nov 2022 10:13:25 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Please review another portion of changes to add MSVS2019 support to jdk-8. This one adds recognition of MSVS2019 compiler/linker to the hotspot build scripts and applies build rules accordingly. Before the patch the scripts didn't not know how to link precompiled headers and builds failed with the error
> 
> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
> jvm.dll : fatal error LNK1120: 1 unresolved externals
> 
> 
> Verification: MSVS2019 (32/64-bits, release/debug) builds now fail with
> 
> awt_DCHolder.cpp
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(46): error C2039: 'Do_Not_Use_calloc_Use_safe_Calloc_Instead': is not a member of '`global namespace''
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(46): error C2873: 'Do_Not_Use_calloc_Use_safe_Calloc_Instead': symbol cannot be used in a using-declaration
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(52): error C2039: 'Do_Not_Use_malloc_Use_safe_Malloc_Instead': is not a member of '`global namespace''
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(52): error C2873: 'Do_Not_Use_malloc_Use_safe_Malloc_Instead': symbol cannot be used in a using-declaration
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(58): error C2039: 'Do_Not_Use_realloc_Use_safe_Realloc_Instead': is not a member of '`global namespace''
> slowdebug/jdk/objs/libawt/awt_DCHolder.obj] Error 2
> make[2]: *** Waiting for unfinished jobs....
> 
> that will be fixed by backporting of [JDK-8241087](https://bugs.openjdk.org/browse/JDK-8241087)
> 
> Regression: MSVS2017 (32/64-bits, release/debug) build - Ok

This pull request has now been integrated.

Changeset: 7b548500
Author:    Alexey Pavlyutkin <apavlyutkin at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/7b5485004616b596e38f1205be76b91aa426ef65
Stats:     23 lines in 3 files changed: 22 ins; 0 del; 1 mod

8297329: [8u] hotspot needs to recognise VS2019

Reviewed-by: phh

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/187

From rmarchenko at openjdk.org  Thu Dec  1 10:35:49 2022
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Thu, 1 Dec 2022 10:35:49 GMT
Subject: [jdk8u-dev] RFR: 8295982: Failure in
 sun/security/tools/keytool/WeakAlg.java - ks: The process cannot access the
 file because it is being used by another process
In-Reply-To: <Fz5E8csQ8Utp6DgA1MQml67c0jCPkvcZe8E5TJyid7U=.2decc7ff-e5ad-4444-918b-23edc56cd576@github.com>
References: <Fz5E8csQ8Utp6DgA1MQml67c0jCPkvcZe8E5TJyid7U=.2decc7ff-e5ad-4444-918b-23edc56cd576@github.com>
Message-ID: <gDb9c-SOnZ6W6ISe-z1YEycZd7C4Firb-B2leXKsEcI=.eabfff87-4705-4f68-9e40-8055a0cb15f6@github.com>

On Sat, 29 Oct 2022 21:25:40 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> Test sun/security/tools/keytool/WeakAlg.java occasionally fails on Windows 64 bit (win2016, win11) with the following message "java.nio.file.FileSystemException: ks: The process cannot access the file because it is being used by another process".
> 
> The root cause of the problem is "ks" file is still open by FileInputStream instance used by KeyStore in the test code. Perhaps, forcing GC to run may avoid this issue, but I guess explicit closing of the input stream is more suitable here.
> 
> No regression, only the test code is changed.
> The test passes on Windows and Linux now.

up

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/150

From duke at openjdk.org  Thu Dec  1 10:38:08 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Thu, 1 Dec 2022 10:38:08 GMT
Subject: [jdk8u-dev] RFR: 8241087: Build failure with VS 2019 (16.5.0) due
 to C2039 and C2873 [v2]
In-Reply-To: <XUpOOW2zC4goGr3SqrQTM5NZJLTRy7vKVw0XpSPiMTs=.58ef184d-30eb-472b-81c2-7b798046dd42@github.com>
References: <XUpOOW2zC4goGr3SqrQTM5NZJLTRy7vKVw0XpSPiMTs=.58ef184d-30eb-472b-81c2-7b798046dd42@github.com>
Message-ID: <Jmk0fGtmWv2ClAXO9wucgI6pUbsphNPXOqXU7EgKbtc=.b1bc5b5d-d98f-4fc9-8337-ad0bdb882bdd@github.com>

> Hi!
> 
> Here is one more backport from MSVS2019 seria. This one fixes build failure in AWT due to C2039 and C2873. The patch from jdk-11 https://github.com/openjdk/jdk11u-dev/commit/7166e13838a545b1e75307defc2cfa173dc38d20 is applied cleanly.
> 
> Verification MSVS2019 full build succedded
> Regression: MSVS2017 / 2015 (requires `--with-extra-cflags="/wd4005 /wd4091"`) / 2013 / 2012 / 2010 - ok

Alexey Pavlyutkin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/190/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/190/files/1df93352..1df93352

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=190&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=190&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/190.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/190/head:pull/190

PR: https://git.openjdk.org/jdk8u-dev/pull/190

From duke at openjdk.org  Thu Dec  1 10:41:25 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Thu, 1 Dec 2022 10:41:25 GMT
Subject: [jdk8u-dev] RFR: 8241087: Build failure with VS 2019 (16.5.0) due
 to C2039 and C2873 [v3]
In-Reply-To: <XUpOOW2zC4goGr3SqrQTM5NZJLTRy7vKVw0XpSPiMTs=.58ef184d-30eb-472b-81c2-7b798046dd42@github.com>
References: <XUpOOW2zC4goGr3SqrQTM5NZJLTRy7vKVw0XpSPiMTs=.58ef184d-30eb-472b-81c2-7b798046dd42@github.com>
Message-ID: <1NIaYiPo4gj9QkgbTyLIClUvESuVoF9w2524bmeVloU=.18765622-c3a6-4eeb-90f7-b0b0bbe343ba@github.com>

> Hi!
> 
> Here is one more backport from MSVS2019 seria. This one fixes build failure in AWT due to C2039 and C2873. The patch from jdk-11 https://github.com/openjdk/jdk11u-dev/commit/7166e13838a545b1e75307defc2cfa173dc38d20 is applied cleanly.
> 
> Verification MSVS2019 full build succedded
> Regression: MSVS2017 / 2015 (requires `--with-extra-cflags="/wd4005 /wd4091"`) / 2013 / 2012 / 2010 - ok

Alexey Pavlyutkin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'master' of https://git.openjdk.org/jdk8u-dev into 8241087
 - Backport 7166e13838a545b1e75307defc2cfa173dc38d20
 - fix line alignment to be compliant with the baseline
 - 8297329: [8u] hotspot needs to recognise VS2019

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/190/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/190/files/1df93352..60245ad0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=190&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=190&range=01-02

  Stats: 3083 lines in 61 files changed: 2004 ins; 885 del; 194 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/190.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/190/head:pull/190

PR: https://git.openjdk.org/jdk8u-dev/pull/190

From duke at openjdk.org  Thu Dec  1 10:46:48 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Thu, 1 Dec 2022 10:46:48 GMT
Subject: [jdk8u-dev] Integrated: 8241087: Build failure with VS 2019 (16.5.0)
 due to C2039 and C2873
In-Reply-To: <XUpOOW2zC4goGr3SqrQTM5NZJLTRy7vKVw0XpSPiMTs=.58ef184d-30eb-472b-81c2-7b798046dd42@github.com>
References: <XUpOOW2zC4goGr3SqrQTM5NZJLTRy7vKVw0XpSPiMTs=.58ef184d-30eb-472b-81c2-7b798046dd42@github.com>
Message-ID: <zVqbAgh7-h_SQE6GFW2coiqZNDivUtZJQOObdWiKHcg=.e79a1556-1b5e-4a87-b64f-bf40aa11ce45@github.com>

On Tue, 22 Nov 2022 15:20:42 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Here is one more backport from MSVS2019 seria. This one fixes build failure in AWT due to C2039 and C2873. The patch from jdk-11 https://github.com/openjdk/jdk11u-dev/commit/7166e13838a545b1e75307defc2cfa173dc38d20 is applied cleanly.
> 
> Verification MSVS2019 full build succedded
> Regression: MSVS2017 / 2015 (requires `--with-extra-cflags="/wd4005 /wd4091"`) / 2013 / 2012 / 2010 - ok

This pull request has now been integrated.

Changeset: 918a2ab7
Author:    Alexey Pavlyutkin <apavlyutkin at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/918a2ab7c505aa5b22b26558b92ef4d7d6d6aeb9
Stats:     9 lines in 3 files changed: 2 ins; 5 del; 2 mod

8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873

Backport-of: 7166e13838a545b1e75307defc2cfa173dc38d20

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/190

From duke at openjdk.org  Thu Dec  1 10:58:12 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Thu, 1 Dec 2022 10:58:12 GMT
Subject: [jdk8u-dev] RFR: 8242468: VS2019 build missing vcruntime140_1.dll
 [v3]
In-Reply-To: <l1GeRxei1QKwBrvWonMZgK3lIuxzfMFaiJV5DTSvZfg=.c77c5c4f-72fb-440c-b7ba-f635a31f0b0b@github.com>
References: <l1GeRxei1QKwBrvWonMZgK3lIuxzfMFaiJV5DTSvZfg=.c77c5c4f-72fb-440c-b7ba-f635a31f0b0b@github.com>
Message-ID: <KPKhEz2ooDqCJwEuutREnKxs-5QntIsqVRkylr5DQFQ=.7a83f3bf-1c11-4708-b264-70921fe8c69d@github.com>

> Hi!
> 
> Here is another backport from MSVS2019 seria. It fixes bundling of new vcruntime140_1.dll for MSVS2019 builds. The patch https://github.com/openjdk/jdk11u-dev/commit/2548ed31aeb255a61644885c501667a74f90ebc7 is applied with the following changes:
> 
> - make/CreateJmods.gmk -> SKIPPED, cuz jdk8 does not support Jmod
> - make/hotspot/test/GtestImage.gmk -> SKIPPED, cuz jdk8 does not use GTest
> - make/autoconf/basic.m4 -> common/autoconf/basics.m4 (no conflicts)
> - make/autoconf/toolchain_windows.m4 -> common/autoconf/toolchain_windows.m4 (no conflicts)
> - make/autoconf/spec.gmk.in -> common/autoconf/spec.gmk.in (no conflicts)
> - make/lib/CoreLibraries.gmk -> jdk/make/lib/CoreLibraries.gmk (no conflicts)
> - make/devkit/createWindowsDevkit2019.sh -> make/devkit/createWindowsDevkit2019.sh (no conflicts)
> - make/copy/Copy-java.base.gmk -> jdk/make/CopyFiles.gmk: at [line#276](https://github.com/openjdk/jdk8u-dev/pull/193/files#diff-5abbf26d940be8e271c3b80169ef290847b39f577dbbf6cdfed216ca13f78d03R276) jdk11 uses `TARGETS` to hold concatenated value but jdk8 uses `COPY_FILES`
> 
> Verification: MSVS2019 32/64-bit builds populate `vcrunt~1.dll`  and `vcrunt~2.dll` to JRE images, these are `vcruntime140.dll` and `vcruntime140_1.dll` accordingly (in jdk8 `configure` script renames the DLL's to avoid 8.3 conflict. I have no idea, do we still need for this).
> Regression: MSVS2017 builds populate only vcrunt~1.dll
> 
> Note: accordingly to [JDK-8247676](https://bugs.openjdk.org/browse/JDK-8247676) 32-bit builds do not need to populate new runtime library. The backport will be done on top of this one as dependent PR

Alexey Pavlyutkin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Merge branch 'master' of https://git.openjdk.org/jdk8u-dev into 8242468
 - populating generated-configure.sh
 - Backport 2548ed31aeb255a61644885c501667a74f90ebc7
 - Backport 7166e13838a545b1e75307defc2cfa173dc38d20
 - fix line alignment to be compliant with the baseline
 - 8297329: [8u] hotspot needs to recognise VS2019

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/193/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/193/files/f471ed99..e18afb98

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=193&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=193&range=01-02

  Stats: 3083 lines in 61 files changed: 2004 ins; 885 del; 194 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/193.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/193/head:pull/193

PR: https://git.openjdk.org/jdk8u-dev/pull/193

From duke at openjdk.org  Thu Dec  1 11:03:34 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Thu, 1 Dec 2022 11:03:34 GMT
Subject: [jdk8u-dev] Integrated: 8242468: VS2019 build missing
 vcruntime140_1.dll
In-Reply-To: <l1GeRxei1QKwBrvWonMZgK3lIuxzfMFaiJV5DTSvZfg=.c77c5c4f-72fb-440c-b7ba-f635a31f0b0b@github.com>
References: <l1GeRxei1QKwBrvWonMZgK3lIuxzfMFaiJV5DTSvZfg=.c77c5c4f-72fb-440c-b7ba-f635a31f0b0b@github.com>
Message-ID: <bo-xRbo-mNF7f2SxjEY87YVnloaO02IMUgjvr8yLQ9E=.e2367649-54cf-44f4-80c5-41b6de380ee1@github.com>

On Wed, 23 Nov 2022 11:03:08 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Here is another backport from MSVS2019 seria. It fixes bundling of new vcruntime140_1.dll for MSVS2019 builds. The patch https://github.com/openjdk/jdk11u-dev/commit/2548ed31aeb255a61644885c501667a74f90ebc7 is applied with the following changes:
> 
> - make/CreateJmods.gmk -> SKIPPED, cuz jdk8 does not support Jmod
> - make/hotspot/test/GtestImage.gmk -> SKIPPED, cuz jdk8 does not use GTest
> - make/autoconf/basic.m4 -> common/autoconf/basics.m4 (no conflicts)
> - make/autoconf/toolchain_windows.m4 -> common/autoconf/toolchain_windows.m4 (no conflicts)
> - make/autoconf/spec.gmk.in -> common/autoconf/spec.gmk.in (no conflicts)
> - make/lib/CoreLibraries.gmk -> jdk/make/lib/CoreLibraries.gmk (no conflicts)
> - make/devkit/createWindowsDevkit2019.sh -> make/devkit/createWindowsDevkit2019.sh (no conflicts)
> - make/copy/Copy-java.base.gmk -> jdk/make/CopyFiles.gmk: at [line#276](https://github.com/openjdk/jdk8u-dev/pull/193/files#diff-5abbf26d940be8e271c3b80169ef290847b39f577dbbf6cdfed216ca13f78d03R276) jdk11 uses `TARGETS` to hold concatenated value but jdk8 uses `COPY_FILES`
> 
> Verification: MSVS2019 32/64-bit builds populate `vcrunt~1.dll`  and `vcrunt~2.dll` to JRE images, these are `vcruntime140.dll` and `vcruntime140_1.dll` accordingly (in jdk8 `configure` script renames the DLL's to avoid 8.3 conflict. I have no idea, do we still need for this).
> Regression: MSVS2017 builds populate only vcrunt~1.dll
> 
> Note: accordingly to [JDK-8247676](https://bugs.openjdk.org/browse/JDK-8247676) 32-bit builds do not need to populate new runtime library. The backport will be done on top of this one as dependent PR

This pull request has now been integrated.

Changeset: 1ec79849
Author:    Alexey Pavlyutkin <apavlyutkin at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/1ec79849c25aed9fa7f71c6316da62d1441abbaa
Stats:     1504 lines in 8 files changed: 1475 ins; 0 del; 29 mod

8242468: VS2019 build missing vcruntime140_1.dll

Reviewed-by: phh
Backport-of: 2548ed31aeb255a61644885c501667a74f90ebc7

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/193

From duke at openjdk.org  Thu Dec  1 11:05:32 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Thu, 1 Dec 2022 11:05:32 GMT
Subject: [jdk8u-dev] RFR: 8247676: vcruntime140_1.dll is not needed on
 32-bit Windows
In-Reply-To: <Jzt4Oav3AmFad6k6_IX9Px61QJLtgzyNanC6A9evNpE=.67a9a827-7840-4fcf-9025-248c7579f246@github.com>
References: <Jzt4Oav3AmFad6k6_IX9Px61QJLtgzyNanC6A9evNpE=.67a9a827-7840-4fcf-9025-248c7579f246@github.com>
Message-ID: <D7P2z_4nh6OD-NF5NQPKN24dUHx0e0pdIMlOFrGuDOk=.1933c58c-ea05-447c-a6d2-04de970f7ad8@github.com>

On Mon, 28 Nov 2022 07:50:30 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Here is the last backport of MSVS2019 seria. This one fixes unnecessary populating of 32-bit images with vcruntime140_1.dll. The patch from 11u applied cleanly except `generated-configure.sh` refreshing
> 
> Verification: MSVS2019 32-bit build -> JRE image contains only `vcrunt~1.dll` (`vcruntime140.dll`)
> Regression: MSVS2019 64-bit build -> JRE image still contains both `vcrunt~1.dll` (`vcruntime140.dll`) and `vcrunt~2.dll` (`vcruntime140_1.dll`)

Paul, thank you for the reviews

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/195

From sgehwolf at openjdk.org  Thu Dec  1 11:13:54 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 1 Dec 2022 11:13:54 GMT
Subject: [jdk8u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base
 so as to recognize unified hierarchy [v8]
In-Reply-To: <EyYFUu2CT6ziWeFjNjxy_iuMdDOQKYgO_tUIDN2GgrA=.251461c5-fd06-41d9-93b7-812a236e99ba@github.com>
References: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
 <EyYFUu2CT6ziWeFjNjxy_iuMdDOQKYgO_tUIDN2GgrA=.251461c5-fd06-41d9-93b7-812a236e99ba@github.com>
Message-ID: <vwpcj_2y3ZEWiD9VGo71EekSXhlAfTrmHoFHam6JN8g=.7e7e7ec5-4988-4b85-8858-5fc5b6eaf473@github.com>

On Thu, 1 Dec 2022 10:23:58 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of [4def210a22faaec6b47912dd314e6365ea48d28f](https://github.com/openjdk/jdk/commit/4def210a22faaec6b47912dd314e6365ea48d28f) for jdk8u-dev as part of an effort to backport cgroups v2 support.
>> 
>> It does not apply clean. Paths need unshuffling. A number of changes were needed for 8u support. I've structured the PR as separate commits, with each change made in a separate commit for (hopefully) ease of review.
>> 
>> Not all the new tests pass:     TestDockerMemoryMetrics  failing one, specifically:
>> 
>>     Exception in thread "main" java.lang.RuntimeException: Memory and swap limit not equal, expected : [209715200, 1073741824], got : [209715200, 864026624]
>> 
>> I think this is fixed in a further patch to backport, and will confirm.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
> 
>  - Address style nit
>  - TestCgroupSubsystemController: rework use of Files.writeString
>  - CgroupSubsystemController: fix library paths
>    
>    We need the testlibrary copy of FileUtils but the test.lib.util copy of
>    Utils (method createTempDirectory is missing from the testlib copy)
>  - TestCgroupSubsystemController: fix jtreg @library path
>  - Replace Arrays.compare with Arrays.equals
>    
>    jdk8u does not have Arrays.compare()
>  - incorporate (part of) 8275713: TestDockerMemoryMetrics test fails on recent runc
>    
>    The main hunk from 8275713 was rolled up in the changes for 8231111.
>    This line is also necessary.
>  - update mapfile for new JNI method name
>  - tests for the backport
>    
>    two files had fairly significant merge conflicts, eyeball only to resolve
>    
>    haven't run any of them yet -- will depend on the rest of the patch
>  - CgroupSubsystemFactory: remove logging lines
>    
>    jdk8u doesn't have java.lang.System.Logger. There's no existing logging
>    in place for other classes in the Metrics/platform/etc family that I can
>    see, so remove it.
>  - Metrics => CgroupV1Subsystem.java
>    
>    unshuffle, rename, resolve unclean hunks although I'm not sure why they
>    didn't apply, they look trivial and the context is the same, will look
>    closer
>  - ... and 6 more: https://git.openjdk.org/jdk8u-dev/compare/7eb2803b...831ee9c1

Marked as reviewed by sgehwolf (Reviewer).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/121

From duke at openjdk.org  Thu Dec  1 11:14:54 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Thu, 1 Dec 2022 11:14:54 GMT
Subject: [jdk8u-dev] RFR: 8247676: vcruntime140_1.dll is not needed on
 32-bit Windows [v2]
In-Reply-To: <Jzt4Oav3AmFad6k6_IX9Px61QJLtgzyNanC6A9evNpE=.67a9a827-7840-4fcf-9025-248c7579f246@github.com>
References: <Jzt4Oav3AmFad6k6_IX9Px61QJLtgzyNanC6A9evNpE=.67a9a827-7840-4fcf-9025-248c7579f246@github.com>
Message-ID: <OdAKCK6FY1Pxv6SpXFa7yutLOHifIJq7LyqlgWf2EDk=.ddfac3c2-a5bb-4098-8684-e99fd9b80423@github.com>

> Hi!
> 
> Here is the last backport of MSVS2019 seria. This one fixes unnecessary populating of 32-bit images with vcruntime140_1.dll. The patch from 11u applied cleanly except `generated-configure.sh` refreshing
> 
> Verification: MSVS2019 32-bit build -> JRE image contains only `vcrunt~1.dll` (`vcruntime140.dll`)
> Regression: MSVS2019 64-bit build -> JRE image still contains both `vcrunt~1.dll` (`vcruntime140.dll`) and `vcrunt~2.dll` (`vcruntime140_1.dll`)

Alexey Pavlyutkin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/195/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/195/files/181c30f2..181c30f2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=195&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=195&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/195.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/195/head:pull/195

PR: https://git.openjdk.org/jdk8u-dev/pull/195

From duke at openjdk.org  Thu Dec  1 11:19:48 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Thu, 1 Dec 2022 11:19:48 GMT
Subject: [jdk8u-dev] RFR: 8247676: vcruntime140_1.dll is not needed on
 32-bit Windows [v3]
In-Reply-To: <Jzt4Oav3AmFad6k6_IX9Px61QJLtgzyNanC6A9evNpE=.67a9a827-7840-4fcf-9025-248c7579f246@github.com>
References: <Jzt4Oav3AmFad6k6_IX9Px61QJLtgzyNanC6A9evNpE=.67a9a827-7840-4fcf-9025-248c7579f246@github.com>
Message-ID: <MBWuH6YpVmOAuFN6Qx-GBZo6B9CMG5bZnBdmfNkkKDY=.5c119930-95f4-4af7-912a-241e6cb4bfd7@github.com>

> Hi!
> 
> Here is the last backport of MSVS2019 seria. This one fixes unnecessary populating of 32-bit images with vcruntime140_1.dll. The patch from 11u applied cleanly except `generated-configure.sh` refreshing
> 
> Verification: MSVS2019 32-bit build -> JRE image contains only `vcrunt~1.dll` (`vcruntime140.dll`)
> Regression: MSVS2019 64-bit build -> JRE image still contains both `vcrunt~1.dll` (`vcruntime140.dll`) and `vcrunt~2.dll` (`vcruntime140_1.dll`)

Alexey Pavlyutkin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:

 - Merge master
 - populating generated-configure.sh
 - Backport 78ba1e5a5f69909ddf073cb014784127b09dd47d
 - populating generated-configure.sh
 - Backport 2548ed31aeb255a61644885c501667a74f90ebc7
 - Backport 7166e13838a545b1e75307defc2cfa173dc38d20
 - fix line alignment to be compliant with the baseline
 - 8297329: [8u] hotspot needs to recognise VS2019

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/195/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/195/files/181c30f2..5b373e7b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=195&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=195&range=01-02

  Stats: 59499 lines in 62 files changed: 2004 ins; 57301 del; 194 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/195.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/195/head:pull/195

PR: https://git.openjdk.org/jdk8u-dev/pull/195

From duke at openjdk.org  Thu Dec  1 11:24:51 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Thu, 1 Dec 2022 11:24:51 GMT
Subject: [jdk8u-dev] RFR: 8247676: vcruntime140_1.dll is not needed on
 32-bit Windows [v4]
In-Reply-To: <Jzt4Oav3AmFad6k6_IX9Px61QJLtgzyNanC6A9evNpE=.67a9a827-7840-4fcf-9025-248c7579f246@github.com>
References: <Jzt4Oav3AmFad6k6_IX9Px61QJLtgzyNanC6A9evNpE=.67a9a827-7840-4fcf-9025-248c7579f246@github.com>
Message-ID: <RRRvP-nZMLTDihCAQhWhk_YFQUvagAqTGxfW7idDbBc=.0ffd8544-6571-481e-bfbb-7cbc8fb770c3@github.com>

> Hi!
> 
> Here is the last backport of MSVS2019 seria. This one fixes unnecessary populating of 32-bit images with vcruntime140_1.dll. The patch from 11u applied cleanly except `generated-configure.sh` refreshing
> 
> Verification: MSVS2019 32-bit build -> JRE image contains only `vcrunt~1.dll` (`vcruntime140.dll`)
> Regression: MSVS2019 64-bit build -> JRE image still contains both `vcrunt~1.dll` (`vcruntime140.dll`) and `vcrunt~2.dll` (`vcruntime140_1.dll`)

Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:

  refreshing generated-configure.sh

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/195/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/195/files/5b373e7b..ce8a4623

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=195&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=195&range=02-03

  Stats: 56416 lines in 1 file changed: 56416 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/195.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/195/head:pull/195

PR: https://git.openjdk.org/jdk8u-dev/pull/195

From duke at openjdk.org  Thu Dec  1 13:20:02 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Thu, 1 Dec 2022 13:20:02 GMT
Subject: [jdk8u-dev] Integrated: 8247676: vcruntime140_1.dll is not needed on
 32-bit Windows
In-Reply-To: <Jzt4Oav3AmFad6k6_IX9Px61QJLtgzyNanC6A9evNpE=.67a9a827-7840-4fcf-9025-248c7579f246@github.com>
References: <Jzt4Oav3AmFad6k6_IX9Px61QJLtgzyNanC6A9evNpE=.67a9a827-7840-4fcf-9025-248c7579f246@github.com>
Message-ID: <0u9fIH3VKr3D53vmnCCs5ThhvKDPJUQL9RxwwoV-wkA=.e9fe069f-e4ee-4441-b082-b347cf8df8a6@github.com>

On Mon, 28 Nov 2022 07:50:30 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Here is the last backport of MSVS2019 seria. This one fixes unnecessary populating of 32-bit images with vcruntime140_1.dll. The patch from 11u applied cleanly except `generated-configure.sh` refreshing
> 
> Verification: MSVS2019 32-bit build -> JRE image contains only `vcrunt~1.dll` (`vcruntime140.dll`)
> Regression: MSVS2019 64-bit build -> JRE image still contains both `vcrunt~1.dll` (`vcruntime140.dll`) and `vcrunt~2.dll` (`vcruntime140_1.dll`)

This pull request has now been integrated.

Changeset: fcd3c9ce
Author:    Alexey Pavlyutkin <apavlyutkin at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/fcd3c9ce6b503e63f2a898467d65893a7c703734
Stats:     3 lines in 2 files changed: 0 ins; 0 del; 3 mod

8247676: vcruntime140_1.dll is not needed on 32-bit Windows

Reviewed-by: phh
Backport-of: 78ba1e5a5f69909ddf073cb014784127b09dd47d

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/195

From rmarchenko at openjdk.org  Thu Dec  1 15:29:09 2022
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Thu, 1 Dec 2022 15:29:09 GMT
Subject: [jdk8u-dev] Integrated: 8295982: Failure in
 sun/security/tools/keytool/WeakAlg.java - ks: The process cannot access the
 file because it is being used by another process
In-Reply-To: <Fz5E8csQ8Utp6DgA1MQml67c0jCPkvcZe8E5TJyid7U=.2decc7ff-e5ad-4444-918b-23edc56cd576@github.com>
References: <Fz5E8csQ8Utp6DgA1MQml67c0jCPkvcZe8E5TJyid7U=.2decc7ff-e5ad-4444-918b-23edc56cd576@github.com>
Message-ID: <5H2dVaYAEvqH_YcS8Wvd720FRwKmaA6-P-4gMhbxtlk=.cd420818-d25d-4b93-9e97-e4d2dd2c9417@github.com>

On Sat, 29 Oct 2022 21:25:40 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> Test sun/security/tools/keytool/WeakAlg.java occasionally fails on Windows 64 bit (win2016, win11) with the following message "java.nio.file.FileSystemException: ks: The process cannot access the file because it is being used by another process".
> 
> The root cause of the problem is "ks" file is still open by FileInputStream instance used by KeyStore in the test code. Perhaps, forcing GC to run may avoid this issue, but I guess explicit closing of the input stream is more suitable here.
> 
> No regression, only the test code is changed.
> The test passes on Windows and Linux now.

This pull request has now been integrated.

Changeset: 8356d04a
Author:    Roman Marchenko <rmarchenko at openjdk.org>
Committer: Andrew Brygin <bae at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/8356d04acbbb3c31c4baea034fce2f7bc0691847
Stats:     9 lines in 1 file changed: 6 ins; 0 del; 3 mod

8295982: Failure in sun/security/tools/keytool/WeakAlg.java - ks: The process cannot access the file because it is being used by another process

Reviewed-by: dcherepanov

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/150

From serb at openjdk.org  Thu Dec  1 17:09:36 2022
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 1 Dec 2022 17:09:36 GMT
Subject: [jdk8u-dev] RFR: 8284690: [macos] VoiceOver : Getting
 java.lang.IllegalArgumentException: Invalid location on Editable JComboBox
 [v2]
In-Reply-To: <tnRICaU2yXxPpxJuwg_lKzaxst3-4W-KoJVt5diXctk=.893177c3-72dd-4dfb-b384-b7b997452364@github.com>
References: <nEKWNOJZ8TtOhNhCkfx7o_CLw-ihEAUYGwsUd5trUk8=.b7ba5810-5af5-46df-a66e-3f8eb2292a93@github.com>
 <tnRICaU2yXxPpxJuwg_lKzaxst3-4W-KoJVt5diXctk=.893177c3-72dd-4dfb-b384-b7b997452364@github.com>
Message-ID: <i8r9-OFCWZjFPDt-_jgcll4sINZM8csZRBTfeV85nK4=.da49e194-1c0e-4ff7-ad25-5cacff830ba9@github.com>

On Sun, 30 Oct 2022 00:08:52 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Hi all,
>> This pull request contains a backport of commit [ebfa27b9](https://github.com/openjdk/jdk/commit/ebfa27b9f06aee8ceceabc564a78a351903ce9a1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>> The commit being backported was authored by Alexander Zuev on 25 May 2022 and was reviewed by Sergey Bylokhov.
>> Thanks!
>
> Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into JDK-8284690
>  - Backport ebfa27b9f06aee8ceceabc564a78a351903ce9a1

leave open

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/132

From vrudomet at openjdk.org  Thu Dec  1 18:06:05 2022
From: vrudomet at openjdk.org (Victor Rudometov)
Date: Thu, 1 Dec 2022 18:06:05 GMT
Subject: [jdk8u-dev] Integrated: 8286624: Regression Test
 CoordinateTruncationBug.java fails on OL8.3
In-Reply-To: <EiX9B0PlsYBmmKlp8eLgjB2WfpZeM5bISoPsUCb4HW4=.5eb2feed-8ea2-485b-ad8f-b76554e26c5d@github.com>
References: <EiX9B0PlsYBmmKlp8eLgjB2WfpZeM5bISoPsUCb4HW4=.5eb2feed-8ea2-485b-ad8f-b76554e26c5d@github.com>
Message-ID: <wTeZDQHuWl4tU7N3xyYPllYrJ1eLB2-KnhrZibG8izg=.3baaf475-13fa-4169-891d-8a4eb64d81cf@github.com>

On Tue, 29 Nov 2022 04:53:27 GMT, Victor Rudometov <vrudomet at openjdk.org> wrote:

> Backport for [JDK-8286624](https://bugs.openjdk.org/browse/JDK-8286624) Regression Test CoordinateTruncationBug.java fails on OL8.3
> 
> 
> Clean Backport, but the test needs to be moved due to 8 directory structure
> New test, low risk.
> Test passes during manual run on linux and mac.

This pull request has now been integrated.

Changeset: 77403ed2
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/77403ed2500d1560ca71e5db1dbe49401697f7f7
Stats:     271 lines in 1 file changed: 271 ins; 0 del; 0 mod

8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3

Backport-of: 7964440dd3274b84713c0debe1846092bb6d6d68

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/199

From duke at openjdk.org  Thu Dec  1 22:40:52 2022
From: duke at openjdk.org (zzambers)
Date: Thu, 1 Dec 2022 22:40:52 GMT
Subject: [jdk8u-dev] RFR: 8226236: win32:
 gc/metaspace/TestCapacityUntilGCWrapAround.java fails
In-Reply-To: <GT8ox0RRB00IkYWboYC3ffzcNu2IwtSOVo4G9bcbnw4=.40bd7a3b-2920-4895-9f02-63de9b5aaae9@github.com>
References: <RpujPbCIVt-QHe89s8lK0a5YpfCx545LNPjQLb3aTVk=.52ff5adc-8cbd-4d6c-8129-8d313694c856@github.com>
 <GT8ox0RRB00IkYWboYC3ffzcNu2IwtSOVo4G9bcbnw4=.40bd7a3b-2920-4895-9f02-63de9b5aaae9@github.com>
Message-ID: <_MnAH3QUS5-V-wz-eP43L98BVtJyYvpRYJJJ2sGMxCU=.2ed4475e-9072-42d9-8772-1bfb2b7b3324@github.com>

On Fri, 25 Nov 2022 16:44:49 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Following tests from hotspot/tier1 currently fails on Windows x86:
>> `gc/metaspace/TestCapacityUntilGCWrapAround.java` 
>> 
>> This backport fixes that failure.
>> 
>> Backport is not clear as there was some renaming done in `metaspace.cpp` file. However apart from some renames (e.g. `align_size_down` -> `align_down`, `capacity_until_GC` -> `old_capacity_until_GC`) and location of the file surrounding method looks practically the same (See original change [1]). 
>> 
>> Tested on branch with hotspot/tier1 testing enabled for x86 OSes [2]. Fixed that one test, caused no regressions (Compare [3][4]).
>> 
>> [1] https://github.com/openjdk/jdk/commit/038f58d4
>> [2] https://github.com/zzambers/jdk8u-dev/commits/metaspace-fix-test
>> [3] https://github.com/zzambers/jdk8u-dev/actions/runs/3438556844/jobs/5735312562
>> [4] https://github.com/zzambers/jdk8u-dev/actions/runs/3471835524/jobs/5803573225
>
> This looks clean to me (only path changes).

@jerboaa Thanks

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/192

From duke at openjdk.org  Fri Dec  2 08:22:49 2022
From: duke at openjdk.org (zzambers)
Date: Fri, 2 Dec 2022 08:22:49 GMT
Subject: [jdk8u-dev] Integrated: 8226236: win32:
 gc/metaspace/TestCapacityUntilGCWrapAround.java fails
In-Reply-To: <RpujPbCIVt-QHe89s8lK0a5YpfCx545LNPjQLb3aTVk=.52ff5adc-8cbd-4d6c-8129-8d313694c856@github.com>
References: <RpujPbCIVt-QHe89s8lK0a5YpfCx545LNPjQLb3aTVk=.52ff5adc-8cbd-4d6c-8129-8d313694c856@github.com>
Message-ID: <TIfO1l_y8F09-jMQI4dKPciON8rucQHcMiHrrYr2A3E=.328772e3-fb95-4e08-86b7-6b447dc8ca7a@github.com>

On Wed, 23 Nov 2022 00:25:55 GMT, zzambers <duke at openjdk.org> wrote:

> Following tests from hotspot/tier1 currently fails on Windows x86:
> `gc/metaspace/TestCapacityUntilGCWrapAround.java` 
> 
> This backport fixes that failure.
> 
> Backport is not clear as there was some renaming done in `metaspace.cpp` file. However apart from some renames (e.g. `align_size_down` -> `align_down`, `capacity_until_GC` -> `old_capacity_until_GC`) and location of the file surrounding method looks practically the same (See original change [1]). 
> 
> Tested on branch with hotspot/tier1 testing enabled for x86 OSes [2]. Fixed that one test, caused no regressions (Compare [3][4]).
> 
> [1] https://github.com/openjdk/jdk/commit/038f58d4
> [2] https://github.com/zzambers/jdk8u-dev/commits/metaspace-fix-test
> [3] https://github.com/zzambers/jdk8u-dev/actions/runs/3438556844/jobs/5735312562
> [4] https://github.com/zzambers/jdk8u-dev/actions/runs/3471835524/jobs/5803573225

This pull request has now been integrated.

Changeset: 55101454
Author:    Zdenek Zambersky <zzambers at redhat.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/5510145420117f1f3c4a933021c3675cd2a99051
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails

Backport-of: 038f58d4f0782f885547d2b052a47fdf2229cfe3

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/192

From dcherepanov at openjdk.org  Fri Dec  2 13:40:39 2022
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Fri, 2 Dec 2022 13:40:39 GMT
Subject: [jdk8u-dev] RFR: 8283277: ISO 4217 Amendment 171 Update
Message-ID: <COgMsqlyTyS32_bm0a2d_7JBRCAM0L5X8ycpxKjisSY=.2ad8c5c2-1b17-4623-bc51-e8eff7f78601@github.com>

Please review the currency data update (ISO 4217 Amendment 171 Update)

CurrencyData.properties - conflict in copyright year
ValidateISO4217.java - conflict in copyright year and bug id list
tablea1.txt - conflict in FILEVERSION
LocaleDataTest.java - conflict in bug id list

Testing: jdk/test/java/util/Currency and jdk/test/sun/text/resources passed

-------------

Commit messages:
 - Backport c4dc58e12e197562dce90c0027aa74c29047cea6

Changes: https://git.openjdk.org/jdk8u-dev/pull/202/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=202&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8283277
  Stats: 17 lines in 6 files changed: 3 ins; 0 del; 14 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/202.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/202/head:pull/202

PR: https://git.openjdk.org/jdk8u-dev/pull/202

From sgehwolf at openjdk.org  Fri Dec  2 16:02:20 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 2 Dec 2022 16:02:20 GMT
Subject: [jdk8u-dev] RFR: 8237479: 8230305 causes slowdebug build failure
 [v5]
In-Reply-To: <I-L2k9rqN9qCGiUZoAVp7OnuEkmscHO29tjPXfiw_N8=.f34d9704-dd8f-409f-8df8-6e69d20de367@github.com>
References: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
 <I-L2k9rqN9qCGiUZoAVp7OnuEkmscHO29tjPXfiw_N8=.f34d9704-dd8f-409f-8df8-6e69d20de367@github.com>
Message-ID: <oJE5Hj-YMnRTv7cTuMa-5-PdrzEKjfV3RW-gSe0nS04=.57dbf7ca-9aa4-4f1f-a0f1-7cb5c294b6eb@github.com>

On Fri, 4 Nov 2022 10:23:04 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8237479 to jdk8u-dev, as part of cgroups v2 support. It deepnds on 8230305 (pr/127) and I've set up the GitHub PR accordingly.
>> 
>> Apart from path shuffling, it applies clean.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
> 
>  - 8237479: 8230305 causes slowdebug build failure
>    
>    Declare methods as pure virtual.
>    
>    Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76
>  - 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
>    
>    The early implementation of cgroups v2 support was done with
>    crun 0.8 and it contained a bug which set memory.high over
>    memory.low when --memory-reservation was being used as a CLI
>    option.
>    
>    This bug has been fixed in later crun versions, starting with
>    crun 0.11. Use memory.low in OpenJDK as well.
>    
>    Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
>  - Address style nit
>  - TestCgroupSubsystemController: rework use of Files.writeString
>  - CgroupSubsystemController: fix library paths
>    
>    We need the testlibrary copy of FileUtils but the test.lib.util copy of
>    Utils (method createTempDirectory is missing from the testlib copy)
>  - TestCgroupSubsystemController: fix jtreg @library path
>  - Replace Arrays.compare with Arrays.equals
>    
>    jdk8u does not have Arrays.compare()
>  - incorporate (part of) 8275713: TestDockerMemoryMetrics test fails on recent runc
>    
>    The main hunk from 8275713 was rolled up in the changes for 8231111.
>    This line is also necessary.
>  - update mapfile for new JNI method name
>  - tests for the backport
>    
>    two files had fairly significant merge conflicts, eyeball only to resolve
>    
>    haven't run any of them yet -- will depend on the rest of the patch
>  - ... and 14 more: https://git.openjdk.org/jdk8u-dev/compare/f04ad96c...463f7511

Keep open, please.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/128

From ebaron at redhat.com  Fri Dec  2 16:02:33 2022
From: ebaron at redhat.com (Elliott Baron)
Date: Fri, 2 Dec 2022 11:02:33 -0500
Subject: =?UTF-8?Q?Re=3a_CFV=3a_New_OpenJDK_8_Updates_Committer=3a_Zden?=
 =?UTF-8?B?xJtrIMW9YW1iZXJza8O9?=
In-Reply-To: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>
References: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>
Message-ID: <22dfc88d-f918-340f-9bd8-117d5cc7f85d@redhat.com>

Vote: yes

On 2022-11-28 8:41 p.m., Andrew Hughes wrote:
> I hereby nominate Zden?k ?ambersk? (zzambers) [0] to OpenJDK 8 Updates
> Committer.
> 
> Zden?k is doing active backporting work for 8u [1], primarily in the
> areas of PKCS11 support and testing infrastructure. Having the
> committer role would aid this backporting work by avoiding the need to
> wait for sponsorship of fixes, after review & approval.
> 
> Votes are due by 00h00 UTC on Tuesday, the 13th of December, 2022.
> 
> Only current OpenJDK 8 Updates Committers (and above) [2] are eligible
> to vote on this nomination.
> 
> Votes must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [3].
> 
> [0] https://openjdk.java.net/census#zzambers
> [1] https://github.com/openjdk/jdk8u-dev/search?q=author:zzambers&type=commits
> [2] http://openjdk.java.net/census#jdk8u
> [3] http://openjdk.java.net/projects/#committer-vote
> 
> Thanks,


From phh at openjdk.org  Fri Dec  2 17:26:53 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 2 Dec 2022 17:26:53 GMT
Subject: [jdk8u-dev] RFR: 8283277: ISO 4217 Amendment 171 Update
In-Reply-To: <COgMsqlyTyS32_bm0a2d_7JBRCAM0L5X8ycpxKjisSY=.2ad8c5c2-1b17-4623-bc51-e8eff7f78601@github.com>
References: <COgMsqlyTyS32_bm0a2d_7JBRCAM0L5X8ycpxKjisSY=.2ad8c5c2-1b17-4623-bc51-e8eff7f78601@github.com>
Message-ID: <I3VgVz-_udiyBZZ9Zqyg7LbGEYuRS1XWiotCvcSfSkk=.05968b50-cf9e-471c-b66c-1043dbb5caa6@github.com>

On Fri, 2 Dec 2022 13:33:24 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Please review the currency data update (ISO 4217 Amendment 171 Update)
> 
> CurrencyData.properties - conflict in copyright year
> ValidateISO4217.java - conflict in copyright year and bug id list
> tablea1.txt - conflict in FILEVERSION
> LocaleDataTest.java - conflict in bug id list
> 
> Testing: jdk/test/java/util/Currency and jdk/test/sun/text/resources passed

Lgtm, but see comment.

Does the FILEVERSION conflict point to another backport to do?

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/202

From dcherepanov at openjdk.org  Fri Dec  2 17:35:30 2022
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Fri, 2 Dec 2022 17:35:30 GMT
Subject: [jdk8u-dev] RFR: 8283277: ISO 4217 Amendment 171 Update
In-Reply-To: <I3VgVz-_udiyBZZ9Zqyg7LbGEYuRS1XWiotCvcSfSkk=.05968b50-cf9e-471c-b66c-1043dbb5caa6@github.com>
References: <COgMsqlyTyS32_bm0a2d_7JBRCAM0L5X8ycpxKjisSY=.2ad8c5c2-1b17-4623-bc51-e8eff7f78601@github.com>
 <I3VgVz-_udiyBZZ9Zqyg7LbGEYuRS1XWiotCvcSfSkk=.05968b50-cf9e-471c-b66c-1043dbb5caa6@github.com>
Message-ID: <EZdViomI1YlJQQGZZ-wtNBssCbtFsAkGsONFcYLbhs0=.1e6c7bc4-8e61-4a3c-a50c-b54c1aad63cf@github.com>

On Fri, 2 Dec 2022 17:24:01 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> Does the FILEVERSION conflict point to another backport to do?

yes, it points to another bug (https://bugs.openjdk.org/browse/JDK-7102969) but I'm not really sure it makes sense to port this second patch.

> Lgtm, but see comment.

Thanks for the review. Added jdk8u-fix-request label.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/202

From phh at openjdk.org  Fri Dec  2 19:02:56 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 2 Dec 2022 19:02:56 GMT
Subject: [jdk8u-dev] RFR: 8283277: ISO 4217 Amendment 171 Update
In-Reply-To: <COgMsqlyTyS32_bm0a2d_7JBRCAM0L5X8ycpxKjisSY=.2ad8c5c2-1b17-4623-bc51-e8eff7f78601@github.com>
References: <COgMsqlyTyS32_bm0a2d_7JBRCAM0L5X8ycpxKjisSY=.2ad8c5c2-1b17-4623-bc51-e8eff7f78601@github.com>
Message-ID: <24hNZTsYXVj5zqn-YStq4a2Ihq8FdiAmK1azykHJGDo=.4108f7b5-45b4-4e96-a35c-4d4fe7688006@github.com>

On Fri, 2 Dec 2022 13:33:24 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Please review the currency data update (ISO 4217 Amendment 171 Update)
> 
> CurrencyData.properties - conflict in copyright year
> ValidateISO4217.java - conflict in copyright year and bug id list
> tablea1.txt - conflict in FILEVERSION
> LocaleDataTest.java - conflict in bug id list
> 
> Testing: jdk/test/java/util/Currency and jdk/test/sun/text/resources passed

Imo worth backporting [JDK-7102969](https://bugs.openjdk.org/browse/JDK-7102969) because it covers 3 issues that are worth fixing.

7102969: currency.properties supercede not working correctly
8149452: j.t.SimpleDateFormat.getDateFormatSymbols().getZoneStrings() returns incorrect result for some time zones
8157138: Error while fetching currency instance by Currency.getInstance(currencycode)

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/202

From ecki at zusammenkunft.net  Sun Dec  4 09:22:42 2022
From: ecki at zusammenkunft.net (Bernd)
Date: Sun, 4 Dec 2022 10:22:42 +0100
Subject: [jdk8u-dev] Integrated: 8286624: Regression Test
 CoordinateTruncationBug.java fails on OL8.3
In-Reply-To: <wTeZDQHuWl4tU7N3xyYPllYrJ1eLB2-KnhrZibG8izg=.3baaf475-13fa-4169-891d-8a4eb64d81cf@github.com>
References: <EiX9B0PlsYBmmKlp8eLgjB2WfpZeM5bISoPsUCb4HW4=.5eb2feed-8ea2-485b-ad8f-b76554e26c5d@github.com>,
 <wTeZDQHuWl4tU7N3xyYPllYrJ1eLB2-KnhrZibG8izg=.3baaf475-13fa-4169-891d-8a4eb64d81cf@github.com>
Message-ID: <60E9B450-ECB3-4144-8964-1DBFFA30E955@hxcore.ol>

An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20221204/5dc36c21/attachment.htm>

From andrew at openjdk.org  Mon Dec  5 03:39:00 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 5 Dec 2022 03:39:00 GMT
Subject: [jdk8u] RFR: 8275887: jarsigner prints invalid digest/signature
 algorithm warnings if keysize is weak/disabled
In-Reply-To: <BSQjXPQheDPTTG00DezXj_kuj1TEq9-6Me-dngya8bE=.b1b0875e-134a-4a9d-8e32-ff5e42b3f6c7@github.com>
References: <BSQjXPQheDPTTG00DezXj_kuj1TEq9-6Me-dngya8bE=.b1b0875e-134a-4a9d-8e32-ff5e42b3f6c7@github.com>
Message-ID: <JtzHctZYev6GN3cG5I6XwvzEfjy5osn35MO98u3Mvc0=.27445f81-fa15-414b-9292-3c231bab0f20@github.com>

On Tue, 29 Nov 2022 07:10:58 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Backported as a follow-on issue for JDK-8269039
> 
> Based on the JDK11u patch
> I had to resolve some merge issues in a few places:
> 
> TimestampCheck.java - simple merge because of no JDK-8171319 in JDK8
> ManifestEntryVerifier.java - Manually updated because of different arguments of the permits() method
> DisabledAlgorithmConstraints.java - permits() method manually updated because of no JDK-8285398
> SignerInfo.java - use explicit type instead of var
> All corresponding tests passed

Please close the 8u-dev PR. We'll merge the next build promotion with this change back into 8u-dev.

-------------

PR: https://git.openjdk.org/jdk8u/pull/24

From andrew at openjdk.org  Mon Dec  5 03:59:12 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 5 Dec 2022 03:59:12 GMT
Subject: [jdk8u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base
 so as to recognize unified hierarchy [v8]
In-Reply-To: <EyYFUu2CT6ziWeFjNjxy_iuMdDOQKYgO_tUIDN2GgrA=.251461c5-fd06-41d9-93b7-812a236e99ba@github.com>
References: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
 <EyYFUu2CT6ziWeFjNjxy_iuMdDOQKYgO_tUIDN2GgrA=.251461c5-fd06-41d9-93b7-812a236e99ba@github.com>
Message-ID: <EwWf89khwa3rAWmClh2P_vr9085PctC9syRXGPfasfY=.54e7dbc9-02f8-4b69-907c-8488f6186ea5@github.com>

On Thu, 1 Dec 2022 10:23:58 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of [4def210a22faaec6b47912dd314e6365ea48d28f](https://github.com/openjdk/jdk/commit/4def210a22faaec6b47912dd314e6365ea48d28f) for jdk8u-dev as part of an effort to backport cgroups v2 support.
>> 
>> It does not apply clean. Paths need unshuffling. A number of changes were needed for 8u support. I've structured the PR as separate commits, with each change made in a separate commit for (hopefully) ease of review.
>> 
>> Not all the new tests pass:     TestDockerMemoryMetrics  failing one, specifically:
>> 
>>     Exception in thread "main" java.lang.RuntimeException: Memory and swap limit not equal, expected : [209715200, 1073741824], got : [209715200, 864026624]
>> 
>> I think this is fixed in a further patch to backport, and will confirm.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
> 
>  - Address style nit
>  - TestCgroupSubsystemController: rework use of Files.writeString
>  - CgroupSubsystemController: fix library paths
>    
>    We need the testlibrary copy of FileUtils but the test.lib.util copy of
>    Utils (method createTempDirectory is missing from the testlib copy)
>  - TestCgroupSubsystemController: fix jtreg @library path
>  - Replace Arrays.compare with Arrays.equals
>    
>    jdk8u does not have Arrays.compare()
>  - incorporate (part of) 8275713: TestDockerMemoryMetrics test fails on recent runc
>    
>    The main hunk from 8275713 was rolled up in the changes for 8231111.
>    This line is also necessary.
>  - update mapfile for new JNI method name
>  - tests for the backport
>    
>    two files had fairly significant merge conflicts, eyeball only to resolve
>    
>    haven't run any of them yet -- will depend on the rest of the patch
>  - CgroupSubsystemFactory: remove logging lines
>    
>    jdk8u doesn't have java.lang.System.Logger. There's no existing logging
>    in place for other classes in the Metrics/platform/etc family that I can
>    see, so remove it.
>  - Metrics => CgroupV1Subsystem.java
>    
>    unshuffle, rename, resolve unclean hunks although I'm not sure why they
>    didn't apply, they look trivial and the context is the same, will look
>    closer
>  - ... and 6 more: https://git.openjdk.org/jdk8u-dev/compare/7eb2803b...831ee9c1

This looks ok, though again I don't see why two additional changes have been mixed in with this backport, when they could have been in follow-ups.  Thanks to @jerboaa for catching that they were in there.

Approved for 8u.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/121

From andrew at openjdk.org  Mon Dec  5 04:04:09 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 5 Dec 2022 04:04:09 GMT
Subject: [jdk8u-dev] RFR: 8253714: [cgroups v2] Soft memory limit
 incorrectly using memory.high [v4]
In-Reply-To: <8n0lFjYJzANI0BgrTJudZktSBHRfemfMmnpH1Wsofso=.bb06cc3e-7674-469f-9cbe-fc92470369f4@github.com>
References: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>
 <8n0lFjYJzANI0BgrTJudZktSBHRfemfMmnpH1Wsofso=.bb06cc3e-7674-469f-9cbe-fc92470369f4@github.com>
Message-ID: <yhMLf28celQlCVavGG6pwYptyiqhPB8yPbhbT_GrKAY=.2fed6a47-77e3-4625-aea1-6a6640990550@github.com>

On Fri, 4 Nov 2022 10:23:45 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of a cgroupsv2 related change for jdk8u-dev.
>> 
>> ----
>> 
>> The early implementation of cgroups v2 support was done with crun 0.8 and it contained a bug which set memory.high over memory.low when --memory-reservation was being used as a CLI option.
>> 
>> This bug has been fixed in later crun versions, starting with crun 0.11. Use memory.low in OpenJDK as well.
>> 
>> Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
>   
>   The early implementation of cgroups v2 support was done with
>   crun 0.8 and it contained a bug which set memory.high over
>   memory.low when --memory-reservation was being used as a CLI
>   option.
>   
>   This bug has been fixed in later crun versions, starting with
>   crun 0.11. Use memory.low in OpenJDK as well.
>   
>   Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc

Confirmed clean and approved.

Not sure why it needed 23 commits in this case...  :/

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/130

From andrew at openjdk.org  Mon Dec  5 04:10:15 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 5 Dec 2022 04:10:15 GMT
Subject: [jdk8u-dev] RFR: 8253727: [cgroups v2] Memory and swap limits
 reported incorrectly
In-Reply-To: <Q-KEOu8M2rYgapZvIwnwWSUb_4ZFQb0eIKjXWqYp2Og=.9e0cbb72-5659-43bb-83b3-8e684f94d7c1@github.com>
References: <Q-KEOu8M2rYgapZvIwnwWSUb_4ZFQb0eIKjXWqYp2Og=.9e0cbb72-5659-43bb-83b3-8e684f94d7c1@github.com>
Message-ID: <NcG4bcFopMLWW4rrTzdOYUdmWPxFNXzy2guFyYCO0a8=.bbd743ab-06a7-4b96-8f75-910304948909@github.com>

On Thu, 10 Nov 2022 16:09:34 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Clean backport to the 11u version. Only path changes.

Confirmed clean and approved.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/168

From andrew at openjdk.org  Mon Dec  5 04:15:12 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 5 Dec 2022 04:15:12 GMT
Subject: [jdk8u-dev] RFR: 8294767: 8u contains two copies of
 test/../FileUtils.java, one uses JDK9+ features
In-Reply-To: <KiYXSKr9LwNCnJkL5nqcIaLCynP4yMkAtvdqi6JGSbU=.2f495b0f-1f81-4447-bd58-1f4568ad2c80@github.com>
References: <KiYXSKr9LwNCnJkL5nqcIaLCynP4yMkAtvdqi6JGSbU=.2f495b0f-1f81-4447-bd58-1f4568ad2c80@github.com>
Message-ID: <RvVVVgx0M5Td36KjehWyZe_K-gGnUYidR6yo585d7rU=.fa22af24-9dcf-47a3-9f1a-c7fe1212848e@github.com>

On Tue, 4 Oct 2022 13:25:24 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> There are two copies of the test utility class FileUtils.java in the jdk8u-dev source tree:
> 
> 
> $ find . -name FileUtils.java
> ./jdk/test/lib/testlibrary/jdk/testlibrary/FileUtils.java
> ./jdk/test/lib/jdk/test/lib/util/FileUtils.java
> 
> 
> One of them is not used by anything. It also uses language features that are not present in 8u:
> 
> 
> $ $JAVA_HOME/bin/javac ./jdk/test/lib/jdk/test/lib/util/FileUtils.java
> # snip
> ./jdk/test/lib/jdk/test/lib/util/FileUtils.java:166: error: cannot infer type arguments for SimpleFileVisitor<T>
>             java.nio.file.Files.walkFileTree(dir, new SimpleFileVisitor<>() {
>                                                                        ^
>   reason: cannot use '<>' with anonymous inner classes
> 
> 
> The soluton for this case is simple, just remove the above file.
> 
> This is part of a wider issue of duplicated test material, but I'm filing for the one I found for now. 
> 
> * https://bugs.openjdk.org/browse/JDK-8294767

This is fine by me. Please add `jdk8u-fix-yes` to the bug and I'll approve.

I'm aware of the whole mess created by the JFR import. I'd like to clean this up and move the tests to top-level, as they are in later JDKs, but this should wait until after this CGroup backlog is done.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/129

From jdowland at openjdk.org  Mon Dec  5 04:18:17 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 5 Dec 2022 04:18:17 GMT
Subject: [jdk8u-dev] Integrated: 8231111: Cgroups v2: Rework Metrics in
 java.base so as to recognize unified hierarchy
In-Reply-To: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
References: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
Message-ID: <-0tpTnEd4Is_UNSESX0vqL4tJkzNZtlxK4Hfs5CZzig=.e1dccd7d-8ae5-4992-bc93-dc2fc929b31d@github.com>

On Wed, 21 Sep 2022 10:12:07 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of [4def210a22faaec6b47912dd314e6365ea48d28f](https://github.com/openjdk/jdk/commit/4def210a22faaec6b47912dd314e6365ea48d28f) for jdk8u-dev as part of an effort to backport cgroups v2 support.
> 
> It does not apply clean. Paths need unshuffling. A number of changes were needed for 8u support. I've structured the PR as separate commits, with each change made in a separate commit for (hopefully) ease of review.
> 
> Not all the new tests pass:     TestDockerMemoryMetrics  failing one, specifically:
> 
>     Exception in thread "main" java.lang.RuntimeException: Memory and swap limit not equal, expected : [209715200, 1073741824], got : [209715200, 864026624]
> 
> I think this is fixed in a further patch to backport, and will confirm.

This pull request has now been integrated.

Changeset: c9007cd4
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/c9007cd44db764fbd791218c6f38491f38af70c2
Stats:     5335 lines in 33 files changed: 3621 ins; 1582 del; 132 mod

8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
8275713: TestDockerMemoryMetrics test fails on recent runc
8228585: jdk/internal/platform/cgroup/TestCgroupMetrics.java - NumberFormatException because of large long values (memory limit_in_bytes)

Reviewed-by: sgehwolf, andrew
Backport-of: 4def210a22faaec6b47912dd314e6365ea48d28f

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/121

From jdowland at openjdk.org  Mon Dec  5 04:20:46 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 5 Dec 2022 04:20:46 GMT
Subject: [jdk8u-dev] RFR: 8253714: [cgroups v2] Soft memory limit
 incorrectly using memory.high [v4]
In-Reply-To: <yhMLf28celQlCVavGG6pwYptyiqhPB8yPbhbT_GrKAY=.2fed6a47-77e3-4625-aea1-6a6640990550@github.com>
References: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>
 <8n0lFjYJzANI0BgrTJudZktSBHRfemfMmnpH1Wsofso=.bb06cc3e-7674-469f-9cbe-fc92470369f4@github.com>
 <yhMLf28celQlCVavGG6pwYptyiqhPB8yPbhbT_GrKAY=.2fed6a47-77e3-4625-aea1-6a6640990550@github.com>
Message-ID: <ggzM_taZm1RL2eovKAik7xzf76WCZ6pew1covdWrMEg=.b861a411-fd63-4168-a724-4d4c6051f5ec@github.com>

On Mon, 5 Dec 2022 04:01:34 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
>> 
>>   8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
>>   
>>   The early implementation of cgroups v2 support was done with
>>   crun 0.8 and it contained a bug which set memory.high over
>>   memory.low when --memory-reservation was being used as a CLI
>>   option.
>>   
>>   This bug has been fixed in later crun versions, starting with
>>   crun 0.11. Use memory.low in OpenJDK as well.
>>   
>>   Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
>
> Confirmed clean and approved.
> 
> Not sure why it needed 23 commits in this case...  :/

@gnu-andrew  the 23 commits are likely a result of the PR branch and the target branch diverging too much so copies of already merged stuff is showing up. I?ll have to do a manual rebase of the PR before it can be integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/130

From abakhtin at openjdk.org  Mon Dec  5 07:23:06 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Mon, 5 Dec 2022 07:23:06 GMT
Subject: [jdk8u-dev] RFR: 8275887: jarsigner prints invalid
 digest/signature algorithm warnings if keysize is weak/disabled
In-Reply-To: <umtI6fNRqIuplRD52H8VXI4ElAWk47zsD1M0B5tv3iA=.9102c954-81fd-4d7e-b888-bfe0514b46d4@github.com>
References: <umtI6fNRqIuplRD52H8VXI4ElAWk47zsD1M0B5tv3iA=.9102c954-81fd-4d7e-b888-bfe0514b46d4@github.com>
Message-ID: <j0qQITGV2fcj6LwtvIYMi4MTqaY3QQvbGCXjb-6DMCs=.bc2de6e6-ad8f-4113-a45d-17d155edceba@github.com>

On Mon, 28 Nov 2022 13:25:42 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Backported as a follow-on issue for JDK-8269039
> 
> Based on the JDK11u patch
> I had to resolve some merge issues in a few places:
> - TimestampCheck.java - simple merge because of no JDK-8171319 in JDK8
> - ManifestEntryVerifier.java - Manually updated because of different arguments of the permits() method
> - DisabledAlgorithmConstraints.java - permits() method manually updated because of no JDK-8285398 
> - SignerInfo.java - use explicit type instead of var
> 
> All corresponding tests passed

The patch is submitted to jdk8u repo

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/197

From abakhtin at openjdk.org  Mon Dec  5 07:23:06 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Mon, 5 Dec 2022 07:23:06 GMT
Subject: [jdk8u-dev] Withdrawn: 8275887: jarsigner prints invalid
 digest/signature algorithm warnings if keysize is weak/disabled
In-Reply-To: <umtI6fNRqIuplRD52H8VXI4ElAWk47zsD1M0B5tv3iA=.9102c954-81fd-4d7e-b888-bfe0514b46d4@github.com>
References: <umtI6fNRqIuplRD52H8VXI4ElAWk47zsD1M0B5tv3iA=.9102c954-81fd-4d7e-b888-bfe0514b46d4@github.com>
Message-ID: <UIw-_Sj4n0gE_4pPlmtNx3AWiUO6TY-Cn7LL3m_WoIY=.bfb84b0d-5a6b-4ae6-ba72-365473dccede@github.com>

On Mon, 28 Nov 2022 13:25:42 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Backported as a follow-on issue for JDK-8269039
> 
> Based on the JDK11u patch
> I had to resolve some merge issues in a few places:
> - TimestampCheck.java - simple merge because of no JDK-8171319 in JDK8
> - ManifestEntryVerifier.java - Manually updated because of different arguments of the permits() method
> - DisabledAlgorithmConstraints.java - permits() method manually updated because of no JDK-8285398 
> - SignerInfo.java - use explicit type instead of var
> 
> All corresponding tests passed

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/197

From duke at openjdk.org  Mon Dec  5 08:31:29 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Mon, 5 Dec 2022 08:31:29 GMT
Subject: [jdk8u-dev] RFR: 8297996: [8u] generated images are broken due to
 renaming of MSVC runtime DLL's
Message-ID: <rBE3rNSo7kYwJuUUbJ-CPDin9z8f0urlq3SOHvG09PA=.c902b393-e0f7-4e77-8163-8dd0ce54ea52@github.com>

Hi!

The patch fixes Windows image generation with proper VC runtime DLL names. The problem is that MSVS2019 uses two DLL's `vcruntime140.dll` and `vcruntime140_1.dll` and their names conflict under 8.3 limitation. For this reason the [BASIC_MAKE_WINDOWS_SPACE_SAFE_CYGWIN](https://github.com/openjdk/jdk8u-dev/blob/c9007cd44db764fbd791218c6f38491f38af70c2/common/autoconf/basics_windows.m4#L53) renames DLL's to

-------------

Commit messages:
 - use BASENAME variable instead of direct call
 - refreshing generated-configure.sh
 - fixup shall not touch DLL's basename
 - refreshing generated-configure.sh
 - 2013 and the earliers still require VC runtime DLL's file name fixup
 - refreshing generated-configure.sh
 - fixes renaming of MSVC runtime DLL's

Changes: https://git.openjdk.org/jdk8u-dev/pull/203/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=203&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8297996
  Stats: 849 lines in 3 files changed: 848 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/203.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/203/head:pull/203

PR: https://git.openjdk.org/jdk8u-dev/pull/203

From duke at openjdk.org  Mon Dec  5 08:42:33 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Mon, 5 Dec 2022 08:42:33 GMT
Subject: [jdk8u-dev] RFR: 8297996: [8u] generated images are broken due to
 renaming of MSVC runtime DLL's [v2]
In-Reply-To: <rBE3rNSo7kYwJuUUbJ-CPDin9z8f0urlq3SOHvG09PA=.c902b393-e0f7-4e77-8163-8dd0ce54ea52@github.com>
References: <rBE3rNSo7kYwJuUUbJ-CPDin9z8f0urlq3SOHvG09PA=.c902b393-e0f7-4e77-8163-8dd0ce54ea52@github.com>
Message-ID: <kmwMHa8T0-HNk_CFFZYvHI4qmwGjmgs1Xt9Vqj4VSi4=.11941c4f-b7c3-431c-ad70-02c10f8e6134@github.com>

> Hi!
> 
> The patch fixes Windows image generation with proper VC runtime DLL names. The problem is that MSVS2019 uses two DLL's `vcruntime140.dll` and `vcruntime140_1.dll` and their names conflict under 8.3 limitation. For this reason the [BASIC_MAKE_WINDOWS_SPACE_SAFE_CYGWIN](https://github.com/openjdk/jdk8u-dev/blob/c9007cd44db764fbd791218c6f38491f38af70c2/common/autoconf/basics_windows.m4#L53) renames DLL's to

Alexey Pavlyutkin has updated the pull request incrementally with two additional commits since the last revision:

 - Merge branch '8297996' of https://github.com/apavlyutkin/jdk8u-dev into 8297996
 - forcing pre-sumbit test

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/203/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/203/files/570384f1..72cfc731

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=203&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=203&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/203.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/203/head:pull/203

PR: https://git.openjdk.org/jdk8u-dev/pull/203

From sgehwolf at openjdk.org  Mon Dec  5 08:50:10 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 5 Dec 2022 08:50:10 GMT
Subject: [jdk8u-dev] RFR: 8294767: 8u contains two copies of
 test/../FileUtils.java, one uses JDK9+ features
In-Reply-To: <RvVVVgx0M5Td36KjehWyZe_K-gGnUYidR6yo585d7rU=.fa22af24-9dcf-47a3-9f1a-c7fe1212848e@github.com>
References: <KiYXSKr9LwNCnJkL5nqcIaLCynP4yMkAtvdqi6JGSbU=.2f495b0f-1f81-4447-bd58-1f4568ad2c80@github.com>
 <RvVVVgx0M5Td36KjehWyZe_K-gGnUYidR6yo585d7rU=.fa22af24-9dcf-47a3-9f1a-c7fe1212848e@github.com>
Message-ID: <4f90VDL5HOzkMoT5IM2iPbsttCR-qzmfnLJkWUXdbvI=.10657136-11da-45e6-bfe0-8076db65bd59@github.com>

On Mon, 5 Dec 2022 04:12:40 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is fine by me. Please add `jdk8u-fix-yes` to the bug and I'll approve.

`jdk8u-fix-request` not, `jdk8u-fix-yes` ;-)

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/129

From sgehwolf at openjdk.org  Mon Dec  5 08:56:32 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 5 Dec 2022 08:56:32 GMT
Subject: [jdk8u-dev] RFR: 8253714: [cgroups v2] Soft memory limit
 incorrectly using memory.high [v4]
In-Reply-To: <ggzM_taZm1RL2eovKAik7xzf76WCZ6pew1covdWrMEg=.b861a411-fd63-4168-a724-4d4c6051f5ec@github.com>
References: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>
 <8n0lFjYJzANI0BgrTJudZktSBHRfemfMmnpH1Wsofso=.bb06cc3e-7674-469f-9cbe-fc92470369f4@github.com>
 <yhMLf28celQlCVavGG6pwYptyiqhPB8yPbhbT_GrKAY=.2fed6a47-77e3-4625-aea1-6a6640990550@github.com>
 <ggzM_taZm1RL2eovKAik7xzf76WCZ6pew1covdWrMEg=.b861a411-fd63-4168-a724-4d4c6051f5ec@github.com>
Message-ID: <C_uSvugtCYKTQ7uyRKMqssT_u5SL-ADhWVOj32Fg_lQ=.1f4d414f-bc51-40da-b5e5-bb1c4a419ccc@github.com>

On Mon, 5 Dec 2022 04:15:33 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> Confirmed clean and approved.
>> 
>> Not sure why it needed 23 commits in this case...  :/
>
> @gnu-andrew  the 23 commits are likely a result of the PR branch and the target branch diverging too much so copies of already merged stuff is showing up. I?ll have to do a manual rebase of the PR before it can be integrated.

@jmtd Please rebase to latest master. Happy for you to mark as `/clean` again, once that's done. This will likely be a recurring theme (manual rebase/cherry-pick) for other dependent PRs :-/

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/130

From jdowland at openjdk.org  Mon Dec  5 09:20:33 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 5 Dec 2022 09:20:33 GMT
Subject: [jdk8u-dev] RFR: 8253714: [cgroups v2] Soft memory limit
 incorrectly using memory.high [v5]
In-Reply-To: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>
References: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>
Message-ID: <Qn2Ls4_Fgrf9yXIxwnSuCO-lEbvxiPH9osxuNJq6jow=.252cf31b-7098-47da-9100-42464b37763c@github.com>

> This is a backport of a cgroupsv2 related change for jdk8u-dev.
> 
> ----
> 
> The early implementation of cgroups v2 support was done with crun 0.8 and it contained a bug which set memory.high over memory.low when --memory-reservation was being used as a CLI option.
> 
> This bug has been fixed in later crun versions, starting with crun 0.11. Use memory.low in OpenJDK as well.
> 
> Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
  
  The early implementation of cgroups v2 support was done with
  crun 0.8 and it contained a bug which set memory.high over
  memory.low when --memory-reservation was being used as a CLI
  option.
  
  This bug has been fixed in later crun versions, starting with
  crun 0.11. Use memory.low in OpenJDK as well.
  
  Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/130/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=130&range=04
  Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/130.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/130/head:pull/130

PR: https://git.openjdk.org/jdk8u-dev/pull/130

From jdowland at openjdk.org  Mon Dec  5 09:20:36 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 5 Dec 2022 09:20:36 GMT
Subject: [jdk8u-dev] RFR: 8253714: [cgroups v2] Soft memory limit
 incorrectly using memory.high [v4]
In-Reply-To: <8n0lFjYJzANI0BgrTJudZktSBHRfemfMmnpH1Wsofso=.bb06cc3e-7674-469f-9cbe-fc92470369f4@github.com>
References: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>
 <8n0lFjYJzANI0BgrTJudZktSBHRfemfMmnpH1Wsofso=.bb06cc3e-7674-469f-9cbe-fc92470369f4@github.com>
Message-ID: <MFgTRwV9CUboD0013rsLOS-raMyfjmOdpIywutNgR8M=.50bc1b5f-7cf1-4f02-a63e-742e95c0ef72@github.com>

On Fri, 4 Nov 2022 10:23:45 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of a cgroupsv2 related change for jdk8u-dev.
>> 
>> ----
>> 
>> The early implementation of cgroups v2 support was done with crun 0.8 and it contained a bug which set memory.high over memory.low when --memory-reservation was being used as a CLI option.
>> 
>> This bug has been fixed in later crun versions, starting with crun 0.11. Use memory.low in OpenJDK as well.
>> 
>> Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
>   
>   The early implementation of cgroups v2 support was done with
>   crun 0.8 and it contained a bug which set memory.high over
>   memory.low when --memory-reservation was being used as a CLI
>   option.
>   
>   This bug has been fixed in later crun versions, starting with
>   crun 0.11. Use memory.low in OpenJDK as well.
>   
>   Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc

Greatings from Schipol!

@jerboaa :
> Please rebase to latest master.

Done

> Happy for you to mark as /clean again, once that's done. 

OK

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/130

From sgehwolf at openjdk.org  Mon Dec  5 09:24:12 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 5 Dec 2022 09:24:12 GMT
Subject: [jdk8u-dev] RFR: 8253727: [cgroups v2] Memory and swap limits
 reported incorrectly [v2]
In-Reply-To: <Q-KEOu8M2rYgapZvIwnwWSUb_4ZFQb0eIKjXWqYp2Og=.9e0cbb72-5659-43bb-83b3-8e684f94d7c1@github.com>
References: <Q-KEOu8M2rYgapZvIwnwWSUb_4ZFQb0eIKjXWqYp2Og=.9e0cbb72-5659-43bb-83b3-8e684f94d7c1@github.com>
Message-ID: <tEy1C-x6dReWD43z_-UmcDX6vliY_8dVvVEf4qYZmOs=.60675096-ae88-47bd-a44e-0f7a98c8ada5@github.com>

> Clean backport to the 11u version. Only path changes.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/168/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/168/files/8bb7bb07..8bb7bb07

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=168&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=168&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/168.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/168/head:pull/168

PR: https://git.openjdk.org/jdk8u-dev/pull/168

From sgehwolf at openjdk.org  Mon Dec  5 09:55:14 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 5 Dec 2022 09:55:14 GMT
Subject: [jdk8u-dev] RFR: 8253714: [cgroups v2] Soft memory limit
 incorrectly using memory.high [v5]
In-Reply-To: <Qn2Ls4_Fgrf9yXIxwnSuCO-lEbvxiPH9osxuNJq6jow=.252cf31b-7098-47da-9100-42464b37763c@github.com>
References: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>
 <Qn2Ls4_Fgrf9yXIxwnSuCO-lEbvxiPH9osxuNJq6jow=.252cf31b-7098-47da-9100-42464b37763c@github.com>
Message-ID: <92g91Llk_U9q2QLDxk0Dx0wbqkBL7H1w4pZ1QTwhTJs=.b690fa55-ea0c-4938-8a53-4b4ae2a0b27d@github.com>

On Mon, 5 Dec 2022 09:20:33 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of a cgroupsv2 related change for jdk8u-dev.
>> 
>> ----
>> 
>> The early implementation of cgroups v2 support was done with crun 0.8 and it contained a bug which set memory.high over memory.low when --memory-reservation was being used as a CLI option.
>> 
>> This bug has been fixed in later crun versions, starting with crun 0.11. Use memory.low in OpenJDK as well.
>> 
>> Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
>   
>   The early implementation of cgroups v2 support was done with
>   crun 0.8 and it contained a bug which set memory.high over
>   memory.low when --memory-reservation was being used as a CLI
>   option.
>   
>   This bug has been fixed in later crun versions, starting with
>   crun 0.11. Use memory.low in OpenJDK as well.
>   
>   Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc

Looks good. Feel free to integrate.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/130

From aoqi at openjdk.org  Mon Dec  5 13:43:41 2022
From: aoqi at openjdk.org (Ao Qi)
Date: Mon, 5 Dec 2022 13:43:41 GMT
Subject: [jdk8u-dev] RFR: 8296485: BuildEEBasicConstraints.java test fails
 with SunCertPathBuilderException
In-Reply-To: <8yq4gpfHabsQEKOqSC-8BVJh-5GXQQPL965JAenQNcs=.e31bf92c-494b-4ecc-a10e-8a9eb48dcc35@github.com>
References: <8yq4gpfHabsQEKOqSC-8BVJh-5GXQQPL965JAenQNcs=.e31bf92c-494b-4ecc-a10e-8a9eb48dcc35@github.com>
Message-ID: <MD5KkHl835T6rgxzy70EkWpLT0LlXHYzSAsGD-Mgw8w=.74180822-50dd-440e-883d-a40601b639b0@github.com>

On Mon, 21 Nov 2022 15:31:36 GMT, Ao Qi <aoqi at openjdk.org> wrote:

> I request the backport for parity with Oracle JDK 8. The patch applies clean after the fix of the copyright year and the import part. This backport is only a test change and fixes the test failure.

I see `jdk8u-fix-yes`.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/188

From aoqi at openjdk.org  Mon Dec  5 13:45:09 2022
From: aoqi at openjdk.org (Ao Qi)
Date: Mon, 5 Dec 2022 13:45:09 GMT
Subject: [jdk8u-dev] RFR: 8296480:
 java/security/cert/pkix/policyChanges/TestPolicy.java is failing
In-Reply-To: <Eobym4MMbA4sIvCZ9LKyHpWhjFmFaa7irTElhjJXgVI=.f1fb70be-d04b-4a00-bcdf-255de8631783@github.com>
References: <Eobym4MMbA4sIvCZ9LKyHpWhjFmFaa7irTElhjJXgVI=.f1fb70be-d04b-4a00-bcdf-255de8631783@github.com>
Message-ID: <-p_992EOgMuoLFYqmmVrr0WIlJgRuSpYfC2nuTfcq8g=.b29c6a98-19f9-4b9f-b765-0837820dc1a2@github.com>

On Mon, 21 Nov 2022 15:46:18 GMT, Ao Qi <aoqi at openjdk.org> wrote:

> I request the backport for parity with Oracle JDK 8. The patch applies clean. This backport is only a test change and fixes the test failure.

I see `jdk8u-fix-yes`.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/189

From sgehwolf at openjdk.org  Mon Dec  5 13:52:21 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 5 Dec 2022 13:52:21 GMT
Subject: [jdk8u-dev] RFR: 8296480:
 java/security/cert/pkix/policyChanges/TestPolicy.java is failing
In-Reply-To: <Eobym4MMbA4sIvCZ9LKyHpWhjFmFaa7irTElhjJXgVI=.f1fb70be-d04b-4a00-bcdf-255de8631783@github.com>
References: <Eobym4MMbA4sIvCZ9LKyHpWhjFmFaa7irTElhjJXgVI=.f1fb70be-d04b-4a00-bcdf-255de8631783@github.com>
Message-ID: <9KtBhvdsaLEqh0GcAP39LbtwJ8bDBnlHcyZpDxL8OAw=.1bbf8f57-b4db-4003-9ce8-edd0425015fc@github.com>

On Mon, 21 Nov 2022 15:46:18 GMT, Ao Qi <aoqi at openjdk.org> wrote:

> I request the backport for parity with Oracle JDK 8. The patch applies clean. This backport is only a test change and fixes the test failure.

Please enable testing on your fork going forward.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/189

From aoqi at openjdk.org  Mon Dec  5 13:53:59 2022
From: aoqi at openjdk.org (Ao Qi)
Date: Mon, 5 Dec 2022 13:53:59 GMT
Subject: [jdk8u-dev] Integrated: 8296480:
 java/security/cert/pkix/policyChanges/TestPolicy.java is failing
In-Reply-To: <Eobym4MMbA4sIvCZ9LKyHpWhjFmFaa7irTElhjJXgVI=.f1fb70be-d04b-4a00-bcdf-255de8631783@github.com>
References: <Eobym4MMbA4sIvCZ9LKyHpWhjFmFaa7irTElhjJXgVI=.f1fb70be-d04b-4a00-bcdf-255de8631783@github.com>
Message-ID: <QJsyeKbDFsbtb748-c6n8uYzsHgS5UlYowuPIizrryo=.16f0aa76-eb1a-4bb4-9a44-c767eb7cd240@github.com>

On Mon, 21 Nov 2022 15:46:18 GMT, Ao Qi <aoqi at openjdk.org> wrote:

> I request the backport for parity with Oracle JDK 8. The patch applies clean. This backport is only a test change and fixes the test failure.

This pull request has now been integrated.

Changeset: 21a12369
Author:    Ao Qi <aoqi at openjdk.org>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/21a123695dc17bd7618e9059ec9453bdec5318b0
Stats:     6 lines in 1 file changed: 5 ins; 0 del; 1 mod

8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing

Backport-of: b6ea69c06aca7f013e26596cebd039960c5b4d34

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/189

From aoqi at openjdk.org  Mon Dec  5 13:57:40 2022
From: aoqi at openjdk.org (Ao Qi)
Date: Mon, 5 Dec 2022 13:57:40 GMT
Subject: [jdk8u-dev] Integrated: 8296485: BuildEEBasicConstraints.java test
 fails with SunCertPathBuilderException
In-Reply-To: <8yq4gpfHabsQEKOqSC-8BVJh-5GXQQPL965JAenQNcs=.e31bf92c-494b-4ecc-a10e-8a9eb48dcc35@github.com>
References: <8yq4gpfHabsQEKOqSC-8BVJh-5GXQQPL965JAenQNcs=.e31bf92c-494b-4ecc-a10e-8a9eb48dcc35@github.com>
Message-ID: <rIgpYiIZu8oNC8BRdIYnlah1wPZ8GPXroLlOLwReqvY=.d4f20ec7-a340-4122-99c9-277bdfc5f2bb@github.com>

On Mon, 21 Nov 2022 15:31:36 GMT, Ao Qi <aoqi at openjdk.org> wrote:

> I request the backport for parity with Oracle JDK 8. The patch applies clean after the fix of the copyright year and the import part. This backport is only a test change and fixes the test failure.

This pull request has now been integrated.

Changeset: 4388fa8e
Author:    Ao Qi <aoqi at openjdk.org>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/4388fa8e9d00248dce0e1af7fa90e55eb74b43d6
Stats:     8 lines in 1 file changed: 7 ins; 0 del; 1 mod

8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException

Reviewed-by: phh
Backport-of: 520db1eeb18797c782ddfad90467e19bbdd424ac

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/188

From andrew at openjdk.org  Mon Dec  5 14:25:21 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 5 Dec 2022 14:25:21 GMT
Subject: [jdk8u-dev] RFR: 8237479: 8230305 causes slowdebug build failure
 [v5]
In-Reply-To: <I-L2k9rqN9qCGiUZoAVp7OnuEkmscHO29tjPXfiw_N8=.f34d9704-dd8f-409f-8df8-6e69d20de367@github.com>
References: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
 <I-L2k9rqN9qCGiUZoAVp7OnuEkmscHO29tjPXfiw_N8=.f34d9704-dd8f-409f-8df8-6e69d20de367@github.com>
Message-ID: <RV6jgsTKz3KBwFKGPf3QA_W-kA0QWhYUdiXczIFSC-c=.15a6d45c-7403-4fb2-9b5b-7bb793de9989@github.com>

On Fri, 4 Nov 2022 10:23:04 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8237479 to jdk8u-dev, as part of cgroups v2 support. It deepnds on 8230305 (pr/127) and I've set up the GitHub PR accordingly.
>> 
>> Apart from path shuffling, it applies clean.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
> 
>  - 8237479: 8230305 causes slowdebug build failure
>    
>    Declare methods as pure virtual.
>    
>    Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76
>  - 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
>    
>    The early implementation of cgroups v2 support was done with
>    crun 0.8 and it contained a bug which set memory.high over
>    memory.low when --memory-reservation was being used as a CLI
>    option.
>    
>    This bug has been fixed in later crun versions, starting with
>    crun 0.11. Use memory.low in OpenJDK as well.
>    
>    Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
>  - Address style nit
>  - TestCgroupSubsystemController: rework use of Files.writeString
>  - CgroupSubsystemController: fix library paths
>    
>    We need the testlibrary copy of FileUtils but the test.lib.util copy of
>    Utils (method createTempDirectory is missing from the testlib copy)
>  - TestCgroupSubsystemController: fix jtreg @library path
>  - Replace Arrays.compare with Arrays.equals
>    
>    jdk8u does not have Arrays.compare()
>  - incorporate (part of) 8275713: TestDockerMemoryMetrics test fails on recent runc
>    
>    The main hunk from 8275713 was rolled up in the changes for 8231111.
>    This line is also necessary.
>  - update mapfile for new JNI method name
>  - tests for the backport
>    
>    two files had fairly significant merge conflicts, eyeball only to resolve
>    
>    haven't run any of them yet -- will depend on the rest of the patch
>  - ... and 14 more: https://git.openjdk.org/jdk8u-dev/compare/f04ad96c...463f7511

I can't see what changes are actually being made here. It should just be a couple of changes to one file, not 41. Do we need to rebase or something?

It would also be good to do that so the Windows tests run.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/128

From duke at openjdk.org  Mon Dec  5 18:27:35 2022
From: duke at openjdk.org (Joshua Cao)
Date: Mon, 5 Dec 2022 18:27:35 GMT
Subject: [jdk8u-dev] Integrated: 6829250: Reg test:
 java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows
In-Reply-To: <vYo8xnt2GA6jyezcthEVhMJIumpcgTIzW3BeoND0W2Q=.676694b2-8069-4aa3-8c49-96e19565c05f@github.com>
References: <vYo8xnt2GA6jyezcthEVhMJIumpcgTIzW3BeoND0W2Q=.676694b2-8069-4aa3-8c49-96e19565c05f@github.com>
Message-ID: <veJ1Yo4zUFzFqUv4DEpuIF02ZG2RVXDkjGevK93qnVY=.97f2c1f3-ef55-4b72-8b43-8f96e42a6317@github.com>

On Thu, 20 Oct 2022 19:33:00 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Passes `jdk/test/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java` on my Windows machine. Not a clean backport due to:
> 
> * fix file paths
> * affected test not included in ProblemList.txt in JDK8. No change required in ProblemList.txt
> * conflict in copyright year
> 
> Rest is clean.

This pull request has now been integrated.

Changeset: a983a003
Author:    Joshua Cao <joshcao at amazon.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/a983a003976a98ca4d2041b2550d789792b71801
Stats:     9 lines in 1 file changed: 6 ins; 1 del; 2 mod

6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows

Reviewed-by: phh
Backport-of: f56396f1689ea7e13dea78dcb1d14dcce94da898

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/145

From vrudomet at openjdk.org  Mon Dec  5 18:49:44 2022
From: vrudomet at openjdk.org (Victor Rudometov)
Date: Mon, 5 Dec 2022 18:49:44 GMT
Subject: [jdk8u-dev] Integrated: 8296632: Write a test to verify the content
 change of TextArea sends TextEvent
In-Reply-To: <3iBoe9F74XwEmBrC3MyA3HVJcVGClcWeaLwZgSIDAmw=.6cd549af-59c0-4abc-9d91-231a7b689b94@github.com>
References: <3iBoe9F74XwEmBrC3MyA3HVJcVGClcWeaLwZgSIDAmw=.6cd549af-59c0-4abc-9d91-231a7b689b94@github.com>
Message-ID: <KbNOrQwyOEQwrZcYC1jOuE3KuXGxj_puo4g4Mw4G7Qg=.8c486b37-5a89-4f16-b56a-2d27f0ae37fa@github.com>

On Tue, 29 Nov 2022 03:10:42 GMT, Victor Rudometov <vrudomet at openjdk.org> wrote:

> Backport for [JDK-8296632](https://bugs.openjdk.org/browse/JDK-8296632) Write a test to verify the content change of TextArea sends TextEvent 
> 
> Clean Backport, but the test needs to be moved due to 8 directory structure
> New test, low risk.
> Test passes during manual run on linux and mac.

This pull request has now been integrated.

Changeset: 72269ee9
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/72269ee95f2aaea02bf818b4e84cecc5ad23be38
Stats:     141 lines in 1 file changed: 141 ins; 0 del; 0 mod

8296632: Write a test to verify the content change of TextArea sends TextEvent

Backport-of: 14592778b19af792f7394be381c3e23bf216372d

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/198

From btaylor at openjdk.org  Mon Dec  5 23:21:34 2022
From: btaylor at openjdk.org (Ben Taylor)
Date: Mon, 5 Dec 2022 23:21:34 GMT
Subject: [jdk8u-dev] Integrated: 8257620: Do not use objc_msgSend_stret to get
 macOS version
In-Reply-To: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
References: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
Message-ID: <DG0Ure1VTGZlQivxTnIM58iySwBKotko-YwlBsw4FwM=.3c648886-3f85-49bb-974f-30ba2a0305a6@github.com>

On Tue, 1 Nov 2022 20:44:38 GMT, Ben Taylor <btaylor at openjdk.org> wrote:

> This backports [JDK-8257620](https://bugs.openjdk.org/browse/JDK-8257620) for parity with Oracle JDK8 and OpenJDK 11+. 
> 
> The backport is not clean because [JDK-8269850](https://bugs.openjdk.org/browse/JDK-8269850) was applied first in 8u. If that change is backed out and reapplied after this backport, both are clean.
> 
> Change applied with:
> - `git revert 43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b` (backout JDK-8269850)
> - `git backport --from https://github.com/openjdk/jdk d4c7db5060978302382549246f9ad6831f19377d` (apply JDK-8257620)
> - `git backport --from https://github.com/openjdk/jdk 3b1b8fc646493eae5f4df828afe29abb75fa5e60` (re-apply JDK-8269850)
> - `git rebase -i HEAD~3` (squash commits)

This pull request has now been integrated.

Changeset: 2abc2062
Author:    Ben Taylor <btaylor at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/2abc2062b6706d7cdd01a9d95c46de3a63e9c763
Stats:     8 lines in 1 file changed: 4 ins; 0 del; 4 mod

8257620: Do not use objc_msgSend_stret to get macOS version

Reviewed-by: akozlov, phh, omikhaltcova
Backport-of: d4c7db5060978302382549246f9ad6831f19377d

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/153

From andrew at openjdk.org  Tue Dec  6 02:00:30 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 6 Dec 2022 02:00:30 GMT
Subject: [jdk8u-dev] RFR: 8294767: 8u contains two copies of
 test/../FileUtils.java, one uses JDK9+ features
In-Reply-To: <4f90VDL5HOzkMoT5IM2iPbsttCR-qzmfnLJkWUXdbvI=.10657136-11da-45e6-bfe0-8076db65bd59@github.com>
References: <KiYXSKr9LwNCnJkL5nqcIaLCynP4yMkAtvdqi6JGSbU=.2f495b0f-1f81-4447-bd58-1f4568ad2c80@github.com>
 <RvVVVgx0M5Td36KjehWyZe_K-gGnUYidR6yo585d7rU=.fa22af24-9dcf-47a3-9f1a-c7fe1212848e@github.com>
 <4f90VDL5HOzkMoT5IM2iPbsttCR-qzmfnLJkWUXdbvI=.10657136-11da-45e6-bfe0-8076db65bd59@github.com>
Message-ID: <ZVnkgbs2WDvauFHOKM8kirsva-cgZWaPn14P0TmbXkU=.7f7484c8-3918-4bb3-908d-2cf300eb4736@github.com>

On Mon, 5 Dec 2022 08:48:03 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> > This is fine by me. Please add `jdk8u-fix-yes` to the bug and I'll approve.
> 
> `jdk8u-fix-request` not, `jdk8u-fix-yes` ;-)

Heh, yeah :) I see you both added the right ones now, so this is ready to integrate.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/129

From andrew at openjdk.org  Tue Dec  6 02:05:18 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 6 Dec 2022 02:05:18 GMT
Subject: [jdk8u-dev] RFR: 8291570: [TESTBUG] Part of JDK-8250984 absent
 from 11u
In-Reply-To: <37RigSmjiXfQ216QBRI2ew1ln2GVMWFa3q0Da3RTVC8=.90472b38-3ea7-481e-add1-f9a607dfc203@github.com>
References: <37RigSmjiXfQ216QBRI2ew1ln2GVMWFa3q0Da3RTVC8=.90472b38-3ea7-481e-add1-f9a607dfc203@github.com>
Message-ID: <Tq_1hbgZoFZx3l4LCiEVhnLcc3ziCxlYu0rWRQTXuQY=.8d749535-4483-41cd-b186-09df07613545@github.com>

On Tue, 15 Nov 2022 10:08:51 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a clean backport of 8291570 (from jdk11u) as part of cgroups v2 support.
> 
> The affected test passes for me after the patch.

Yes, same ordering issue we had in 11u for which I filed this bug. Please add `jdk8u-fix-request` and I'll approve.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/175

From aoqi at openjdk.org  Tue Dec  6 02:18:27 2022
From: aoqi at openjdk.org (Ao Qi)
Date: Tue, 6 Dec 2022 02:18:27 GMT
Subject: [jdk8u-dev] RFR: 8296485: BuildEEBasicConstraints.java test fails
 with SunCertPathBuilderException
In-Reply-To: <8yq4gpfHabsQEKOqSC-8BVJh-5GXQQPL965JAenQNcs=.e31bf92c-494b-4ecc-a10e-8a9eb48dcc35@github.com>
References: <8yq4gpfHabsQEKOqSC-8BVJh-5GXQQPL965JAenQNcs=.e31bf92c-494b-4ecc-a10e-8a9eb48dcc35@github.com>
Message-ID: <RROA0n6i16dcSA56Pwet6K6QTuUVS0MSY_8DbdHEiVg=.b6b3eae2-c0a8-4fa8-868a-2e8896abe785@github.com>

On Mon, 21 Nov 2022 15:31:36 GMT, Ao Qi <aoqi at openjdk.org> wrote:

> I request the backport for parity with Oracle JDK 8. The patch applies clean after the fix of the copyright year and the import part. This backport is only a test change and fixes the test failure.

Thanks, @jerboaa !

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/188

From aoqi at openjdk.org  Tue Dec  6 02:24:28 2022
From: aoqi at openjdk.org (Ao Qi)
Date: Tue, 6 Dec 2022 02:24:28 GMT
Subject: [jdk8u-dev] RFR: 8296480:
 java/security/cert/pkix/policyChanges/TestPolicy.java is failing
In-Reply-To: <9KtBhvdsaLEqh0GcAP39LbtwJ8bDBnlHcyZpDxL8OAw=.1bbf8f57-b4db-4003-9ce8-edd0425015fc@github.com>
References: <Eobym4MMbA4sIvCZ9LKyHpWhjFmFaa7irTElhjJXgVI=.f1fb70be-d04b-4a00-bcdf-255de8631783@github.com>
 <9KtBhvdsaLEqh0GcAP39LbtwJ8bDBnlHcyZpDxL8OAw=.1bbf8f57-b4db-4003-9ce8-edd0425015fc@github.com>
Message-ID: <zvamik4mpbITmFD9DRSdp1um5xF24lkL9e2uf34RVPc=.d46bcb4d-5635-4636-9268-058d67e064be@github.com>

On Mon, 5 Dec 2022 13:49:29 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> I request the backport for parity with Oracle JDK 8. The patch applies clean. This backport is only a test change and fixes the test failure.
>
> Please enable testing on your fork going forward.

Thanks, @jerboaa ! I have realized GHA of my fork is disabled after the PR is created and I have enabled it, but I don't know how to trigger it manually. It will work next time:)

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/189

From serb at openjdk.org  Tue Dec  6 03:31:46 2022
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 6 Dec 2022 03:31:46 GMT
Subject: [jdk8u-dev] Integrated: 8284690: [macos] VoiceOver : Getting
 java.lang.IllegalArgumentException: Invalid location on Editable JComboBox
In-Reply-To: <nEKWNOJZ8TtOhNhCkfx7o_CLw-ihEAUYGwsUd5trUk8=.b7ba5810-5af5-46df-a66e-3f8eb2292a93@github.com>
References: <nEKWNOJZ8TtOhNhCkfx7o_CLw-ihEAUYGwsUd5trUk8=.b7ba5810-5af5-46df-a66e-3f8eb2292a93@github.com>
Message-ID: <T-w6Fa0v7n5MAjxMVbWqIs1g1O3pUceYRP42QZTI_Ns=.9cdc396e-624e-458e-9fff-87a07bf0d5eb@github.com>

On Mon, 10 Oct 2022 01:56:29 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> This pull request contains a backport of commit [ebfa27b9](https://github.com/openjdk/jdk/commit/ebfa27b9f06aee8ceceabc564a78a351903ce9a1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> The commit being backported was authored by Alexander Zuev on 25 May 2022 and was reviewed by Sergey Bylokhov.
> Thanks!

This pull request has now been integrated.

Changeset: d13b8131
Author:    Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/d13b8131bf6612de0a83d6e4721d554a74c2f664
Stats:     4 lines in 1 file changed: 2 ins; 0 del; 2 mod

8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox

Backport-of: ebfa27b9f06aee8ceceabc564a78a351903ce9a1

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/132

From serb at openjdk.org  Tue Dec  6 03:40:27 2022
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 6 Dec 2022 03:40:27 GMT
Subject: [jdk8u-dev] Integrated: 8296496: Overzealous check in sizecalc.h
 prevents large memory allocation
In-Reply-To: <SgGzFGkk2MJraD92GsJg8KkX9QSHl3BvFbOStFbNsgE=.c21d4fe6-6123-47e7-9fea-27500e758257@github.com>
References: <SgGzFGkk2MJraD92GsJg8KkX9QSHl3BvFbOStFbNsgE=.c21d4fe6-6123-47e7-9fea-27500e758257@github.com>
Message-ID: <9nAdUKu6SGCuks9oWwXMbxGP6fFalXZyoIUb406aSIk=.3f3b9e6c-b8dd-4960-9411-4cf3009a6cd4@github.com>

On Thu, 24 Nov 2022 02:37:43 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> This pull request contains a backport of commit [84e12244](https://github.com/openjdk/jdk/commit/84e12244a4ff82b3307a5ffe6fbe9dded7b08d86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> The commit being backported was authored by Alexander Zuev on 10 Nov 2022 and was reviewed by Alexey Ivanov and Alexander Zvegintsev.
> Thanks!

This pull request has now been integrated.

Changeset: da681cf9
Author:    Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/da681cf9103486eb33319349fa800e79241aea44
Stats:     11 lines in 1 file changed: 0 ins; 4 del; 7 mod

8296496: Overzealous check in sizecalc.h prevents large memory allocation

Backport-of: 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/194

From serb at openjdk.org  Tue Dec  6 03:42:55 2022
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 6 Dec 2022 03:42:55 GMT
Subject: [jdk8u-dev] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2
 [v2]
In-Reply-To: <RfX6lPy1qDiPOBRJSTBo5jcpRZS7t7BTaBpafYfmjj0=.b20bb399-e5ce-43fd-9cbc-a0b8f8fed508@github.com>
References: <RfX6lPy1qDiPOBRJSTBo5jcpRZS7t7BTaBpafYfmjj0=.b20bb399-e5ce-43fd-9cbc-a0b8f8fed508@github.com>
Message-ID: <_t38iRRFngqGR-OELAU_uVz7pzod4m6Y_jpZg-e7tpU=.d04d8b96-f008-4dda-bf55-9b02ad50a39a@github.com>

> Hi all,
> This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov.
> Thanks!

Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/196/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/196/files/17138c00..17138c00

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=196&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=196&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/196.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/196/head:pull/196

PR: https://git.openjdk.org/jdk8u-dev/pull/196

From serb at openjdk.org  Tue Dec  6 03:46:01 2022
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 6 Dec 2022 03:46:01 GMT
Subject: [jdk8u-dev] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2
 [v3]
In-Reply-To: <RfX6lPy1qDiPOBRJSTBo5jcpRZS7t7BTaBpafYfmjj0=.b20bb399-e5ce-43fd-9cbc-a0b8f8fed508@github.com>
References: <RfX6lPy1qDiPOBRJSTBo5jcpRZS7t7BTaBpafYfmjj0=.b20bb399-e5ce-43fd-9cbc-a0b8f8fed508@github.com>
Message-ID: <mknPTrbI2dIJf0yZ8jp3oDQNvcxScK-MKd7l3limYCQ=.b99270d6-ec98-43c8-a085-cfa09b7ffa11@github.com>

> Hi all,
> This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov.
> Thanks!

Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into mrserb-backport-fb6c992f
 - Backport fb6c992f325981c42c7f75109a6c9db7ca8715d8
 - Backport 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/196/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/196/files/17138c00..5698959c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=196&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=196&range=01-02

  Stats: 9745 lines in 85 files changed: 7247 ins; 2258 del; 240 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/196.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/196/head:pull/196

PR: https://git.openjdk.org/jdk8u-dev/pull/196

From jdowland at openjdk.org  Tue Dec  6 05:32:52 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 6 Dec 2022 05:32:52 GMT
Subject: [jdk8u-dev] Integrated: 8294767: 8u contains two copies of
 test/../FileUtils.java, one uses JDK9+ features
In-Reply-To: <KiYXSKr9LwNCnJkL5nqcIaLCynP4yMkAtvdqi6JGSbU=.2f495b0f-1f81-4447-bd58-1f4568ad2c80@github.com>
References: <KiYXSKr9LwNCnJkL5nqcIaLCynP4yMkAtvdqi6JGSbU=.2f495b0f-1f81-4447-bd58-1f4568ad2c80@github.com>
Message-ID: <Mp7Oi_p0qExaZu1T_a93lbLWLpEZhc-cRsJVLOTU--E=.4aeaf901-ae44-4f55-82ab-d5d9e6afda38@github.com>

On Tue, 4 Oct 2022 13:25:24 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> There are two copies of the test utility class FileUtils.java in the jdk8u-dev source tree:
> 
> 
> $ find . -name FileUtils.java
> ./jdk/test/lib/testlibrary/jdk/testlibrary/FileUtils.java
> ./jdk/test/lib/jdk/test/lib/util/FileUtils.java
> 
> 
> One of them is not used by anything. It also uses language features that are not present in 8u:
> 
> 
> $ $JAVA_HOME/bin/javac ./jdk/test/lib/jdk/test/lib/util/FileUtils.java
> # snip
> ./jdk/test/lib/jdk/test/lib/util/FileUtils.java:166: error: cannot infer type arguments for SimpleFileVisitor<T>
>             java.nio.file.Files.walkFileTree(dir, new SimpleFileVisitor<>() {
>                                                                        ^
>   reason: cannot use '<>' with anonymous inner classes
> 
> 
> The soluton for this case is simple, just remove the above file.
> 
> This is part of a wider issue of duplicated test material, but I'm filing for the one I found for now. 
> 
> * https://bugs.openjdk.org/browse/JDK-8294767

This pull request has now been integrated.

Changeset: 2ad48cb3
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/2ad48cb3ca0e79346d74dccb5c172a7f017c5c6d
Stats:     276 lines in 1 file changed: 0 ins; 276 del; 0 mod

8294767: 8u contains two copies of test/../FileUtils.java, one uses JDK9+ features

Reviewed-by: sgehwolf, andrew

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/129

From serb at openjdk.org  Tue Dec  6 05:49:14 2022
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 6 Dec 2022 05:49:14 GMT
Subject: [jdk8u-dev] Integrated: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2
In-Reply-To: <RfX6lPy1qDiPOBRJSTBo5jcpRZS7t7BTaBpafYfmjj0=.b20bb399-e5ce-43fd-9cbc-a0b8f8fed508@github.com>
References: <RfX6lPy1qDiPOBRJSTBo5jcpRZS7t7BTaBpafYfmjj0=.b20bb399-e5ce-43fd-9cbc-a0b8f8fed508@github.com>
Message-ID: <PIcghwr_AAPecSqhd_GRPvKtw-8uZqQaGN2lSecXnho=.dc0a5597-b9de-4719-a27a-9c4bb40d131e@github.com>

On Mon, 28 Nov 2022 07:50:57 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov.
> Thanks!

This pull request has now been integrated.

Changeset: 3f44b9bf
Author:    Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/3f44b9bfdd447c3cca889631e529ab57a1310e95
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8296957: One more cast in SAFE_SIZE_NEW_ARRAY2

Backport-of: fb6c992f325981c42c7f75109a6c9db7ca8715d8

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/196

From duke at openjdk.org  Tue Dec  6 18:00:54 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 6 Dec 2022 18:00:54 GMT
Subject: [jdk8u-dev] Integrated: 8295952: Problemlist existing compiler/rtm
 tests also on x86
In-Reply-To: <tA2t6MeeJUTzjggQ6InGf95NkmyEj8MyfgYVjIKtm6U=.29c92380-a676-4cfe-b8d6-f51e78cb0555@github.com>
References: <tA2t6MeeJUTzjggQ6InGf95NkmyEj8MyfgYVjIKtm6U=.29c92380-a676-4cfe-b8d6-f51e78cb0555@github.com>
Message-ID: <_MrdSvTL2xk1FY-vT2UQpd94DVN-eH8gtY2drnoMI1w=.77823a2f-611b-4163-927c-d42d2a74f67e@github.com>

On Wed, 23 Nov 2022 00:00:07 GMT, zzambers <duke at openjdk.org> wrote:

> Problemlist should be extended so that existing compiler/rtm entries include x86 (32-bit) intel builds as well, as these are also affected.

This pull request has now been integrated.

Changeset: 40e7b68f
Author:    Zdenek Zambersky <zzambers at redhat.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/40e7b68f2ed4bcba5c270856eadc15720a9d354e
Stats:     11 lines in 1 file changed: 0 ins; 0 del; 11 mod

8295952: Problemlist existing compiler/rtm tests also on x86

Reviewed-by: sgehwolf
Backport-of: 3f2f128af6ec2f9097af7758bfd41aeaa4354d40

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/191

From jdowland at openjdk.org  Wed Dec  7 02:14:12 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 7 Dec 2022 02:14:12 GMT
Subject: [jdk8u-dev] Integrated: 8253714: [cgroups v2] Soft memory limit
 incorrectly using memory.high
In-Reply-To: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>
References: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>
Message-ID: <ModeHsVBp2ZWZ3TxoRyR0PzwaAcruFHCieG_3VNI4Ug=.0c4a1d0e-d52c-40c9-9f4a-e442e67bee51@github.com>

On Wed, 5 Oct 2022 08:41:27 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of a cgroupsv2 related change for jdk8u-dev.
> 
> ----
> 
> The early implementation of cgroups v2 support was done with crun 0.8 and it contained a bug which set memory.high over memory.low when --memory-reservation was being used as a CLI option.
> 
> This bug has been fixed in later crun versions, starting with crun 0.11. Use memory.low in OpenJDK as well.
> 
> Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc

This pull request has now been integrated.

Changeset: 633acfab
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/633acfabf29e73b9f9cffedd2604c6fa652b9ebe
Stats:     4 lines in 3 files changed: 0 ins; 0 del; 4 mod

8253714: [cgroups v2] Soft memory limit incorrectly using memory.high

The early implementation of cgroups v2 support was done with
crun 0.8 and it contained a bug which set memory.high over
memory.low when --memory-reservation was being used as a CLI
option.

This bug has been fixed in later crun versions, starting with
crun 0.11. Use memory.low in OpenJDK as well.

Reviewed-by: andrew
Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/130

From jdowland at openjdk.org  Wed Dec  7 03:30:01 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 7 Dec 2022 03:30:01 GMT
Subject: [jdk8u-dev] RFR: 8237479: 8230305 causes slowdebug build failure
 [v6]
In-Reply-To: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
References: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
Message-ID: <VmdFKIBc-fz3JOhA--TMLnlpU-3R01kzHhAV6YTdktg=.6886642e-902e-4f63-9052-1a365a3e66f2@github.com>

> This is a backport of 8237479 to jdk8u-dev, as part of cgroups v2 support. It deepnds on 8230305 (pr/127) and I've set up the GitHub PR accordingly.
> 
> Apart from path shuffling, it applies clean.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8237479: 8230305 causes slowdebug build failure
  
  Declare methods as pure virtual.
  
  Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/128/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=128&range=05
  Stats: 14 lines in 1 file changed: 0 ins; 0 del; 14 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/128.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/128/head:pull/128

PR: https://git.openjdk.org/jdk8u-dev/pull/128

From jdowland at openjdk.org  Wed Dec  7 03:48:16 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 7 Dec 2022 03:48:16 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot [v7]
In-Reply-To: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
Message-ID: <bkOyb_6hGnDZpDhSlqz8ExQptCL9TRFzI2258ApUMDI=.13ab6b56-7562-4797-93c6-3665b6857d92@github.com>

> This is a backport of add18914fb1294999877b563c734a25b4c17b922 for cgroups v2 support injdk8u-dev, via the 11u backport.
> 
> It does not apply clean:
> 
>  * context issues for changes made for the different approach for logging in 8u
>  * copyright lines
> 
> Small amount of re-working of new code that used `log_trace`/`log_debug` to use the 8u approach.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:

 - Update file path in comment
 - Severin's test fixes. Thanks!
 - Move test to a more 8u-appropriate location
   
   Container (cgroups, docker) tests in 8u reside in
   hotspot/test/runtime/containers
 - remove duplicate include of osContainer_linux
   
   With the backport of 8189762, the include of osContainer_linux was
   moved to a later #ifdef stanza, relative to the original. This caused
   a context problem with this backport.
 - 8239785: Cgroups: Incorrect detection logic on old systems in hotspot
   
   Return NULL subsystem if no cgroup controllers are mounted.
   
   Reviewed-by: sgehwolf
   Backport-of: add18914fb1294999877b563c734a25b4c17b922

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/135/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=135&range=06
  Stats: 749 lines in 7 files changed: 573 ins; 95 del; 81 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/135.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/135/head:pull/135

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From sgehwolf at openjdk.org  Wed Dec  7 10:51:10 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 7 Dec 2022 10:51:10 GMT
Subject: [jdk8u-dev] RFR: 8253727: [cgroups v2] Memory and swap limits
 reported incorrectly [v3]
In-Reply-To: <Q-KEOu8M2rYgapZvIwnwWSUb_4ZFQb0eIKjXWqYp2Og=.9e0cbb72-5659-43bb-83b3-8e684f94d7c1@github.com>
References: <Q-KEOu8M2rYgapZvIwnwWSUb_4ZFQb0eIKjXWqYp2Og=.9e0cbb72-5659-43bb-83b3-8e684f94d7c1@github.com>
Message-ID: <SjVsyDyWaaOcjTo4Y85PvyjeqxTp4-gPU2RU3OoZJIo=.d211f52a-0f6c-4ec6-a7bb-bae7b3315f71@github.com>

> Clean backport to the 11u version. Only path changes.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8253727: [cgroups v2] Memory and swap limits reported incorrectly
  
  Account for interface files for swap and memory being reported independently.
  The cgroup v1-like value is now reported by adding the memory.max value to
  the memory.swap.max value, and memory.current and memory.swap.current
  respectively.
  
  Backport-of: 3e96721cd9d1e1f46711e70dfc22064bab212b64

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/168/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=168&range=02
  Stats: 47 lines in 3 files changed: 42 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/168.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/168/head:pull/168

PR: https://git.openjdk.org/jdk8u-dev/pull/168

From sgehwolf at openjdk.org  Wed Dec  7 10:54:34 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 7 Dec 2022 10:54:34 GMT
Subject: [jdk8u-dev] RFR: 8237479: 8230305 causes slowdebug build failure
 [v5]
In-Reply-To: <RV6jgsTKz3KBwFKGPf3QA_W-kA0QWhYUdiXczIFSC-c=.15a6d45c-7403-4fb2-9b5b-7bb793de9989@github.com>
References: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
 <I-L2k9rqN9qCGiUZoAVp7OnuEkmscHO29tjPXfiw_N8=.f34d9704-dd8f-409f-8df8-6e69d20de367@github.com>
 <RV6jgsTKz3KBwFKGPf3QA_W-kA0QWhYUdiXczIFSC-c=.15a6d45c-7403-4fb2-9b5b-7bb793de9989@github.com>
Message-ID: <5vfLG4K_p_PLATDzDfKAWafVVS_nHkAWdSivoMY53VQ=.52b4ad16-425a-492a-9ded-e8a61f00a9d9@github.com>

On Mon, 5 Dec 2022 14:21:40 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
>> 
>>  - 8237479: 8230305 causes slowdebug build failure
>>    
>>    Declare methods as pure virtual.
>>    
>>    Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76
>>  - 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
>>    
>>    The early implementation of cgroups v2 support was done with
>>    crun 0.8 and it contained a bug which set memory.high over
>>    memory.low when --memory-reservation was being used as a CLI
>>    option.
>>    
>>    This bug has been fixed in later crun versions, starting with
>>    crun 0.11. Use memory.low in OpenJDK as well.
>>    
>>    Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
>>  - Address style nit
>>  - TestCgroupSubsystemController: rework use of Files.writeString
>>  - CgroupSubsystemController: fix library paths
>>    
>>    We need the testlibrary copy of FileUtils but the test.lib.util copy of
>>    Utils (method createTempDirectory is missing from the testlib copy)
>>  - TestCgroupSubsystemController: fix jtreg @library path
>>  - Replace Arrays.compare with Arrays.equals
>>    
>>    jdk8u does not have Arrays.compare()
>>  - incorporate (part of) 8275713: TestDockerMemoryMetrics test fails on recent runc
>>    
>>    The main hunk from 8275713 was rolled up in the changes for 8231111.
>>    This line is also necessary.
>>  - update mapfile for new JNI method name
>>  - tests for the backport
>>    
>>    two files had fairly significant merge conflicts, eyeball only to resolve
>>    
>>    haven't run any of them yet -- will depend on the rest of the patch
>>  - ... and 14 more: https://git.openjdk.org/jdk8u-dev/compare/f04ad96c...463f7511
>
> I can't see what changes are actually being made here. It should just be a couple of changes to one file, not 41. Do we need to rebase or something?
> 
> It would also be good to do that so the Windows tests run.

@gnu-andrew Please have another look for 8u approval. Thank you!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/128

From jdowland at openjdk.org  Wed Dec  7 10:57:23 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 7 Dec 2022 10:57:23 GMT
Subject: [jdk8u-dev] RFR: 8253797: [cgroups v2] Account for the fact that
 swap accounting is disabled on some systems [v2]
In-Reply-To: <yV0TTtmloYwEpPcxo1xeYZj-R3vJNJ_M0muQ1T4kthM=.57959f64-9110-49ab-8738-3f4efc8b131d@github.com>
References: <yV0TTtmloYwEpPcxo1xeYZj-R3vJNJ_M0muQ1T4kthM=.57959f64-9110-49ab-8738-3f4efc8b131d@github.com>
Message-ID: <zIqlBDEmKVl0LM5OR6ofLk3SMWXFCgMFh5nU97Lh4yA=.e0745871-29df-42ec-8313-e26c05b1280a@github.com>

> This is a clean backport of 8253797 (via 11u) for jdk8u-dev for cgroups v2 support.
> 
> The changed files are exercised by the jtreg test `TestSystemMetrics.java` which passes on my cgroups v2 system.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/185/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/185/files/48414a2a..48414a2a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=185&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=185&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/185.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/185/head:pull/185

PR: https://git.openjdk.org/jdk8u-dev/pull/185

From sgehwolf at openjdk.org  Wed Dec  7 15:06:34 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 7 Dec 2022 15:06:34 GMT
Subject: [jdk8u-dev] Integrated: 8253727: [cgroups v2] Memory and swap limits
 reported incorrectly
In-Reply-To: <Q-KEOu8M2rYgapZvIwnwWSUb_4ZFQb0eIKjXWqYp2Og=.9e0cbb72-5659-43bb-83b3-8e684f94d7c1@github.com>
References: <Q-KEOu8M2rYgapZvIwnwWSUb_4ZFQb0eIKjXWqYp2Og=.9e0cbb72-5659-43bb-83b3-8e684f94d7c1@github.com>
Message-ID: <M_9auwwN7S-vL9S6uwiYcEf63S6eu__uYpWzxQSHN1g=.06c85c1b-dec8-45d6-88fa-3b302941bfb6@github.com>

On Thu, 10 Nov 2022 16:09:34 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Clean backport to the 11u version. Only path changes.

This pull request has now been integrated.

Changeset: 97d00caf
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/97d00caf3d79f534da431d373dfbae8e93f735cd
Stats:     47 lines in 3 files changed: 42 ins; 0 del; 5 mod

8253727: [cgroups v2] Memory and swap limits reported incorrectly

Account for interface files for swap and memory being reported independently.
The cgroup v1-like value is now reported by adding the memory.max value to
the memory.swap.max value, and memory.current and memory.swap.current
respectively.

Reviewed-by: andrew
Backport-of: 3e96721cd9d1e1f46711e70dfc22064bab212b64

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/168

From jdowland at openjdk.org  Wed Dec  7 15:47:43 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 7 Dec 2022 15:47:43 GMT
Subject: [jdk8u-dev] RFR: 8253797: [cgroups v2] Account for the fact that
 swap accounting is disabled on some systems [v3]
In-Reply-To: <yV0TTtmloYwEpPcxo1xeYZj-R3vJNJ_M0muQ1T4kthM=.57959f64-9110-49ab-8738-3f4efc8b131d@github.com>
References: <yV0TTtmloYwEpPcxo1xeYZj-R3vJNJ_M0muQ1T4kthM=.57959f64-9110-49ab-8738-3f4efc8b131d@github.com>
Message-ID: <AS_qt4GDd9inrSepm4Eij7s4mco82_qgEnxmLntVUQY=.24e11d69-1925-4777-963d-5d8f0a5f9115@github.com>

> This is a clean backport of 8253797 (via 11u) for jdk8u-dev for cgroups v2 support.
> 
> The changed files are exercised by the jtreg test `TestSystemMetrics.java` which passes on my cgroups v2 system.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems
  
  Backport-of: 669361117d30c9904813b6f728714f8d6abe8484

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/185/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=185&range=02
  Stats: 45 lines in 2 files changed: 24 ins; 1 del; 20 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/185.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/185/head:pull/185

PR: https://git.openjdk.org/jdk8u-dev/pull/185

From duke at openjdk.org  Wed Dec  7 18:33:53 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 7 Dec 2022 18:33:53 GMT
Subject: [jdk8u-dev] RFR: 8298307: Enable hotspot/tier1 for 32-bit builds in
 GHA for 8u
Message-ID: <3PIxuJ0yXRaPo7_acjGtyKYct2KeNm8uLQxkBJymS4I=.99650462-679c-430c-850d-f23e7b54bdbd@github.com>

All issues in hotspot/tier1 affecting 32-bit builds are now resolved so these configurations can now be enabled in GHA.

Notes:
- hotspot/tier1 on linux requires working C/C++ compiler for some tests (gcc multilib packages are required for linux-x86)
- hotspot/tier1 contains some container tests, but ubuntu:latest does not include 32-bit libs by default. Multilib image needs to be created.

-------------

Commit messages:
 - Enable hotspot/tier1 testing on x86

Changes: https://git.openjdk.org/jdk8u-dev/pull/204/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=204&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8298307
  Stats: 16 lines in 1 file changed: 8 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/204.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/204/head:pull/204

PR: https://git.openjdk.org/jdk8u-dev/pull/204

From andrew at openjdk.org  Thu Dec  8 06:10:15 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 8 Dec 2022 06:10:15 GMT
Subject: [jdk8u-dev] RFR: 8237479: 8230305 causes slowdebug build failure
 [v6]
In-Reply-To: <VmdFKIBc-fz3JOhA--TMLnlpU-3R01kzHhAV6YTdktg=.6886642e-902e-4f63-9052-1a365a3e66f2@github.com>
References: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
 <VmdFKIBc-fz3JOhA--TMLnlpU-3R01kzHhAV6YTdktg=.6886642e-902e-4f63-9052-1a365a3e66f2@github.com>
Message-ID: <N6hFLcDEfw_L-hAKetNQoTZXgf3hlloyGNp7ac7EoTY=.82840ae8-33b2-414c-a921-8fe53f8621c8@github.com>

On Wed, 7 Dec 2022 03:30:01 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8237479 to jdk8u-dev, as part of cgroups v2 support. It deepnds on 8230305 (pr/127) and I've set up the GitHub PR accordingly.
>> 
>> Apart from path shuffling, it applies clean.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8237479: 8230305 causes slowdebug build failure
>   
>   Declare methods as pure virtual.
>   
>   Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76

Thanks. Much clearer now what's going on. Approved for 8u.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/128

From jdowland at openjdk.org  Thu Dec  8 20:23:37 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 8 Dec 2022 20:23:37 GMT
Subject: [jdk8u-dev] Integrated: 8237479: 8230305 causes slowdebug build
 failure
In-Reply-To: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
References: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
Message-ID: <QkxRTfudgRhW292H9G92x7sL32pKE02i7RPs-J7_t2Y=.e356125c-6129-4906-b36d-1214b570891c@github.com>

On Tue, 4 Oct 2022 09:40:02 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8237479 to jdk8u-dev, as part of cgroups v2 support. It deepnds on 8230305 (pr/127) and I've set up the GitHub PR accordingly.
> 
> Apart from path shuffling, it applies clean.

This pull request has now been integrated.

Changeset: 362cf762
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/362cf7628b73f4112bee464cea52a8a29e6671ce
Stats:     14 lines in 1 file changed: 0 ins; 0 del; 14 mod

8237479: 8230305 causes slowdebug build failure

Declare methods as pure virtual.

Reviewed-by: sgehwolf, andrew
Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/128

From rmarchenko at openjdk.org  Fri Dec  9 09:48:00 2022
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Fri, 9 Dec 2022 09:48:00 GMT
Subject: [jdk8u-dev] RFR: 8065422: Trailing dot in hostname causes TLS
 handshake to fail with SNI disabled
Message-ID: <8cGmyej6l-EDJL3S3OPRf-JxyrImPBIR1loWvWPsa10=.3f353c2f-23b1-40db-b6d4-e277fc57cb58@github.com>

clean backport

-------------

Commit messages:
 - Backport a95ee5ada230a0177517efd3a417f319066169dd

Changes: https://git.openjdk.org/jdk8u-dev/pull/205/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=205&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8065422
  Stats: 616 lines in 4 files changed: 613 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/205.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/205/head:pull/205

PR: https://git.openjdk.org/jdk8u-dev/pull/205

From rmarchenko at openjdk.org  Fri Dec  9 09:56:32 2022
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Fri, 9 Dec 2022 09:56:32 GMT
Subject: [jdk8u-dev] RFR: 8282398: EndingDotHostname.java test fails because
 SSL cert expired
Message-ID: <aSKp6K9ZjFpaadF_MmFQN0zl_-coClaorCAGjTLWNRQ=.a09d41b5-e8d6-4d38-9821-efbabd29e393@github.com>

clean backport

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/205

Commit messages:
 - Backport afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e

Changes: https://git.openjdk.org/jdk8u-dev/pull/206/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=206&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8282398
  Stats: 202 lines in 2 files changed: 30 ins; 2 del; 170 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/206.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/206/head:pull/206

PR: https://git.openjdk.org/jdk8u-dev/pull/206

From rmarchenko at openjdk.org  Fri Dec  9 10:08:07 2022
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Fri, 9 Dec 2022 10:08:07 GMT
Subject: [jdk8u-dev] RFR: 8282511: Use fixed certificate validation date in
 SSLExampleCert template
Message-ID: <aAOj7bNYHwji49wXzu9p8BVoPm2Gdj6PhdQoQCfOMwY=.3cfd795c-f6c4-44cc-a5e1-e0f486ffb92a@github.com>

clean backport

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/206

Commit messages:
 - Backport 268fa693188b685de6289927ee5a1e99473a50f6

Changes: https://git.openjdk.org/jdk8u-dev/pull/207/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=207&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8282511
  Stats: 218 lines in 2 files changed: 37 ins; 2 del; 179 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/207.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/207/head:pull/207

PR: https://git.openjdk.org/jdk8u-dev/pull/207

From sgehwolf at openjdk.org  Fri Dec  9 11:07:02 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 9 Dec 2022 11:07:02 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot [v7]
In-Reply-To: <bkOyb_6hGnDZpDhSlqz8ExQptCL9TRFzI2258ApUMDI=.13ab6b56-7562-4797-93c6-3665b6857d92@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
 <bkOyb_6hGnDZpDhSlqz8ExQptCL9TRFzI2258ApUMDI=.13ab6b56-7562-4797-93c6-3665b6857d92@github.com>
Message-ID: <4w0adS5q_dfCC2ooRugvX_cNvnLwCKag6KMPkHhhGNs=.41493103-068d-4da1-b890-b22b6550ea96@github.com>

On Wed, 7 Dec 2022 03:48:16 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of add18914fb1294999877b563c734a25b4c17b922 for cgroups v2 support injdk8u-dev, via the 11u backport.
>> 
>> It does not apply clean:
>> 
>>  * context issues for changes made for the different approach for logging in 8u
>>  * copyright lines
>> 
>> Small amount of re-working of new code that used `log_trace`/`log_debug` to use the 8u approach.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Update file path in comment
>  - Severin's test fixes. Thanks!
>  - Move test to a more 8u-appropriate location
>    
>    Container (cgroups, docker) tests in 8u reside in
>    hotspot/test/runtime/containers
>  - remove duplicate include of osContainer_linux
>    
>    With the backport of 8189762, the include of osContainer_linux was
>    moved to a later #ifdef stanza, relative to the original. This caused
>    a context problem with this backport.
>  - 8239785: Cgroups: Incorrect detection logic on old systems in hotspot
>    
>    Return NULL subsystem if no cgroup controllers are mounted.
>    
>    Reviewed-by: sgehwolf
>    Backport-of: add18914fb1294999877b563c734a25b4c17b922

Marked as reviewed by sgehwolf (Reviewer).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From sgehwolf at openjdk.org  Fri Dec  9 11:07:03 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 9 Dec 2022 11:07:03 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot [v5]
In-Reply-To: <O_iXj1CUNjnhlDnt61dFMxWR3DA_JVFp9YyJHh8eC_A=.d1a125c5-2f49-4898-883b-7139ddf65788@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
 <umT7bPFldE58AZB3EstDbAUk9vXZyeCilvy-kBm0sWE=.f1851b51-3afd-4277-ba6c-3eba700061cd@github.com>
 <0Jl3jdA-AzVYu37P34N8HJEHlW5YNPd7zV6U-mmTWzI=.19d77744-04cb-41e1-9e3f-c82a7dc00f60@github.com>
 <O_iXj1CUNjnhlDnt61dFMxWR3DA_JVFp9YyJHh8eC_A=.d1a125c5-2f49-4898-883b-7139ddf65788@github.com>
Message-ID: <dF9sr_2kxg-769PSSx65IMHQHq8HBM92WGoEymH-ITU=.793b4c1b-1930-49fd-8fd3-b365a44de433@github.com>

On Mon, 7 Nov 2022 15:38:47 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> Did you run the newly added test `hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java`? It didn't work for me and required a patch like this to actually work:
>> 
>> 
>> commit 74dbb1af01d367194a3638b52a286909e78c38b6
>> Author: Severin Gehwolf <sgehwolf at redhat.com>
>> Date:   Mon Nov 7 15:25:27 2022 +0100
>> 
>>     Test updates for JDK-8239785
>> 
>> diff --git a/hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java b/hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java
>> index c08b64dcda..036eae9156 100644
>> --- a/hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java
>> +++ b/hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java
>> @@ -24,9 +24,9 @@
>>  /*
>>   * @test CgroupSubsystemFactory
>>   * @requires os.family == "linux"
>> - * @library /testlibrary /test/lib
>> - * @build sun.hotspot.WhiteBox
>> - * @run driver ClassFileInstaller sun.hotspot.WhiteBox
>> + * @library /testlibrary /testlibrary/whitebox
>> + * @build CgroupSubsystemFactory
>> + * @run main ClassFileInstaller sun.hotspot.WhiteBox
>>   *                              sun.hotspot.WhiteBox$WhiteBoxPermission
>>   * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI CgroupSubsystemFactory
>>   */
>> @@ -36,10 +36,12 @@ import java.nio.charset.StandardCharsets;
>>  import java.nio.file.Files;
>>  import java.nio.file.Path;
>>  import java.nio.file.Paths;
>> +import java.nio.file.FileVisitResult;
>> +import java.nio.file.SimpleFileVisitor;
>> +import java.nio.file.attribute.BasicFileAttributes;
>>  
>> -import jdk.test.lib.Asserts;
>> -import jdk.test.lib.Utils;
>> -import jdk.test.lib.util.FileUtils;
>> +import com.oracle.java.testlibrary.Asserts;
>> +import com.oracle.java.testlibrary.Utils;
>>  import sun.hotspot.WhiteBox;
>>  
>>  /*
>> @@ -129,35 +131,35 @@ public class CgroupSubsystemFactory {
>>          try {
>>              existingDirectory = Utils.createTempDirectory(CgroupSubsystemFactory.class.getSimpleName());
>>              Path cgroupsZero = Paths.get(existingDirectory.toString(), "cgroups_zero");
>> -            Files.writeString(cgroupsZero, cgroupsZeroHierarchy, StandardCharsets.UTF_8);
>> +            Files.write(cgroupsZero, cgroupsZeroHierarchy.getBytes(StandardCharsets.UTF_8));
>>              cgroupv1CgInfoZeroHierarchy = cgroupsZero;
>>              cgroupv2CgInfoZeroHierarchy = cgroupsZero;
>>              cgroupv1MntInfoZeroHierarchy = Paths.get(existingDirectory.toString(), "mountinfo_empty");
>> -            Files.writeString(cgroupv1MntInfoZeroHierarchy, mntInfoEmpty);
>> +            Files.write(cgroupv1MntInfoZeroHierarchy, mntInfoEmpty.getBytes());
>>  
>>              cgroupv2MntInfoZeroHierarchy = Paths.get(existingDirectory.toString(), "mountinfo_cgroupv2");
>> -            Files.writeString(cgroupv2MntInfoZeroHierarchy, mntInfoCgroupsV2Only);
>> +            Files.write(cgroupv2MntInfoZeroHierarchy, mntInfoCgroupsV2Only.getBytes());
>>  
>>              cgroupv1CgInfoNonZeroHierarchy = Paths.get(existingDirectory.toString(), "cgroups_non_zero");
>> -            Files.writeString(cgroupv1CgInfoNonZeroHierarchy, cgroupsNonZeroHierarchy);
>> +            Files.write(cgroupv1CgInfoNonZeroHierarchy, cgroupsNonZeroHierarchy.getBytes());
>>  
>>              cgroupv1MntInfoNonZeroHierarchy = Paths.get(existingDirectory.toString(), "mountinfo_non_zero");
>> -            Files.writeString(cgroupv1MntInfoNonZeroHierarchy, mntInfoHybrid);
>> +            Files.write(cgroupv1MntInfoNonZeroHierarchy, mntInfoHybrid.getBytes());
>>  
>>              cgroupv1MntInfoNonZeroHierarchyOtherOrder = Paths.get(existingDirectory.toString(), "mountinfo_non_zero_cgroupv2_last");
>> -            Files.writeString(cgroupv1MntInfoNonZeroHierarchyOtherOrder, mntInfoHybridFlippedOrder);
>> +            Files.write(cgroupv1MntInfoNonZeroHierarchyOtherOrder, mntInfoHybridFlippedOrder.getBytes());
>>  
>>              cgroupV1SelfCgroup = Paths.get(existingDirectory.toString(), "cgroup_self_hybrid");
>> -            Files.writeString(cgroupV1SelfCgroup, procSelfCgroupHybridContent);
>> +            Files.write(cgroupV1SelfCgroup, procSelfCgroupHybridContent.getBytes());
>>  
>>              cgroupV2SelfCgroup = Paths.get(existingDirectory.toString(), "cgroup_self_v2");
>> -            Files.writeString(cgroupV2SelfCgroup, procSelfCgroupV2UnifiedContent);
>> +            Files.write(cgroupV2SelfCgroup, procSelfCgroupV2UnifiedContent.getBytes());
>>  
>>              cgroupv1MntInfoMissingMemoryController = Paths.get(existingDirectory.toString(), "mnt_info_missing_memory");
>> -            Files.writeString(cgroupv1MntInfoMissingMemoryController, mntInfoHybridMissingMemory);
>> +            Files.write(cgroupv1MntInfoMissingMemoryController, mntInfoHybridMissingMemory.getBytes());
>>  
>>              cgroupV2MntInfoMissingCgroupv2 = Paths.get(existingDirectory.toString(), "mnt_info_missing_cgroup2");
>> -            Files.writeString(cgroupV2MntInfoMissingCgroupv2, mntInfoHybridStub);
>> +            Files.write(cgroupV2MntInfoMissingCgroupv2, mntInfoHybridStub.getBytes());
>>          } catch (IOException e) {
>>              throw new RuntimeException(e);
>>          }
>> @@ -165,12 +167,31 @@ public class CgroupSubsystemFactory {
>>  
>>      private void teardown() {
>>          try {
>> -            FileUtils.deleteFileTreeWithRetry(existingDirectory);
>> +            deleteFileTree(existingDirectory);
>>          } catch (IOException e) {
>>              System.err.println("Teardown failed. " + e.getMessage());
>>          }
>>      }
>>  
>> +    private static void deleteFileTree(Path dir) throws IOException {
>> +        java.nio.file.Files.walkFileTree(dir, new SimpleFileVisitor<Path>() {
>> +            @Override
>> +            public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IOException {
>> +                Files.delete(file);
>> +                return FileVisitResult.CONTINUE;
>> +            }
>> +            @Override
>> +            public FileVisitResult postVisitDirectory(Path dir, IOException exc) throws IOException {
>> +                Files.delete(dir);
>> +                return FileVisitResult.CONTINUE;
>> +            }
>> +            @Override
>> +            public FileVisitResult visitFileFailed(Path file, IOException exc) {
>> +                return FileVisitResult.CONTINUE;
>> +            }
>> +        });
>> +    }
>> +
>>      private boolean isValidCgroup(int value) {
>>          return value == CGROUPS_V1 || value == CGROUPS_V2;
>>      }
>> diff --git a/hotspot/test/testlibrary/com/oracle/java/testlibrary/Utils.java b/hotspot/test/testlibrary/com/oracle/java/testlibrary/Utils.java
>> index 902e3b1383..0e79599d20 100644
>> --- a/hotspot/test/testlibrary/com/oracle/java/testlibrary/Utils.java
>> +++ b/hotspot/test/testlibrary/com/oracle/java/testlibrary/Utils.java
>> @@ -32,6 +32,10 @@ import java.io.IOException;
>>  import java.net.InetAddress;
>>  import java.net.ServerSocket;
>>  import java.net.UnknownHostException;
>> +import java.nio.file.Path;
>> +import java.nio.file.Files;
>> +import java.nio.file.Paths;
>> +import java.nio.file.attribute.FileAttribute;
>>  import java.util.ArrayList;
>>  import java.util.List;
>>  import java.util.Arrays;
>> @@ -370,4 +374,25 @@ public final class Utils {
>>          }
>>          return new String(hexView);
>>      }
>> +
>> +    /**
>> +     * Creates an empty directory in "user.dir" or "."
>> +     * <p>
>> +     * This method is meant as a replacement for {@code Files#createTempDirectory(String, String, FileAttribute...)}
>> +     * that doesn't leave files behind in /tmp directory of the test machine
>> +     * <p>
>> +     * If the property "user.dir" is not set, "." will be used.
>> +     *
>> +     * @param prefix
>> +     * @param attrs
>> +     * @return the path to the newly created directory
>> +     * @throws IOException
>> +     *
>> +     * @see {@link Files#createTempDirectory(String, String, FileAttribute...)}
>> +     */
>> +    public static Path createTempDirectory(String prefix, FileAttribute<?>... attrs) throws IOException {
>> +        Path dir = Paths.get(System.getProperty("user.dir", "."));
>> +        return Files.createTempDirectory(dir, prefix);
>> +    }
>> +
>>  }
>> diff --git a/hotspot/test/testlibrary/whitebox/sun/hotspot/WhiteBox.java b/hotspot/test/testlibrary/whitebox/sun/hotspot/WhiteBox.java
>> index 24632c037e..393f3b1ca8 100644
>> --- a/hotspot/test/testlibrary/whitebox/sun/hotspot/WhiteBox.java
>> +++ b/hotspot/test/testlibrary/whitebox/sun/hotspot/WhiteBox.java
>> @@ -256,5 +256,8 @@ public class WhiteBox {
>>    // Container testing
>>    public native boolean isContainerized();
>>    public native void printOsInfo();
>> +  public native int validateCgroup(String procCgroups,
>> +                                   String procSelfCgroup,
>> +                                   String procSelfMountinfo);
>>  
>>  }
>> diff --git a/jdk/test/lib/sun/hotspot/WhiteBox.java b/jdk/test/lib/sun/hotspot/WhiteBox.java
>> index da3a617661..9497c95305 100644
>> --- a/jdk/test/lib/sun/hotspot/WhiteBox.java
>> +++ b/jdk/test/lib/sun/hotspot/WhiteBox.java
>> @@ -443,9 +443,6 @@ public class WhiteBox {
>>  
>>    // Container testing
>>    public native boolean isContainerized();
>> -  public native int validateCgroup(String procCgroups,
>> -                                   String procSelfCgroup,
>> -                                   String procSelfMountinfo);
>>    public native void printOsInfo();
>>  
>>    // Decoder
>
>> Did you run the newly added test hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java?
> 
> I guess not. I began the patch series running all the touched tests, but since review wasn't going to start for a while, and also some tests are known-broken until later patches are applied, I decided to focus on the non-test hunks and watch the status of test pass/fail via GHA on the "tip" of the backport effort.
> 
> Now that review has started I should switch to paying attention to them!
> 
>> It didn't work for me and required a patch like this to actually work:
> 
> Thanks for fixing this one. I'll look at the rest downstream of this PR.

@jmtd Please add approval requests to the bug.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From jdowland at openjdk.org  Fri Dec  9 15:34:56 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 9 Dec 2022 15:34:56 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot [v8]
In-Reply-To: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
Message-ID: <f5bnsG-Wk0dOU_KaGwnzuAC3wRbqoc4db6HU-jmAKt8=.2832e973-16d1-4cf2-b97e-281d679765d9@github.com>

> This is a backport of add18914fb1294999877b563c734a25b4c17b922 for cgroups v2 support injdk8u-dev, via the 11u backport.
> 
> It does not apply clean:
> 
>  * context issues for changes made for the different approach for logging in 8u
>  * copyright lines
> 
> Small amount of re-working of new code that used `log_trace`/`log_debug` to use the 8u approach.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Update file path in comment
 - Severin's test fixes. Thanks!
 - Move test to a more 8u-appropriate location
   
   Container (cgroups, docker) tests in 8u reside in
   hotspot/test/runtime/containers
 - remove duplicate include of osContainer_linux
   
   With the backport of 8189762, the include of osContainer_linux was
   moved to a later #ifdef stanza, relative to the original. This caused
   a context problem with this backport.
 - 8239785: Cgroups: Incorrect detection logic on old systems in hotspot
   
   Return NULL subsystem if no cgroup controllers are mounted.
   
   Reviewed-by: sgehwolf
   Backport-of: add18914fb1294999877b563c734a25b4c17b922

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/135/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/135/files/5bc91b88..2de43617

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=135&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=135&range=06-07

  Stats: 47 lines in 3 files changed: 42 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/135.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/135/head:pull/135

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From jdowland at openjdk.org  Fri Dec  9 15:36:56 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 9 Dec 2022 15:36:56 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot [v5]
In-Reply-To: <dF9sr_2kxg-769PSSx65IMHQHq8HBM92WGoEymH-ITU=.793b4c1b-1930-49fd-8fd3-b365a44de433@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
 <umT7bPFldE58AZB3EstDbAUk9vXZyeCilvy-kBm0sWE=.f1851b51-3afd-4277-ba6c-3eba700061cd@github.com>
 <0Jl3jdA-AzVYu37P34N8HJEHlW5YNPd7zV6U-mmTWzI=.19d77744-04cb-41e1-9e3f-c82a7dc00f60@github.com>
 <O_iXj1CUNjnhlDnt61dFMxWR3DA_JVFp9YyJHh8eC_A=.d1a125c5-2f49-4898-883b-7139ddf65788@github.com>
 <dF9sr_2kxg-769PSSx65IMHQHq8HBM92WGoEymH-ITU=.793b4c1b-1930-49fd-8fd3-b365a44de433@github.com>
Message-ID: <IHn__uOSREyjNWSf0sOXm4CgDsjcejYRhHeBiF-szP0=.a0336c3c-67a7-44a8-b856-3f47bc40ef92@github.com>

On Fri, 9 Dec 2022 11:02:29 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>>> Did you run the newly added test hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java?
>> 
>> I guess not. I began the patch series running all the touched tests, but since review wasn't going to start for a while, and also some tests are known-broken until later patches are applied, I decided to focus on the non-test hunks and watch the status of test pass/fail via GHA on the "tip" of the backport effort.
>> 
>> Now that review has started I should switch to paying attention to them!
>> 
>>> It didn't work for me and required a patch like this to actually work:
>> 
>> Thanks for fixing this one. I'll look at the rest downstream of this PR.
>
> @jmtd Please add approval requests to the bug.

@jerboaa 
> Please add approval requests to the bug.

Done  ? also another rebase as GitHub was showing the previous PR commit again. I'm going to try and get ahead of this and pre-emptively rebase the rest of the chain ahead of reviews. Shall I do all the fix-request labels at this point too? It looks like we've gone past the initial set of patches under consideration.

Thanks

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From sgehwolf at openjdk.org  Fri Dec  9 15:55:18 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 9 Dec 2022 15:55:18 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot [v5]
In-Reply-To: <IHn__uOSREyjNWSf0sOXm4CgDsjcejYRhHeBiF-szP0=.a0336c3c-67a7-44a8-b856-3f47bc40ef92@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
 <umT7bPFldE58AZB3EstDbAUk9vXZyeCilvy-kBm0sWE=.f1851b51-3afd-4277-ba6c-3eba700061cd@github.com>
 <0Jl3jdA-AzVYu37P34N8HJEHlW5YNPd7zV6U-mmTWzI=.19d77744-04cb-41e1-9e3f-c82a7dc00f60@github.com>
 <O_iXj1CUNjnhlDnt61dFMxWR3DA_JVFp9YyJHh8eC_A=.d1a125c5-2f49-4898-883b-7139ddf65788@github.com>
 <dF9sr_2kxg-769PSSx65IMHQHq8HBM92WGoEymH-ITU=.793b4c1b-1930-49fd-8fd3-b365a44de433@github.com>
 <IHn__uOSREyjNWSf0sOXm4CgDsjcejYRhHeBiF-szP0=.a0336c3c-67a7-44a8-b856-3f47bc40ef92@github.com>
Message-ID: <odGJH780QsNQS1Y1lPzOyp-fLHo6FpVCBNKGhA0xwnc=.b3d1ba63-faad-4d98-bff6-d8e2b584acd0@github.com>

On Fri, 9 Dec 2022 15:34:22 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> Shall I do all the fix-request labels at this point too? It looks like we've gone past the initial set of patches under consideration.

Yes, please.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From sgehwolf at openjdk.org  Fri Dec  9 16:04:27 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 9 Dec 2022 16:04:27 GMT
Subject: [jdk8u-dev] RFR: 8298307: Enable hotspot/tier1 for 32-bit builds
 in GHA for 8u
In-Reply-To: <3PIxuJ0yXRaPo7_acjGtyKYct2KeNm8uLQxkBJymS4I=.99650462-679c-430c-850d-f23e7b54bdbd@github.com>
References: <3PIxuJ0yXRaPo7_acjGtyKYct2KeNm8uLQxkBJymS4I=.99650462-679c-430c-850d-f23e7b54bdbd@github.com>
Message-ID: <5bq3bE9Nikk4rL-VEhL5MY-Did7bekrj31lcHVHV3M0=.dc361576-6f1e-4d0f-96bb-0b69121a4ac1@github.com>

On Wed, 7 Dec 2022 18:26:53 GMT, zzambers <duke at openjdk.org> wrote:

> All issues in hotspot/tier1 affecting 32-bit builds are now resolved so these configurations can now be enabled in GHA. This is the last piece to have full tier1 testing on all platforms we have in GHA.
> 
> Notes:
> - hotspot/tier1 on linux requires working C/C++ compiler for some tests (gcc multilib packages are required for linux-x86)
> - hotspot/tier1 contains some container tests, but ubuntu:latest does not include 32-bit libs by default. Multilib image needs to be created.

LGTM, thanks!

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/204

From sgehwolf at openjdk.org  Fri Dec  9 16:12:09 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 9 Dec 2022 16:12:09 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot [v5]
In-Reply-To: <IHn__uOSREyjNWSf0sOXm4CgDsjcejYRhHeBiF-szP0=.a0336c3c-67a7-44a8-b856-3f47bc40ef92@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
 <umT7bPFldE58AZB3EstDbAUk9vXZyeCilvy-kBm0sWE=.f1851b51-3afd-4277-ba6c-3eba700061cd@github.com>
 <0Jl3jdA-AzVYu37P34N8HJEHlW5YNPd7zV6U-mmTWzI=.19d77744-04cb-41e1-9e3f-c82a7dc00f60@github.com>
 <O_iXj1CUNjnhlDnt61dFMxWR3DA_JVFp9YyJHh8eC_A=.d1a125c5-2f49-4898-883b-7139ddf65788@github.com>
 <dF9sr_2kxg-769PSSx65IMHQHq8HBM92WGoEymH-ITU=.793b4c1b-1930-49fd-8fd3-b365a44de433@github.com>
 <IHn__uOSREyjNWSf0sOXm4CgDsjcejYRhHeBiF-szP0=.a0336c3c-67a7-44a8-b856-3f47bc40ef92@github.com>
Message-ID: <tfJatRNgbkqkkoodTF1qX-91YHPAimySJm_oQnNywpU=.2b734b55-65cf-4d24-97ca-5c48cb8d0e15@github.com>

On Fri, 9 Dec 2022 15:34:22 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> I'm going to try and get ahead of this and pre-emptively rebase the rest of the chain ahead of reviews.

@jmtd When doing so, please ensure to rebase on top of [JDK-8296555](https://bugs.openjdk.org/browse/JDK-8296555) as this enables hotspot tier1 tests in GHA and runs some container tests which would be good to have as an additional verification step. Thanks!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From sgehwolf at openjdk.org  Fri Dec  9 18:00:05 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 9 Dec 2022 18:00:05 GMT
Subject: [jdk8u-dev] RFR: 8197408: Bad pointer comparison and small cleanup
 in os_linux.cpp [v2]
In-Reply-To: <qvOJC76-7U8T4Qe3mKEJe74rBKio2BxkQ9lCj22XHwo=.1416039b-7b1c-4504-9e82-68b4954b2fd9@github.com>
References: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
 <qvOJC76-7U8T4Qe3mKEJe74rBKio2BxkQ9lCj22XHwo=.1416039b-7b1c-4504-9e82-68b4954b2fd9@github.com>
Message-ID: <bZ1L5S4YewRfwURXVdhjoYcx0v6Q9YhcRHaygG5s78M=.abb0d627-efdd-4969-b193-3c02a2e6a5fe@github.com>

On Fri, 11 Nov 2022 16:27:12 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of [JDK-8197408](https://bugs.openjdk.org/browse/JDK-8197408) to jdk8u-dev as part of cgroups v2. I've backported it as a pre-requisite for 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 (<https://github.com/openjdk/jdk8u-dev/pull/155>)
>> 
>> Most of the original patch has been integrated already: I've left a whitespace change in for os_linux.cpp to hopefully avoid context problems later on. The majority of this patch is introducing the test PlainRead.java.
>> 
>> Not clean: test adjustments to jtreg metadata, imports, and JVM flags needed.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
> 
>  - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
>  - adjust jtreg settings and imports for 8u
>  - 8197408: Bad pointer comparison and small cleanup in os_linux.cpp
>    
>    Reviewed-by: bobv, stuefe
>  - Test fix by Severin. Thanks!
>  - replace post-jdk8u Optional.isEmpty
>  - 8239559: Cgroups: Incorrect detection logic on some systems
>    
>    Adjust heuristic with cgroup mounts according to mountinfo
>    
>    Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
>  - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
>    
>    Reviewed-by: mdoerr
>    Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
>  - Don't pass --add-exports to jdk8u java inside docker
>    
>    These are JDK9+ module specific parameters.
>  - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
>    
>    When the kernel doesn't support swap limits, expect host values instead.
>    
>    Reviewed-by: sgehwolf
>    Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e
>  - Update file path in comment
>  - ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/3ef0d0e0...74d73c96

Keep open, please.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/164

From sgehwolf at openjdk.org  Fri Dec  9 18:01:25 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 9 Dec 2022 18:01:25 GMT
Subject: [jdk8u-dev] RFR: 8278951: containers/cgroup/PlainRead.java fails
 on Ubuntu 21.10 [v3]
In-Reply-To: <qt6OmwgXaFe5T9eab4hKPzs_pHsfvz8FIiMwz6qxn04=.f633f503-c788-417d-8f9a-2161f4cd9c12@github.com>
References: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
 <qt6OmwgXaFe5T9eab4hKPzs_pHsfvz8FIiMwz6qxn04=.f633f503-c788-417d-8f9a-2161f4cd9c12@github.com>
Message-ID: <8yofm9qeiIhRJkkTyUkjks2H_jmoTvNxFH34WDvrOes=.47af8677-9e94-4fa2-b533-a7a9c246860f@github.com>

On Fri, 11 Nov 2022 16:28:59 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8278951 to jdk8u-dev as part of the cgroups v2 backport initiative.
>> 
>> Dependent PRs are in use.
>> 
>> It was clean (modulo path shuffles). The use of `log_trace` needed adjusting for jdk8u-dev.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
> 
>  - replace log_trace with tty->print_cr
>  - 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
>    
>    Reviewed-by: sgehwolf
>    Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b
>  - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
>  - adjust jtreg settings and imports for 8u
>  - 8197408: Bad pointer comparison and small cleanup in os_linux.cpp
>    
>    Reviewed-by: bobv, stuefe
>  - Test fix by Severin. Thanks!
>  - replace post-jdk8u Optional.isEmpty
>  - 8239559: Cgroups: Incorrect detection logic on some systems
>    
>    Adjust heuristic with cgroup mounts according to mountinfo
>    
>    Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
>  - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
>    
>    Reviewed-by: mdoerr
>    Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
>  - Don't pass --add-exports to jdk8u java inside docker
>    
>    These are JDK9+ module specific parameters.
>  - ... and 3 more: https://git.openjdk.org/jdk8u-dev/compare/e6c38804...7fc8633b

Keep open, please.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/155

From sgehwolf at openjdk.org  Fri Dec  9 18:02:02 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 9 Dec 2022 18:02:02 GMT
Subject: [jdk8u-dev] RFR: 8253435: Cgroup: 'stomping of _mount_path' crash
 if manually mounted cpusets exist [v5]
In-Reply-To: <IchTUmpp_hF3uXE9hXIyQ_Hfjyk8jvFeDkJF4nls4E0=.685326da-6498-4fdb-bef3-0b73a16249d6@github.com>
References: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
 <IchTUmpp_hF3uXE9hXIyQ_Hfjyk8jvFeDkJF4nls4E0=.685326da-6498-4fdb-bef3-0b73a16249d6@github.com>
Message-ID: <HouaJqZ3_W4ufDOIL0jZtbVfAGnXgr4LLfy06clxFv4=.13137afe-d50c-4f1d-824f-fb839227d7d8@github.com>

On Fri, 11 Nov 2022 16:29:25 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8253435 to jdk8u-dev for cgroups v2 support.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:
> 
>  - Severin's test fixes. Thanks!
>  - Replace log_warning with tty->print_cr
>  - 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
>    
>    Backport-of: 0054c15f60cce6470be05d29bfacbdb74cfb7bc9
>  - 8252359: HotSpot Not Identifying it is Running in a Container
>    
>    Backport-of: 76f0588aaf265439a589cceb924e3ea9d3fda8f1
>  - replace log_trace with tty->print_cr
>  - 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
>    
>    Reviewed-by: sgehwolf
>    Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b
>  - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
>  - adjust jtreg settings and imports for 8u
>  - 8197408: Bad pointer comparison and small cleanup in os_linux.cpp
>    
>    Reviewed-by: bobv, stuefe
>  - Test fix by Severin. Thanks!
>  - ... and 7 more: https://git.openjdk.org/jdk8u-dev/compare/95e430ef...00dc64aa

Keep open please.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/158

From sgehwolf at openjdk.org  Fri Dec  9 18:03:06 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 9 Dec 2022 18:03:06 GMT
Subject: [jdk8u-dev] RFR: 8252359: HotSpot Not Identifying it is Running in
 a Container [v4]
In-Reply-To: <4BxSkz8IlxdVDWwb7qiK5EODTCbfRZ-bLGhy2JV9Wn0=.898cb06d-357e-416e-904a-3065926ce43f@github.com>
References: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>
 <4BxSkz8IlxdVDWwb7qiK5EODTCbfRZ-bLGhy2JV9Wn0=.898cb06d-357e-416e-904a-3065926ce43f@github.com>
Message-ID: <kGUm4p85I_03pvzNTLl2FxAwaEOcQVD6qtoXHdKfb1I=.7b7ba3f1-35b4-4cdc-a718-2af572587ada@github.com>

On Fri, 11 Nov 2022 16:27:24 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a clean backport of 8252359  to jdk8u-dev, as part of cgroups v2 support.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
> 
>  - 8252359: HotSpot Not Identifying it is Running in a Container
>    
>    Backport-of: 76f0588aaf265439a589cceb924e3ea9d3fda8f1
>  - replace log_trace with tty->print_cr
>  - 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
>    
>    Reviewed-by: sgehwolf
>    Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b
>  - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
>  - adjust jtreg settings and imports for 8u
>  - 8197408: Bad pointer comparison and small cleanup in os_linux.cpp
>    
>    Reviewed-by: bobv, stuefe
>  - Test fix by Severin. Thanks!
>  - replace post-jdk8u Optional.isEmpty
>  - 8239559: Cgroups: Incorrect detection logic on some systems
>    
>    Adjust heuristic with cgroup mounts according to mountinfo
>    
>    Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
>  - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
>    
>    Reviewed-by: mdoerr
>    Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
>  - ... and 4 more: https://git.openjdk.org/jdk8u-dev/compare/793364d2...34b0259f

Keep open please.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/157

From jdowland at openjdk.org  Sun Dec 11 13:27:03 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Sun, 11 Dec 2022 13:27:03 GMT
Subject: [jdk8u-dev] RFR: 8240189: [TESTBUG] Some cgroup tests are failing
 after JDK-8231111 [v4]
In-Reply-To: <z_AjEWrIJynlKKNRP1Sn0kSXnQN9Q4Ed-BZ2hSNm4GI=.bcb72ce0-133f-4625-b295-bac9f2468581@github.com>
References: <xMzwOwQNLqXe-C5x9_Vhg7oKETlwaMvxTxwDOmzd2iM=.1f8a3396-c7a0-4cdc-af4e-49837439b4e6@github.com>
 <z_AjEWrIJynlKKNRP1Sn0kSXnQN9Q4Ed-BZ2hSNm4GI=.bcb72ce0-133f-4625-b295-bac9f2468581@github.com>
Message-ID: <hrWeluwq99zUdvUpUEWlMVFoiDJndG0aBlidhWRbIEw=.a707143e-a230-4e38-a3a5-2ea7726f2e60@github.com>

On Fri, 11 Nov 2022 16:25:29 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a back port of 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
>> for jdk8u-dev as part of an effort to backport support for Cgroups V2.
>> 
>> The intention is for this PR to depend upon [8231111: 2Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy](https://github.com/openjdk/jdk8u-dev/pull/121), which in turn depends upon [8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems](https://github.com/openjdk/jdk8u-dev/pull/123), both of which are dependencies for this patch-set.
>> 
>> This backport is one commit on top of pr/121. It does not apply clean after path unshuffling: some of the patch contexts around `MetricsMemoryTester.java`,  `MetricsTesterCgroupV1.java` and  `MetricsTesterCgroupV2.java` differ due to changes made in pr/121 to adjust for jdk8u-dev support (replacing `Arrays.compare` with `Arrays.equals`)
>> 
>> I'll report back testing results to this PR, I have to untangle them a bit first.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
>    
>    Reviewed-by: mdoerr
>    Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
>  - Don't pass --add-exports to jdk8u java inside docker
>    
>    These are JDK9+ module specific parameters.
>  - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
>    
>    When the kernel doesn't support swap limits, expect host values instead.
>    
>    Reviewed-by: sgehwolf
>    Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e
>  - Update file path in comment
>  - Severin's test fixes. Thanks!

wake up

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/124

From jdowland at openjdk.org  Sun Dec 11 13:27:15 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Sun, 11 Dec 2022 13:27:15 GMT
Subject: [jdk8u-dev] RFR: 8244500: jtreg test error in
 test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java [v5]
In-Reply-To: <gkLUHz4NmJ7v94SAXxJf-6FxBHkdYpZ155M5bsrdr2s=.c38f101e-2950-403d-94fd-2d793af810dc@github.com>
References: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
 <gkLUHz4NmJ7v94SAXxJf-6FxBHkdYpZ155M5bsrdr2s=.c38f101e-2950-403d-94fd-2d793af810dc@github.com>
Message-ID: <PA9O6rifuzRpzofvcGEoAonC3K8J31B2x66P-HGqoqc=.fec301dd-8958-4a65-8991-6fbfeaedbbb7@github.com>

On Fri, 11 Nov 2022 16:25:51 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8244500 to jdk8u-dev as part of cgroups v2 support.
>> 
>> It's a test-only change.
>> 
>> The patch needed adjusting for jdk8u, mostly to JDK-module-specific things.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Don't pass --add-exports to jdk8u java inside docker
>    
>    These are JDK9+ module specific parameters.
>  - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
>    
>    When the kernel doesn't support swap limits, expect host values instead.
>    
>    Reviewed-by: sgehwolf
>    Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e

wake up

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/142

From lzhai at openjdk.org  Mon Dec 12 00:59:43 2022
From: lzhai at openjdk.org (Leslie Zhai)
Date: Mon, 12 Dec 2022 00:59:43 GMT
Subject: [jdk8u-dev] RFR: 8203485: [freetype] text rotated on 180 degrees is
 too narrow
Message-ID: <2tCemlFksSCt1w0KKdB2YwnPbun9-i-kRRzaNjT02s0=.08ac882a-833e-4293-89dd-6aa568fd28cf@github.com>

Hi,

java/awt/Graphics2D/DrawString/RotTransText.java fail:


STDERR:
java.lang.RuntimeException: Ratio of blue to red is too great: 0.14015748031496064
        at RotTransText.testIt(RotTransText.java:102)
        at RotTransText.main(RotTransText.java:41)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
        at java.lang.Thread.run(Thread.java:750)


And JDK-8203485: [freetype] text rotated on 180 degrees is too narrow fix the issue.

Tested jtreg tier1~3 for fastdebug/release.

Thanks,
Leslie Zhai

-------------

Commit messages:
 - Backport db67279f08b2db148958a4faafd19a0d50ff8742

Changes: https://git.openjdk.org/jdk8u-dev/pull/208/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=208&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8203485
  Stats: 143 lines in 2 files changed: 140 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/208.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/208/head:pull/208

PR: https://git.openjdk.org/jdk8u-dev/pull/208

From duke at openjdk.org  Mon Dec 12 02:27:59 2022
From: duke at openjdk.org (zzambers)
Date: Mon, 12 Dec 2022 02:27:59 GMT
Subject: [jdk8u-dev] RFR: 8298307: Enable hotspot/tier1 for 32-bit builds
 in GHA for 8u
In-Reply-To: <5bq3bE9Nikk4rL-VEhL5MY-Did7bekrj31lcHVHV3M0=.dc361576-6f1e-4d0f-96bb-0b69121a4ac1@github.com>
References: <3PIxuJ0yXRaPo7_acjGtyKYct2KeNm8uLQxkBJymS4I=.99650462-679c-430c-850d-f23e7b54bdbd@github.com>
 <5bq3bE9Nikk4rL-VEhL5MY-Did7bekrj31lcHVHV3M0=.dc361576-6f1e-4d0f-96bb-0b69121a4ac1@github.com>
Message-ID: <V_IBM0FxBJqZR325-Whjob-0bLeXxLZQ0uxWTbCKEjs=.e506bec3-9d5b-4595-ada7-a63de728c0aa@github.com>

On Fri, 9 Dec 2022 16:01:42 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> All issues in hotspot/tier1 affecting 32-bit builds are now resolved so these configurations can now be enabled in GHA. This is the last piece to have full tier1 testing on all platforms we have in GHA.
>> 
>> Notes:
>> - hotspot/tier1 on linux requires working C/C++ compiler for some tests (gcc multilib packages are required for linux-x86)
>> - hotspot/tier1 contains some container tests, but ubuntu:latest does not include 32-bit libs by default. Multilib image needs to be created.
>
> LGTM, thanks!

@jerboaa Thank you for review

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/204

From yan at openjdk.org  Mon Dec 12 07:18:09 2022
From: yan at openjdk.org (Yuri Nesterenko)
Date: Mon, 12 Dec 2022 07:18:09 GMT
Subject: [jdk8u-dev] RFR: 8065422: Trailing dot in hostname causes TLS
 handshake to fail with SNI disabled
In-Reply-To: <8cGmyej6l-EDJL3S3OPRf-JxyrImPBIR1loWvWPsa10=.3f353c2f-23b1-40db-b6d4-e277fc57cb58@github.com>
References: <8cGmyej6l-EDJL3S3OPRf-JxyrImPBIR1loWvWPsa10=.3f353c2f-23b1-40db-b6d4-e277fc57cb58@github.com>
Message-ID: <NlCdFcA9ZD7_IqZRY_TUBw0epWXltsUX1aUV7Yz2GwM=.73e3ed5b-f7e3-4f71-8076-cf906005e53b@github.com>

On Fri, 9 Dec 2022 09:39:45 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> Actually clean backport.
> 
> There were 2 conflicts with test files paths:
> 
> - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` added and moved to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`.
> - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` added and moved to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`.
> 
> Please note that new test added by the change fails for now because of the certs are expired in March, 2022. To fix this, there are additional JDK fixes being backported as dependant PRs
> 
> - #206 
> - #207

Marked as reviewed by yan (Reviewer).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/205

From yan at openjdk.org  Mon Dec 12 07:24:09 2022
From: yan at openjdk.org (Yuri Nesterenko)
Date: Mon, 12 Dec 2022 07:24:09 GMT
Subject: [jdk8u-dev] RFR: 8282398: EndingDotHostname.java test fails
 because SSL cert expired
In-Reply-To: <aSKp6K9ZjFpaadF_MmFQN0zl_-coClaorCAGjTLWNRQ=.a09d41b5-e8d6-4d38-9821-efbabd29e393@github.com>
References: <aSKp6K9ZjFpaadF_MmFQN0zl_-coClaorCAGjTLWNRQ=.a09d41b5-e8d6-4d38-9821-efbabd29e393@github.com>
Message-ID: <UtHz00lhnMnMQtnTdXi8-DoEpvRKmw4Uz0hRnnS8tn4=.fd6944db-eb63-4d94-b697-8c7b76b6fa37@github.com>

On Fri, 9 Dec 2022 09:48:57 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> Actually clean backport. Test files changed only.
> 
> There were 2 conflicts with test files paths:
> 
> - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`.
> - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`.
> 
> Please note that this PR is a part of dependant PR chain
> 
> - Prev PR #205 
> - Next PR #207

Marked as reviewed by yan (Reviewer).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/206

From yan at openjdk.org  Mon Dec 12 07:29:05 2022
From: yan at openjdk.org (Yuri Nesterenko)
Date: Mon, 12 Dec 2022 07:29:05 GMT
Subject: [jdk8u-dev] RFR: 8282511: Use fixed certificate validation date in
 SSLExampleCert template
In-Reply-To: <aAOj7bNYHwji49wXzu9p8BVoPm2Gdj6PhdQoQCfOMwY=.3cfd795c-f6c4-44cc-a5e1-e0f486ffb92a@github.com>
References: <aAOj7bNYHwji49wXzu9p8BVoPm2Gdj6PhdQoQCfOMwY=.3cfd795c-f6c4-44cc-a5e1-e0f486ffb92a@github.com>
Message-ID: <LFJ2hnOWw914m9Qq7MHj981wNxx6VPqXO7DNi02lQPA=.4b86296d-8d5a-42ab-a36f-e950dd2997a0@github.com>

On Fri, 9 Dec 2022 09:59:40 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> Actually clean backport. Test files changed only.
> 
> There were 2 conflicts with test files paths:
> 
> - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`.
> - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`.
> 
> Please note that this PR is a part of dependant PR chain
> Prev PRs:
> - #205 
> - #206

Marked as reviewed by yan (Reviewer).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/207

From duke at openjdk.org  Mon Dec 12 07:49:11 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Mon, 12 Dec 2022 07:49:11 GMT
Subject: [jdk8u-dev] RFR: 8297996: [8u] generated images are broken due to
 renaming of MSVC runtime DLL's [v2]
In-Reply-To: <kmwMHa8T0-HNk_CFFZYvHI4qmwGjmgs1Xt9Vqj4VSi4=.11941c4f-b7c3-431c-ad70-02c10f8e6134@github.com>
References: <rBE3rNSo7kYwJuUUbJ-CPDin9z8f0urlq3SOHvG09PA=.c902b393-e0f7-4e77-8163-8dd0ce54ea52@github.com>
 <kmwMHa8T0-HNk_CFFZYvHI4qmwGjmgs1Xt9Vqj4VSi4=.11941c4f-b7c3-431c-ad70-02c10f8e6134@github.com>
Message-ID: <KpSE-WYea99JBhtdc2bkBrgsVwSs9_08WtjWMAd6onE=.147cb62a-e23c-493c-9e84-8a443ca75163@github.com>

On Mon, 5 Dec 2022 08:42:33 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

>> Hi!
>> 
>> The patch fixes Windows image generation with proper VC runtime DLL names. The problem is that MSVS2019 uses two DLL's `vcruntime140.dll` and `vcruntime140_1.dll` and their names conflict under 8.3 limitation. For this reason the [BASIC_MAKE_WINDOWS_SPACE_SAFE_CYGWIN](https://github.com/openjdk/jdk8u-dev/blob/c9007cd44db764fbd791218c6f38491f38af70c2/common/autoconf/basics_windows.m4#L53) renames DLL's to
>
> Alexey Pavlyutkin has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge branch '8297996' of https://github.com/apavlyutkin/jdk8u-dev into 8297996
>  - forcing pre-sumbit test

ping

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/203

From jdowland at openjdk.org  Mon Dec 12 09:45:09 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 09:45:09 GMT
Subject: [jdk8u-dev] RFR: 8240189: [TESTBUG] Some cgroup tests are failing
 after JDK-8231111 [v5]
In-Reply-To: <xMzwOwQNLqXe-C5x9_Vhg7oKETlwaMvxTxwDOmzd2iM=.1f8a3396-c7a0-4cdc-af4e-49837439b4e6@github.com>
References: <xMzwOwQNLqXe-C5x9_Vhg7oKETlwaMvxTxwDOmzd2iM=.1f8a3396-c7a0-4cdc-af4e-49837439b4e6@github.com>
Message-ID: <K0lbZ6Y6ZoaFTnUw2nClnzGSTP0-h_-ncczDFKNoJxY=.3fe4a49f-4bca-4104-89cf-16e356597af0@github.com>

> This is a back port of 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
> for jdk8u-dev as part of an effort to backport support for Cgroups V2.
> 
> The intention is for this PR to depend upon [8231111: 2Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy](https://github.com/openjdk/jdk8u-dev/pull/121), which in turn depends upon [8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems](https://github.com/openjdk/jdk8u-dev/pull/123), both of which are dependencies for this patch-set.
> 
> This backport is one commit on top of pr/121. It does not apply clean after path unshuffling: some of the patch contexts around `MetricsMemoryTester.java`,  `MetricsTesterCgroupV1.java` and  `MetricsTesterCgroupV2.java` differ due to changes made in pr/121 to adjust for jdk8u-dev support (replacing `Arrays.compare` with `Arrays.equals`)
> 
> I'll report back testing results to this PR, I have to untangle them a bit first.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
  
  Reviewed-by: mdoerr
  Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/124/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=124&range=04
  Stats: 145 lines in 5 files changed: 46 ins; 28 del; 71 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/124.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/124/head:pull/124

PR: https://git.openjdk.org/jdk8u-dev/pull/124

From jdowland at openjdk.org  Mon Dec 12 09:45:33 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 09:45:33 GMT
Subject: [jdk8u-dev] RFR: 8244500: jtreg test error in
 test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java [v6]
In-Reply-To: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
References: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
Message-ID: <czSPoo91ZU5hZLLcNSiHnjacQUxd1uG-_CEFH7DRsCk=.1f1af7c0-9825-4d64-b53a-7931175d9d76@github.com>

> This is a backport of 8244500 to jdk8u-dev as part of cgroups v2 support.
> 
> It's a test-only change.
> 
> The patch needed adjusting for jdk8u, mostly to JDK-module-specific things.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - Don't pass --add-exports to jdk8u java inside docker
   
   These are JDK9+ module specific parameters.
 - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
   
   When the kernel doesn't support swap limits, expect host values instead.
   
   Reviewed-by: sgehwolf
   Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/142/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=142&range=05
  Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/142.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/142/head:pull/142

PR: https://git.openjdk.org/jdk8u-dev/pull/142

From duke at openjdk.org  Mon Dec 12 09:47:07 2022
From: duke at openjdk.org (zzambers)
Date: Mon, 12 Dec 2022 09:47:07 GMT
Subject: [jdk8u-dev] Integrated: 8298307: Enable hotspot/tier1 for 32-bit
 builds in GHA for 8u
In-Reply-To: <3PIxuJ0yXRaPo7_acjGtyKYct2KeNm8uLQxkBJymS4I=.99650462-679c-430c-850d-f23e7b54bdbd@github.com>
References: <3PIxuJ0yXRaPo7_acjGtyKYct2KeNm8uLQxkBJymS4I=.99650462-679c-430c-850d-f23e7b54bdbd@github.com>
Message-ID: <zfI-Dmycjw0Zh3zPjFRlD7lEej2BRYs4z5rDjjiZVEw=.cd3db3d7-837d-44ab-b550-4c1ad31e322f@github.com>

On Wed, 7 Dec 2022 18:26:53 GMT, zzambers <duke at openjdk.org> wrote:

> All issues in hotspot/tier1 affecting 32-bit builds are now resolved so these configurations can now be enabled in GHA. This is the last piece to have full tier1 testing on all platforms we have in GHA.
> 
> Notes:
> - hotspot/tier1 on linux requires working C/C++ compiler for some tests (gcc multilib packages are required for linux-x86)
> - hotspot/tier1 contains some container tests, but ubuntu:latest does not include 32-bit libs by default. Multilib image needs to be created.

This pull request has now been integrated.

Changeset: c84a5b28
Author:    Zdenek Zambersky <zzambers at redhat.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/c84a5b2857aacff54ad0bf31d4bdd3747451d92f
Stats:     16 lines in 1 file changed: 8 ins; 0 del; 8 mod

8298307: Enable hotspot/tier1 for 32-bit builds in GHA for 8u

Reviewed-by: sgehwolf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/204

From jdowland at openjdk.org  Mon Dec 12 09:47:36 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 09:47:36 GMT
Subject: [jdk8u-dev] RFR: 8239559: Cgroups: Incorrect detection logic on
 some systems [v7]
In-Reply-To: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
References: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
Message-ID: <f0lb1Zv_A0xx5NOqmykpMqo6EqKDhu-o84SpiHZQrNs=.3cf40da1-2cc3-457c-bb80-b366e0adec1a@github.com>

> This is a backport of 53ee0c4963007b86db7979312b81f990e6ce271a via the 11u backport 53ee0c4963007b86db7979312b81f990e6ce271a for cgroups v2 support in jdk8u-dev.
> 
> It isn't clean: context differences in CgroupSubsystemFactory.java around the use of post-8u logging in the original patch.
> 
> I also had to Optional.isEmpty which is not present in 8u's Optional.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 62 additional commits since the last revision:

 - Test fix by Severin. Thanks!
 - replace post-jdk8u Optional.isEmpty
 - 8239559: Cgroups: Incorrect detection logic on some systems
   
   Adjust heuristic with cgroup mounts according to mountinfo
   
   Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
 - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
   
   Reviewed-by: mdoerr
   Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
 - Don't pass --add-exports to jdk8u java inside docker
   
   These are JDK9+ module specific parameters.
 - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
   
   When the kernel doesn't support swap limits, expect host values instead.
   
   Reviewed-by: sgehwolf
   Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e
 - Update file path in comment
 - Severin's test fixes. Thanks!
 - Move test to a more 8u-appropriate location
   
   Container (cgroups, docker) tests in 8u reside in
   hotspot/test/runtime/containers
 - remove duplicate include of osContainer_linux
   
   With the backport of 8189762, the include of osContainer_linux was
   moved to a later #ifdef stanza, relative to the original. This caused
   a context problem with this backport.
 - ... and 52 more: https://git.openjdk.org/jdk8u-dev/compare/54407433...07cb4ea5

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/136/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/136/files/54407433..07cb4ea5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=136&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=136&range=05-06

  Stats: 4480 lines in 127 files changed: 3197 ins; 781 del; 502 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/136.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/136/head:pull/136

PR: https://git.openjdk.org/jdk8u-dev/pull/136

From jdowland at openjdk.org  Mon Dec 12 09:48:32 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 09:48:32 GMT
Subject: [jdk8u-dev] RFR: 8278951: containers/cgroup/PlainRead.java fails
 on Ubuntu 21.10 [v4]
In-Reply-To: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
References: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
Message-ID: <BGArJvapj4Epba1NWPuCkETciD_hWhGLdfjBZ1eTHlo=.b2a1fd4f-100a-4b1a-ba27-a8c0ef44343b@github.com>

> This is a backport of 8278951 to jdk8u-dev as part of the cgroups v2 backport initiative.
> 
> Dependent PRs are in use.
> 
> It was clean (modulo path shuffles). The use of `log_trace` needed adjusting for jdk8u-dev.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - replace log_trace with tty->print_cr
 - 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
   
   Reviewed-by: sgehwolf
   Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/155/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=155&range=03
  Stats: 7 lines in 2 files changed: 4 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/155.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/155/head:pull/155

PR: https://git.openjdk.org/jdk8u-dev/pull/155

From jdowland at openjdk.org  Mon Dec 12 09:49:28 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 09:49:28 GMT
Subject: [jdk8u-dev] RFR: 8197408: Bad pointer comparison and small cleanup
 in os_linux.cpp [v3]
In-Reply-To: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
References: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
Message-ID: <Ze1PtaDkpGCwCxQl9_s6fosrqZVVrC2W-BUYwZY_vBc=.7b0abfbc-15ef-46c1-adb6-e3f42ed7487b@github.com>

> This is a backport of [JDK-8197408](https://bugs.openjdk.org/browse/JDK-8197408) to jdk8u-dev as part of cgroups v2. I've backported it as a pre-requisite for 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 (<https://github.com/openjdk/jdk8u-dev/pull/155>)
> 
> Most of the original patch has been integrated already: I've left a whitespace change in for os_linux.cpp to hopefully avoid context problems later on. The majority of this patch is introducing the test PlainRead.java.
> 
> Not clean: test adjustments to jtreg metadata, imports, and JVM flags needed.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 65 additional commits since the last revision:

 - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
 - adjust jtreg settings and imports for 8u
 - 8197408: Bad pointer comparison and small cleanup in os_linux.cpp
   
   Reviewed-by: bobv, stuefe
 - Test fix by Severin. Thanks!
 - replace post-jdk8u Optional.isEmpty
 - 8239559: Cgroups: Incorrect detection logic on some systems
   
   Adjust heuristic with cgroup mounts according to mountinfo
   
   Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
 - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
   
   Reviewed-by: mdoerr
   Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
 - Don't pass --add-exports to jdk8u java inside docker
   
   These are JDK9+ module specific parameters.
 - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
   
   When the kernel doesn't support swap limits, expect host values instead.
   
   Reviewed-by: sgehwolf
   Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e
 - Update file path in comment
 - ... and 55 more: https://git.openjdk.org/jdk8u-dev/compare/74d73c96...0b65ee05

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/164/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/164/files/74d73c96..0b65ee05

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=164&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=164&range=01-02

  Stats: 4480 lines in 127 files changed: 3197 ins; 781 del; 502 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/164.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/164/head:pull/164

PR: https://git.openjdk.org/jdk8u-dev/pull/164

From jdowland at openjdk.org  Mon Dec 12 09:50:26 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 09:50:26 GMT
Subject: [jdk8u-dev] RFR: 8253435: Cgroup: 'stomping of _mount_path' crash
 if manually mounted cpusets exist [v6]
In-Reply-To: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
References: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
Message-ID: <1Rh5VKa-N7DG3HV1Z6iw-hVFCZ_L8wooZ6d8zCoIlNk=.f75c2db1-f602-4806-b993-6548cd53c880@github.com>

> This is a backport of 8253435 to jdk8u-dev for cgroups v2 support.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:

 - Severin's test fixes. Thanks!
 - Replace log_warning with tty->print_cr
 - 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
   
   Backport-of: 0054c15f60cce6470be05d29bfacbdb74cfb7bc9

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/158/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=158&range=05
  Stats: 44 lines in 2 files changed: 41 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/158.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/158/head:pull/158

PR: https://git.openjdk.org/jdk8u-dev/pull/158

From jdowland at openjdk.org  Mon Dec 12 09:51:02 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 09:51:02 GMT
Subject: [jdk8u-dev] RFR: 8252359: HotSpot Not Identifying it is Running in
 a Container [v5]
In-Reply-To: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>
References: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>
Message-ID: <SyIWMOrWKnRLafCpQPuFHyAymfPcct75_W9rOo3IwYk=.a7a9e656-1c22-4779-93e5-5bd8f70fae81@github.com>

> This is a clean backport of 8252359  to jdk8u-dev, as part of cgroups v2 support.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 68 additional commits since the last revision:

 - 8252359: HotSpot Not Identifying it is Running in a Container
   
   Backport-of: 76f0588aaf265439a589cceb924e3ea9d3fda8f1
 - replace log_trace with tty->print_cr
 - 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
   
   Reviewed-by: sgehwolf
   Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b
 - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
 - adjust jtreg settings and imports for 8u
 - 8197408: Bad pointer comparison and small cleanup in os_linux.cpp
   
   Reviewed-by: bobv, stuefe
 - Test fix by Severin. Thanks!
 - replace post-jdk8u Optional.isEmpty
 - 8239559: Cgroups: Incorrect detection logic on some systems
   
   Adjust heuristic with cgroup mounts according to mountinfo
   
   Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
 - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
   
   Reviewed-by: mdoerr
   Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
 - ... and 58 more: https://git.openjdk.org/jdk8u-dev/compare/34b0259f...564b1a01

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/157/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/157/files/34b0259f..564b1a01

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=157&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=157&range=03-04

  Stats: 4480 lines in 127 files changed: 3197 ins; 781 del; 502 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/157.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/157/head:pull/157

PR: https://git.openjdk.org/jdk8u-dev/pull/157

From jdowland at openjdk.org  Mon Dec 12 09:52:48 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 09:52:48 GMT
Subject: [jdk8u-dev] RFR: 8253797: [cgroups v2] Account for the fact that
 swap accounting is disabled on some systems [v4]
In-Reply-To: <yV0TTtmloYwEpPcxo1xeYZj-R3vJNJ_M0muQ1T4kthM=.57959f64-9110-49ab-8738-3f4efc8b131d@github.com>
References: <yV0TTtmloYwEpPcxo1xeYZj-R3vJNJ_M0muQ1T4kthM=.57959f64-9110-49ab-8738-3f4efc8b131d@github.com>
Message-ID: <LfnoafE1LxZp30QKyCFq42marPpCm7PLUjfsIzoP8Ok=.ae587361-e437-4eac-a7a7-2778a88ed3ff@github.com>

> This is a clean backport of 8253797 (via 11u) for jdk8u-dev for cgroups v2 support.
> 
> The changed files are exercised by the jtreg test `TestSystemMetrics.java` which passes on my cgroups v2 system.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:

 - 8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems
   
   Backport-of: 669361117d30c9904813b6f728714f8d6abe8484
 - 8253939: [TESTBUG] Increase coverage of the cgroups detection code
   
   Backport-of: 42fc15899115ca61151bbee96b5580d4e4252beb
 - replace use of Optional.isEmpty
 - 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)
   
   Backport-of: 2bbf8a2a964a64d88298a3dd184459af506e58ed
 - Severin's test fixes. Thanks!
 - Replace log_warning with tty->print_cr
 - 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
   
   Backport-of: 0054c15f60cce6470be05d29bfacbdb74cfb7bc9
 - 8252359: HotSpot Not Identifying it is Running in a Container
   
   Backport-of: 76f0588aaf265439a589cceb924e3ea9d3fda8f1
 - replace log_trace with tty->print_cr
 - 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
   
   Reviewed-by: sgehwolf
   Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b
 - ... and 14 more: https://git.openjdk.org/jdk8u-dev/compare/362cf762...7c0dab20

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/185/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=185&range=03
  Stats: 1618 lines in 20 files changed: 1289 ins; 145 del; 184 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/185.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/185/head:pull/185

PR: https://git.openjdk.org/jdk8u-dev/pull/185

From jdowland at openjdk.org  Mon Dec 12 09:52:44 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 09:52:44 GMT
Subject: [jdk8u-dev] RFR: 8245543: Cgroups: Incorrect detection logic on
 some systems (still reproducible) [v6]
In-Reply-To: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
References: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
Message-ID: <JPXChvRS-8qWnyL26Vkw1fKW01kpyI1bB8oPQA_5nFE=.2be17ffe-aff9-4061-8430-187d018fac3e@github.com>

> A backport of 8245543 to jdk8u-dev for cgroups v2 support.
> 
> Not clean: needed minor adjusting for 8u approach to log output.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 73 additional commits since the last revision:

 - replace use of Optional.isEmpty
 - 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)
   
   Backport-of: 2bbf8a2a964a64d88298a3dd184459af506e58ed
 - Severin's test fixes. Thanks!
 - Replace log_warning with tty->print_cr
 - 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
   
   Backport-of: 0054c15f60cce6470be05d29bfacbdb74cfb7bc9
 - 8252359: HotSpot Not Identifying it is Running in a Container
   
   Backport-of: 76f0588aaf265439a589cceb924e3ea9d3fda8f1
 - replace log_trace with tty->print_cr
 - 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
   
   Reviewed-by: sgehwolf
   Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b
 - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
 - adjust jtreg settings and imports for 8u
 - ... and 63 more: https://git.openjdk.org/jdk8u-dev/compare/0b56b96c...e4e93116

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/159/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/159/files/0b56b96c..e4e93116

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=159&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=159&range=04-05

  Stats: 4480 lines in 127 files changed: 3197 ins; 781 del; 502 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/159.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/159/head:pull/159

PR: https://git.openjdk.org/jdk8u-dev/pull/159

From jdowland at openjdk.org  Mon Dec 12 09:53:49 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 09:53:49 GMT
Subject: [jdk8u-dev] RFR: 8253939: [TESTBUG] Increase coverage of the
 cgroups detection code [v2]
In-Reply-To: <dYPEgmHKhn69tLbt52VLYmJ2ypPf0TQRoaKSS-i7vdM=.df8dd0d3-29cf-45c8-813c-3026ce20c116@github.com>
References: <dYPEgmHKhn69tLbt52VLYmJ2ypPf0TQRoaKSS-i7vdM=.df8dd0d3-29cf-45c8-813c-3026ce20c116@github.com>
Message-ID: <Sf6DujLLAOslCgt0l1IjGWK7ydU0TVqNC-JOarl-Dkc=.1425862f-c9c5-4feb-967c-c034d523f812@github.com>

> This is a backport of 8253939  to jdk8u-dev for cgroups v2 support.
> 
> It's not clean: several `Files.writeString` ? `Files.write(?,.getBytes())` changes needed.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 74 additional commits since the last revision:

 - 8253939: [TESTBUG] Increase coverage of the cgroups detection code
   
   Backport-of: 42fc15899115ca61151bbee96b5580d4e4252beb
 - replace use of Optional.isEmpty
 - 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)
   
   Backport-of: 2bbf8a2a964a64d88298a3dd184459af506e58ed
 - Severin's test fixes. Thanks!
 - Replace log_warning with tty->print_cr
 - 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
   
   Backport-of: 0054c15f60cce6470be05d29bfacbdb74cfb7bc9
 - 8252359: HotSpot Not Identifying it is Running in a Container
   
   Backport-of: 76f0588aaf265439a589cceb924e3ea9d3fda8f1
 - replace log_trace with tty->print_cr
 - 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
   
   Reviewed-by: sgehwolf
   Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b
 - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
 - ... and 64 more: https://git.openjdk.org/jdk8u-dev/compare/3640d59a...72765b59

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/169/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/169/files/3640d59a..72765b59

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=169&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=169&range=00-01

  Stats: 4480 lines in 127 files changed: 3197 ins; 781 del; 502 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/169.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/169/head:pull/169

PR: https://git.openjdk.org/jdk8u-dev/pull/169

From jdowland at openjdk.org  Mon Dec 12 09:55:39 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 09:55:39 GMT
Subject: [jdk8u-dev] RFR: 8254001: [Metrics] Enhance parsing of cgroup
 interface files for version detection [v2]
In-Reply-To: <PP2f9scIGys7GxR51PHbTrwzYlW5t1KWdOF8YVMkq3Q=.c1c64001-e51b-427f-b579-564cf00b0b01@github.com>
References: <PP2f9scIGys7GxR51PHbTrwzYlW5t1KWdOF8YVMkq3Q=.c1c64001-e51b-427f-b579-564cf00b0b01@github.com>
Message-ID: <dv5uWRUvUt8tUL0zGLGz046jwPxm-SJu027eEZzGIgM=.5afdd221-5fa6-4ece-9d6e-ce4dbaade6d5@github.com>

> This is a backport of 8254001 to jdk8u-dev for cgroups v2 support.
> 
> It's not clean: some context issues around import lines and `Files.writeString` replacements.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection
   
   Reviewed-by: sgehwolf
   Backport-of: a50725db2ab621e1a17cb5505f78e4bc73972a27
 - 8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems
   
   Backport-of: 669361117d30c9904813b6f728714f8d6abe8484

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/170/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=170&range=01
  Stats: 636 lines in 6 files changed: 341 ins; 139 del; 156 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/170.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/170/head:pull/170

PR: https://git.openjdk.org/jdk8u-dev/pull/170

From jdowland at openjdk.org  Mon Dec 12 09:55:49 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 09:55:49 GMT
Subject: [jdk8u-dev] RFR: 8262379: Add regression test for JDK-8257746 [v2]
In-Reply-To: <AUjvc6fgHrk80T8rTap5uR-6Sjza_aZFK7vTfzvBMtM=.10ac857e-a29d-46be-952f-bc8100e0dafd@github.com>
References: <AUjvc6fgHrk80T8rTap5uR-6Sjza_aZFK7vTfzvBMtM=.10ac857e-a29d-46be-952f-bc8100e0dafd@github.com>
Message-ID: <oA3oxOvlhqUVXzPmslK8P97YJbpGXJtcIch-wGRd_Rg=.edb447f4-5f46-496b-a3e4-b9fba7fe5d22@github.com>

> This is a backport of 8262379: Add regression test for JDK-8257746 for jdk8u-dev as part of cgroups v2 support.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8262379: Add regression test for JDK-8257746
  
  Backport-of: 4c9adce20d114a3df629fa8c72d88795039ae69a

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/171/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=171&range=01
  Stats: 55 lines in 1 file changed: 55 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/171.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/171/head:pull/171

PR: https://git.openjdk.org/jdk8u-dev/pull/171

From jdowland at openjdk.org  Mon Dec 12 09:58:54 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 09:58:54 GMT
Subject: [jdk8u-dev] RFR: 8291570: [TESTBUG] Part of JDK-8250984 absent
 from 11u [v2]
In-Reply-To: <37RigSmjiXfQ216QBRI2ew1ln2GVMWFa3q0Da3RTVC8=.90472b38-3ea7-481e-add1-f9a607dfc203@github.com>
References: <37RigSmjiXfQ216QBRI2ew1ln2GVMWFa3q0Da3RTVC8=.90472b38-3ea7-481e-add1-f9a607dfc203@github.com>
Message-ID: <qfZlJJOdg6zzFw-XWK1Q6FiZ0l-GWBCxBWJ1f-xUlkk=.a3ae88c9-26fe-4b47-bb97-f72a5ab8d03d@github.com>

> This is a clean backport of 8291570 (from jdk11u) as part of cgroups v2 support.
> 
> The affected test passes for me after the patch.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 78 additional commits since the last revision:

 - 8291570: [TESTBUG] Part of JDK-8250984 absent from 11u
   
   Reviewed-by: serb, sgehwolf
 - 8262379: Add regression test for JDK-8257746
   
   Backport-of: 4c9adce20d114a3df629fa8c72d88795039ae69a
 - 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection
   
   Reviewed-by: sgehwolf
   Backport-of: a50725db2ab621e1a17cb5505f78e4bc73972a27
 - 8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems
   
   Backport-of: 669361117d30c9904813b6f728714f8d6abe8484
 - 8253939: [TESTBUG] Increase coverage of the cgroups detection code
   
   Backport-of: 42fc15899115ca61151bbee96b5580d4e4252beb
 - replace use of Optional.isEmpty
 - 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)
   
   Backport-of: 2bbf8a2a964a64d88298a3dd184459af506e58ed
 - Severin's test fixes. Thanks!
 - Replace log_warning with tty->print_cr
 - 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
   
   Backport-of: 0054c15f60cce6470be05d29bfacbdb74cfb7bc9
 - ... and 68 more: https://git.openjdk.org/jdk8u-dev/compare/428514ec...a591008b

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/175/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/175/files/428514ec..a591008b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=175&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=175&range=00-01

  Stats: 4512 lines in 127 files changed: 3220 ins; 781 del; 511 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/175.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/175/head:pull/175

PR: https://git.openjdk.org/jdk8u-dev/pull/175

From jdowland at openjdk.org  Mon Dec 12 10:02:10 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 10:02:10 GMT
Subject: [jdk8u-dev] RFR: 8252957: Wrong comment in
 CgroupV1Subsystem::cpu_quota [v2]
In-Reply-To: <HMBOxy7GXn7eWD1jZOra2oSlYzKQkl8HR0I3-M16egk=.1bccef4a-4aa4-4a44-b0af-e439dafab265@github.com>
References: <HMBOxy7GXn7eWD1jZOra2oSlYzKQkl8HR0I3-M16egk=.1bccef4a-4aa4-4a44-b0af-e439dafab265@github.com>
Message-ID: <sebDGE-MSkUUnokK74oodgtk93W06cjTK31543gUYYg=.1ebee7f3-3cc4-4074-a7bb-ee956f4ba05c@github.com>

> Simple, comment-only backport for cgroups v2 support in jdk8u. Clean.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/176/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/176/files/b300b94c..b300b94c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=176&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=176&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/176.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/176/head:pull/176

PR: https://git.openjdk.org/jdk8u-dev/pull/176

From sgehwolf at openjdk.org  Mon Dec 12 13:29:59 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 12 Dec 2022 13:29:59 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot [v8]
In-Reply-To: <f5bnsG-Wk0dOU_KaGwnzuAC3wRbqoc4db6HU-jmAKt8=.2832e973-16d1-4cf2-b97e-281d679765d9@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
 <f5bnsG-Wk0dOU_KaGwnzuAC3wRbqoc4db6HU-jmAKt8=.2832e973-16d1-4cf2-b97e-281d679765d9@github.com>
Message-ID: <llI39CQvkXT89F2mLZIJigKPSAyWVgWa87BinYwxUpM=.1fc5e4cf-5297-4cbc-bf28-51aa9e84a3f3@github.com>

On Fri, 9 Dec 2022 15:34:56 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of add18914fb1294999877b563c734a25b4c17b922 for cgroups v2 support injdk8u-dev, via the 11u backport.
>> 
>> It does not apply clean:
>> 
>>  * context issues for changes made for the different approach for logging in 8u
>>  * copyright lines
>> 
>> Small amount of re-working of new code that used `log_trace`/`log_debug` to use the 8u approach.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Update file path in comment
>  - Severin's test fixes. Thanks!
>  - Move test to a more 8u-appropriate location
>    
>    Container (cgroups, docker) tests in 8u reside in
>    hotspot/test/runtime/containers
>  - remove duplicate include of osContainer_linux
>    
>    With the backport of 8189762, the include of osContainer_linux was
>    moved to a later #ifdef stanza, relative to the original. This caused
>    a context problem with this backport.
>  - 8239785: Cgroups: Incorrect detection logic on old systems in hotspot
>    
>    Return NULL subsystem if no cgroup controllers are mounted.
>    
>    Reviewed-by: sgehwolf
>    Backport-of: add18914fb1294999877b563c734a25b4c17b922

Looks good. The bug is a approved. Please integrate.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From jdowland at openjdk.org  Mon Dec 12 14:12:38 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 14:12:38 GMT
Subject: [jdk8u-dev] Integrated: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot
In-Reply-To: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
Message-ID: <xU6T438v6YhQSu-dYf0C5ImFwodxbZSAOdauUt-lQxo=.2c22ea58-5c3f-46b8-ba67-ca992e29c606@github.com>

On Wed, 12 Oct 2022 10:19:37 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of add18914fb1294999877b563c734a25b4c17b922 for cgroups v2 support injdk8u-dev, via the 11u backport.
> 
> It does not apply clean:
> 
>  * context issues for changes made for the different approach for logging in 8u
>  * copyright lines
> 
> Small amount of re-working of new code that used `log_trace`/`log_debug` to use the 8u approach.

This pull request has now been integrated.

Changeset: 989d68f1
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/989d68f1e1d046829d0b19aadb3453febd0566db
Stats:     749 lines in 7 files changed: 573 ins; 95 del; 81 mod

8239785: Cgroups: Incorrect detection logic on old systems in hotspot

Return NULL subsystem if no cgroup controllers are mounted.

Reviewed-by: sgehwolf
Backport-of: add18914fb1294999877b563c734a25b4c17b922

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From sgehwolf at openjdk.org  Mon Dec 12 14:31:01 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 12 Dec 2022 14:31:01 GMT
Subject: [jdk8u-dev] RFR: 8244500: jtreg test error in
 test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java [v6]
In-Reply-To: <czSPoo91ZU5hZLLcNSiHnjacQUxd1uG-_CEFH7DRsCk=.1f1af7c0-9825-4d64-b53a-7931175d9d76@github.com>
References: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
 <czSPoo91ZU5hZLLcNSiHnjacQUxd1uG-_CEFH7DRsCk=.1f1af7c0-9825-4d64-b53a-7931175d9d76@github.com>
Message-ID: <qLgF8laW9jnLa5tgxAzGTPHRVtHLunbdb0aeSoN8k_g=.906ed6f9-c4d9-4cdb-9142-de3e07c6b5bd@github.com>

On Mon, 12 Dec 2022 09:45:33 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8244500 to jdk8u-dev as part of cgroups v2 support.
>> 
>> It's a test-only change.
>> 
>> The patch needed adjusting for jdk8u, mostly to JDK-module-specific things.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Don't pass --add-exports to jdk8u java inside docker
>    
>    These are JDK9+ module specific parameters.
>  - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
>    
>    When the kernel doesn't support swap limits, expect host values instead.
>    
>    Reviewed-by: sgehwolf
>    Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e

This patch needs a rebase, now.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/142

From jdowland at openjdk.org  Mon Dec 12 17:05:52 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 17:05:52 GMT
Subject: [jdk8u-dev] RFR: 8244500: jtreg test error in
 test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java [v7]
In-Reply-To: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
References: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
Message-ID: <hnmDUWbAA8cpdwm8r3_M9g-us7H7MW8Xq_it2V1vuXI=.8e662aeb-6af1-4d21-9cb5-75535c6e270a@github.com>

> This is a backport of 8244500 to jdk8u-dev as part of cgroups v2 support.
> 
> It's a test-only change.
> 
> The patch needed adjusting for jdk8u, mostly to JDK-module-specific things.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - Don't pass --add-exports to jdk8u java inside docker
   
   These are JDK9+ module specific parameters.
 - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
   
   When the kernel doesn't support swap limits, expect host values instead.
   
   Reviewed-by: sgehwolf
   Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/142/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=142&range=06
  Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/142.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/142/head:pull/142

PR: https://git.openjdk.org/jdk8u-dev/pull/142

From jdowland at openjdk.org  Mon Dec 12 17:05:53 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 17:05:53 GMT
Subject: [jdk8u-dev] RFR: 8244500: jtreg test error in
 test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java [v6]
In-Reply-To: <qLgF8laW9jnLa5tgxAzGTPHRVtHLunbdb0aeSoN8k_g=.906ed6f9-c4d9-4cdb-9142-de3e07c6b5bd@github.com>
References: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
 <czSPoo91ZU5hZLLcNSiHnjacQUxd1uG-_CEFH7DRsCk=.1f1af7c0-9825-4d64-b53a-7931175d9d76@github.com>
 <qLgF8laW9jnLa5tgxAzGTPHRVtHLunbdb0aeSoN8k_g=.906ed6f9-c4d9-4cdb-9142-de3e07c6b5bd@github.com>
Message-ID: <O_K2MPg-HD4uJUtNlSnteGTFF4IV2fCnkcL0hZv5gV0=.b50d2c6f-6db5-4b70-b96c-45e3ee177d1c@github.com>

On Mon, 12 Dec 2022 14:28:49 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> This patch needs a rebase, now.

Aargh :) I did all of them this morning. One useful outcome: it's not worthwhile to try and rebase ahead of the merges. We might face this each time regardless.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/142

From sgehwolf at openjdk.org  Mon Dec 12 19:13:42 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 12 Dec 2022 19:13:42 GMT
Subject: [jdk8u-dev] RFR: 8244500: jtreg test error in
 test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java [v7]
In-Reply-To: <hnmDUWbAA8cpdwm8r3_M9g-us7H7MW8Xq_it2V1vuXI=.8e662aeb-6af1-4d21-9cb5-75535c6e270a@github.com>
References: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
 <hnmDUWbAA8cpdwm8r3_M9g-us7H7MW8Xq_it2V1vuXI=.8e662aeb-6af1-4d21-9cb5-75535c6e270a@github.com>
Message-ID: <oM38yo6z0Hj1uYSEL--t-B08-EhyHaQWomfixn9aelU=.54ee815b-035d-466a-abeb-f15d80f92319@github.com>

On Mon, 12 Dec 2022 17:05:52 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8244500 to jdk8u-dev as part of cgroups v2 support.
>> 
>> It's a test-only change.
>> 
>> The patch needed adjusting for jdk8u, mostly to JDK-module-specific things.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Don't pass --add-exports to jdk8u java inside docker
>    
>    These are JDK9+ module specific parameters.
>  - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
>    
>    When the kernel doesn't support swap limits, expect host values instead.
>    
>    Reviewed-by: sgehwolf
>    Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e

Still good.

Feel free to integrate.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/142

From sgehwolf at openjdk.org  Mon Dec 12 19:21:59 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 12 Dec 2022 19:21:59 GMT
Subject: [jdk8u-dev] RFR: 8244500: jtreg test error in
 test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java [v6]
In-Reply-To: <O_K2MPg-HD4uJUtNlSnteGTFF4IV2fCnkcL0hZv5gV0=.b50d2c6f-6db5-4b70-b96c-45e3ee177d1c@github.com>
References: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
 <czSPoo91ZU5hZLLcNSiHnjacQUxd1uG-_CEFH7DRsCk=.1f1af7c0-9825-4d64-b53a-7931175d9d76@github.com>
 <qLgF8laW9jnLa5tgxAzGTPHRVtHLunbdb0aeSoN8k_g=.906ed6f9-c4d9-4cdb-9142-de3e07c6b5bd@github.com>
 <O_K2MPg-HD4uJUtNlSnteGTFF4IV2fCnkcL0hZv5gV0=.b50d2c6f-6db5-4b70-b96c-45e3ee177d1c@github.com>
Message-ID: <yHvp2hQOv3Z5G-NRNOBdSR-WVmeAI0zXWRK_rPoSzuY=.6809e4a4-fa52-4716-a73c-dfd7202927fb@github.com>

On Mon, 12 Dec 2022 17:00:35 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> > This patch needs a rebase, now.
> 
> Aargh :) I did all of them this morning. One useful outcome: it's not worthwhile to try and rebase ahead of the merges. We might face this each time regardless.

Yep. Once this one is integrated, a rebase of the next one in the chain #124 will need a rebase :-/ Good times.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/142

From jdowland at openjdk.org  Mon Dec 12 20:10:50 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 12 Dec 2022 20:10:50 GMT
Subject: [jdk8u-dev] Integrated: 8244500: jtreg test error in
 test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
In-Reply-To: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
References: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
Message-ID: <3DFmYhooveMzKKflafcH-jzGhX6uTfYKOJkhgZ5DLvk=.d7cc73d6-0755-49b3-bb96-a80c20fa207b@github.com>

On Mon, 17 Oct 2022 08:17:20 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8244500 to jdk8u-dev as part of cgroups v2 support.
> 
> It's a test-only change.
> 
> The patch needed adjusting for jdk8u, mostly to JDK-module-specific things.

This pull request has now been integrated.

Changeset: 4ab80ff5
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/4ab80ff59d51d15432ea2378ae8138d10dccd934
Stats:     9 lines in 1 file changed: 9 ins; 0 del; 0 mod

8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java

When the kernel doesn't support swap limits, expect host values instead.

Reviewed-by: sgehwolf
Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/142

From serb at openjdk.org  Mon Dec 12 20:44:02 2022
From: serb at openjdk.org (Sergey Bylokhov)
Date: Mon, 12 Dec 2022 20:44:02 GMT
Subject: [jdk8u-dev] RFR: 8203485: [freetype] text rotated on 180 degrees
 is too narrow
In-Reply-To: <2tCemlFksSCt1w0KKdB2YwnPbun9-i-kRRzaNjT02s0=.08ac882a-833e-4293-89dd-6aa568fd28cf@github.com>
References: <2tCemlFksSCt1w0KKdB2YwnPbun9-i-kRRzaNjT02s0=.08ac882a-833e-4293-89dd-6aa568fd28cf@github.com>
Message-ID: <qW6PMXQNG8ZRFihxNOIAxw3EyarTWLtWhvqfeY4j_U4=.ca602e1e-9325-45da-8aec-a078d2fbd65b@github.com>

On Mon, 12 Dec 2022 00:53:06 GMT, Leslie Zhai <lzhai at openjdk.org> wrote:

> Hi,
> 
> java/awt/Graphics2D/DrawString/RotTransText.java fail:
> 
> 
> STDERR:
> java.lang.RuntimeException: Ratio of blue to red is too great: 0.14015748031496064
>         at RotTransText.testIt(RotTransText.java:102)
>         at RotTransText.main(RotTransText.java:41)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:498)
>         at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
>         at java.lang.Thread.run(Thread.java:750)
> 
> 
> And JDK-8203485: [freetype] text rotated on 180 degrees is too narrow fix the issue.
> 
> The patch applies clean except manually change the source file path:
> 
> * jdk/src/share/native/sun/font/freetypeScaler.c
> * jdk/test/java/awt/font/Rotate/RotatedTextTest.java
> 
> Tested jtreg tier1~3 for fastdebug/release.
> 
> Thanks,
> Leslie Zhai

The change looks fine, but let me additionally test this patch.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/208

From lzhai at openjdk.org  Tue Dec 13 00:44:53 2022
From: lzhai at openjdk.org (Leslie Zhai)
Date: Tue, 13 Dec 2022 00:44:53 GMT
Subject: [jdk8u-dev] RFR: 8203485: [freetype] text rotated on 180 degrees
 is too narrow
In-Reply-To: <qW6PMXQNG8ZRFihxNOIAxw3EyarTWLtWhvqfeY4j_U4=.ca602e1e-9325-45da-8aec-a078d2fbd65b@github.com>
References: <2tCemlFksSCt1w0KKdB2YwnPbun9-i-kRRzaNjT02s0=.08ac882a-833e-4293-89dd-6aa568fd28cf@github.com>
 <qW6PMXQNG8ZRFihxNOIAxw3EyarTWLtWhvqfeY4j_U4=.ca602e1e-9325-45da-8aec-a078d2fbd65b@github.com>
Message-ID: <WgzwC60cw67VGBhsC2tChjNYVrek47jdHypXl386Gv0=.4c5b41e0-0dbb-4674-aab8-a728b3df20d4@github.com>

On Mon, 12 Dec 2022 20:41:28 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Hi,
>> 
>> java/awt/Graphics2D/DrawString/RotTransText.java fail:
>> 
>> 
>> STDERR:
>> java.lang.RuntimeException: Ratio of blue to red is too great: 0.14015748031496064
>>         at RotTransText.testIt(RotTransText.java:102)
>>         at RotTransText.main(RotTransText.java:41)
>>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>         at java.lang.reflect.Method.invoke(Method.java:498)
>>         at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
>>         at java.lang.Thread.run(Thread.java:750)
>> 
>> 
>> And JDK-8203485: [freetype] text rotated on 180 degrees is too narrow fix the issue.
>> 
>> The patch applies clean except manually change the source file path:
>> 
>> * jdk/src/share/native/sun/font/freetypeScaler.c
>> * jdk/test/java/awt/font/Rotate/RotatedTextTest.java
>> 
>> Tested jtreg tier1~3 for fastdebug/release.
>> 
>> Thanks,
>> Leslie Zhai
>
> The change looks fine, but let me additionally test this patch.

Hi @mrserb 

> The change looks fine, but let me additionally test this patch.

Do I need to trigger another Pre-submit tests or jtreg tier>3?

Thanks,
Leslie Zhai

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/208

From aoqi at openjdk.org  Tue Dec 13 06:18:58 2022
From: aoqi at openjdk.org (Ao Qi)
Date: Tue, 13 Dec 2022 06:18:58 GMT
Subject: [jdk8u-dev] RFR: 8072770: [TESTBUG] Some Introspector tests fail with
 a Java heap bigger than 4GB
Message-ID: <NjHcxJERMMKl-JyuB5No2n3EJSi9sZ6w_zDay5OvowU=.60cdd558-b2ed-4d05-b083-1f63502bcd4f@github.com>

The patch applies clean. This backport only includes test changes and fixes the test failure.

-------------

Commit messages:
 - Backport 137f13474383d72a0d2e392bc2f8926ad69d3da6

Changes: https://git.openjdk.org/jdk8u-dev/pull/209/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=209&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8072770
  Stats: 3 lines in 3 files changed: 3 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/209.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/209/head:pull/209

PR: https://git.openjdk.org/jdk8u-dev/pull/209

From jdowland at openjdk.org  Tue Dec 13 09:07:03 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 13 Dec 2022 09:07:03 GMT
Subject: [jdk8u-dev] RFR: 8240189: [TESTBUG] Some cgroup tests are failing
 after JDK-8231111 [v6]
In-Reply-To: <xMzwOwQNLqXe-C5x9_Vhg7oKETlwaMvxTxwDOmzd2iM=.1f8a3396-c7a0-4cdc-af4e-49837439b4e6@github.com>
References: <xMzwOwQNLqXe-C5x9_Vhg7oKETlwaMvxTxwDOmzd2iM=.1f8a3396-c7a0-4cdc-af4e-49837439b4e6@github.com>
Message-ID: <-OuTFwZ4JqjhpAQeBQ6HjFq2w9YT170HIJLYV3IhkZE=.a5933966-e003-4daf-8307-2d46db879e14@github.com>

> This is a back port of 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
> for jdk8u-dev as part of an effort to backport support for Cgroups V2.
> 
> The intention is for this PR to depend upon [8231111: 2Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy](https://github.com/openjdk/jdk8u-dev/pull/121), which in turn depends upon [8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems](https://github.com/openjdk/jdk8u-dev/pull/123), both of which are dependencies for this patch-set.
> 
> This backport is one commit on top of pr/121. It does not apply clean after path unshuffling: some of the patch contexts around `MetricsMemoryTester.java`,  `MetricsTesterCgroupV1.java` and  `MetricsTesterCgroupV2.java` differ due to changes made in pr/121 to adjust for jdk8u-dev support (replacing `Arrays.compare` with `Arrays.equals`)
> 
> I'll report back testing results to this PR, I have to untangle them a bit first.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
  
  Reviewed-by: mdoerr
  Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/124/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=124&range=05
  Stats: 145 lines in 5 files changed: 46 ins; 28 del; 71 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/124.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/124/head:pull/124

PR: https://git.openjdk.org/jdk8u-dev/pull/124

From lzhai at openjdk.org  Tue Dec 13 09:08:50 2022
From: lzhai at openjdk.org (Leslie Zhai)
Date: Tue, 13 Dec 2022 09:08:50 GMT
Subject: [jdk8u-dev] RFR: 8196196: Headful tests should not be run in headless
 mode
Message-ID: <Wz6iDU1QbRr2xA6aJ_VVQyJbBWTx0DHY09tuVnMdF9U=.d3678622-6589-430a-bebd-7765c22ddc9b@github.com>

Hi,

javax/swing/GroupLayout/7071166/bug7071166.java fail due to TESTBUG.

The patch applies clean except manually change the source file path.

Tested jtreg tier1~3 for fastdebug/release. This backport is only a test change and fixes the test failure.

Thanks,
Leslie Zhai

-------------

Commit messages:
 - Backport 7578044e7107c1914d85894cef5eb712c223252a

Changes: https://git.openjdk.org/jdk8u-dev/pull/210/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=210&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8196196
  Stats: 65 lines in 14 files changed: 46 ins; 0 del; 19 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/210.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/210/head:pull/210

PR: https://git.openjdk.org/jdk8u-dev/pull/210

From sgehwolf at openjdk.org  Tue Dec 13 10:10:59 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 13 Dec 2022 10:10:59 GMT
Subject: [jdk8u-dev] RFR: 8240189: [TESTBUG] Some cgroup tests are failing
 after JDK-8231111 [v6]
In-Reply-To: <-OuTFwZ4JqjhpAQeBQ6HjFq2w9YT170HIJLYV3IhkZE=.a5933966-e003-4daf-8307-2d46db879e14@github.com>
References: <xMzwOwQNLqXe-C5x9_Vhg7oKETlwaMvxTxwDOmzd2iM=.1f8a3396-c7a0-4cdc-af4e-49837439b4e6@github.com>
 <-OuTFwZ4JqjhpAQeBQ6HjFq2w9YT170HIJLYV3IhkZE=.a5933966-e003-4daf-8307-2d46db879e14@github.com>
Message-ID: <2cezZGtCsRoIHM_EfnSeyweJLnsAP_bJ3DyZydYv7Gc=.3976845f-4dc7-464d-9a58-91d468178b62@github.com>

On Tue, 13 Dec 2022 09:07:03 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a back port of 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
>> for jdk8u-dev as part of an effort to backport support for Cgroups V2.
>> 
>> The intention is for this PR to depend upon [8231111: 2Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy](https://github.com/openjdk/jdk8u-dev/pull/121), which in turn depends upon [8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems](https://github.com/openjdk/jdk8u-dev/pull/123), both of which are dependencies for this patch-set.
>> 
>> This backport is one commit on top of pr/121. It does not apply clean after path unshuffling: some of the patch contexts around `MetricsMemoryTester.java`,  `MetricsTesterCgroupV1.java` and  `MetricsTesterCgroupV2.java` differ due to changes made in pr/121 to adjust for jdk8u-dev support (replacing `Arrays.compare` with `Arrays.equals`)
>> 
>> I'll report back testing results to this PR, I have to untangle them a bit first.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
>   
>   Reviewed-by: mdoerr
>   Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa

Still good. Feel free to integrate and move on to rebase #136 :)

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/124

From aoqi at openjdk.org  Tue Dec 13 11:00:52 2022
From: aoqi at openjdk.org (Ao Qi)
Date: Tue, 13 Dec 2022 11:00:52 GMT
Subject: [jdk8u-dev] RFR: 8072770: [TESTBUG] Some Introspector tests fail
 with a Java heap bigger than 4GB
In-Reply-To: <NjHcxJERMMKl-JyuB5No2n3EJSi9sZ6w_zDay5OvowU=.60cdd558-b2ed-4d05-b083-1f63502bcd4f@github.com>
References: <NjHcxJERMMKl-JyuB5No2n3EJSi9sZ6w_zDay5OvowU=.60cdd558-b2ed-4d05-b083-1f63502bcd4f@github.com>
Message-ID: <-Nb1vR2jGmCxt2Z5PJ4_w93-gJtMH1aYBF2S4llbN88=.935ea296-bef0-4324-b5be-facb36663891@github.com>

On Tue, 13 Dec 2022 06:07:52 GMT, Ao Qi <aoqi at openjdk.org> wrote:

> The patch applies clean. This backport only includes test changes and fixes the test failure.

`jdk8u-fix-yes` was labeled.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/209

From jdowland at openjdk.org  Tue Dec 13 11:14:11 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 13 Dec 2022 11:14:11 GMT
Subject: [jdk8u-dev] Integrated: 8240189: [TESTBUG] Some cgroup tests are
 failing after JDK-8231111
In-Reply-To: <xMzwOwQNLqXe-C5x9_Vhg7oKETlwaMvxTxwDOmzd2iM=.1f8a3396-c7a0-4cdc-af4e-49837439b4e6@github.com>
References: <xMzwOwQNLqXe-C5x9_Vhg7oKETlwaMvxTxwDOmzd2iM=.1f8a3396-c7a0-4cdc-af4e-49837439b4e6@github.com>
Message-ID: <fXP3mLM3NymK3q6-hNIWxVTI-FSityxcl8UrO5mAyrM=.53e12c11-ace5-4839-8e70-e0d6cc47dc76@github.com>

On Mon, 26 Sep 2022 10:15:27 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a back port of 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
> for jdk8u-dev as part of an effort to backport support for Cgroups V2.
> 
> The intention is for this PR to depend upon [8231111: 2Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy](https://github.com/openjdk/jdk8u-dev/pull/121), which in turn depends upon [8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems](https://github.com/openjdk/jdk8u-dev/pull/123), both of which are dependencies for this patch-set.
> 
> This backport is one commit on top of pr/121. It does not apply clean after path unshuffling: some of the patch contexts around `MetricsMemoryTester.java`,  `MetricsTesterCgroupV1.java` and  `MetricsTesterCgroupV2.java` differ due to changes made in pr/121 to adjust for jdk8u-dev support (replacing `Arrays.compare` with `Arrays.equals`)
> 
> I'll report back testing results to this PR, I have to untangle them a bit first.

This pull request has now been integrated.

Changeset: 9cd39a40
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/9cd39a4018c2126f4cccde07be9482c7a03ce663
Stats:     145 lines in 5 files changed: 46 ins; 28 del; 71 mod

8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111

Reviewed-by: sgehwolf
Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/124

From jdowland at openjdk.org  Tue Dec 13 11:16:03 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 13 Dec 2022 11:16:03 GMT
Subject: [jdk8u-dev] RFR: 8239559: Cgroups: Incorrect detection logic on
 some systems [v8]
In-Reply-To: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
References: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
Message-ID: <WuxaNXtT8zRtZgX0Kd1T3KllQid0mgMBAzI9_KdOCJY=.7aa4d8d0-8cda-4bd3-b7de-231a269eb970@github.com>

> This is a backport of 53ee0c4963007b86db7979312b81f990e6ce271a via the 11u backport 53ee0c4963007b86db7979312b81f990e6ce271a for cgroups v2 support in jdk8u-dev.
> 
> It isn't clean: context differences in CgroupSubsystemFactory.java around the use of post-8u logging in the original patch.
> 
> I also had to Optional.isEmpty which is not present in 8u's Optional.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:

 - Test fix by Severin. Thanks!
 - replace post-jdk8u Optional.isEmpty
 - 8239559: Cgroups: Incorrect detection logic on some systems
   
   Adjust heuristic with cgroup mounts according to mountinfo
   
   Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
 - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
   
   Reviewed-by: sgehwolf
   Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/136/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=136&range=07
  Stats: 461 lines in 8 files changed: 333 ins; 49 del; 79 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/136.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/136/head:pull/136

PR: https://git.openjdk.org/jdk8u-dev/pull/136

From sgehwolf at openjdk.org  Tue Dec 13 14:50:36 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 13 Dec 2022 14:50:36 GMT
Subject: [jdk8u-dev] RFR: 8239559: Cgroups: Incorrect detection logic on
 some systems [v8]
In-Reply-To: <WuxaNXtT8zRtZgX0Kd1T3KllQid0mgMBAzI9_KdOCJY=.7aa4d8d0-8cda-4bd3-b7de-231a269eb970@github.com>
References: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
 <WuxaNXtT8zRtZgX0Kd1T3KllQid0mgMBAzI9_KdOCJY=.7aa4d8d0-8cda-4bd3-b7de-231a269eb970@github.com>
Message-ID: <ZEKpXL0xq2dc863QK32TVrZp0V7C88emjYfwSvsuMlQ=.513fb9ba-50a8-4c8b-8a3d-341478626573@github.com>

On Tue, 13 Dec 2022 11:16:03 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 53ee0c4963007b86db7979312b81f990e6ce271a via the 11u backport 53ee0c4963007b86db7979312b81f990e6ce271a for cgroups v2 support in jdk8u-dev.
>> 
>> It isn't clean: context differences in CgroupSubsystemFactory.java around the use of post-8u logging in the original patch.
>> 
>> I also had to Optional.isEmpty which is not present in 8u's Optional.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - Test fix by Severin. Thanks!
>  - replace post-jdk8u Optional.isEmpty
>  - 8239559: Cgroups: Incorrect detection logic on some systems
>    
>    Adjust heuristic with cgroup mounts according to mountinfo
>    
>    Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
>  - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
>    
>    Reviewed-by: sgehwolf
>    Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa

Still good. Please proceed with integration and then rebase #164 Thank you!

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/136

From aoqi at openjdk.org  Tue Dec 13 14:54:26 2022
From: aoqi at openjdk.org (Ao Qi)
Date: Tue, 13 Dec 2022 14:54:26 GMT
Subject: [jdk8u-dev] Integrated: 8072770: [TESTBUG] Some Introspector tests
 fail with a Java heap bigger than 4GB
In-Reply-To: <NjHcxJERMMKl-JyuB5No2n3EJSi9sZ6w_zDay5OvowU=.60cdd558-b2ed-4d05-b083-1f63502bcd4f@github.com>
References: <NjHcxJERMMKl-JyuB5No2n3EJSi9sZ6w_zDay5OvowU=.60cdd558-b2ed-4d05-b083-1f63502bcd4f@github.com>
Message-ID: <sQdvmaR7TJafZp3b4oauRNWqf3OVyePRSb0yb2QRtSU=.fa6780bf-d78f-4256-952e-84cd07a4dbdd@github.com>

On Tue, 13 Dec 2022 06:07:52 GMT, Ao Qi <aoqi at openjdk.org> wrote:

> The patch applies clean. This backport only includes test changes and fixes the test failure.

This pull request has now been integrated.

Changeset: a318e006
Author:    Ao Qi <aoqi at openjdk.org>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/a318e0067c7bceae124c39794400685b956e37d2
Stats:     3 lines in 3 files changed: 3 ins; 0 del; 0 mod

8072770: [TESTBUG] Some Introspector tests fail with a Java heap bigger than 4GB

Backport-of: 137f13474383d72a0d2e392bc2f8926ad69d3da6

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/209

From aoqi at openjdk.org  Tue Dec 13 15:03:04 2022
From: aoqi at openjdk.org (Ao Qi)
Date: Tue, 13 Dec 2022 15:03:04 GMT
Subject: [jdk8u-dev] RFR: 8072770: [TESTBUG] Some Introspector tests fail
 with a Java heap bigger than 4GB
In-Reply-To: <NjHcxJERMMKl-JyuB5No2n3EJSi9sZ6w_zDay5OvowU=.60cdd558-b2ed-4d05-b083-1f63502bcd4f@github.com>
References: <NjHcxJERMMKl-JyuB5No2n3EJSi9sZ6w_zDay5OvowU=.60cdd558-b2ed-4d05-b083-1f63502bcd4f@github.com>
Message-ID: <EjriMlXDx4OsjtFfsSE4dU--n32FSySuAxl1Y1hd_4o=.266c922b-4c20-4d4f-addf-f0e3599b5ccb@github.com>

On Tue, 13 Dec 2022 06:07:52 GMT, Ao Qi <aoqi at openjdk.org> wrote:

> The patch applies clean. This backport only includes test changes and fixes the test failure.

Thank you very much for the quick approval and sponsorship, @jerboaa.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/209

From sgehwolf at openjdk.org  Tue Dec 13 15:17:01 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 13 Dec 2022 15:17:01 GMT
Subject: [jdk8u-dev] RFR: 8196196: Headful tests should not be run in
 headless mode
In-Reply-To: <Wz6iDU1QbRr2xA6aJ_VVQyJbBWTx0DHY09tuVnMdF9U=.d3678622-6589-430a-bebd-7765c22ddc9b@github.com>
References: <Wz6iDU1QbRr2xA6aJ_VVQyJbBWTx0DHY09tuVnMdF9U=.d3678622-6589-430a-bebd-7765c22ddc9b@github.com>
Message-ID: <tmePZdPhhige-VjdtSOvdj__Fp4xWUT1otxB7rbZMHo=.01aec847-40f9-491a-b678-49afd21c18a5@github.com>

On Tue, 13 Dec 2022 09:01:01 GMT, Leslie Zhai <lzhai at openjdk.org> wrote:

> Hi,
> 
> javax/swing/GroupLayout/7071166/bug7071166.java fail due to TESTBUG.
> 
> The patch applies clean except manually change the source file path.
> 
> Tested jtreg tier1~3 for fastdebug/release. This backport is only a test change and fixes the test failure.
> 
> Thanks,
> Leslie Zhai

One small difference. Once that's fixed it's good to go.

jdk/test/javax/swing/JComboBox/6632953/bug6632953.java line 47:

> 45:                     try {
> 46:                         UIManager.setLookAndFeel(lafInfo.getClassName());
> 47:                     } catch (final UnsupportedLookAndFeelException ignored) {

The JDK 11 patches doesn't have `final` keyword here. Please remove.

-------------

Changes requested by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/210

From jdowland at openjdk.org  Tue Dec 13 15:50:07 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 13 Dec 2022 15:50:07 GMT
Subject: [jdk8u-dev] Integrated: 8239559: Cgroups: Incorrect detection logic on
 some systems
In-Reply-To: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
References: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
Message-ID: <kh7AVSYx6iP401SqsWQP5ZR8OPxH_KsKjAJQT1EOCJE=.122a700d-4f3b-437f-998d-772381fe10a8@github.com>

On Thu, 13 Oct 2022 09:34:05 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 53ee0c4963007b86db7979312b81f990e6ce271a via the 11u backport 53ee0c4963007b86db7979312b81f990e6ce271a for cgroups v2 support in jdk8u-dev.
> 
> It isn't clean: context differences in CgroupSubsystemFactory.java around the use of post-8u logging in the original patch.
> 
> I also had to Optional.isEmpty which is not present in 8u's Optional.

This pull request has now been integrated.

Changeset: b0826174
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/b0826174b78d2acf758b1df8c3233a4885eb1715
Stats:     316 lines in 3 files changed: 287 ins; 21 del; 8 mod

8239559: Cgroups: Incorrect detection logic on some systems

Adjust heuristic with cgroup mounts according to mountinfo

Reviewed-by: sgehwolf
Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/136

From sgehwolf at openjdk.org  Tue Dec 13 17:07:12 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 13 Dec 2022 17:07:12 GMT
Subject: [jdk8u-dev] RFR: 8197408: Bad pointer comparison and small cleanup
 in os_linux.cpp [v3]
In-Reply-To: <Ze1PtaDkpGCwCxQl9_s6fosrqZVVrC2W-BUYwZY_vBc=.7b0abfbc-15ef-46c1-adb6-e3f42ed7487b@github.com>
References: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
 <Ze1PtaDkpGCwCxQl9_s6fosrqZVVrC2W-BUYwZY_vBc=.7b0abfbc-15ef-46c1-adb6-e3f42ed7487b@github.com>
Message-ID: <jRRS102ZsDefiJMd2mknXtTnlMCg0EXfPkhsps4Qnzs=.938d20e1-b879-4366-8c62-99ffc752ee3b@github.com>

On Mon, 12 Dec 2022 09:49:28 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of [JDK-8197408](https://bugs.openjdk.org/browse/JDK-8197408) to jdk8u-dev as part of cgroups v2. I've backported it as a pre-requisite for 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 (<https://github.com/openjdk/jdk8u-dev/pull/155>)
>> 
>> Most of the original patch has been integrated already: I've left a whitespace change in for os_linux.cpp to hopefully avoid context problems later on. The majority of this patch is introducing the test PlainRead.java.
>> 
>> Not clean: test adjustments to jtreg metadata, imports, and JVM flags needed.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 65 additional commits since the last revision:
> 
>  - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
>  - adjust jtreg settings and imports for 8u
>  - 8197408: Bad pointer comparison and small cleanup in os_linux.cpp
>    
>    Reviewed-by: bobv, stuefe
>  - Test fix by Severin. Thanks!
>  - replace post-jdk8u Optional.isEmpty
>  - 8239559: Cgroups: Incorrect detection logic on some systems
>    
>    Adjust heuristic with cgroup mounts according to mountinfo
>    
>    Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
>  - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
>    
>    Reviewed-by: mdoerr
>    Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
>  - Don't pass --add-exports to jdk8u java inside docker
>    
>    These are JDK9+ module specific parameters.
>  - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
>    
>    When the kernel doesn't support swap limits, expect host values instead.
>    
>    Reviewed-by: sgehwolf
>    Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e
>  - Update file path in comment
>  - ... and 55 more: https://git.openjdk.org/jdk8u-dev/compare/74d73c96...0b65ee05

This cannot be merged as is, needs a rebase.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/164

From jdowland at openjdk.org  Tue Dec 13 17:09:51 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 13 Dec 2022 17:09:51 GMT
Subject: [jdk8u-dev] RFR: 8197408: Bad pointer comparison and small cleanup
 in os_linux.cpp [v4]
In-Reply-To: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
References: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
Message-ID: <14mKWtZQ2gEUCehd4fBKRZLyPLR2Ly-95HbPcs-a-Qk=.2adbb396-a37d-4585-b9d7-db0b87bbe1f6@github.com>

> This is a backport of [JDK-8197408](https://bugs.openjdk.org/browse/JDK-8197408) to jdk8u-dev as part of cgroups v2. I've backported it as a pre-requisite for 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 (<https://github.com/openjdk/jdk8u-dev/pull/155>)
> 
> Most of the original patch has been integrated already: I've left a whitespace change in for os_linux.cpp to hopefully avoid context problems later on. The majority of this patch is introducing the test PlainRead.java.
> 
> Not clean: test adjustments to jtreg metadata, imports, and JVM flags needed.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:

 - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
 - adjust jtreg settings and imports for 8u
 - 8197408: Bad pointer comparison and small cleanup in os_linux.cpp
   
   Reviewed-by: bobv, stuefe

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/164/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=164&range=03
  Stats: 82 lines in 2 files changed: 81 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/164.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/164/head:pull/164

PR: https://git.openjdk.org/jdk8u-dev/pull/164

From sgehwolf at openjdk.org  Tue Dec 13 18:01:04 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 13 Dec 2022 18:01:04 GMT
Subject: [jdk8u-dev] RFR: 8197408: Bad pointer comparison and small cleanup
 in os_linux.cpp [v4]
In-Reply-To: <14mKWtZQ2gEUCehd4fBKRZLyPLR2Ly-95HbPcs-a-Qk=.2adbb396-a37d-4585-b9d7-db0b87bbe1f6@github.com>
References: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
 <14mKWtZQ2gEUCehd4fBKRZLyPLR2Ly-95HbPcs-a-Qk=.2adbb396-a37d-4585-b9d7-db0b87bbe1f6@github.com>
Message-ID: <_DpeY86esXA6nr6EG-9Wf8NkrtFz6Q3ToXRZAv5zb98=.1e66d7ac-e52b-4bb0-897a-17bd10031030@github.com>

On Tue, 13 Dec 2022 17:09:51 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of [JDK-8197408](https://bugs.openjdk.org/browse/JDK-8197408) to jdk8u-dev as part of cgroups v2. I've backported it as a pre-requisite for 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 (<https://github.com/openjdk/jdk8u-dev/pull/155>)
>> 
>> Most of the original patch has been integrated already: I've left a whitespace change in for os_linux.cpp to hopefully avoid context problems later on. The majority of this patch is introducing the test PlainRead.java.
>> 
>> Not clean: test adjustments to jtreg metadata, imports, and JVM flags needed.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
>  - adjust jtreg settings and imports for 8u
>  - 8197408: Bad pointer comparison and small cleanup in os_linux.cpp
>    
>    Reviewed-by: bobv, stuefe

OK. Feel free to integrate and then rebase #155, thanks!

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/164

From jdowland at openjdk.org  Tue Dec 13 19:34:34 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 13 Dec 2022 19:34:34 GMT
Subject: [jdk8u-dev] Integrated: 8197408: Bad pointer comparison and small
 cleanup in os_linux.cpp
In-Reply-To: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
References: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
Message-ID: <3JPMRlsmpQ9ZY5ssw-HcvhiNYA3MVc6f7QGNFkP4Gig=.da430263-1689-437f-bc64-dff59572cd25@github.com>

On Wed, 9 Nov 2022 10:25:03 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of [JDK-8197408](https://bugs.openjdk.org/browse/JDK-8197408) to jdk8u-dev as part of cgroups v2. I've backported it as a pre-requisite for 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 (<https://github.com/openjdk/jdk8u-dev/pull/155>)
> 
> Most of the original patch has been integrated already: I've left a whitespace change in for os_linux.cpp to hopefully avoid context problems later on. The majority of this patch is introducing the test PlainRead.java.
> 
> Not clean: test adjustments to jtreg metadata, imports, and JVM flags needed.

This pull request has now been integrated.

Changeset: c7599bd2
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/c7599bd217bf4ba638456d9c58c69b33b405199b
Stats:     82 lines in 2 files changed: 81 ins; 0 del; 1 mod

8197408: Bad pointer comparison and small cleanup in os_linux.cpp

Reviewed-by: sgehwolf
Backport-of: 5287d9a366791793b644d765ece783496b011119

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/164

From lzhai at openjdk.org  Wed Dec 14 00:52:53 2022
From: lzhai at openjdk.org (Leslie Zhai)
Date: Wed, 14 Dec 2022 00:52:53 GMT
Subject: [jdk8u-dev] RFR: 8196196: Headful tests should not be run in
 headless mode [v2]
In-Reply-To: <Wz6iDU1QbRr2xA6aJ_VVQyJbBWTx0DHY09tuVnMdF9U=.d3678622-6589-430a-bebd-7765c22ddc9b@github.com>
References: <Wz6iDU1QbRr2xA6aJ_VVQyJbBWTx0DHY09tuVnMdF9U=.d3678622-6589-430a-bebd-7765c22ddc9b@github.com>
Message-ID: <DI_ylbnwtLJUDWqR8fEJPmfYvK1pwQyD7fM3e-oWBhY=.bb862766-65ca-425a-9174-801a7f035d0f@github.com>

> Hi,
> 
> javax/swing/GroupLayout/7071166/bug7071166.java fail due to TESTBUG.
> 
> The patch applies clean except manually change the source file path.
> 
> Tested jtreg tier1~3 for fastdebug/release. This backport is only a test change and fixes the test failure.
> 
> Thanks,
> Leslie Zhai

Leslie Zhai has updated the pull request incrementally with one additional commit since the last revision:

  Remove keyword final for jdk/test/javax/swing/JComboBox/6632953/bug6632953.java

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/210/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/210/files/5bdc9114..5f5ac73e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=210&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=210&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/210.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/210/head:pull/210

PR: https://git.openjdk.org/jdk8u-dev/pull/210

From lzhai at openjdk.org  Wed Dec 14 00:52:53 2022
From: lzhai at openjdk.org (Leslie Zhai)
Date: Wed, 14 Dec 2022 00:52:53 GMT
Subject: [jdk8u-dev] RFR: 8196196: Headful tests should not be run in
 headless mode [v2]
In-Reply-To: <tmePZdPhhige-VjdtSOvdj__Fp4xWUT1otxB7rbZMHo=.01aec847-40f9-491a-b678-49afd21c18a5@github.com>
References: <Wz6iDU1QbRr2xA6aJ_VVQyJbBWTx0DHY09tuVnMdF9U=.d3678622-6589-430a-bebd-7765c22ddc9b@github.com>
 <tmePZdPhhige-VjdtSOvdj__Fp4xWUT1otxB7rbZMHo=.01aec847-40f9-491a-b678-49afd21c18a5@github.com>
Message-ID: <6C_vkiwMIc44ydDiyRmwxmHc0BzDXqgNDvFlK6nIq20=.cda8ab78-1e79-4f01-ac59-dbe89c2e29cc@github.com>

On Tue, 13 Dec 2022 15:14:48 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Leslie Zhai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove keyword final for jdk/test/javax/swing/JComboBox/6632953/bug6632953.java
>
> One small difference. Once that's fixed it's good to go.

Hi @jerboaa 

Thanks for your review!

I updated my patch, please review it again.

Thanks,
Leslie Zhai

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/210

From sgehwolf at openjdk.org  Wed Dec 14 09:55:12 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 14 Dec 2022 09:55:12 GMT
Subject: [jdk8u-dev] RFR: 8196196: Headful tests should not be run in
 headless mode [v2]
In-Reply-To: <DI_ylbnwtLJUDWqR8fEJPmfYvK1pwQyD7fM3e-oWBhY=.bb862766-65ca-425a-9174-801a7f035d0f@github.com>
References: <Wz6iDU1QbRr2xA6aJ_VVQyJbBWTx0DHY09tuVnMdF9U=.d3678622-6589-430a-bebd-7765c22ddc9b@github.com>
 <DI_ylbnwtLJUDWqR8fEJPmfYvK1pwQyD7fM3e-oWBhY=.bb862766-65ca-425a-9174-801a7f035d0f@github.com>
Message-ID: <lijHNmH7H7vpzCxoMVOYi6Bg-MnQzTqfqxBxX7dqBiE=.cb3d023c-9488-4613-a2a9-75f1291715e1@github.com>

On Wed, 14 Dec 2022 00:52:53 GMT, Leslie Zhai <lzhai at openjdk.org> wrote:

>> Hi,
>> 
>> javax/swing/GroupLayout/7071166/bug7071166.java fail due to TESTBUG.
>> 
>> The patch applies clean except manually change the source file path.
>> 
>> Tested jtreg tier1~3 for fastdebug/release. This backport is only a test change and fixes the test failure.
>> 
>> Thanks,
>> Leslie Zhai
>
> Leslie Zhai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove keyword final for jdk/test/javax/swing/JComboBox/6632953/bug6632953.java

Looks fine now.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/210

From sgehwolf at openjdk.org  Wed Dec 14 09:56:20 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 14 Dec 2022 09:56:20 GMT
Subject: [jdk8u-dev] RFR: 8278951: containers/cgroup/PlainRead.java fails
 on Ubuntu 21.10
In-Reply-To: <S8mH-_n4Y5TixifsHGxKEFXo9mJ4QL2Ld-ghlCf-dTs=.76600d20-8a5b-4eae-ba11-b9f84cda6253@github.com>
References: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
 <S8mH-_n4Y5TixifsHGxKEFXo9mJ4QL2Ld-ghlCf-dTs=.76600d20-8a5b-4eae-ba11-b9f84cda6253@github.com>
Message-ID: <Udasqnxn9W43ES5Hs3pkckGNkubtOeAe4HAdSw4YaGw=.273f6d15-0c56-4e11-b85d-821f2038dcec@github.com>

On Thu, 10 Nov 2022 10:46:54 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8278951 to jdk8u-dev as part of the cgroups v2 backport initiative.
>> 
>> Dependent PRs are in use.
>> 
>> It was clean (modulo path shuffles). The use of `log_trace` needed adjusting for jdk8u-dev.
>
> Same test behaviour as the parent PR: passes on cgroups v1, fails on v2.

@jmtd This needs a rebase onto latest master, please. Thanks! We cannot merge as is.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/155

From lzhai at openjdk.org  Wed Dec 14 10:09:53 2022
From: lzhai at openjdk.org (Leslie Zhai)
Date: Wed, 14 Dec 2022 10:09:53 GMT
Subject: [jdk8u-dev] Integrated: 8196196: Headful tests should not be run in
 headless mode
In-Reply-To: <Wz6iDU1QbRr2xA6aJ_VVQyJbBWTx0DHY09tuVnMdF9U=.d3678622-6589-430a-bebd-7765c22ddc9b@github.com>
References: <Wz6iDU1QbRr2xA6aJ_VVQyJbBWTx0DHY09tuVnMdF9U=.d3678622-6589-430a-bebd-7765c22ddc9b@github.com>
Message-ID: <2r47l1PK_DeAMtAVHNeRg4y4egjhYiExXR2kjP3OYNw=.9500067a-dc6f-4ad5-a983-c1572c439a33@github.com>

On Tue, 13 Dec 2022 09:01:01 GMT, Leslie Zhai <lzhai at openjdk.org> wrote:

> Hi,
> 
> javax/swing/GroupLayout/7071166/bug7071166.java fail due to TESTBUG.
> 
> The patch applies clean except manually change the source file path.
> 
> Tested jtreg tier1~3 for fastdebug/release. This backport is only a test change and fixes the test failure.
> 
> Thanks,
> Leslie Zhai

This pull request has now been integrated.

Changeset: 537ff942
Author:    Leslie Zhai <lzhai at openjdk.org>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/537ff942252e33831446d285800e5765a84bc19c
Stats:     65 lines in 14 files changed: 46 ins; 0 del; 19 mod

8196196: Headful tests should not be run in headless mode

Reviewed-by: sgehwolf
Backport-of: 7578044e7107c1914d85894cef5eb712c223252a

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/210

From sgehwolf at openjdk.org  Wed Dec 14 16:56:30 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 14 Dec 2022 16:56:30 GMT
Subject: [jdk8u-dev] RFR: 8266391: Replace use of reflection in
 jdk.internal.platform.Metrics [v2]
In-Reply-To: <k2EWx15uzhpGQWYRzB_XmiMBH4a5paKeFt7HzEO3hws=.f6473142-56b6-4653-91a3-3534238079e9@github.com>
References: <g7RG2DZHfz5Fo7fxo56Q4FIsUdQlABEvbthK8k3xOwU=.74f82cd8-e4eb-4db1-a5c8-eb2a1a19d391@github.com>
 <k2EWx15uzhpGQWYRzB_XmiMBH4a5paKeFt7HzEO3hws=.f6473142-56b6-4653-91a3-3534238079e9@github.com>
Message-ID: <hLacAORVo-Y3Hr3UiWdE9ndxPsD44MGVBY19Kwdrgnk=.00790001-c0a0-48b7-8bab-492bfd21cbcc@github.com>

On Wed, 16 Nov 2022 14:51:31 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> A clean backport of 8266391 for jdk8u-dev as part of cgroups v2 support.
>
> Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add a macosx platform specific SystemMetrics class

Keep open, please.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/177

From phh at openjdk.org  Wed Dec 14 20:06:04 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Wed, 14 Dec 2022 20:06:04 GMT
Subject: [jdk8u-dev] RFR: 8254717: isAssignableFrom checks in
 KeyFactorySpi.engineGetKeySpec appear to be backwards
Message-ID: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>

Backport for Oracle parity. Backport from 11u is not clean.

1.  Copyright date mismatch in P11SecretKeyFactory.java.
2. XDHKeyFactory.java does not exist in 8u.
3. In KeyFactoryGetKeySpecForInvalidSpec.java, class FakeX509Spec does not include a (byte[], String) constructor since in 8u, X509EncodedKeySpec does not.

-------------

Commit messages:
 - Backport a777e82cd81fb5f02b09c4917b2a44f94c603939

Changes: https://git.openjdk.org/jdk8u-dev/pull/211/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=211&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8254717
  Stats: 129 lines in 15 files changed: 75 ins; 3 del; 51 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/211.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/211/head:pull/211

PR: https://git.openjdk.org/jdk8u-dev/pull/211

From jdowland at openjdk.org  Wed Dec 14 20:48:07 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 14 Dec 2022 20:48:07 GMT
Subject: [jdk8u-dev] RFR: 8278951: containers/cgroup/PlainRead.java fails
 on Ubuntu 21.10 [v5]
In-Reply-To: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
References: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
Message-ID: <lt_g87Mc9QRprKBeL9Xt1ovd_A294vcAuImk4WnM5Hw=.6477c31f-d5cb-4703-ad86-84f46f01e989@github.com>

> This is a backport of 8278951 to jdk8u-dev as part of the cgroups v2 backport initiative.
> 
> Dependent PRs are in use.
> 
> It was clean (modulo path shuffles). The use of `log_trace` needed adjusting for jdk8u-dev.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - replace log_trace with tty->print_cr
 - 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
   
   Reviewed-by: sgehwolf
   Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/155/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=155&range=04
  Stats: 7 lines in 2 files changed: 4 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/155.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/155/head:pull/155

PR: https://git.openjdk.org/jdk8u-dev/pull/155

From andrew at openjdk.org  Wed Dec 14 21:46:15 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 14 Dec 2022 21:46:15 GMT
Subject: [jdk8u-dev] RFR: 8254717: isAssignableFrom checks in
 KeyFactorySpi.engineGetKeySpec appear to be backwards
In-Reply-To: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>
References: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>
Message-ID: <MualKppAflaT0T_4HSCPe10-lxX2HEyOhtK52hETiKc=.6d2b7d88-ccf9-4d22-a611-6820b7c33fdc@github.com>

On Wed, 14 Dec 2022 19:58:48 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> Backport for Oracle parity from 11u is not clean.
> 
> 1.  Copyright date mismatch in P11SecretKeyFactory.java.
> 2. XDHKeyFactory.java does not exist in 8u.
> 3. In KeyFactoryGetKeySpecForInvalidSpec.java, class FakeX509Spec does not include a (byte[], String) constructor since in 8u, X509EncodedKeySpec does not.

Patch looks good to me.

We need to make sure we follow this up with [JDK-8263404](https://bugs.openjdk.org/browse/JDK-8263404)

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/211

From phh at openjdk.org  Wed Dec 14 21:51:13 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Wed, 14 Dec 2022 21:51:13 GMT
Subject: [jdk8u-dev] RFR: 8254717: isAssignableFrom checks in
 KeyFactorySpi.engineGetKeySpec appear to be backwards
In-Reply-To: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>
References: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>
Message-ID: <B9vN_2FOn4ZqHp6eEZKnmXdAQd11k_rB37HVKDMC-78=.18519c50-6ea2-4470-8fbc-19e876062a0f@github.com>

On Wed, 14 Dec 2022 19:58:48 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> Backport for Oracle parity from 11u is not clean.
> 
> 1.  Copyright date mismatch in P11SecretKeyFactory.java.
> 2. XDHKeyFactory.java does not exist in 8u.
> 3. In KeyFactoryGetKeySpecForInvalidSpec.java, class FakeX509Spec does not include a (byte[], String) constructor since in 8u, X509EncodedKeySpec does not.

Thanks for the review, Andrew, and will do.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/211

From sgehwolf at openjdk.org  Thu Dec 15 09:21:21 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 15 Dec 2022 09:21:21 GMT
Subject: [jdk8u-dev] RFR: 8278951: containers/cgroup/PlainRead.java fails
 on Ubuntu 21.10 [v5]
In-Reply-To: <lt_g87Mc9QRprKBeL9Xt1ovd_A294vcAuImk4WnM5Hw=.6477c31f-d5cb-4703-ad86-84f46f01e989@github.com>
References: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
 <lt_g87Mc9QRprKBeL9Xt1ovd_A294vcAuImk4WnM5Hw=.6477c31f-d5cb-4703-ad86-84f46f01e989@github.com>
Message-ID: <R5_2M_CSDCdePw4a8vG2-leT85s_YmBFtR67_-SWEF8=.ff75742a-1d01-4d45-bd9e-aa40f36f0655@github.com>

On Wed, 14 Dec 2022 20:48:07 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8278951 to jdk8u-dev as part of the cgroups v2 backport initiative.
>> 
>> Dependent PRs are in use.
>> 
>> It was clean (modulo path shuffles). The use of `log_trace` needed adjusting for jdk8u-dev.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - replace log_trace with tty->print_cr
>  - 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
>    
>    Reviewed-by: sgehwolf
>    Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b

Looks good. Feel free to integrate and then rebase #157. Thanks!

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/155

From jdowland at openjdk.org  Thu Dec 15 10:00:29 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 15 Dec 2022 10:00:29 GMT
Subject: [jdk8u-dev] Integrated: 8278951: containers/cgroup/PlainRead.java
 fails on Ubuntu 21.10
In-Reply-To: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
References: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
Message-ID: <p-Qgbuc3OJ7cKGXn-voe2-4gbsddLuGX0nBEs_-AuyU=.97162c6a-b21a-486e-89c6-2d13f0da0925@github.com>

On Fri, 4 Nov 2022 10:56:03 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8278951 to jdk8u-dev as part of the cgroups v2 backport initiative.
> 
> Dependent PRs are in use.
> 
> It was clean (modulo path shuffles). The use of `log_trace` needed adjusting for jdk8u-dev.

This pull request has now been integrated.

Changeset: 5b01ebb6
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/5b01ebb6aaaa36cc54f14a260dec5a68077aa9e8
Stats:     7 lines in 2 files changed: 4 ins; 0 del; 3 mod

8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10

Reviewed-by: sgehwolf
Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/155

From jdowland at openjdk.org  Thu Dec 15 10:03:20 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 15 Dec 2022 10:03:20 GMT
Subject: [jdk8u-dev] RFR: 8252359: HotSpot Not Identifying it is Running in
 a Container [v6]
In-Reply-To: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>
References: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>
Message-ID: <bmzGwbkWwhpRbXBUy2SSwlX8Xvlp5MHGczp08xCyyAY=.9606bec9-bf6e-4f20-b094-b2564793ebc5@github.com>

> This is a clean backport of 8252359  to jdk8u-dev, as part of cgroups v2 support.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8252359: HotSpot Not Identifying it is Running in a Container
  
  Backport-of: 76f0588aaf265439a589cceb924e3ea9d3fda8f1

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/157/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=157&range=05
  Stats: 15 lines in 2 files changed: 0 ins; 0 del; 15 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/157.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/157/head:pull/157

PR: https://git.openjdk.org/jdk8u-dev/pull/157

From sgehwolf at openjdk.org  Thu Dec 15 10:43:14 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 15 Dec 2022 10:43:14 GMT
Subject: [jdk8u-dev] RFR: 8252359: HotSpot Not Identifying it is Running in
 a Container [v6]
In-Reply-To: <bmzGwbkWwhpRbXBUy2SSwlX8Xvlp5MHGczp08xCyyAY=.9606bec9-bf6e-4f20-b094-b2564793ebc5@github.com>
References: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>
 <bmzGwbkWwhpRbXBUy2SSwlX8Xvlp5MHGczp08xCyyAY=.9606bec9-bf6e-4f20-b094-b2564793ebc5@github.com>
Message-ID: <fDh_P-AQ-PWRmsKcPmpLGjNd93XQCF7ORMOa8eZ_7bc=.e52fb3dc-7cf3-4e6b-8e56-27589c098a8e@github.com>

On Thu, 15 Dec 2022 10:03:20 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a clean backport of 8252359  to jdk8u-dev, as part of cgroups v2 support.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8252359: HotSpot Not Identifying it is Running in a Container
>   
>   Backport-of: 76f0588aaf265439a589cceb924e3ea9d3fda8f1

Approved for 8u. Please integrate and then rebase #158. Thanks!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/157

From jdowland at openjdk.org  Thu Dec 15 10:57:09 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 15 Dec 2022 10:57:09 GMT
Subject: [jdk8u-dev] Integrated: 8252359: HotSpot Not Identifying it is Running
 in a Container
In-Reply-To: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>
References: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>
Message-ID: <m0NWMbX-ITORV1BdU0VJwPtHR7Qs7AWqH6-rCsNKUCs=.a8e386d3-371a-4645-8040-6bb79fd5fab1@github.com>

On Mon, 7 Nov 2022 10:03:22 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a clean backport of 8252359  to jdk8u-dev, as part of cgroups v2 support.

This pull request has now been integrated.

Changeset: d9db01cc
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/d9db01ccc6253429b62aff71dea54be38be121c5
Stats:     15 lines in 2 files changed: 0 ins; 0 del; 15 mod

8252359: HotSpot Not Identifying it is Running in a Container

Backport-of: 76f0588aaf265439a589cceb924e3ea9d3fda8f1

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/157

From jdowland at openjdk.org  Thu Dec 15 11:05:26 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 15 Dec 2022 11:05:26 GMT
Subject: [jdk8u-dev] RFR: 8253435: Cgroup: 'stomping of _mount_path' crash
 if manually mounted cpusets exist [v7]
In-Reply-To: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
References: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
Message-ID: <9k9U9iIvgPUlWLajKYU5G47GB-IsUokiB5Dz8o8feSc=.1d5a1f8e-d14c-4fe3-83ea-563999179ecf@github.com>

> This is a backport of 8253435 to jdk8u-dev for cgroups v2 support.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:

 - Severin's test fixes. Thanks!
 - Replace log_warning with tty->print_cr
 - 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
   
   Backport-of: 0054c15f60cce6470be05d29bfacbdb74cfb7bc9

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/158/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=158&range=06
  Stats: 44 lines in 2 files changed: 41 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/158.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/158/head:pull/158

PR: https://git.openjdk.org/jdk8u-dev/pull/158

From sgehwolf at openjdk.org  Thu Dec 15 13:08:12 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 15 Dec 2022 13:08:12 GMT
Subject: [jdk8u-dev] RFR: 8253435: Cgroup: 'stomping of _mount_path' crash
 if manually mounted cpusets exist [v7]
In-Reply-To: <9k9U9iIvgPUlWLajKYU5G47GB-IsUokiB5Dz8o8feSc=.1d5a1f8e-d14c-4fe3-83ea-563999179ecf@github.com>
References: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
 <9k9U9iIvgPUlWLajKYU5G47GB-IsUokiB5Dz8o8feSc=.1d5a1f8e-d14c-4fe3-83ea-563999179ecf@github.com>
Message-ID: <56eSiIulbYVEto3BqS_YG-GCx5F-PlLRuHVaqXJPwYc=.9fbba590-7860-4fa5-a919-20175184129a@github.com>

On Thu, 15 Dec 2022 11:05:26 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8253435 to jdk8u-dev for cgroups v2 support.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Severin's test fixes. Thanks!
>  - Replace log_warning with tty->print_cr
>  - 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
>    
>    Backport-of: 0054c15f60cce6470be05d29bfacbdb74cfb7bc9

OK. Feel free to integrate and then rebase #159. Thank you!

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/158

From jdowland at openjdk.org  Thu Dec 15 13:50:13 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 15 Dec 2022 13:50:13 GMT
Subject: [jdk8u-dev] Integrated: 8253435: Cgroup: 'stomping of _mount_path'
 crash if manually mounted cpusets exist
In-Reply-To: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
References: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
Message-ID: <C2jBeTKvytCFEe_9hMJsYQdFUqZo5I_0fP5SIy5r-W0=.08c3f1d4-97ed-4307-bd29-753ee61e17b5@github.com>

On Mon, 7 Nov 2022 10:22:13 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8253435 to jdk8u-dev for cgroups v2 support.

This pull request has now been integrated.

Changeset: 2bee6454
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/2bee6454e81edc18c66f28504dd5502adedf24ab
Stats:     44 lines in 2 files changed: 41 ins; 0 del; 3 mod

8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist

Reviewed-by: sgehwolf
Backport-of: 0054c15f60cce6470be05d29bfacbdb74cfb7bc9

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/158

From jdowland at openjdk.org  Thu Dec 15 13:50:53 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 15 Dec 2022 13:50:53 GMT
Subject: [jdk8u-dev] RFR: 8245543: Cgroups: Incorrect detection logic on
 some systems (still reproducible) [v7]
In-Reply-To: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
References: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
Message-ID: <OtOi_v65Aa2_RrKZLEb0m0PujNaxUTsdfqjLWIQ-_u0=.09eac9eb-507f-4eef-aa1b-830a2933cf1c@github.com>

> A backport of 8245543 to jdk8u-dev for cgroups v2 support.
> 
> Not clean: needed minor adjusting for 8u approach to log output.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:

 - replace use of Optional.isEmpty
 - 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)
   
   Backport-of: 2bbf8a2a964a64d88298a3dd184459af506e58ed
 - 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
   
   Reviewed-by: sgehwolf
   Backport-of: 0054c15f60cce6470be05d29bfacbdb74cfb7bc9

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/159/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=159&range=06
  Stats: 141 lines in 4 files changed: 132 ins; 1 del; 8 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/159.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/159/head:pull/159

PR: https://git.openjdk.org/jdk8u-dev/pull/159

From sgehwolf at openjdk.org  Thu Dec 15 14:39:13 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 15 Dec 2022 14:39:13 GMT
Subject: [jdk8u-dev] RFR: 8245543: Cgroups: Incorrect detection logic on
 some systems (still reproducible) [v7]
In-Reply-To: <OtOi_v65Aa2_RrKZLEb0m0PujNaxUTsdfqjLWIQ-_u0=.09eac9eb-507f-4eef-aa1b-830a2933cf1c@github.com>
References: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
 <OtOi_v65Aa2_RrKZLEb0m0PujNaxUTsdfqjLWIQ-_u0=.09eac9eb-507f-4eef-aa1b-830a2933cf1c@github.com>
Message-ID: <xfI32SxuJpEsHdgk8sdYDUGlnJvwbFCqF4dYpYpOjD4=.7b3217c7-d2d6-4eb8-be54-c394b60a0ca9@github.com>

On Thu, 15 Dec 2022 13:50:53 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> A backport of 8245543 to jdk8u-dev for cgroups v2 support.
>> 
>> Not clean: needed minor adjusting for 8u approach to log output.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - replace use of Optional.isEmpty
>  - 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)
>    
>    Backport-of: 2bbf8a2a964a64d88298a3dd184459af506e58ed
>  - 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
>    
>    Reviewed-by: sgehwolf
>    Backport-of: 0054c15f60cce6470be05d29bfacbdb74cfb7bc9

Looks fine. I've approved the bug as well. Feel free to integrate and then rebase #169. Thank you!

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/159

From jdowland at openjdk.org  Thu Dec 15 15:01:16 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 15 Dec 2022 15:01:16 GMT
Subject: [jdk8u-dev] Integrated: 8245543: Cgroups: Incorrect detection logic on
 some systems (still reproducible)
In-Reply-To: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
References: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
Message-ID: <HzBy5HAufw4PLRUH_4v6jg8n8YF8mesI5b4VKvrnZzA=.13b2b731-15d2-42cc-9c01-8807e4611675@github.com>

On Mon, 7 Nov 2022 10:30:16 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> A backport of 8245543 to jdk8u-dev for cgroups v2 support.
> 
> Not clean: needed minor adjusting for 8u approach to log output.

This pull request has now been integrated.

Changeset: d2df91dc
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/d2df91dc5cbb83052c9e9f1a1460abf1c9900423
Stats:     97 lines in 4 files changed: 91 ins; 1 del; 5 mod

8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)

Reviewed-by: sgehwolf
Backport-of: 2bbf8a2a964a64d88298a3dd184459af506e58ed

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/159

From jdowland at openjdk.org  Thu Dec 15 15:32:11 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 15 Dec 2022 15:32:11 GMT
Subject: [jdk8u-dev] RFR: 8253939: [TESTBUG] Increase coverage of the
 cgroups detection code [v3]
In-Reply-To: <dYPEgmHKhn69tLbt52VLYmJ2ypPf0TQRoaKSS-i7vdM=.df8dd0d3-29cf-45c8-813c-3026ce20c116@github.com>
References: <dYPEgmHKhn69tLbt52VLYmJ2ypPf0TQRoaKSS-i7vdM=.df8dd0d3-29cf-45c8-813c-3026ce20c116@github.com>
Message-ID: <6dkjFhNF2noT-a65ADHz1tswvauruLTbWeZWi_o7NBc=.57e5e9b6-37e5-4efb-ac2f-2a7acd20c026@github.com>

> This is a backport of 8253939  to jdk8u-dev for cgroups v2 support.
> 
> It's not clean: several `Files.writeString` ? `Files.write(?,.getBytes())` changes needed.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8253939: [TESTBUG] Increase coverage of the cgroups detection code
  
  Backport-of: 42fc15899115ca61151bbee96b5580d4e4252beb

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/169/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=169&range=02
  Stats: 147 lines in 2 files changed: 134 ins; 0 del; 13 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/169.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/169/head:pull/169

PR: https://git.openjdk.org/jdk8u-dev/pull/169

From sgehwolf at openjdk.org  Thu Dec 15 17:22:12 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 15 Dec 2022 17:22:12 GMT
Subject: [jdk8u-dev] RFR: 8253939: [TESTBUG] Increase coverage of the
 cgroups detection code [v3]
In-Reply-To: <6dkjFhNF2noT-a65ADHz1tswvauruLTbWeZWi_o7NBc=.57e5e9b6-37e5-4efb-ac2f-2a7acd20c026@github.com>
References: <dYPEgmHKhn69tLbt52VLYmJ2ypPf0TQRoaKSS-i7vdM=.df8dd0d3-29cf-45c8-813c-3026ce20c116@github.com>
 <6dkjFhNF2noT-a65ADHz1tswvauruLTbWeZWi_o7NBc=.57e5e9b6-37e5-4efb-ac2f-2a7acd20c026@github.com>
Message-ID: <3qZ64NP5SE-Km9CuDl9o54IrfI_eK1BIIf_wBtrixYY=.90149172-1629-48e8-afa4-fa287b27a852@github.com>

On Thu, 15 Dec 2022 15:32:11 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8253939  to jdk8u-dev for cgroups v2 support.
>> 
>> It's not clean: several `Files.writeString` ? `Files.write(?,.getBytes())` changes needed.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8253939: [TESTBUG] Increase coverage of the cgroups detection code
>   
>   Backport-of: 42fc15899115ca61151bbee96b5580d4e4252beb

Looks good. I've approved the bug. Feel free to integrate. Please rebase #185 after. Thanks!

Tier 1 GHA test failure on x86 of `gc/6581734/Test6581734.java` seems unrelated.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/169

From jdowland at openjdk.org  Thu Dec 15 18:04:09 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 15 Dec 2022 18:04:09 GMT
Subject: [jdk8u-dev] Integrated: 8253939: [TESTBUG] Increase coverage of the
 cgroups detection code
In-Reply-To: <dYPEgmHKhn69tLbt52VLYmJ2ypPf0TQRoaKSS-i7vdM=.df8dd0d3-29cf-45c8-813c-3026ce20c116@github.com>
References: <dYPEgmHKhn69tLbt52VLYmJ2ypPf0TQRoaKSS-i7vdM=.df8dd0d3-29cf-45c8-813c-3026ce20c116@github.com>
Message-ID: <qLrUEun-6pBrBlmcvyqZBU0aeVjAbVNmXzjOrxA5pSg=.5e5ec0a9-648c-4c96-bb98-d1f47e5cfb5b@github.com>

On Mon, 14 Nov 2022 10:19:29 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8253939  to jdk8u-dev for cgroups v2 support.
> 
> It's not clean: several `Files.writeString` ? `Files.write(?,.getBytes())` changes needed.

This pull request has now been integrated.

Changeset: 4dfc7421
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/4dfc7421e8b934f503837659396e21cb4e29e694
Stats:     147 lines in 2 files changed: 134 ins; 0 del; 13 mod

8253939: [TESTBUG] Increase coverage of the cgroups detection code

Reviewed-by: sgehwolf
Backport-of: 42fc15899115ca61151bbee96b5580d4e4252beb

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/169

From jdowland at openjdk.org  Thu Dec 15 18:07:58 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 15 Dec 2022 18:07:58 GMT
Subject: [jdk8u-dev] RFR: 8253797: [cgroups v2] Account for the fact that
 swap accounting is disabled on some systems [v5]
In-Reply-To: <yV0TTtmloYwEpPcxo1xeYZj-R3vJNJ_M0muQ1T4kthM=.57959f64-9110-49ab-8738-3f4efc8b131d@github.com>
References: <yV0TTtmloYwEpPcxo1xeYZj-R3vJNJ_M0muQ1T4kthM=.57959f64-9110-49ab-8738-3f4efc8b131d@github.com>
Message-ID: <ZXwfTOeIPAKRKKQdPtgtYI37qHHI0BITZS4m5sUulo8=.3d447ccf-afab-4414-a0b3-c16a9d1a179d@github.com>

> This is a clean backport of 8253797 (via 11u) for jdk8u-dev for cgroups v2 support.
> 
> The changed files are exercised by the jtreg test `TestSystemMetrics.java` which passes on my cgroups v2 system.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - 8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems
   
   Backport-of: 669361117d30c9904813b6f728714f8d6abe8484
 - 8253939: [TESTBUG] Increase coverage of the cgroups detection code
   
   Reviewed-by: sgehwolf
   Backport-of: 42fc15899115ca61151bbee96b5580d4e4252beb

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/185/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=185&range=04
  Stats: 192 lines in 4 files changed: 158 ins; 1 del; 33 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/185.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/185/head:pull/185

PR: https://git.openjdk.org/jdk8u-dev/pull/185

From jdowland at openjdk.org  Thu Dec 15 18:26:15 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 15 Dec 2022 18:26:15 GMT
Subject: [jdk8u-dev] Integrated: 8253797: [cgroups v2] Account for the fact
 that swap accounting is disabled on some systems
In-Reply-To: <yV0TTtmloYwEpPcxo1xeYZj-R3vJNJ_M0muQ1T4kthM=.57959f64-9110-49ab-8738-3f4efc8b131d@github.com>
References: <yV0TTtmloYwEpPcxo1xeYZj-R3vJNJ_M0muQ1T4kthM=.57959f64-9110-49ab-8738-3f4efc8b131d@github.com>
Message-ID: <MYpb6vvGjpZINMoEnxDQ7BVdz7u6CtCGG3fStm-kVB4=.83be57a8-65c9-482a-a78a-86e069877711@github.com>

On Fri, 18 Nov 2022 09:56:24 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a clean backport of 8253797 (via 11u) for jdk8u-dev for cgroups v2 support.
> 
> The changed files are exercised by the jtreg test `TestSystemMetrics.java` which passes on my cgroups v2 system.

This pull request has now been integrated.

Changeset: b2619cf5
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/b2619cf5338fcc536aaa161e44f352e3578513ea
Stats:     45 lines in 2 files changed: 24 ins; 1 del; 20 mod

8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems

Backport-of: 669361117d30c9904813b6f728714f8d6abe8484

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/185

From jdowland at openjdk.org  Thu Dec 15 18:26:13 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 15 Dec 2022 18:26:13 GMT
Subject: [jdk8u-dev] RFR: 8253797: [cgroups v2] Account for the fact that
 swap accounting is disabled on some systems [v5]
In-Reply-To: <ZXwfTOeIPAKRKKQdPtgtYI37qHHI0BITZS4m5sUulo8=.3d447ccf-afab-4414-a0b3-c16a9d1a179d@github.com>
References: <yV0TTtmloYwEpPcxo1xeYZj-R3vJNJ_M0muQ1T4kthM=.57959f64-9110-49ab-8738-3f4efc8b131d@github.com>
 <ZXwfTOeIPAKRKKQdPtgtYI37qHHI0BITZS4m5sUulo8=.3d447ccf-afab-4414-a0b3-c16a9d1a179d@github.com>
Message-ID: <zR_tioBG8V_f0LKFbo01QYEVn1fRcOyvAoFLPtyhCrE=.23d13cb3-1a1d-46f0-b5ff-c522a410f9b2@github.com>

On Thu, 15 Dec 2022 18:07:58 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a clean backport of 8253797 (via 11u) for jdk8u-dev for cgroups v2 support.
>> 
>> The changed files are exercised by the jtreg test `TestSystemMetrics.java` which passes on my cgroups v2 system.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - 8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems
>    
>    Backport-of: 669361117d30c9904813b6f728714f8d6abe8484
>  - 8253939: [TESTBUG] Increase coverage of the cgroups detection code
>    
>    Reviewed-by: sgehwolf
>    Backport-of: 42fc15899115ca61151bbee96b5580d4e4252beb

Oddly we got this approved a week ago. I've rebased since, so I've just double-checked that the patch is clean (yes)

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/185

From sgehwolf at openjdk.org  Thu Dec 15 18:48:13 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 15 Dec 2022 18:48:13 GMT
Subject: [jdk8u-dev] RFR: 8254001: [Metrics] Enhance parsing of cgroup
 interface files for version detection [v2]
In-Reply-To: <dv5uWRUvUt8tUL0zGLGz046jwPxm-SJu027eEZzGIgM=.5afdd221-5fa6-4ece-9d6e-ce4dbaade6d5@github.com>
References: <PP2f9scIGys7GxR51PHbTrwzYlW5t1KWdOF8YVMkq3Q=.c1c64001-e51b-427f-b579-564cf00b0b01@github.com>
 <dv5uWRUvUt8tUL0zGLGz046jwPxm-SJu027eEZzGIgM=.5afdd221-5fa6-4ece-9d6e-ce4dbaade6d5@github.com>
Message-ID: <65iANxdmqM6yZoDEU-pfNohgfpt8hAiEleEBNmYi2OM=.b9054639-ec49-4c28-b612-35453f845277@github.com>

On Mon, 12 Dec 2022 09:55:39 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8254001 to jdk8u-dev for cgroups v2 support.
>> 
>> It's not clean: some context issues around import lines and `Files.writeString` replacements.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection
>    
>    Reviewed-by: sgehwolf
>    Backport-of: a50725db2ab621e1a17cb5505f78e4bc73972a27
>  - 8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems
>    
>    Backport-of: 669361117d30c9904813b6f728714f8d6abe8484

@jmtd This one needs a rebase now, please. Thanks!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/170

From jdowland at openjdk.org  Thu Dec 15 19:11:49 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 15 Dec 2022 19:11:49 GMT
Subject: [jdk8u-dev] RFR: 8254001: [Metrics] Enhance parsing of cgroup
 interface files for version detection [v3]
In-Reply-To: <PP2f9scIGys7GxR51PHbTrwzYlW5t1KWdOF8YVMkq3Q=.c1c64001-e51b-427f-b579-564cf00b0b01@github.com>
References: <PP2f9scIGys7GxR51PHbTrwzYlW5t1KWdOF8YVMkq3Q=.c1c64001-e51b-427f-b579-564cf00b0b01@github.com>
Message-ID: <hdptN12sAVe9DTUj6XnI20SVe4zSauIgiFzhUVyd27c=.329b98ba-d2c0-43f6-aab4-bee1e538e68f@github.com>

> This is a backport of 8254001 to jdk8u-dev for cgroups v2 support.
> 
> It's not clean: some context issues around import lines and `Files.writeString` replacements.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8254001: [Metrics] Enhance parsing of cgroup interface files for version detection
  
  Reviewed-by: sgehwolf
  Backport-of: a50725db2ab621e1a17cb5505f78e4bc73972a27

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/170/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=170&range=02
  Stats: 595 lines in 5 files changed: 321 ins; 142 del; 132 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/170.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/170/head:pull/170

PR: https://git.openjdk.org/jdk8u-dev/pull/170

From sgehwolf at openjdk.org  Fri Dec 16 10:00:02 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 16 Dec 2022 10:00:02 GMT
Subject: [jdk8u-dev] RFR: 8254001: [Metrics] Enhance parsing of cgroup
 interface files for version detection [v3]
In-Reply-To: <hdptN12sAVe9DTUj6XnI20SVe4zSauIgiFzhUVyd27c=.329b98ba-d2c0-43f6-aab4-bee1e538e68f@github.com>
References: <PP2f9scIGys7GxR51PHbTrwzYlW5t1KWdOF8YVMkq3Q=.c1c64001-e51b-427f-b579-564cf00b0b01@github.com>
 <hdptN12sAVe9DTUj6XnI20SVe4zSauIgiFzhUVyd27c=.329b98ba-d2c0-43f6-aab4-bee1e538e68f@github.com>
Message-ID: <BXRxruTHjrmpkTj4f3PK18EI5t9V8RoHluPerExoOeA=.ab5af4fd-f41b-4490-a3b8-025cc98828d1@github.com>

On Thu, 15 Dec 2022 19:11:49 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8254001 to jdk8u-dev for cgroups v2 support.
>> 
>> It's not clean: some context issues around import lines and `Files.writeString` replacements.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8254001: [Metrics] Enhance parsing of cgroup interface files for version detection
>   
>   Reviewed-by: sgehwolf
>   Backport-of: a50725db2ab621e1a17cb5505f78e4bc73972a27

OK. The bug is approved. Feel free to integrate and then rebase #171 Thank you.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/170

From jdowland at openjdk.org  Fri Dec 16 10:10:58 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 16 Dec 2022 10:10:58 GMT
Subject: [jdk8u-dev] Integrated: 8254001: [Metrics] Enhance parsing of cgroup
 interface files for version detection
In-Reply-To: <PP2f9scIGys7GxR51PHbTrwzYlW5t1KWdOF8YVMkq3Q=.c1c64001-e51b-427f-b579-564cf00b0b01@github.com>
References: <PP2f9scIGys7GxR51PHbTrwzYlW5t1KWdOF8YVMkq3Q=.c1c64001-e51b-427f-b579-564cf00b0b01@github.com>
Message-ID: <NitQt8Adb3uri1orn0ch9ZHIv2BLFuR1zp1Or9P1GYg=.cb7a7b52-6bc0-4d5c-b749-bb157848bef5@github.com>

On Mon, 14 Nov 2022 10:51:48 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8254001 to jdk8u-dev for cgroups v2 support.
> 
> It's not clean: some context issues around import lines and `Files.writeString` replacements.

This pull request has now been integrated.

Changeset: 1b04ffe9
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/1b04ffe97c7be3bdcd506e1f69c3eaf4fdd029d0
Stats:     595 lines in 5 files changed: 321 ins; 142 del; 132 mod

8254001: [Metrics] Enhance parsing of cgroup interface files for version detection

Reviewed-by: sgehwolf
Backport-of: a50725db2ab621e1a17cb5505f78e4bc73972a27

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/170

From jdowland at openjdk.org  Fri Dec 16 10:22:50 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 16 Dec 2022 10:22:50 GMT
Subject: [jdk8u-dev] RFR: 8262379: Add regression test for JDK-8257746 [v3]
In-Reply-To: <AUjvc6fgHrk80T8rTap5uR-6Sjza_aZFK7vTfzvBMtM=.10ac857e-a29d-46be-952f-bc8100e0dafd@github.com>
References: <AUjvc6fgHrk80T8rTap5uR-6Sjza_aZFK7vTfzvBMtM=.10ac857e-a29d-46be-952f-bc8100e0dafd@github.com>
Message-ID: <pGcNC_BZKewMjlIrAMnffub3D4zsS0rlgt81rUOkzEw=.9ce87862-8de4-451a-8791-df1692f05345@github.com>

> This is a backport of 8262379: Add regression test for JDK-8257746 for jdk8u-dev as part of cgroups v2 support.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8262379: Add regression test for JDK-8257746
  
  Backport-of: 4c9adce20d114a3df629fa8c72d88795039ae69a

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/171/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=171&range=02
  Stats: 55 lines in 1 file changed: 55 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/171.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/171/head:pull/171

PR: https://git.openjdk.org/jdk8u-dev/pull/171

From sgehwolf at openjdk.org  Fri Dec 16 10:44:53 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 16 Dec 2022 10:44:53 GMT
Subject: [jdk8u-dev] RFR: 8262379: Add regression test for JDK-8257746 [v3]
In-Reply-To: <pGcNC_BZKewMjlIrAMnffub3D4zsS0rlgt81rUOkzEw=.9ce87862-8de4-451a-8791-df1692f05345@github.com>
References: <AUjvc6fgHrk80T8rTap5uR-6Sjza_aZFK7vTfzvBMtM=.10ac857e-a29d-46be-952f-bc8100e0dafd@github.com>
 <pGcNC_BZKewMjlIrAMnffub3D4zsS0rlgt81rUOkzEw=.9ce87862-8de4-451a-8791-df1692f05345@github.com>
Message-ID: <7u5mynL0RMWF9Fycpl1JmtmPG9Q7mjnT34l8KzaP5I0=.4a82acb2-6177-4b6f-af4c-51b967fe477b@github.com>

On Fri, 16 Dec 2022 10:22:50 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8262379: Add regression test for JDK-8257746 for jdk8u-dev as part of cgroups v2 support.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8262379: Add regression test for JDK-8257746
>   
>   Backport-of: 4c9adce20d114a3df629fa8c72d88795039ae69a

Good. Feel free to integrate and then rebase #175. Thank you!

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/171

From jdowland at openjdk.org  Fri Dec 16 10:48:01 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 16 Dec 2022 10:48:01 GMT
Subject: [jdk8u-dev] Integrated: 8262379: Add regression test for JDK-8257746
In-Reply-To: <AUjvc6fgHrk80T8rTap5uR-6Sjza_aZFK7vTfzvBMtM=.10ac857e-a29d-46be-952f-bc8100e0dafd@github.com>
References: <AUjvc6fgHrk80T8rTap5uR-6Sjza_aZFK7vTfzvBMtM=.10ac857e-a29d-46be-952f-bc8100e0dafd@github.com>
Message-ID: <0hrturEbiBsUtLLZNrSkCa6iXeE7yvI8TJRlix8eBfw=.a1c4c751-80ed-4def-8bb3-d0e37292b015@github.com>

On Mon, 14 Nov 2022 11:26:26 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8262379: Add regression test for JDK-8257746 for jdk8u-dev as part of cgroups v2 support.

This pull request has now been integrated.

Changeset: d7b14be2
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/d7b14be2b944d528679cdc447357dfda82fe3238
Stats:     55 lines in 1 file changed: 55 ins; 0 del; 0 mod

8262379: Add regression test for JDK-8257746

Reviewed-by: sgehwolf
Backport-of: 4c9adce20d114a3df629fa8c72d88795039ae69a

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/171

From jdowland at openjdk.org  Fri Dec 16 10:53:45 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 16 Dec 2022 10:53:45 GMT
Subject: [jdk8u-dev] RFR: 8291570: [TESTBUG] Part of JDK-8250984 absent
 from 11u [v3]
In-Reply-To: <37RigSmjiXfQ216QBRI2ew1ln2GVMWFa3q0Da3RTVC8=.90472b38-3ea7-481e-add1-f9a607dfc203@github.com>
References: <37RigSmjiXfQ216QBRI2ew1ln2GVMWFa3q0Da3RTVC8=.90472b38-3ea7-481e-add1-f9a607dfc203@github.com>
Message-ID: <_D3NW0xownlfEgGddnNPIjSzg6_6SPigeEGGsggMRI4=.0aeb148f-146e-4c6f-a5d6-0c2741cde48d@github.com>

> This is a clean backport of 8291570 (from jdk11u) as part of cgroups v2 support.
> 
> The affected test passes for me after the patch.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8291570: [TESTBUG] Part of JDK-8250984 absent from 11u
  
  Reviewed-by: serb, sgehwolf

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/175/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=175&range=02
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/175.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/175/head:pull/175

PR: https://git.openjdk.org/jdk8u-dev/pull/175

From sgehwolf at openjdk.org  Fri Dec 16 11:03:02 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 16 Dec 2022 11:03:02 GMT
Subject: [jdk8u-dev] RFR: 8252957: Wrong comment in
 CgroupV1Subsystem::cpu_quota [v2]
In-Reply-To: <sebDGE-MSkUUnokK74oodgtk93W06cjTK31543gUYYg=.1ebee7f3-3cc4-4074-a7bb-ee956f4ba05c@github.com>
References: <HMBOxy7GXn7eWD1jZOra2oSlYzKQkl8HR0I3-M16egk=.1bccef4a-4aa4-4a44-b0af-e439dafab265@github.com>
 <sebDGE-MSkUUnokK74oodgtk93W06cjTK31543gUYYg=.1ebee7f3-3cc4-4074-a7bb-ee956f4ba05c@github.com>
Message-ID: <VaikLL25dom0Tmfu9hxK8odMjgPpBpIB4t1LRvOC_1Y=.8a2589fa-42a4-4fa2-88d4-ce925a912c84@github.com>

On Mon, 12 Dec 2022 10:02:10 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> Simple, comment-only backport for cgroups v2 support in jdk8u. Clean.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

@jmtd Please rebase this patch next once #175 is integrated. Thanks!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/176

From jdowland at openjdk.org  Fri Dec 16 11:37:55 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 16 Dec 2022 11:37:55 GMT
Subject: [jdk8u-dev] Integrated: 8291570: [TESTBUG] Part of JDK-8250984 absent
 from 11u
In-Reply-To: <37RigSmjiXfQ216QBRI2ew1ln2GVMWFa3q0Da3RTVC8=.90472b38-3ea7-481e-add1-f9a607dfc203@github.com>
References: <37RigSmjiXfQ216QBRI2ew1ln2GVMWFa3q0Da3RTVC8=.90472b38-3ea7-481e-add1-f9a607dfc203@github.com>
Message-ID: <Hyb_bCLtPiTs-fI6vJ-8c3isqbMdbOXbutRg8wMOlXQ=.acedf6f8-2a38-4d9e-99b6-6fb6504cd157@github.com>

On Tue, 15 Nov 2022 10:08:51 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a clean backport of 8291570 (from jdk11u) as part of cgroups v2 support.
> 
> The affected test passes for me after the patch.

This pull request has now been integrated.

Changeset: d039c8de
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/d039c8de57bc9ed2263538189547082aee05e599
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8291570: [TESTBUG] Part of JDK-8250984 absent from 11u

Reviewed-by: andrew
Backport-of: 2f0f34ce4cbe0f51a1bcc3145eb4d7ade9287d5d

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/175

From jdowland at openjdk.org  Fri Dec 16 11:43:32 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 16 Dec 2022 11:43:32 GMT
Subject: [jdk8u-dev] RFR: 8252957: Wrong comment in
 CgroupV1Subsystem::cpu_quota [v3]
In-Reply-To: <HMBOxy7GXn7eWD1jZOra2oSlYzKQkl8HR0I3-M16egk=.1bccef4a-4aa4-4a44-b0af-e439dafab265@github.com>
References: <HMBOxy7GXn7eWD1jZOra2oSlYzKQkl8HR0I3-M16egk=.1bccef4a-4aa4-4a44-b0af-e439dafab265@github.com>
Message-ID: <HQXETp3A12Kif42oeFiMZtFw4M4Bj5sVXesEC2QueQ8=.76e1b897-d55c-4238-931a-c5c9779e0493@github.com>

> Simple, comment-only backport for cgroups v2 support in jdk8u. Clean.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8252957: Wrong comment in CgroupV1Subsystem::cpu_quota
  
  The comment is wrong. The 'us' in 'cpu.cfs_quota_us' stands for
  microseconds, which is read verbatim. Similarly for cgroups v2
  all units in 'cpu.max' are in microseconds.
  
  Backport-of: 5166094647f8bfae32ef4bbde2e40f68e073b595

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/176/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=176&range=02
  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/176.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/176/head:pull/176

PR: https://git.openjdk.org/jdk8u-dev/pull/176

From andrew at openjdk.org  Fri Dec 16 12:38:05 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 16 Dec 2022 12:38:05 GMT
Subject: [jdk8u-dev] RFR: 8254717: isAssignableFrom checks in
 KeyFactorySpi.engineGetKeySpec appear to be backwards
In-Reply-To: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>
References: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>
Message-ID: <YSreBcKAS9gqlKWJh001yih6lg5caDBeyEQ7YLBPWdw=.43130e88-54c8-4c19-8425-c0cd0c59b386@github.com>

On Wed, 14 Dec 2022 19:58:48 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> Backport for Oracle parity from 11u is not clean.
> 
> 1.  Copyright date mismatch in P11SecretKeyFactory.java.
> 2. XDHKeyFactory.java does not exist in 8u.
> 3. In KeyFactoryGetKeySpecForInvalidSpec.java, class FakeX509Spec does not include a (byte[], String) constructor since in 8u, X509EncodedKeySpec does not.

Ok, if you want to add `jdk8u-fix-request` to the bug, I'll approve :)

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/211

From duke at openjdk.org  Fri Dec 16 12:51:52 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Fri, 16 Dec 2022 12:51:52 GMT
Subject: [jdk8u-dev] RFR: 8297996: [8u] generated images are broken due to
 renaming of MSVC runtime DLL's [v2]
In-Reply-To: <kmwMHa8T0-HNk_CFFZYvHI4qmwGjmgs1Xt9Vqj4VSi4=.11941c4f-b7c3-431c-ad70-02c10f8e6134@github.com>
References: <rBE3rNSo7kYwJuUUbJ-CPDin9z8f0urlq3SOHvG09PA=.c902b393-e0f7-4e77-8163-8dd0ce54ea52@github.com>
 <kmwMHa8T0-HNk_CFFZYvHI4qmwGjmgs1Xt9Vqj4VSi4=.11941c4f-b7c3-431c-ad70-02c10f8e6134@github.com>
Message-ID: <GDqjrpyeFYmvG_O5Y4_s_Bokf6A4sAO61BOsU5IzPtU=.9c6d7f25-e7f7-498f-98d1-f9d00e118a33@github.com>

On Mon, 5 Dec 2022 08:42:33 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

>> Hi!
>> 
>> The patch fixes Windows image generation with proper VC runtime DLL names. The problem is that MSVS2019 uses two DLL's `vcruntime140.dll` and `vcruntime140_1.dll` and their names conflict under 8.3 limitation. For this reason the [BASIC_MAKE_WINDOWS_SPACE_SAFE_CYGWIN](https://github.com/openjdk/jdk8u-dev/blob/c9007cd44db764fbd791218c6f38491f38af70c2/common/autoconf/basics_windows.m4#L53) renames DLL's to
>
> Alexey Pavlyutkin has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge branch '8297996' of https://github.com/apavlyutkin/jdk8u-dev into 8297996
>  - forcing pre-sumbit test

Guys, sorry to trouble you, but Windows images are still broken for 8u-dev. Please review the fix

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/203

From sgehwolf at openjdk.org  Fri Dec 16 13:18:56 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 16 Dec 2022 13:18:56 GMT
Subject: [jdk8u-dev] RFR: 8266391: Replace use of reflection in
 jdk.internal.platform.Metrics [v2]
In-Reply-To: <k2EWx15uzhpGQWYRzB_XmiMBH4a5paKeFt7HzEO3hws=.f6473142-56b6-4653-91a3-3534238079e9@github.com>
References: <g7RG2DZHfz5Fo7fxo56Q4FIsUdQlABEvbthK8k3xOwU=.74f82cd8-e4eb-4db1-a5c8-eb2a1a19d391@github.com>
 <k2EWx15uzhpGQWYRzB_XmiMBH4a5paKeFt7HzEO3hws=.f6473142-56b6-4653-91a3-3534238079e9@github.com>
Message-ID: <xDYtmeFaKDfDsZ4ChKKMmvzdAWKt8DekLilYPiPGdX0=.e0fca0b5-9f5c-46af-abfc-922c66c8a3c7@github.com>

On Wed, 16 Nov 2022 14:51:31 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> A clean backport of 8266391 for jdk8u-dev as part of cgroups v2 support.
>
> Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add a macosx platform specific SystemMetrics class

@jmtd Please rebase once #176 is integrated. Thanks.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/177

From phh at openjdk.org  Fri Dec 16 13:28:52 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 16 Dec 2022 13:28:52 GMT
Subject: [jdk8u-dev] RFR: 8254717: isAssignableFrom checks in
 KeyFactorySpi.engineGetKeySpec appear to be backwards
In-Reply-To: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>
References: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>
Message-ID: <H3cqsuz5uXMreDIJZ0Z1q0dxN7sDhDUjXxbyCedfr1k=.16867443-3497-4e98-aaeb-76ee390d0315@github.com>

On Wed, 14 Dec 2022 19:58:48 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> Backport for Oracle parity from 11u is not clean.
> 
> 1.  Copyright date mismatch in P11SecretKeyFactory.java.
> 2. XDHKeyFactory.java does not exist in 8u.
> 3. In KeyFactoryGetKeySpecForInvalidSpec.java, class FakeX509Spec does not include a (byte[], String) constructor since in 8u, X509EncodedKeySpec does not.

Done. I'd been waiting until I had time for [JDK-8263404](https://bugs.openjdk.org/browse/JDK-8263404), which latter I'm testing now.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/211

From jdowland at openjdk.org  Fri Dec 16 14:33:54 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 16 Dec 2022 14:33:54 GMT
Subject: [jdk8u-dev] Integrated: 8252957: Wrong comment in
 CgroupV1Subsystem::cpu_quota
In-Reply-To: <HMBOxy7GXn7eWD1jZOra2oSlYzKQkl8HR0I3-M16egk=.1bccef4a-4aa4-4a44-b0af-e439dafab265@github.com>
References: <HMBOxy7GXn7eWD1jZOra2oSlYzKQkl8HR0I3-M16egk=.1bccef4a-4aa4-4a44-b0af-e439dafab265@github.com>
Message-ID: <PDplvyILrNlnXbQRldH_ApKsVG3AYZXoYoCuUkytahU=.ac7c327b-dc92-4a33-9d93-0dcc9d1d1dae@github.com>

On Wed, 16 Nov 2022 10:39:05 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> Simple, comment-only backport for cgroups v2 support in jdk8u. Clean.

This pull request has now been integrated.

Changeset: 0662db27
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/0662db27bf72d15b2fdd7ed21ea675d40531aef5
Stats:     4 lines in 2 files changed: 0 ins; 0 del; 4 mod

8252957: Wrong comment in CgroupV1Subsystem::cpu_quota

The comment is wrong. The 'us' in 'cpu.cfs_quota_us' stands for
microseconds, which is read verbatim. Similarly for cgroups v2
all units in 'cpu.max' are in microseconds.

Backport-of: 5166094647f8bfae32ef4bbde2e40f68e073b595

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/176

From jdowland at openjdk.org  Fri Dec 16 14:39:43 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 16 Dec 2022 14:39:43 GMT
Subject: [jdk8u-dev] RFR: 8266391: Replace use of reflection in
 jdk.internal.platform.Metrics [v3]
In-Reply-To: <g7RG2DZHfz5Fo7fxo56Q4FIsUdQlABEvbthK8k3xOwU=.74f82cd8-e4eb-4db1-a5c8-eb2a1a19d391@github.com>
References: <g7RG2DZHfz5Fo7fxo56Q4FIsUdQlABEvbthK8k3xOwU=.74f82cd8-e4eb-4db1-a5c8-eb2a1a19d391@github.com>
Message-ID: <CxlzBDIBNAYrg871WM1O2vCvjxF_AF65GB5Fe6nylJk=.e56e754e-aa82-475f-9baf-2f3450f7da85@github.com>

> A clean backport of 8266391 for jdk8u-dev as part of cgroups v2 support.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - Add a macosx platform specific SystemMetrics class
 - 8266391: Replace use of reflection in jdk.internal.platform.Metrics
   
   Backport-of: 3544a9d0e4a071ad9c82aa17ab113e0101b4020b

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/177/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=177&range=02
  Stats: 134 lines in 5 files changed: 124 ins; 8 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/177.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/177/head:pull/177

PR: https://git.openjdk.org/jdk8u-dev/pull/177

From sgehwolf at openjdk.org  Fri Dec 16 15:19:55 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 16 Dec 2022 15:19:55 GMT
Subject: [jdk8u-dev] RFR: 8266391: Replace use of reflection in
 jdk.internal.platform.Metrics [v3]
In-Reply-To: <CxlzBDIBNAYrg871WM1O2vCvjxF_AF65GB5Fe6nylJk=.e56e754e-aa82-475f-9baf-2f3450f7da85@github.com>
References: <g7RG2DZHfz5Fo7fxo56Q4FIsUdQlABEvbthK8k3xOwU=.74f82cd8-e4eb-4db1-a5c8-eb2a1a19d391@github.com>
 <CxlzBDIBNAYrg871WM1O2vCvjxF_AF65GB5Fe6nylJk=.e56e754e-aa82-475f-9baf-2f3450f7da85@github.com>
Message-ID: <zxdeaM_z-8Ofmhl-dkMmQfcQ1Nri3xSOkR0Y2I4LTSc=.c3803cff-ce02-4abd-af2f-d5141e8030a3@github.com>

On Fri, 16 Dec 2022 14:39:43 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> A clean backport of 8266391 for jdk8u-dev as part of cgroups v2 support.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Add a macosx platform specific SystemMetrics class
>  - 8266391: Replace use of reflection in jdk.internal.platform.Metrics
>    
>    Backport-of: 3544a9d0e4a071ad9c82aa17ab113e0101b4020b

Looks good. Bug is approved. Feel free to integrate. After, please rebase #178 Thanks!

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/177

From jdowland at openjdk.org  Fri Dec 16 17:01:04 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 16 Dec 2022 17:01:04 GMT
Subject: [jdk8u-dev] Integrated: 8266391: Replace use of reflection in
 jdk.internal.platform.Metrics
In-Reply-To: <g7RG2DZHfz5Fo7fxo56Q4FIsUdQlABEvbthK8k3xOwU=.74f82cd8-e4eb-4db1-a5c8-eb2a1a19d391@github.com>
References: <g7RG2DZHfz5Fo7fxo56Q4FIsUdQlABEvbthK8k3xOwU=.74f82cd8-e4eb-4db1-a5c8-eb2a1a19d391@github.com>
Message-ID: <4Ncm-XXbBQ9dDbqIHnAUidsV4z68iQdFks2BsRybS9U=.c45050b3-94cc-4e44-b982-39fc6c99ca72@github.com>

On Wed, 16 Nov 2022 10:47:37 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> A clean backport of 8266391 for jdk8u-dev as part of cgroups v2 support.

This pull request has now been integrated.

Changeset: 99ff02e4
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/99ff02e404778c69cc7c6d3bd532c0326202d91f
Stats:     134 lines in 5 files changed: 124 ins; 8 del; 2 mod

8266391: Replace use of reflection in jdk.internal.platform.Metrics

Reviewed-by: sgehwolf
Backport-of: 3544a9d0e4a071ad9c82aa17ab113e0101b4020b

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/177

From vtewari at openjdk.org  Fri Dec 16 17:46:55 2022
From: vtewari at openjdk.org (Vyom Tewari)
Date: Fri, 16 Dec 2022 17:46:55 GMT
Subject: [jdk8u-dev] RFR: 8234484: Add ability to configure third port for
 remote JMX
Message-ID: <XOxX88FMmRCGDO2mJAojQnQixRGQPBB1jDHqRA0nG_8=.b86bb88e-2e37-468a-8c0e-23ceefb9a9c8@github.com>

Reviewed-by: ksrini
Backport-of: f129cc43283a18cb5afdd1416b09691a636a7758

-------------

Commit messages:
 - 8263231: Add ability to configure third port for remote JMX

Changes: https://git.openjdk.org/jdk8u-dev/pull/213/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=213&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8234484
  Stats: 35 lines in 3 files changed: 30 ins; 2 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/213.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/213/head:pull/213

PR: https://git.openjdk.org/jdk8u-dev/pull/213

From vtewari at openjdk.org  Fri Dec 16 17:53:52 2022
From: vtewari at openjdk.org (Vyom Tewari)
Date: Fri, 16 Dec 2022 17:53:52 GMT
Subject: [jdk8u-dev] RFR: 8234484: Add ability to configure third port for
 remote JMX
In-Reply-To: <XOxX88FMmRCGDO2mJAojQnQixRGQPBB1jDHqRA0nG_8=.b86bb88e-2e37-468a-8c0e-23ceefb9a9c8@github.com>
References: <XOxX88FMmRCGDO2mJAojQnQixRGQPBB1jDHqRA0nG_8=.b86bb88e-2e37-468a-8c0e-23ceefb9a9c8@github.com>
Message-ID: <NtxSXgFx_bNd65AoUuhJSbiuW0kAfTGvMC0RPxN8fLo=.fbe2e804-85c9-4889-b346-27f57a6b18d9@github.com>

On Fri, 16 Dec 2022 17:39:35 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:

> Reviewed-by: ksrini
> Backport-of: f129cc43283a18cb5afdd1416b09691a636a7758

I tested locally on Linux/Windows Tier1 & Tier2 and all test pass.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/213

From ksrini at openjdk.org  Fri Dec 16 17:58:52 2022
From: ksrini at openjdk.org (Kumar Srinivasan)
Date: Fri, 16 Dec 2022 17:58:52 GMT
Subject: [jdk8u-dev] RFR: 8234484: Add ability to configure third port for
 remote JMX
In-Reply-To: <XOxX88FMmRCGDO2mJAojQnQixRGQPBB1jDHqRA0nG_8=.b86bb88e-2e37-468a-8c0e-23ceefb9a9c8@github.com>
References: <XOxX88FMmRCGDO2mJAojQnQixRGQPBB1jDHqRA0nG_8=.b86bb88e-2e37-468a-8c0e-23ceefb9a9c8@github.com>
Message-ID: <sWzgYok6Qz1kIdAZa7lthmO6BtO-xltdK3ndoqDAXAY=.53b68e9b-3921-40c9-b12f-cd1946132e7b@github.com>

On Fri, 16 Dec 2022 17:39:35 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:

> Reviewed-by: ksrini
> Backport-of: f129cc43283a18cb5afdd1416b09691a636a7758

Looks good the backport is identical except for the jdk8 layout differences.

-------------

Marked as reviewed by ksrini (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/213

From phh at openjdk.org  Fri Dec 16 19:11:39 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 16 Dec 2022 19:11:39 GMT
Subject: [jdk8u-dev] RFR: 8263404: RsaPrivateKeySpec is always recognized as
 RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec
Message-ID: <kMA-NFXukvyo3VBzyAlUsc3vidEmVBCHyoszZQLRVNs=.bfaf790a-619a-4bbf-9845-e212029d8723@github.com>

Backport for Oracle parity from 11u is almost clean.

1. PKCS11Test.java	is unchanged because 8u does not throw a RuntimeException for an unknown command.
2. In TestP11KeyFactoryGetRSAKeySpec.java, /test/lib is unneeded in the @library comment, and the @module comment was deleted.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/211

Commit messages:
 - Backport a5d7de235101696463dba22792703c6809ff7fc4

Changes: https://git.openjdk.org/jdk8u-dev/pull/214/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=214&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8263404
  Stats: 309 lines in 5 files changed: 252 ins; 24 del; 33 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/214.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/214/head:pull/214

PR: https://git.openjdk.org/jdk8u-dev/pull/214

From phh at openjdk.org  Fri Dec 16 19:17:01 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 16 Dec 2022 19:17:01 GMT
Subject: [jdk8u-dev] RFR: 8254717: isAssignableFrom checks in
 KeyFactorySpi.engineGetKeySpec appear to be backwards
In-Reply-To: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>
References: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>
Message-ID: <cK6jUJ7-vT-mJIQyuXQuBVDrq03KQ_fkhwwyTwg35OA=.a3c659b4-6a58-47b7-8477-b8dfb6cf4843@github.com>

On Wed, 14 Dec 2022 19:58:48 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> Backport for Oracle parity from 11u is not clean.
> 
> 1.  Copyright date mismatch in P11SecretKeyFactory.java.
> 2. XDHKeyFactory.java does not exist in 8u.
> 3. In KeyFactoryGetKeySpecForInvalidSpec.java, class FakeX509Spec does not include a (byte[], String) constructor since in 8u, X509EncodedKeySpec does not.

Posted https://github.com/openjdk/jdk8u-dev/pull/214.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/211

From jdowland at openjdk.org  Fri Dec 16 19:55:51 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 16 Dec 2022 19:55:51 GMT
Subject: [jdk8u-dev] RFR: 8284756: [11u] Remove unused
 isUseContainerSupport in CgroupV1Subsystem [v3]
In-Reply-To: <CSeL_FK3dHwojSZ7B6LFKMd4QYJzTVhHbyXrQ_vzJ8M=.09f25f84-d591-47aa-9665-9798dfe188c2@github.com>
References: <CSeL_FK3dHwojSZ7B6LFKMd4QYJzTVhHbyXrQ_vzJ8M=.09f25f84-d591-47aa-9665-9798dfe188c2@github.com>
Message-ID: <18mSwS-xotXof-DXRRoXm6jLg3Ui2OrXxi8kltac4Eg=.0537aeb3-d349-4767-b406-fe75fc4a09e9@github.com>

> Clean simple backport of 8284756 for jdk8u-dev cgroups v2 support.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/178/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=178&range=02
  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/178.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/178/head:pull/178

PR: https://git.openjdk.org/jdk8u-dev/pull/178

From andrew at openjdk.org  Sat Dec 17 21:46:56 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Sat, 17 Dec 2022 21:46:56 GMT
Subject: [jdk8u-dev] RFR: 8254717: isAssignableFrom checks in
 KeyFactorySpi.engineGetKeySpec appear to be backwards
In-Reply-To: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>
References: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>
Message-ID: <dvflRy16pUD7n2Kfq-cHvSFwX1Lg78aQJIU2QxfcSA0=.55132b5d-821f-4593-9809-9c2b50127789@github.com>

On Wed, 14 Dec 2022 19:58:48 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> Backport for Oracle parity from 11u is not clean.
> 
> 1.  Copyright date mismatch in P11SecretKeyFactory.java.
> 2. XDHKeyFactory.java does not exist in 8u.
> 3. In KeyFactoryGetKeySpecForInvalidSpec.java, class FakeX509Spec does not include a (byte[], String) constructor since in 8u, X509EncodedKeySpec does not.

Ok, if you want to add `jdk8u-fix-request` to the bug, I'll approve :)

> Done. I'd been waiting until I had time for [JDK-8263404](https://bugs.openjdk.org/browse/JDK-8263404), which latter I'm testing now.

No problem, just wanted to make sure you weren't waiting on me or anything. I've approved it now.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/211

From serb at openjdk.org  Sun Dec 18 11:13:51 2022
From: serb at openjdk.org (Sergey Bylokhov)
Date: Sun, 18 Dec 2022 11:13:51 GMT
Subject: [jdk8u-dev] RFR: 8203485: [freetype] text rotated on 180 degrees
 is too narrow
In-Reply-To: <WgzwC60cw67VGBhsC2tChjNYVrek47jdHypXl386Gv0=.4c5b41e0-0dbb-4674-aab8-a728b3df20d4@github.com>
References: <2tCemlFksSCt1w0KKdB2YwnPbun9-i-kRRzaNjT02s0=.08ac882a-833e-4293-89dd-6aa568fd28cf@github.com>
 <qW6PMXQNG8ZRFihxNOIAxw3EyarTWLtWhvqfeY4j_U4=.ca602e1e-9325-45da-8aec-a078d2fbd65b@github.com>
 <WgzwC60cw67VGBhsC2tChjNYVrek47jdHypXl386Gv0=.4c5b41e0-0dbb-4674-aab8-a728b3df20d4@github.com>
Message-ID: <6o2SFvUu3zwbDlx0vXJY_D_IEUBpYewdgQOs_JxVU-Q=.48a343f1-02ff-4a5f-a701-4098c326a5f9@github.com>

On Tue, 13 Dec 2022 00:42:31 GMT, Leslie Zhai <lzhai at openjdk.org> wrote:

> Do I need to trigger another Pre-submit tests or jtreg tier>3?

No, I'll run them separately.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/208

From phh at openjdk.org  Sun Dec 18 16:47:04 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Sun, 18 Dec 2022 16:47:04 GMT
Subject: [jdk8u-dev] RFR: 8254717: isAssignableFrom checks in
 KeyFactorySpi.engineGetKeySpec appear to be backwards
In-Reply-To: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>
References: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>
Message-ID: <OLUNFaD82WbV1tXBpGIzPu5_PChIrPTlX_jdOT0pRn0=.591a12c1-41cd-408d-91a6-d8fae6c62311@github.com>

On Wed, 14 Dec 2022 19:58:48 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> Backport for Oracle parity from 11u is not clean.
> 
> 1.  Copyright date mismatch in P11SecretKeyFactory.java.
> 2. XDHKeyFactory.java does not exist in 8u.
> 3. In KeyFactoryGetKeySpecForInvalidSpec.java, class FakeX509Spec does not include a (byte[], String) constructor since in 8u, X509EncodedKeySpec does not.

Posted https://github.com/openjdk/jdk8u-dev/pull/214.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/211

From phh at openjdk.org  Sun Dec 18 16:47:05 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Sun, 18 Dec 2022 16:47:05 GMT
Subject: [jdk8u-dev] Integrated: 8254717: isAssignableFrom checks in
 KeyFactorySpi.engineGetKeySpec appear to be backwards
In-Reply-To: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>
References: <odHeMtxyXqDqIRDfiDN1GLUkmk1mBwTzvHuETlXeFik=.04d447eb-dc97-475b-8f12-445fdae80aec@github.com>
Message-ID: <iA4Eg3h67AUt8KMMLzVI69n4d5vz42XDiynx6ZKT624=.3bb9636f-2f3f-4415-bb7c-6bb5c2339b77@github.com>

On Wed, 14 Dec 2022 19:58:48 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> Backport for Oracle parity from 11u is not clean.
> 
> 1.  Copyright date mismatch in P11SecretKeyFactory.java.
> 2. XDHKeyFactory.java does not exist in 8u.
> 3. In KeyFactoryGetKeySpecForInvalidSpec.java, class FakeX509Spec does not include a (byte[], String) constructor since in 8u, X509EncodedKeySpec does not.

This pull request has now been integrated.

Changeset: d6101df2
Author:    Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/d6101df29c7069326d26628f131f0ef8882ad68b
Stats:     129 lines in 15 files changed: 75 ins; 3 del; 51 mod

8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards

Reviewed-by: andrew
Backport-of: a777e82cd81fb5f02b09c4917b2a44f94c603939

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/211

From phh at openjdk.org  Sun Dec 18 16:51:13 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Sun, 18 Dec 2022 16:51:13 GMT
Subject: [jdk8u-dev] RFR: 8263404: RsaPrivateKeySpec is always recognized
 as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec [v2]
In-Reply-To: <kMA-NFXukvyo3VBzyAlUsc3vidEmVBCHyoszZQLRVNs=.bfaf790a-619a-4bbf-9845-e212029d8723@github.com>
References: <kMA-NFXukvyo3VBzyAlUsc3vidEmVBCHyoszZQLRVNs=.bfaf790a-619a-4bbf-9845-e212029d8723@github.com>
Message-ID: <FvKx5PDENDh2QFiuhphxS6Z0qJOA9n0C5asjjVNdanM=.4bb26f0a-e153-491a-bc7b-c448e04dd364@github.com>

> Backport for Oracle parity from 11u is almost clean.
> 
> 1. PKCS11Test.java	is unchanged because 8u does not throw a RuntimeException for an unknown command.
> 2. In TestP11KeyFactoryGetRSAKeySpec.java, /test/lib is unneeded in the @library comment, and the @module comment was deleted.

Paul Hohensee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/214/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/214/files/c5b08d4f..c5b08d4f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=214&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=214&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/214.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/214/head:pull/214

PR: https://git.openjdk.org/jdk8u-dev/pull/214

From kusrinivasan at vmware.com  Sun Dec 18 18:55:09 2022
From: kusrinivasan at vmware.com (Kumar Srinivasan)
Date: Sun, 18 Dec 2022 18:55:09 +0000
Subject: Please approve: JDK-8234484 back-port to jdk8u
Message-ID: <IA1PR05MB89714554CF8BBB36642947C4B5E49@IA1PR05MB8971.namprd05.prod.outlook.com>

Hi jdk8 approvers,

Can someone please approve the back-port of JDK-8234484 ? a CSR has been obtained for the back-port.

The fix has been in jdk15+ for some time now and has been reasonably  soaked for 2 years.

Given the Freeze date for 8u362-b09 is Dec 23rd, it would be preferable to get this in earlier than
later, ie. well before the holidays and shutdown.


Thanks
Kumar Srinivasan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20221218/f1085fc4/attachment.htm>

From kusrinivasan at vmware.com  Sun Dec 18 18:56:02 2022
From: kusrinivasan at vmware.com (Kumar Srinivasan)
Date: Sun, 18 Dec 2022 18:56:02 +0000
Subject: Please approve: JDK-8234484 back-port to jdk8u
In-Reply-To: <IA1PR05MB89714554CF8BBB36642947C4B5E49@IA1PR05MB8971.namprd05.prod.outlook.com>
References: <IA1PR05MB89714554CF8BBB36642947C4B5E49@IA1PR05MB8971.namprd05.prod.outlook.com>
Message-ID: <IA1PR05MB89718CA9219DE7C4DBACA72FB5E49@IA1PR05MB8971.namprd05.prod.outlook.com>

+ added Vyom Tewari who did the heavy lifting.

From: Kumar Srinivasan <kusrinivasan at vmware.com>
Date: Sunday, December 18, 2022 at 10:55 AM
To: jdk8u-dev at openjdk.org <jdk8u-dev at openjdk.org>, jdk-updates-dev at openjdk.org <jdk-updates-dev at openjdk.org>
Subject: Please approve: JDK-8234484 back-port to jdk8u
Hi jdk8 approvers,

Can someone please approve the back-port of JDK-8234484 ? a CSR has been obtained for the back-port.

The fix has been in jdk15+ for some time now and has been reasonably  soaked for 2 years.

Given the Freeze date for 8u362-b09 is Dec 23rd, it would be preferable to get this in earlier than
later, ie. well before the holidays and shutdown.


Thanks
Kumar Srinivasan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20221218/ac1555e1/attachment-0001.htm>

From duke at openjdk.org  Mon Dec 19 01:41:33 2022
From: duke at openjdk.org (ktakakuri)
Date: Mon, 19 Dec 2022 01:41:33 GMT
Subject: [jdk8u-dev] RFR: 8074883: Tab key should move to focused button in a
 button group
Message-ID: <gnhicSYWG9jUWfseV-S6QgNfUZ_QPWP_AjR_qRb9ous=.f78604d4-9e95-48ff-a205-67cc74a623a9@github.com>

This is a backport of JDK-8074883: Tab key should move to focused button in a button group.

I would like to backport the patch to OpenJDK8u.
Original patch does not apply cleanly to 8u, because the fix uses a new API published in JDK9.

* Since RequestFocusController only determines whether or not to set focus, I modified it so that requestFocus/requestFocusInWindow is called by SwingUtilities.invokeLater() and re-set focus and return false.
Without invokeLater(), the focus returns to the first button in case of Cause.ACTIVATION.

* ToggleButton.getGroupSelection() is defined as a package private method, because it must be called by JCompoennt.focusController.

* Calling requestFocus()/requestFocusInWindow() will be processed as Cause.UNKNOWN.
ToggleButton.getGroupSelection() returns itself, so no circular call occurs.

* I moved Component.requestFocusController.acceptRequestFocus because RequestFocusContoroller is not called when Cause.ACTIVATION.

* Only Swing components replace default RequestFocusController to JComponent.focusController.
The focusController returns true except for Swing, so this change does not affect other components.

Testing:
 build on Windows x86_64
 java/awt, javax/swing and ButtonGroupFocusTest.java on Windows x86_64

-------------

Commit messages:
 - Merge branch 'openjdk:master' into 8074883
 - Merge branch 'openjdk:master' into 8074883
 - Backport eef0714323de

Changes: https://git.openjdk.org/jdk8u-dev/pull/212/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=212&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8074883
  Stats: 190 lines in 4 files changed: 181 ins; 9 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/212.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/212/head:pull/212

PR: https://git.openjdk.org/jdk8u-dev/pull/212

From sgehwolf at openjdk.org  Mon Dec 19 09:18:01 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 19 Dec 2022 09:18:01 GMT
Subject: [jdk8u-dev] RFR: 8284756: [11u] Remove unused
 isUseContainerSupport in CgroupV1Subsystem [v3]
In-Reply-To: <18mSwS-xotXof-DXRRoXm6jLg3Ui2OrXxi8kltac4Eg=.0537aeb3-d349-4767-b406-fe75fc4a09e9@github.com>
References: <CSeL_FK3dHwojSZ7B6LFKMd4QYJzTVhHbyXrQ_vzJ8M=.09f25f84-d591-47aa-9665-9798dfe188c2@github.com>
 <18mSwS-xotXof-DXRRoXm6jLg3Ui2OrXxi8kltac4Eg=.0537aeb3-d349-4767-b406-fe75fc4a09e9@github.com>
Message-ID: <QXXSutAf9mafneHgQkqQ1kKeC8bh-V6aK5TPGP5ap54=.5917c848-5967-4b88-ad8b-f27d7614fd77@github.com>

On Fri, 16 Dec 2022 19:55:51 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> Clean simple backport of 8284756 for jdk8u-dev cgroups v2 support.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem

@jmtd Approved for integration. Please do so and then rebase #179. Thanks!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/178

From jdowland at openjdk.org  Mon Dec 19 09:24:06 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 19 Dec 2022 09:24:06 GMT
Subject: [jdk8u-dev] Integrated: 8284756: [11u] Remove unused
 isUseContainerSupport in CgroupV1Subsystem
In-Reply-To: <CSeL_FK3dHwojSZ7B6LFKMd4QYJzTVhHbyXrQ_vzJ8M=.09f25f84-d591-47aa-9665-9798dfe188c2@github.com>
References: <CSeL_FK3dHwojSZ7B6LFKMd4QYJzTVhHbyXrQ_vzJ8M=.09f25f84-d591-47aa-9665-9798dfe188c2@github.com>
Message-ID: <qrYQWXRwHcsKuTDFCh9VrrrsHLZv_PtxHC_5i64iJhk=.06c68248-bfc1-4928-bcf7-9cb9f921dbbc@github.com>

On Wed, 16 Nov 2022 10:55:51 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> Clean simple backport of 8284756 for jdk8u-dev cgroups v2 support.

This pull request has now been integrated.

Changeset: 9f76da9c
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/9f76da9cab5d58aeaaf52e99364616a1e96993bf
Stats:     2 lines in 1 file changed: 0 ins; 2 del; 0 mod

8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem

The actual native method in use is in CgroupsMetrics after JDK-8231111

Backport-of: 8482b376d6630649728929158233984b11d0e2f7

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/178

From sgehwolf at redhat.com  Mon Dec 19 09:51:50 2022
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Mon, 19 Dec 2022 10:51:50 +0100
Subject: Please approve: JDK-8234484 back-port to jdk8u
In-Reply-To: <IA1PR05MB89718CA9219DE7C4DBACA72FB5E49@IA1PR05MB8971.namprd05.prod.outlook.com>
References: <IA1PR05MB89714554CF8BBB36642947C4B5E49@IA1PR05MB8971.namprd05.prod.outlook.com>
 <IA1PR05MB89718CA9219DE7C4DBACA72FB5E49@IA1PR05MB8971.namprd05.prod.outlook.com>
Message-ID: <24bd7b0162324e82edb4b096a9486ad673d3b488.camel@redhat.com>

On Sun, 2022-12-18 at 18:56 +0000, Kumar Srinivasan wrote:
> + added Vyom Tewari who did the heavy lifting.
> ?
> From:Kumar Srinivasan <kusrinivasan at vmware.com>
> Date: Sunday, December 18, 2022 at 10:55 AM
> To: jdk8u-dev at openjdk.org <jdk8u-dev at openjdk.org>,
> jdk-updates-dev at openjdk.org <jdk-updates-dev at openjdk.org>
> Subject: Please approve: JDK-8234484 back-port to jdk8u
> Hi jdk8 approvers, 
> ?
> Can someone please approve the back-port of JDK-8234484 ? a CSR has
> been obtained for the back-port.
> ?
> The fix has been in jdk15+ for some time now and has been reasonably
> ?soaked for 2 years.
> ?
> Given the Freeze date for 8u362-b09 is Dec 23rd, it would be
> preferable to get this in earlier than
> later, ie. well before the holidays and shutdown.

Approved for 8u372 (April CPU). I don't think this one warrants it
getting included as a critical fix for 8u362 in January. jdk8u-dev
branched for 8u372 in early December.

Thanks,
Severin


From jdowland at openjdk.org  Mon Dec 19 10:05:34 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 19 Dec 2022 10:05:34 GMT
Subject: [jdk8u-dev] RFR: 8284102: [TESTBUG] [11u] Retroactively add
 regression test for JDK-8272124 [v3]
In-Reply-To: <1aQIRgA-ktwzsk5i51vX99eXhtCukODGWapG3-PkMhM=.8e97f620-701c-486a-8db8-15e77b586804@github.com>
References: <1aQIRgA-ktwzsk5i51vX99eXhtCukODGWapG3-PkMhM=.8e97f620-701c-486a-8db8-15e77b586804@github.com>
Message-ID: <zVKQ1fVy-MS0DJcnmxjc7aRQmycT_6U1On5m4Ci_8wk=.6b966deb-342c-488e-8dad-23d090458de2@github.com>

> Backport of 8284102 for jdk8u-dev for cgroups v2 support. Not clean, needed `Files.writeString` adjustment. Test builds and passes for me afterwards.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - adjust Files.writeString?write for jdk8u
 - 8284102: [TESTBUG] [11u] Retroactively add regression test for JDK-8272124
   
   Reviewed-by: andrew

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/179/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=179&range=02
  Stats: 53 lines in 1 file changed: 53 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/179.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/179/head:pull/179

PR: https://git.openjdk.org/jdk8u-dev/pull/179

From sgehwolf at openjdk.org  Mon Dec 19 10:51:56 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 19 Dec 2022 10:51:56 GMT
Subject: [jdk8u-dev] RFR: 8284102: [TESTBUG] [11u] Retroactively add
 regression test for JDK-8272124 [v3]
In-Reply-To: <zVKQ1fVy-MS0DJcnmxjc7aRQmycT_6U1On5m4Ci_8wk=.6b966deb-342c-488e-8dad-23d090458de2@github.com>
References: <1aQIRgA-ktwzsk5i51vX99eXhtCukODGWapG3-PkMhM=.8e97f620-701c-486a-8db8-15e77b586804@github.com>
 <zVKQ1fVy-MS0DJcnmxjc7aRQmycT_6U1On5m4Ci_8wk=.6b966deb-342c-488e-8dad-23d090458de2@github.com>
Message-ID: <jvxCgFtx4p7IZlYDwLylAlGJ2OWTTldPMgWMxC8YsEY=.71e3d957-9f41-4f43-9672-b48f1e97254b@github.com>

On Mon, 19 Dec 2022 10:05:34 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> Backport of 8284102 for jdk8u-dev for cgroups v2 support. Not clean, needed `Files.writeString` adjustment. Test builds and passes for me afterwards.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - adjust Files.writeString?write for jdk8u
>  - 8284102: [TESTBUG] [11u] Retroactively add regression test for JDK-8272124
>    
>    Reviewed-by: andrew

Still good. Bug is approved. Feel free to integrate and then rebase #180. Thank you.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/179

From jdowland at openjdk.org  Mon Dec 19 11:16:07 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 19 Dec 2022 11:16:07 GMT
Subject: [jdk8u-dev] Integrated: 8284102: [TESTBUG] [11u] Retroactively add
 regression test for JDK-8272124
In-Reply-To: <1aQIRgA-ktwzsk5i51vX99eXhtCukODGWapG3-PkMhM=.8e97f620-701c-486a-8db8-15e77b586804@github.com>
References: <1aQIRgA-ktwzsk5i51vX99eXhtCukODGWapG3-PkMhM=.8e97f620-701c-486a-8db8-15e77b586804@github.com>
Message-ID: <9vjCAeSrw1FDuKGPi7xNv7fqDr0Agl65At6cmH8GAb0=.fc77928f-984e-4913-8d66-71789f06a178@github.com>

On Wed, 16 Nov 2022 11:05:10 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> Backport of 8284102 for jdk8u-dev for cgroups v2 support. Not clean, needed `Files.writeString` adjustment. Test builds and passes for me afterwards.

This pull request has now been integrated.

Changeset: 06546d78
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/06546d786ae8cc3e445044ef940cb713494a5a95
Stats:     53 lines in 1 file changed: 53 ins; 0 del; 0 mod

8284102: [TESTBUG] [11u] Retroactively add regression test for JDK-8272124

Reviewed-by: sgehwolf
Backport-of: 245e2f2da0302c9354255219248c2f6793947a6a

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/179

From jdowland at openjdk.org  Mon Dec 19 11:18:27 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 19 Dec 2022 11:18:27 GMT
Subject: [jdk8u-dev] RFR: 8292083: Detected container memory limit may
 exceed physical machine memory [v3]
In-Reply-To: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
References: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
Message-ID: <3J4IuW0VVIB1PjhfmTr_N1z1rsOyDGmJv7miP7o-ZqQ=.39cf6191-8635-4436-a296-a91fb805f953@github.com>

> This is a backport of 8292083 for jdk8u-dev cgroups v2 support. It's not clean: context issues, replace the use of some log_debug and log_trace, and an adjustment to Asserts class location for hotspot tests.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:

 - Fix Asserts library for hotspot test in 8u
 - replace log_(trace|debug) for jdk8u
 - 8292083: Detected container memory limit may exceed physical machine memory
   
   Reviewed-by: sgehwolf
   Backport-of: f694f8a7671002559e7d23fdb65d5e9c768f9c03

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/180/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=180&range=02
  Stats: 102 lines in 7 files changed: 66 ins; 28 del; 8 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/180.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/180/head:pull/180

PR: https://git.openjdk.org/jdk8u-dev/pull/180

From sgehwolf at openjdk.org  Mon Dec 19 15:42:59 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 19 Dec 2022 15:42:59 GMT
Subject: [jdk8u-dev] RFR: 8292083: Detected container memory limit may
 exceed physical machine memory [v3]
In-Reply-To: <3J4IuW0VVIB1PjhfmTr_N1z1rsOyDGmJv7miP7o-ZqQ=.39cf6191-8635-4436-a296-a91fb805f953@github.com>
References: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
 <3J4IuW0VVIB1PjhfmTr_N1z1rsOyDGmJv7miP7o-ZqQ=.39cf6191-8635-4436-a296-a91fb805f953@github.com>
Message-ID: <4zMTkSoJh1v8gR4J74iTWdPKQNJRJM-du5I1EkScAlI=.fae10ebf-5f98-4365-bdc7-65adc8d3eba3@github.com>

On Mon, 19 Dec 2022 11:18:27 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8292083 for jdk8u-dev cgroups v2 support. It's not clean: context issues, replace the use of some log_debug and log_trace, and an adjustment to Asserts class location for hotspot tests.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Fix Asserts library for hotspot test in 8u
>  - replace log_(trace|debug) for jdk8u
>  - 8292083: Detected container memory limit may exceed physical machine memory
>    
>    Reviewed-by: sgehwolf
>    Backport-of: f694f8a7671002559e7d23fdb65d5e9c768f9c03

Looks fine.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/180

From vtewari at openjdk.org  Mon Dec 19 15:50:04 2022
From: vtewari at openjdk.org (Vyom Tewari)
Date: Mon, 19 Dec 2022 15:50:04 GMT
Subject: [jdk8u-dev] Integrated: 8234484: Add ability to configure third port
 for remote JMX
In-Reply-To: <XOxX88FMmRCGDO2mJAojQnQixRGQPBB1jDHqRA0nG_8=.b86bb88e-2e37-468a-8c0e-23ceefb9a9c8@github.com>
References: <XOxX88FMmRCGDO2mJAojQnQixRGQPBB1jDHqRA0nG_8=.b86bb88e-2e37-468a-8c0e-23ceefb9a9c8@github.com>
Message-ID: <HbsIJmAYRDT84ymvSXazelwiivaUA3fni8HZlWZYwyI=.6d3dddcc-1498-44c6-abad-df0a459db6d4@github.com>

On Fri, 16 Dec 2022 17:39:35 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:

> Reviewed-by: ksrini
> Backport-of: f129cc43283a18cb5afdd1416b09691a636a7758

This pull request has now been integrated.

Changeset: 78cdc41a
Author:    Vyom Tewari <vtewari at openjdk.org>
Committer: Kumar Srinivasan <ksrini at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/78cdc41a2dcbe93ba594728bd5115c08be43686e
Stats:     35 lines in 3 files changed: 30 ins; 2 del; 3 mod

8234484: Add ability to configure third port for remote JMX

Reviewed-by: ksrini
Backport-of: f129cc43283a18cb5afdd1416b09691a636a7758

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/213

From kusrinivasan at vmware.com  Mon Dec 19 15:56:03 2022
From: kusrinivasan at vmware.com (Kumar Srinivasan)
Date: Mon, 19 Dec 2022 15:56:03 +0000
Subject: Question on Release notes / JDK-8263231 / JDK-8297987
Message-ID: <IA1PR05MB8971A8AE7CC4965235ECA86FB5E59@IA1PR05MB8971.namprd05.prod.outlook.com>

Hi All,

We need to document the newly introduced property as described in the above Bug and Corresponding
CSR, could someone please tell us where to document this property or will this be automatically documented
magically.

Thanks
Kumar Srinivasan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20221219/6bf93b7e/attachment.htm>

From sgehwolf at openjdk.org  Mon Dec 19 15:57:55 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 19 Dec 2022 15:57:55 GMT
Subject: [jdk8u-dev] RFR: 8229182: [TESTBUG]
 runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12 [v2]
In-Reply-To: <K6bFwRxronllnOTzgSbsqZBG1pMP_qFzRQ63bMa-HL4=.7d619c82-22ae-4346-a353-b55285e08080@github.com>
References: <AReidlsEscE0n7lTUuWQWewAPV30L5ZQwlBpw3cjQR4=.0c2f7a7c-3a86-4746-872f-bbe2ec22916e@github.com>
 <p-Ajj4JnpaiuFvIeKeaoOQhoPRx9UJJ_G7EsqmIfMKY=.fc35ebbd-57a5-469c-be6e-f08ee935524c@github.com>
 <K6bFwRxronllnOTzgSbsqZBG1pMP_qFzRQ63bMa-HL4=.7d619c82-22ae-4346-a353-b55285e08080@github.com>
Message-ID: <XOmhezhOvGpo3vyS1OlEYakBBIskdvrgF7loizZfKOo=.3101b19b-4771-48e3-ba7e-c3983d22df72@github.com>

On Mon, 28 Nov 2022 17:20:48 GMT, Dan Lutker <duke at openjdk.org> wrote:

>> Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>> 
>>  - Fix copyright
>>  - Backport a41b9a71acdf69b78104677a1ca899ff36293a60
>
> Sure, we can wait.

@lutkerd Feel free to go ahead and integrate. Thanks!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/186

From jdowland at openjdk.org  Mon Dec 19 16:33:56 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 19 Dec 2022 16:33:56 GMT
Subject: [jdk8u-dev] Integrated: 8292083: Detected container memory limit may
 exceed physical machine memory
In-Reply-To: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
References: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
Message-ID: <JHiKdzqVmhdxycXLcroIahEcxelzcwSxzT0RKyCg6aw=.164d0788-8be4-4028-8d88-5997f8afda11@github.com>

On Wed, 16 Nov 2022 11:44:39 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8292083 for jdk8u-dev cgroups v2 support. It's not clean: context issues, replace the use of some log_debug and log_trace, and an adjustment to Asserts class location for hotspot tests.

This pull request has now been integrated.

Changeset: b4ef3d33
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/b4ef3d338a67baae34933c76aaea94fb0a12b631
Stats:     102 lines in 7 files changed: 66 ins; 28 del; 8 mod

8292083: Detected container memory limit may exceed physical machine memory

Reviewed-by: sgehwolf
Backport-of: f694f8a7671002559e7d23fdb65d5e9c768f9c03

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/180

From gnu.andrew at redhat.com  Tue Dec 20 00:41:19 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Tue, 20 Dec 2022 00:41:19 +0000
Subject: Please approve: JDK-8234484 back-port to jdk8u
In-Reply-To: <24bd7b0162324e82edb4b096a9486ad673d3b488.camel@redhat.com>
References: <IA1PR05MB89714554CF8BBB36642947C4B5E49@IA1PR05MB8971.namprd05.prod.outlook.com>
 <IA1PR05MB89718CA9219DE7C4DBACA72FB5E49@IA1PR05MB8971.namprd05.prod.outlook.com>
 <24bd7b0162324e82edb4b096a9486ad673d3b488.camel@redhat.com>
Message-ID: <Y6EEr9FnWlf2o5j7@hex.discworld.ac.uk>

On 10:51 Mon 19 Dec     , Severin Gehwolf wrote:
> On Sun, 2022-12-18 at 18:56 +0000, Kumar Srinivasan wrote:
> > + added Vyom Tewari who did the heavy lifting.
> > ?
> > From:Kumar Srinivasan <kusrinivasan at vmware.com>
> > Date: Sunday, December 18, 2022 at 10:55 AM
> > To: jdk8u-dev at openjdk.org <jdk8u-dev at openjdk.org>,
> > jdk-updates-dev at openjdk.org <jdk-updates-dev at openjdk.org>
> > Subject: Please approve: JDK-8234484 back-port to jdk8u
> > Hi jdk8 approvers, 
> > ?
> > Can someone please approve the back-port of JDK-8234484 ? a CSR has
> > been obtained for the back-port.
> > ?
> > The fix has been in jdk15+ for some time now and has been reasonably
> > ?soaked for 2 years.
> > ?
> > Given the Freeze date for 8u362-b09 is Dec 23rd, it would be
> > preferable to get this in earlier than
> > later, ie. well before the holidays and shutdown.
> 
> Approved for 8u372 (April CPU). I don't think this one warrants it
> getting included as a critical fix for 8u362 in January. jdk8u-dev
> branched for 8u372 in early December.
> 
> Thanks,
> Severin
> 

I concur. 8u362 is currently in rampdown and only open for
time-critical fixes and regressions from 8u352. An enhancement that
warrants a CSR certainly doesn't meet that criteria.

Why has this not been backported to 11u first? This will now an
inconsistency between the three LTS releases (8u & 17u with the
behaviour, 11u without). This should be rectified.

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20221220/e3f1cc2e/signature.asc>

From andrew at openjdk.org  Tue Dec 20 00:42:01 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 20 Dec 2022 00:42:01 GMT
Subject: [jdk8u-dev] RFR: 8263404: RsaPrivateKeySpec is always recognized
 as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec [v2]
In-Reply-To: <FvKx5PDENDh2QFiuhphxS6Z0qJOA9n0C5asjjVNdanM=.4bb26f0a-e153-491a-bc7b-c448e04dd364@github.com>
References: <kMA-NFXukvyo3VBzyAlUsc3vidEmVBCHyoszZQLRVNs=.bfaf790a-619a-4bbf-9845-e212029d8723@github.com>
 <FvKx5PDENDh2QFiuhphxS6Z0qJOA9n0C5asjjVNdanM=.4bb26f0a-e153-491a-bc7b-c448e04dd364@github.com>
Message-ID: <KFWhWibscDI8PYX6MIA_QofKxLSvxFkcyjEx5z3_uqU=.c798f79a-a9ae-4bb0-9bdd-7a495cdea982@github.com>

On Sun, 18 Dec 2022 16:51:13 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> Backport for Oracle parity from 11u is almost clean.
>> 
>> 1. PKCS11Test.java	is unchanged because 8u does not throw a RuntimeException for an unknown command.
>> 2. In TestP11KeyFactoryGetRSAKeySpec.java, /test/lib is unneeded in the @library comment, and the @module comment was deleted.
>
> Paul Hohensee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

Changes mostly look ok, but will need a rebase before push.

Is there a reason the `*_SHA3_*` definitions have been removed from `p11-nss-sensitive.txt`? Those should be defined, having been added by JDK-8244154

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/214

From duke at openjdk.org  Tue Dec 20 06:40:57 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Tue, 20 Dec 2022 06:40:57 GMT
Subject: [jdk8u-dev] RFR: 8297996: [8u] generated images are broken due to
 renaming of MSVC runtime DLL's [v2]
In-Reply-To: <kmwMHa8T0-HNk_CFFZYvHI4qmwGjmgs1Xt9Vqj4VSi4=.11941c4f-b7c3-431c-ad70-02c10f8e6134@github.com>
References: <rBE3rNSo7kYwJuUUbJ-CPDin9z8f0urlq3SOHvG09PA=.c902b393-e0f7-4e77-8163-8dd0ce54ea52@github.com>
 <kmwMHa8T0-HNk_CFFZYvHI4qmwGjmgs1Xt9Vqj4VSi4=.11941c4f-b7c3-431c-ad70-02c10f8e6134@github.com>
Message-ID: <PucO73Vv5aSM9nTd3RBiALhpDHtoDpH5kNrvyvabDNY=.853d710b-e33f-409c-a552-ce1ea0e508e1@github.com>

On Mon, 5 Dec 2022 08:42:33 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

>> Hi!
>> 
>> The patch fixes Windows image generation with proper VC runtime DLL names. The problem is that MSVS2019 uses two DLL's `vcruntime140.dll` and `vcruntime140_1.dll` and their names conflict under 8.3 limitation. For this reason the [BASIC_MAKE_WINDOWS_SPACE_SAFE_CYGWIN](https://github.com/openjdk/jdk8u-dev/blob/c9007cd44db764fbd791218c6f38491f38af70c2/common/autoconf/basics_windows.m4#L53) renames DLL's to
>
> Alexey Pavlyutkin has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge branch '8297996' of https://github.com/apavlyutkin/jdk8u-dev into 8297996
>  - forcing pre-sumbit test

@phohensee can you find a minute for this one? Thank you

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/203

From duke at openjdk.org  Tue Dec 20 08:14:55 2022
From: duke at openjdk.org (kurashige)
Date: Tue, 20 Dec 2022 08:14:55 GMT
Subject: [jdk8u-dev] RFR: 8284977:
 MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't
 exist
Message-ID: <Kt7Rt8OOSHKyEhEPMIgHrRYtpCMmlt1twsMuO_GV1HU=.e709b1db-4eae-4f79-ab85-6dc67717af98@github.com>

Hi all,

I'd like to backport this to jdk8u-dev.
It fixes a test failure caused by cgroups virtual files (nr_periods etc) not existing in some circumstances.

Thanks.

-------------

Commit messages:
 - Backport 444a0d98ac06ab043e3b11281234fd515abff302

Changes: https://git.openjdk.org/jdk8u-dev/pull/215/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=215&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8284977
  Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/215.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/215/head:pull/215

PR: https://git.openjdk.org/jdk8u-dev/pull/215

From sgehwolf at openjdk.org  Tue Dec 20 10:21:58 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 20 Dec 2022 10:21:58 GMT
Subject: [jdk8u-dev] RFR: 8284977:
 MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't
 exist
In-Reply-To: <Kt7Rt8OOSHKyEhEPMIgHrRYtpCMmlt1twsMuO_GV1HU=.e709b1db-4eae-4f79-ab85-6dc67717af98@github.com>
References: <Kt7Rt8OOSHKyEhEPMIgHrRYtpCMmlt1twsMuO_GV1HU=.e709b1db-4eae-4f79-ab85-6dc67717af98@github.com>
Message-ID: <5rQOyonuSq4SXFelD5yv9n8230spihU_q6HLLVa5CT8=.15485209-91d8-4fc1-8e59-106346aeae8c@github.com>

On Tue, 20 Dec 2022 08:07:14 GMT, kurashige <duke at openjdk.org> wrote:

> Hi all,
> 
> I'd like to backport this to jdk8u-dev.
> It fixes a test failure caused by cgroups virtual files (nr_periods etc) not existing in some circumstances.
> 
> Thanks.

@kurashige23 Please change the PR title to `Backport 444a0d98ac06ab043e3b11281234fd515abff302` as that would make the bots recognize this properly as a backport. Thanks! Please also enable GHA testing on your fork. Instructions should be provided as to how to do that.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/215

From jdowland at openjdk.org  Tue Dec 20 12:21:56 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 20 Dec 2022 12:21:56 GMT
Subject: [jdk8u-dev] RFR: 8293472: Incorrect container resource limit detection
 if manual cgroup fs mounts present
Message-ID: <Ksj9nZH4artzUaE79STM8qFs-oa-acIIJKPbclKHAJc=.7ccf8f04-15ff-45c7-845b-bf032d722492@github.com>

This is a backport of 8293472 to 8u for cgroups v2 support. Not clean: log_debug?tty->print_cr and Files.writeString ? Files.write() needed, as well as adjustments for the lack of [8266490](https://bugs.openjdk.org/browse/JDK-8266490) (PID controller support) in 8u.

-------------

Commit messages:
 - Files.writeString ? Files.write() for jdk8u
 - rework two uses of log_debug
 - 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present

Changes: https://git.openjdk.org/jdk8u-dev/pull/216/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=216&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8293472
  Stats: 167 lines in 6 files changed: 112 ins; 29 del; 26 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/216.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/216/head:pull/216

PR: https://git.openjdk.org/jdk8u-dev/pull/216

From dcherepanov at openjdk.org  Tue Dec 20 12:27:57 2022
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Tue, 20 Dec 2022 12:27:57 GMT
Subject: [jdk8u] RFR: 8297804: (tz) Update Timezone Data to 2022g
Message-ID: <deFpG4Th9Tv5UvYW5YRt2B60Zbrd5biv0ECDvENoNOw=.c97580d7-3d4f-418e-9b65-8c893f39abba@github.com>

Please review the update of timezone data to 2022g.

The existing data was replaced with the new data generated from tzdb-2022g in the rearguard format. This also includes updating a copy of the data in tests (jdk/test/sun/util/calendar/zi/tzdata).

Other parts apply cleanly (with path changes) except timezone.xml. It's added as a part JDK-8186697 (appeared since 10). So changes in timezone.xml ignored.

Testing: all relevant tests passed jdk/test/java/util/TimeZone, jdk/test/sun/util/calendar and jdk/test/java/time/test

-------------

Commit messages:
 - Backport ce896731d38866c2bf99cd49525062e150d94160

Changes: https://git.openjdk.org/jdk8u/pull/26/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=26&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8297804
  Stats: 442 lines in 34 files changed: 255 ins; 112 del; 75 mod
  Patch: https://git.openjdk.org/jdk8u/pull/26.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u pull/26/head:pull/26

PR: https://git.openjdk.org/jdk8u/pull/26

From sgehwolf at openjdk.org  Tue Dec 20 14:38:04 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 20 Dec 2022 14:38:04 GMT
Subject: [jdk8u-dev] RFR: 8293472: Incorrect container resource limit
 detection if manual cgroup fs mounts present
In-Reply-To: <Ksj9nZH4artzUaE79STM8qFs-oa-acIIJKPbclKHAJc=.7ccf8f04-15ff-45c7-845b-bf032d722492@github.com>
References: <Ksj9nZH4artzUaE79STM8qFs-oa-acIIJKPbclKHAJc=.7ccf8f04-15ff-45c7-845b-bf032d722492@github.com>
Message-ID: <qQTLpRm3RiEroh68Yb01j5GP7tEqdMDT6v7ple5sFqM=.f5f543f5-6e06-4dc9-aa60-e7162324e152@github.com>

On Tue, 20 Dec 2022 12:14:12 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8293472 to 8u for cgroups v2 support. Not clean: log_debug?tty->print_cr and Files.writeString ? Files.write() needed, as well as adjustments for the lack of [8266490](https://bugs.openjdk.org/browse/JDK-8266490) (PID controller support) in 8u.

Mostly good. Some comments on test code. Thanks!

hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java line 424:

> 422:             test.testCgroupv1MultipleControllerMounts(wb, test.cgroupv1MntInfoDoubleCpu2);
> 423:             test.testCgroupv1MultipleControllerMounts(wb, test.cgroupv1MntInfoDoublePids);
> 424:             test.testCgroupv1MultipleControllerMounts(wb, test.cgroupv1MntInfoDoublePids2);

The PIDs patch is not in 8u, but I guess this does no harm. OK.

hotspot/test/runtime/containers/docker/DockerBasicTest.java line 91:

> 89:             .shouldHaveExitValue(0)
> 90:             .shouldNotMatch("\\[os,container *\\]");
> 91:     }

This test has no meaning in OpenJDK 8u. There, all container related printouts are guarded with `PrintContainerInfo` which is false for this test. It makes sense for JDKs with unified logging, as there a warning was being printed to stdout/err whether or not logging was otherwise turned on or not. It's conceivable that it would catch the assert, but that would also happen in one of the cpu/memory tests with additional cgroup fs mounts.

TLDR: I suggest to skip these test changes in the backport. All it does is adding to exec time, but would always be tautologically true (especially with the `os,container` match).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/216

From sgehwolf at openjdk.org  Tue Dec 20 17:06:22 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 20 Dec 2022 17:06:22 GMT
Subject: [jdk8u-dev] RFR: 8289695: [TESTBUG] TestMemoryAwareness.java fails on
 cgroups v2 and crun
Message-ID: <5998AxvGX5tMLYgxru5nLdk635a0JDOgzsX5XqPOETk=.5eb7735b-83ce-4806-8213-e33143aa87c1@github.com>

Clean backport. Fixes a test issue on cg v2 where `--memory-swappiness` is not supported.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/186

Commit messages:
 - 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun

Changes: https://git.openjdk.org/jdk8u-dev/pull/217/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=217&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8289695
  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/217.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/217/head:pull/217

PR: https://git.openjdk.org/jdk8u-dev/pull/217

From sgehwolf at openjdk.org  Tue Dec 20 18:09:34 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 20 Dec 2022 18:09:34 GMT
Subject: [jdk8u-dev] RFR: 8287107: CgroupSubsystemFactory.setCgroupV2Path
 asserts with freezer controller
Message-ID: <MmCG2lhrKdt3vO7Cw98Ph50FgHtxArQT7eYR73r6mL4=.40c28657-5937-47d0-b2a3-02cf16f96334@github.com>

Not a clean backport due to changes in test - `Files.writeString(a, b)` => `Files.write(a, b.getBytes())` - and some copyright and `@bug` lines. Fixed manually.

Testing: Linux x86_64 fastdebug (reg-test fails prior and passes after product fix).

-------------

Commit messages:
 - 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller

Changes: https://git.openjdk.org/jdk8u-dev/pull/218/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=218&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8287107
  Stats: 117 lines in 3 files changed: 114 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/218.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/218/head:pull/218

PR: https://git.openjdk.org/jdk8u-dev/pull/218

From sgehwolf at openjdk.org  Tue Dec 20 18:27:37 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 20 Dec 2022 18:27:37 GMT
Subject: [jdk8u-dev] RFR: 8287741: Fix of JDK-8287107 (unused cgv1 freezer
 controller) was incomplete
Message-ID: <UIb_k7TgJWWTzLW91Gj8EI7RshTrjuWIt7miARPaeiA=.e3ae124b-8da1-47b0-ae30-387ee70c5ba5@github.com>

Clean backport. Only path differences.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/218

Commit messages:
 - 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete

Changes: https://git.openjdk.org/jdk8u-dev/pull/219/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=219&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8287741
  Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/219.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/219/head:pull/219

PR: https://git.openjdk.org/jdk8u-dev/pull/219

From andrew at openjdk.org  Tue Dec 20 18:54:57 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 20 Dec 2022 18:54:57 GMT
Subject: [jdk8u] RFR: 8296715: CLDR v42 update for tzdata 2022f
Message-ID: <Tz0bMWTr7dp5pJiREaScQ8HfT91jdkZkkH8cKk0_-7A=.f8b25787-1ebb-4787-954e-e0704aa1b12d@github.com>

This is a minimal backport of the CLDR v42 update for tzdata 2022f, just containing the timezone changes. The previous definition for `America/Chihuahua`, which is superseded by the change to `America_Central` on 2022-10-30, is retained as `America_Mountain` as `Mexico_Pacific` doesn't exist in 8u's version of CLDR and the change here is to define an end to that metazone, not alter it.

The other changes are omitted as follows:

* The `es_419.xml` in 8u's CLDR does not contain the patterns being altered.
* `LocaleData.cldr` does not exist in 8u
* `LocaleDataTest.java` does not need updating as the test has not been changed, as there is no data file change (`LocaleData.cldr`)

Regarding the latter two, the CLDR checks in the test were introduced as part of JDK-8008577: "Use CLDR Locale Data by Default". We obviously don't want to backport that in full, but updating LocaleDataTest.java with a CLDR data set would be useful.

However, I think it's out of scope for a rampdown time critical data fix like this, as it is likely a lengthy effort to get a passing data set, needing further CLDR updates. It should be handled separately. I'll open a bug and PR for this against 8u-dev.

-------------

Commit messages:
 - Backport da9de488990ff47fe06343439f2180ec1b2a3061

Changes: https://git.openjdk.org/jdk8u/pull/27/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=27&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8296715
  Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u/pull/27.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u pull/27/head:pull/27

PR: https://git.openjdk.org/jdk8u/pull/27

From phh at openjdk.org  Tue Dec 20 21:17:55 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 20 Dec 2022 21:17:55 GMT
Subject: [jdk8u-dev] RFR: 8297996: [8u] generated images are broken due to
 renaming of MSVC runtime DLL's [v2]
In-Reply-To: <kmwMHa8T0-HNk_CFFZYvHI4qmwGjmgs1Xt9Vqj4VSi4=.11941c4f-b7c3-431c-ad70-02c10f8e6134@github.com>
References: <rBE3rNSo7kYwJuUUbJ-CPDin9z8f0urlq3SOHvG09PA=.c902b393-e0f7-4e77-8163-8dd0ce54ea52@github.com>
 <kmwMHa8T0-HNk_CFFZYvHI4qmwGjmgs1Xt9Vqj4VSi4=.11941c4f-b7c3-431c-ad70-02c10f8e6134@github.com>
Message-ID: <5pEWEJQZIPWCfni3hn0DQzEOYDDOKOFZ1bZfWxrASrI=.3e615afd-ab86-4123-8591-37b1a57778b4@github.com>

On Mon, 5 Dec 2022 08:42:33 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

>> Hi!
>> 
>> The patch fixes Windows image generation with proper VC runtime DLL names. The problem is that MSVS2019 uses two DLL's `vcruntime140.dll` and `vcruntime140_1.dll` and their names conflict under 8.3 limitation. For this reason the [BASIC_MAKE_WINDOWS_SPACE_SAFE_CYGWIN](https://github.com/openjdk/jdk8u-dev/blob/c9007cd44db764fbd791218c6f38491f38af70c2/common/autoconf/basics_windows.m4#L53) renames DLL's to
>
> Alexey Pavlyutkin has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge branch '8297996' of https://github.com/apavlyutkin/jdk8u-dev into 8297996
>  - forcing pre-sumbit test

This one slipped through the cracks. Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/203

From duke at openjdk.org  Wed Dec 21 03:11:57 2022
From: duke at openjdk.org (kurashige)
Date: Wed, 21 Dec 2022 03:11:57 GMT
Subject: [jdk8u-dev] RFR: 8284977:
 MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't
 exist
In-Reply-To: <5rQOyonuSq4SXFelD5yv9n8230spihU_q6HLLVa5CT8=.15485209-91d8-4fc1-8e59-106346aeae8c@github.com>
References: <Kt7Rt8OOSHKyEhEPMIgHrRYtpCMmlt1twsMuO_GV1HU=.e709b1db-4eae-4f79-ab85-6dc67717af98@github.com>
 <5rQOyonuSq4SXFelD5yv9n8230spihU_q6HLLVa5CT8=.15485209-91d8-4fc1-8e59-106346aeae8c@github.com>
Message-ID: <lhE1SYdVQ66SjReYEgmNzeUbl9pijPdY1kAnHYY9auY=.db89b5c2-9955-4006-86f7-22388e586754@github.com>

On Tue, 20 Dec 2022 10:19:08 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Hi all,
>> 
>> I'd like to backport this to jdk8u-dev.
>> It fixes a test failure caused by cgroups virtual files (nr_periods etc) not existing in some circumstances.
>> 
>> Thanks.
>
> @kurashige23 Please change the PR title to `Backport 444a0d98ac06ab043e3b11281234fd515abff302` as that would make the bots recognize this properly as a backport. Thanks! Please also enable GHA testing on your fork. Instructions should be provided as to how to do that.

@jerboaa I'm sorry for some mistakes.  I fixed PR title and enabled GHA testing. Is that all right?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/215

From andrew at openjdk.org  Wed Dec 21 04:23:39 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 21 Dec 2022 04:23:39 GMT
Subject: [jdk8u] RFR: 8297804: (tz) Update Timezone Data to 2022g
Message-ID: <ExYVcmuR90wTnE8HkNi4iLLMFcPT2157q_Mpo9wanO4=.164b6c84-25b7-403c-8b5f-dbe10ab27385@github.com>

This is a mostly clean backport of the latest tzdata update.

This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato.

Changes from the {11,13,15,17,19}u and 20 versions:
* `timezone.xml` does not exist in 8u so the addition there is omitted
* In `metaZones.xml`, `America_Mountain` is used instead of `Mexico_Pacific`. This is consistent with [PR27](https://github.com/openjdk/jdk8u/pull/27) on top of which this PR is based (`America/Ciudad_Juarez` splits from `America/Ojinaga`). 8u does not contain definitions for `Mexico_Pacific`.
* The tzdata updates are duplicated in `jdk/test/sun/util/calendar/zi/tzdata`, as currently required for 8u testing.

Tests in `java/util/TimeZone`, `java/time/test`, `sun/util/calendar`, `sun/util/resources` and `sun/text/resources` all pass.

Thanks!

-------------

Depends on: https://git.openjdk.org/jdk8u/pull/27

Commit messages:
 - Backport ce896731d38866c2bf99cd49525062e150d94160

Changes: https://git.openjdk.org/jdk8u/pull/28/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=28&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8297804
  Stats: 442 lines in 34 files changed: 255 ins; 112 del; 75 mod
  Patch: https://git.openjdk.org/jdk8u/pull/28.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u pull/28/head:pull/28

PR: https://git.openjdk.org/jdk8u/pull/28

From andrew at openjdk.org  Wed Dec 21 04:27:56 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 21 Dec 2022 04:27:56 GMT
Subject: [jdk8u] RFR: 8297804: (tz) Update Timezone Data to 2022g
In-Reply-To: <deFpG4Th9Tv5UvYW5YRt2B60Zbrd5biv0ECDvENoNOw=.c97580d7-3d4f-418e-9b65-8c893f39abba@github.com>
References: <deFpG4Th9Tv5UvYW5YRt2B60Zbrd5biv0ECDvENoNOw=.c97580d7-3d4f-418e-9b65-8c893f39abba@github.com>
Message-ID: <nXQ_uqU5OTseQZoM3ItVm6KkZnvMncsSwxMx-2wHni4=.370066d1-1d81-4531-b92b-a690f8be845b@github.com>

On Tue, 20 Dec 2022 12:19:11 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Please review the update of timezone data to 2022g.
> 
> The existing data was replaced with the new data generated from tzdb-2022g in the rearguard format. This also includes updating a copy of the data in tests (jdk/test/sun/util/calendar/zi/tzdata).
> 
> Other parts apply cleanly (with path changes) except timezone.xml. It's added as a part JDK-8186697 (appeared since 10). So changes in timezone.xml ignored.
> 
> Testing: all relevant tests passed jdk/test/java/util/TimeZone, jdk/test/sun/util/calendar and jdk/test/java/time/test

This looks the same as what I have here - https://github.com/openjdk/jdk8u/pull/28 - except you haven't adjusted for the absence of `Mexico_Pacific`.  Note also that mine is built on top of #27 which adds CLDR adjustments for the previous update, 2022f.

Reviews of those PRs are welcome.

-------------

PR: https://git.openjdk.org/jdk8u/pull/26

From duke at openjdk.org  Wed Dec 21 06:24:58 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Wed, 21 Dec 2022 06:24:58 GMT
Subject: [jdk8u-dev] RFR: 8297996: [8u] generated images are broken due to
 renaming of MSVC runtime DLL's [v2]
In-Reply-To: <kmwMHa8T0-HNk_CFFZYvHI4qmwGjmgs1Xt9Vqj4VSi4=.11941c4f-b7c3-431c-ad70-02c10f8e6134@github.com>
References: <rBE3rNSo7kYwJuUUbJ-CPDin9z8f0urlq3SOHvG09PA=.c902b393-e0f7-4e77-8163-8dd0ce54ea52@github.com>
 <kmwMHa8T0-HNk_CFFZYvHI4qmwGjmgs1Xt9Vqj4VSi4=.11941c4f-b7c3-431c-ad70-02c10f8e6134@github.com>
Message-ID: <691aOfDwJTXnDDpHwRAiKcNqT1qNEu8J85Yk_cl2Cbk=.4cd04d4f-dd32-40af-9dd4-d38389c806f3@github.com>

On Mon, 5 Dec 2022 08:42:33 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

>> Hi!
>> 
>> The patch fixes Windows image generation with proper VC runtime DLL names. The problem is that MSVS2019 uses two DLL's `vcruntime140.dll` and `vcruntime140_1.dll` and their names conflict under 8.3 limitation. For this reason the [BASIC_MAKE_WINDOWS_SPACE_SAFE_CYGWIN](https://github.com/openjdk/jdk8u-dev/blob/c9007cd44db764fbd791218c6f38491f38af70c2/common/autoconf/basics_windows.m4#L53) renames DLL's to
>
> Alexey Pavlyutkin has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge branch '8297996' of https://github.com/apavlyutkin/jdk8u-dev into 8297996
>  - forcing pre-sumbit test

Thanks a lot

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/203

From dcherepanov at openjdk.org  Wed Dec 21 08:35:54 2022
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 21 Dec 2022 08:35:54 GMT
Subject: [jdk8u] RFR: 8296715: CLDR v42 update for tzdata 2022f
In-Reply-To: <Tz0bMWTr7dp5pJiREaScQ8HfT91jdkZkkH8cKk0_-7A=.f8b25787-1ebb-4787-954e-e0704aa1b12d@github.com>
References: <Tz0bMWTr7dp5pJiREaScQ8HfT91jdkZkkH8cKk0_-7A=.f8b25787-1ebb-4787-954e-e0704aa1b12d@github.com>
Message-ID: <RhZ6v-4HZhwm8Pm_V9VOXPR7253EN3dwPEqWE1p5WTY=.f5f46fe6-129a-42ef-a9be-79f1cd2f5ed1@github.com>

On Tue, 20 Dec 2022 18:45:39 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is a minimal backport of the CLDR v42 update for tzdata 2022f, just containing the timezone changes. The previous definition for `America/Chihuahua`, which is superseded by the change to `America_Central` on 2022-10-30, is retained as `America_Mountain` as `Mexico_Pacific` doesn't exist in 8u's version of CLDR and the change here is to define an end to that metazone, not alter it.
> 
> The other changes are omitted as follows:
> 
> * The `es_419.xml` in 8u's CLDR does not contain the patterns being altered.
> * `LocaleData.cldr` does not exist in 8u
> * `LocaleDataTest.java` does not need updating as the test has not been changed, as there is no data file change (`LocaleData.cldr`)
> 
> Regarding the latter two, the CLDR checks in the test were introduced as part of JDK-8008577: "Use CLDR Locale Data by Default". We obviously don't want to backport that in full, but updating LocaleDataTest.java with a CLDR data set would be useful.
> 
> However, I think it's out of scope for a rampdown time critical data fix like this, as it is likely a lengthy effort to get a passing data set, needing further CLDR updates. It should be handled separately. I'll open a bug and PR for this against 8u-dev.

Looks good.

-------------

Marked as reviewed by dcherepanov (Reviewer).

PR: https://git.openjdk.org/jdk8u/pull/27

From dcherepanov at openjdk.org  Wed Dec 21 08:47:58 2022
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 21 Dec 2022 08:47:58 GMT
Subject: [jdk8u] RFR: 8297804: (tz) Update Timezone Data to 2022g
In-Reply-To: <ExYVcmuR90wTnE8HkNi4iLLMFcPT2157q_Mpo9wanO4=.164b6c84-25b7-403c-8b5f-dbe10ab27385@github.com>
References: <ExYVcmuR90wTnE8HkNi4iLLMFcPT2157q_Mpo9wanO4=.164b6c84-25b7-403c-8b5f-dbe10ab27385@github.com>
Message-ID: <Jfb25PlU0DWCFCl2xQ6JknvQbx5Dfg0ylzbdtFqS0pI=.79dd2de9-70d5-425e-ba7c-db6a1b4dfb81@github.com>

On Wed, 21 Dec 2022 04:16:21 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is a mostly clean backport of the latest tzdata update.
> 
> This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato.
> 
> Changes from the {11,13,15,17,19}u and 20 versions:
> * `timezone.xml` does not exist in 8u so the addition there is omitted
> * In `metaZones.xml`, `America_Mountain` is used instead of `Mexico_Pacific`. This is consistent with [PR27](https://github.com/openjdk/jdk8u/pull/27) on top of which this PR is based (`America/Ciudad_Juarez` splits from `America/Ojinaga`). 8u does not contain definitions for `Mexico_Pacific`.
> * The tzdata updates are duplicated in `jdk/test/sun/util/calendar/zi/tzdata`, as currently required for 8u testing.
> 
> Tests in `java/util/TimeZone`, `java/time/test`, `sun/util/calendar`, `sun/util/resources` and `sun/text/resources` all pass.  The rearguard changes are identical to those for vanguard, as verified against the rearguard data generated using `make rearguard_tarballs` in the tzdata2022g distribution.
> 
> Thanks!

Looks good.

-------------

Marked as reviewed by dcherepanov (Reviewer).

PR: https://git.openjdk.org/jdk8u/pull/28

From dcherepanov at openjdk.org  Wed Dec 21 08:49:54 2022
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 21 Dec 2022 08:49:54 GMT
Subject: [jdk8u] RFR: 8297804: (tz) Update Timezone Data to 2022g
In-Reply-To: <deFpG4Th9Tv5UvYW5YRt2B60Zbrd5biv0ECDvENoNOw=.c97580d7-3d4f-418e-9b65-8c893f39abba@github.com>
References: <deFpG4Th9Tv5UvYW5YRt2B60Zbrd5biv0ECDvENoNOw=.c97580d7-3d4f-418e-9b65-8c893f39abba@github.com>
Message-ID: <iwZGENcJPOjuU0UpFs-cZD-V2lPJOZ61ulv8slmiPiA=.62e2747a-46fd-4ee5-b233-dd12974462ec@github.com>

On Tue, 20 Dec 2022 12:19:11 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Please review the update of timezone data to 2022g.
> 
> The existing data was replaced with the new data generated from tzdb-2022g in the rearguard format. This also includes updating a copy of the data in tests (jdk/test/sun/util/calendar/zi/tzdata).
> 
> Other parts apply cleanly (with path changes) except timezone.xml. It's added as a part JDK-8186697 (appeared since 10). So changes in timezone.xml ignored.
> 
> Testing: all relevant tests passed jdk/test/java/util/TimeZone, jdk/test/sun/util/calendar and jdk/test/java/time/test

> This looks the same as what I have here - #28 - except you haven't adjusted for the absence of `Mexico_Pacific`. Note also that mine is built on top of #27 which adds CLDR adjustments for the previous update, 2022f.
> 
> Reviews of those PRs are welcome.

These PRs look good. Thank you.

-------------

PR: https://git.openjdk.org/jdk8u/pull/26

From dcherepanov at openjdk.org  Wed Dec 21 08:49:54 2022
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 21 Dec 2022 08:49:54 GMT
Subject: [jdk8u] Withdrawn: 8297804: (tz) Update Timezone Data to 2022g
In-Reply-To: <deFpG4Th9Tv5UvYW5YRt2B60Zbrd5biv0ECDvENoNOw=.c97580d7-3d4f-418e-9b65-8c893f39abba@github.com>
References: <deFpG4Th9Tv5UvYW5YRt2B60Zbrd5biv0ECDvENoNOw=.c97580d7-3d4f-418e-9b65-8c893f39abba@github.com>
Message-ID: <k8sIrjyr0bQsPsmUYiRJzSXIHNh-vZ_Swv2Ta9POCig=.bb5fdac4-1cd8-4521-8d5f-12434002b14d@github.com>

On Tue, 20 Dec 2022 12:19:11 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Please review the update of timezone data to 2022g.
> 
> The existing data was replaced with the new data generated from tzdb-2022g in the rearguard format. This also includes updating a copy of the data in tests (jdk/test/sun/util/calendar/zi/tzdata).
> 
> Other parts apply cleanly (with path changes) except timezone.xml. It's added as a part JDK-8186697 (appeared since 10). So changes in timezone.xml ignored.
> 
> Testing: all relevant tests passed jdk/test/java/util/TimeZone, jdk/test/sun/util/calendar and jdk/test/java/time/test

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u/pull/26

From sgehwolf at openjdk.org  Wed Dec 21 09:38:58 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 21 Dec 2022 09:38:58 GMT
Subject: [jdk8u] RFR: 8296715: CLDR v42 update for tzdata 2022f
In-Reply-To: <Tz0bMWTr7dp5pJiREaScQ8HfT91jdkZkkH8cKk0_-7A=.f8b25787-1ebb-4787-954e-e0704aa1b12d@github.com>
References: <Tz0bMWTr7dp5pJiREaScQ8HfT91jdkZkkH8cKk0_-7A=.f8b25787-1ebb-4787-954e-e0704aa1b12d@github.com>
Message-ID: <xlEs1u_pw_F_luWYjnQD8j-88dcJNwc4-KyubSLznDI=.790b3683-6790-41e1-97e6-101db2e3d0e0@github.com>

On Tue, 20 Dec 2022 18:45:39 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is a minimal backport of the CLDR v42 update for tzdata 2022f, just containing the timezone changes. The previous definition for `America/Chihuahua`, which is superseded by the change to `America_Central` on 2022-10-30, is retained as `America_Mountain` as `Mexico_Pacific` doesn't exist in 8u's version of CLDR and the change here is to define an end to that metazone, not alter it.
> 
> The other changes are omitted as follows:
> 
> * The `es_419.xml` in 8u's CLDR does not contain the patterns being altered.
> * `LocaleData.cldr` does not exist in 8u
> * `LocaleDataTest.java` does not need updating as the test has not been changed, as there is no data file change (`LocaleData.cldr`)
> 
> Regarding the latter two, the CLDR checks in the test were introduced as part of JDK-8008577: "Use CLDR Locale Data by Default". We obviously don't want to backport that in full, but updating LocaleDataTest.java with a CLDR data set would be useful.
> 
> However, I think it's out of scope for a rampdown time critical data fix like this, as it is likely a lengthy effort to get a passing data set, needing further CLDR updates. It should be handled separately. I'll open a bug and PR for this against 8u-dev.

OK.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u/pull/27

From sgehwolf at openjdk.org  Wed Dec 21 09:53:53 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 21 Dec 2022 09:53:53 GMT
Subject: [jdk8u-dev] RFR: 8284977:
 MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't
 exist
In-Reply-To: <Kt7Rt8OOSHKyEhEPMIgHrRYtpCMmlt1twsMuO_GV1HU=.e709b1db-4eae-4f79-ab85-6dc67717af98@github.com>
References: <Kt7Rt8OOSHKyEhEPMIgHrRYtpCMmlt1twsMuO_GV1HU=.e709b1db-4eae-4f79-ab85-6dc67717af98@github.com>
Message-ID: <jjN9DCJgqAkYmC0g1TtAHZ8BrAIuD9uhgYwjyOk7yr8=.d413d1be-49e2-4c17-baa4-4ff0a857e605@github.com>

On Tue, 20 Dec 2022 08:07:14 GMT, kurashige <duke at openjdk.org> wrote:

> Hi all,
> 
> I'd like to backport this to jdk8u-dev.
> It fixes a test failure caused by cgroups virtual files (nr_periods etc) not existing in some circumstances.
> 
> Thanks.

Clean backport (only path changes). Marking as such.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/215

From sgehwolf at openjdk.org  Wed Dec 21 09:53:54 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 21 Dec 2022 09:53:54 GMT
Subject: [jdk8u-dev] RFR: 8284977:
 MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't
 exist
In-Reply-To: <lhE1SYdVQ66SjReYEgmNzeUbl9pijPdY1kAnHYY9auY=.db89b5c2-9955-4006-86f7-22388e586754@github.com>
References: <Kt7Rt8OOSHKyEhEPMIgHrRYtpCMmlt1twsMuO_GV1HU=.e709b1db-4eae-4f79-ab85-6dc67717af98@github.com>
 <5rQOyonuSq4SXFelD5yv9n8230spihU_q6HLLVa5CT8=.15485209-91d8-4fc1-8e59-106346aeae8c@github.com>
 <lhE1SYdVQ66SjReYEgmNzeUbl9pijPdY1kAnHYY9auY=.db89b5c2-9955-4006-86f7-22388e586754@github.com>
Message-ID: <fjGt7z4TsLxrpZ-j7kVSgJoVPDKHvoSXjir6SMgIg_4=.62de6adf-0c3c-43eb-8c78-bd06889c8a2c@github.com>

On Wed, 21 Dec 2022 03:08:50 GMT, kurashige <duke at openjdk.org> wrote:

>> @kurashige23 Please change the PR title to `Backport 444a0d98ac06ab043e3b11281234fd515abff302` as that would make the bots recognize this properly as a backport. Thanks! Please also enable GHA testing on your fork. Instructions should be provided as to how to do that.
>
> @jerboaa I'm sorry for some mistakes.  I fixed PR title and enabled GHA testing. Is that all right?

@kurashige23 Please proceed with applying for JDK 8u backports approval as described in `Contributing` section here:
https://wiki.openjdk.org/display/jdk8u

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/215

From sgehwolf at openjdk.org  Wed Dec 21 09:55:56 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 21 Dec 2022 09:55:56 GMT
Subject: [jdk8u-dev] RFR: 8287741: Fix of JDK-8287107 (unused cgv1 freezer
 controller) was incomplete
In-Reply-To: <UIb_k7TgJWWTzLW91Gj8EI7RshTrjuWIt7miARPaeiA=.e3ae124b-8da1-47b0-ae30-387ee70c5ba5@github.com>
References: <UIb_k7TgJWWTzLW91Gj8EI7RshTrjuWIt7miARPaeiA=.e3ae124b-8da1-47b0-ae30-387ee70c5ba5@github.com>
Message-ID: <UMjTsfabJPjQbEPACFjQR4cBlZ7ADm1qYYn98hcqc5E=.ad7bfaa6-1d49-4908-a895-40d807e5eb22@github.com>

On Tue, 20 Dec 2022 18:20:47 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Clean backport. Only path differences.

Clean backport. Marking as such.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/219

From sgehwolf at openjdk.org  Wed Dec 21 10:36:56 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 21 Dec 2022 10:36:56 GMT
Subject: [jdk8u] RFR: 8297804: (tz) Update Timezone Data to 2022g
In-Reply-To: <ExYVcmuR90wTnE8HkNi4iLLMFcPT2157q_Mpo9wanO4=.164b6c84-25b7-403c-8b5f-dbe10ab27385@github.com>
References: <ExYVcmuR90wTnE8HkNi4iLLMFcPT2157q_Mpo9wanO4=.164b6c84-25b7-403c-8b5f-dbe10ab27385@github.com>
Message-ID: <x21KDGPSTUlJVEWuw-rpMD0SsBE4RRSevfaiF0RbG-8=.b57d652b-1531-45e5-ae00-b629da7bab23@github.com>

On Wed, 21 Dec 2022 04:16:21 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is a mostly clean backport of the latest tzdata update.
> 
> This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato.
> 
> Changes from the {11,13,15,17,19}u and 20 versions:
> * `timezone.xml` does not exist in 8u so the addition there is omitted
> * In `metaZones.xml`, `America_Mountain` is used instead of `Mexico_Pacific`. This is consistent with [PR27](https://github.com/openjdk/jdk8u/pull/27) on top of which this PR is based (`America/Ciudad_Juarez` splits from `America/Ojinaga`). 8u does not contain definitions for `Mexico_Pacific`.
> * The tzdata updates are duplicated in `jdk/test/sun/util/calendar/zi/tzdata`, as currently required for 8u testing.
> 
> Tests in `java/util/TimeZone`, `java/time/test`, `sun/util/calendar`, `sun/util/resources` and `sun/text/resources` all pass.  The rearguard changes are identical to those for vanguard, as verified against the rearguard data generated using `make rearguard_tarballs` in the tzdata2022g distribution.
> 
> Thanks!

Marked as reviewed by sgehwolf (Reviewer).

-------------

PR: https://git.openjdk.org/jdk8u/pull/28

From andrew at openjdk.org  Wed Dec 21 16:13:54 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 21 Dec 2022 16:13:54 GMT
Subject: [jdk8u] RFR: 8297804: (tz) Update Timezone Data to 2022g
In-Reply-To: <iwZGENcJPOjuU0UpFs-cZD-V2lPJOZ61ulv8slmiPiA=.62e2747a-46fd-4ee5-b233-dd12974462ec@github.com>
References: <deFpG4Th9Tv5UvYW5YRt2B60Zbrd5biv0ECDvENoNOw=.c97580d7-3d4f-418e-9b65-8c893f39abba@github.com>
 <iwZGENcJPOjuU0UpFs-cZD-V2lPJOZ61ulv8slmiPiA=.62e2747a-46fd-4ee5-b233-dd12974462ec@github.com>
Message-ID: <fwoPrhirnvcgQ-UkIVEfckTWHeB6vJMH9hOrcp38BuM=.65276880-42c6-4964-9775-8edeb58c4d6c@github.com>

On Wed, 21 Dec 2022 08:47:27 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> > This looks the same as what I have here - #28 - except you haven't adjusted for the absence of `Mexico_Pacific`. Note also that mine is built on top of #27 which adds CLDR adjustments for the previous update, 2022f.
> > Reviews of those PRs are welcome.
> 
> These PRs look good. Thank you.

Thanks. Sorry for the duplication. I didn't see your PR until I'd just finished testing my 2022g patch.

-------------

PR: https://git.openjdk.org/jdk8u/pull/26

From andrew at openjdk.org  Wed Dec 21 16:19:51 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 21 Dec 2022 16:19:51 GMT
Subject: [jdk8u] RFR: 8296715: CLDR v42 update for tzdata 2022f
In-Reply-To: <Tz0bMWTr7dp5pJiREaScQ8HfT91jdkZkkH8cKk0_-7A=.f8b25787-1ebb-4787-954e-e0704aa1b12d@github.com>
References: <Tz0bMWTr7dp5pJiREaScQ8HfT91jdkZkkH8cKk0_-7A=.f8b25787-1ebb-4787-954e-e0704aa1b12d@github.com>
Message-ID: <qIiXZ7WJ0EuMiDFRt9QTDmQAL1NDbanbB5onjqsfsnc=.aeb5d5ac-2fc5-4a4b-981b-b7c05af5fca3@github.com>

On Tue, 20 Dec 2022 18:45:39 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is a minimal backport of the CLDR v42 update for tzdata 2022f, just containing the timezone changes. The previous definition for `America/Chihuahua`, which is superseded by the change to `America_Central` on 2022-10-30, is retained as `America_Mountain` as `Mexico_Pacific` doesn't exist in 8u's version of CLDR and the change here is to define an end to that metazone, not alter it.
> 
> The other changes are omitted as follows:
> 
> * The `es_419.xml` in 8u's CLDR does not contain the patterns being altered.
> * `LocaleData.cldr` does not exist in 8u
> * `LocaleDataTest.java` does not need updating as the test has not been changed, as there is no data file change (`LocaleData.cldr`)
> 
> Regarding the latter two, the CLDR checks in the test were introduced as part of JDK-8008577: "Use CLDR Locale Data by Default". We obviously don't want to backport that in full, but updating LocaleDataTest.java with a CLDR data set would be useful.
> 
> However, I think it's out of scope for a rampdown time critical data fix like this, as it is likely a lengthy effort to get a passing data set, needing further CLDR updates. It should be handled separately. I'll open a bug and PR for this against 8u-dev.

Thanks both. Flagged with `jdk8u-critical-request`.

-------------

PR: https://git.openjdk.org/jdk8u/pull/27

From andrew at openjdk.org  Wed Dec 21 16:24:57 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 21 Dec 2022 16:24:57 GMT
Subject: [jdk8u] RFR: 8297804: (tz) Update Timezone Data to 2022g
In-Reply-To: <ExYVcmuR90wTnE8HkNi4iLLMFcPT2157q_Mpo9wanO4=.164b6c84-25b7-403c-8b5f-dbe10ab27385@github.com>
References: <ExYVcmuR90wTnE8HkNi4iLLMFcPT2157q_Mpo9wanO4=.164b6c84-25b7-403c-8b5f-dbe10ab27385@github.com>
Message-ID: <yysz6xxQMF-Z5vab4gbEfbEgGtIhMMCBlTTvn62kQJk=.3ace2354-b33c-4cd9-97ea-b7104a59be5d@github.com>

On Wed, 21 Dec 2022 04:16:21 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is a mostly clean backport of the latest tzdata update.
> 
> This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato.
> 
> Changes from the {11,13,15,17,19}u and 20 versions:
> * `timezone.xml` does not exist in 8u so the addition there is omitted
> * In `metaZones.xml`, `America_Mountain` is used instead of `Mexico_Pacific`. This is consistent with [PR27](https://github.com/openjdk/jdk8u/pull/27) on top of which this PR is based (`America/Ciudad_Juarez` splits from `America/Ojinaga`). 8u does not contain definitions for `Mexico_Pacific`.
> * The tzdata updates are duplicated in `jdk/test/sun/util/calendar/zi/tzdata`, as currently required for 8u testing.
> 
> Tests in `java/util/TimeZone`, `java/time/test`, `sun/util/calendar`, `sun/util/resources` and `sun/text/resources` all pass.  The rearguard changes are identical to those for vanguard, as verified against the rearguard data generated using `make rearguard_tarballs` in the tzdata2022g distribution.
> 
> Thanks!

Thanks both. Flagged with `jdk8u-critical-request`.

-------------

PR: https://git.openjdk.org/jdk8u/pull/28

From gnu.andrew at redhat.com  Wed Dec 21 17:04:28 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Wed, 21 Dec 2022 17:04:28 +0000
Subject: Result: New OpenJDK 8 Updates =?utf-8?Q?Co?=
 =?utf-8?B?bW1pdHRlcjogWmRlbsSbayDFvWFtYmVyc2vDvQ==?=
Message-ID: <Y6M8nHsXeu0JD4/R@hex.discworld.ac.uk>

Voting for Zden?k ?ambersk? [0] is now closed.

Yes: 8
Veto: 0
Abstain: 0

Turnout: 3% (8/230)

According to the Bylaws definition of Lazy Consensus [1], this is
sufficient to approve the nomination.

[0] https://mail.openjdk.org/pipermail/jdk8u-dev/2022-November/016060.html
[1] https://openjdk.java.net/bylaws#lazy-consensus
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20221221/e9bb0ab4/signature.asc>

From andrew at openjdk.org  Thu Dec 22 01:00:59 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 22 Dec 2022 01:00:59 GMT
Subject: [jdk8u] RFR: 8296715: CLDR v42 update for tzdata 2022f
In-Reply-To: <Tz0bMWTr7dp5pJiREaScQ8HfT91jdkZkkH8cKk0_-7A=.f8b25787-1ebb-4787-954e-e0704aa1b12d@github.com>
References: <Tz0bMWTr7dp5pJiREaScQ8HfT91jdkZkkH8cKk0_-7A=.f8b25787-1ebb-4787-954e-e0704aa1b12d@github.com>
Message-ID: <YdJEQ-I_zsCb0TnfAndRwjmQezQIfTp3ZxxtJcuRHis=.11ae01c4-1e8b-4655-a997-d44e8ccd6a55@github.com>

On Tue, 20 Dec 2022 18:45:39 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is a minimal backport of the CLDR v42 update for tzdata 2022f, just containing the timezone changes. The previous definition for `America/Chihuahua`, which is superseded by the change to `America_Central` on 2022-10-30, is retained as `America_Mountain` as `Mexico_Pacific` doesn't exist in 8u's version of CLDR and the change here is to define an end to that metazone, not alter it.
> 
> The other changes are omitted as follows:
> 
> * The `es_419.xml` in 8u's CLDR does not contain the patterns being altered.
> * `LocaleData.cldr` does not exist in 8u
> * `LocaleDataTest.java` does not need updating as the test has not been changed, as there is no data file change (`LocaleData.cldr`)
> 
> Regarding the latter two, the CLDR checks in the test were introduced as part of JDK-8008577: "Use CLDR Locale Data by Default". We obviously don't want to backport that in full, but updating LocaleDataTest.java with a CLDR data set would be useful.
> 
> However, I think it's out of scope for a rampdown time critical data fix like this, as it is likely a lengthy effort to get a passing data set, needing further CLDR updates. It should be handled separately. I'll open a bug and PR for this against 8u-dev.

I see `jdk8u-critical-yes`.

-------------

PR: https://git.openjdk.org/jdk8u/pull/27

From andrew at openjdk.org  Thu Dec 22 01:01:00 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 22 Dec 2022 01:01:00 GMT
Subject: [jdk8u] Integrated: 8296715: CLDR v42 update for tzdata 2022f
In-Reply-To: <Tz0bMWTr7dp5pJiREaScQ8HfT91jdkZkkH8cKk0_-7A=.f8b25787-1ebb-4787-954e-e0704aa1b12d@github.com>
References: <Tz0bMWTr7dp5pJiREaScQ8HfT91jdkZkkH8cKk0_-7A=.f8b25787-1ebb-4787-954e-e0704aa1b12d@github.com>
Message-ID: <VT4KSRY-8QQA9tFM_E_XKN1liZZ7GYHBBsE4QEmD0nA=.fec91dc4-1083-4187-a910-ac670a4b524b@github.com>

On Tue, 20 Dec 2022 18:45:39 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is a minimal backport of the CLDR v42 update for tzdata 2022f, just containing the timezone changes. The previous definition for `America/Chihuahua`, which is superseded by the change to `America_Central` on 2022-10-30, is retained as `America_Mountain` as `Mexico_Pacific` doesn't exist in 8u's version of CLDR and the change here is to define an end to that metazone, not alter it.
> 
> The other changes are omitted as follows:
> 
> * The `es_419.xml` in 8u's CLDR does not contain the patterns being altered.
> * `LocaleData.cldr` does not exist in 8u
> * `LocaleDataTest.java` does not need updating as the test has not been changed, as there is no data file change (`LocaleData.cldr`)
> 
> Regarding the latter two, the CLDR checks in the test were introduced as part of JDK-8008577: "Use CLDR Locale Data by Default". We obviously don't want to backport that in full, but updating LocaleDataTest.java with a CLDR data set would be useful.
> 
> However, I think it's out of scope for a rampdown time critical data fix like this, as it is likely a lengthy effort to get a passing data set, needing further CLDR updates. It should be handled separately. I'll open a bug and PR for this against 8u-dev.

This pull request has now been integrated.

Changeset: 518047d8
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u/commit/518047d8781988191b982b33839c4b4ea9f280e1
Stats:     6 lines in 1 file changed: 2 ins; 0 del; 4 mod

8296715: CLDR v42 update for tzdata 2022f

Reviewed-by: dcherepanov, sgehwolf
Backport-of: da9de488990ff47fe06343439f2180ec1b2a3061

-------------

PR: https://git.openjdk.org/jdk8u/pull/27

From andrew at openjdk.org  Thu Dec 22 01:11:48 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 22 Dec 2022 01:11:48 GMT
Subject: [jdk8u] RFR: 8297804: (tz) Update Timezone Data to 2022g [v2]
In-Reply-To: <ExYVcmuR90wTnE8HkNi4iLLMFcPT2157q_Mpo9wanO4=.164b6c84-25b7-403c-8b5f-dbe10ab27385@github.com>
References: <ExYVcmuR90wTnE8HkNi4iLLMFcPT2157q_Mpo9wanO4=.164b6c84-25b7-403c-8b5f-dbe10ab27385@github.com>
Message-ID: <2GdMxamxYPDkKzoYw1gH60L7XDe40W-YwW2ecc-vCFg=.fab3f377-1c57-40aa-969c-bee2b40a4eac@github.com>

> This is a mostly clean backport of the latest tzdata update.
> 
> This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato.
> 
> Changes from the {11,13,15,17,19}u and 20 versions:
> * `timezone.xml` does not exist in 8u so the addition there is omitted
> * In `metaZones.xml`, `America_Mountain` is used instead of `Mexico_Pacific`. This is consistent with [PR27](https://github.com/openjdk/jdk8u/pull/27) on top of which this PR is based (`America/Ciudad_Juarez` splits from `America/Ojinaga`). 8u does not contain definitions for `Mexico_Pacific`.
> * The tzdata updates are duplicated in `jdk/test/sun/util/calendar/zi/tzdata`, as currently required for 8u testing.
> 
> Tests in `java/util/TimeZone`, `java/time/test`, `sun/util/calendar`, `sun/util/resources` and `sun/text/resources` all pass.  The rearguard changes are identical to those for vanguard, as verified against the rearguard data generated using `make rearguard_tarballs` in the tzdata2022g distribution.
> 
> Thanks!

Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  Backport ce896731d38866c2bf99cd49525062e150d94160

-------------

Changes: https://git.openjdk.org/jdk8u/pull/28/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=28&range=01
  Stats: 442 lines in 34 files changed: 255 ins; 112 del; 75 mod
  Patch: https://git.openjdk.org/jdk8u/pull/28.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u pull/28/head:pull/28

PR: https://git.openjdk.org/jdk8u/pull/28

From andrew at openjdk.org  Thu Dec 22 01:11:48 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 22 Dec 2022 01:11:48 GMT
Subject: [jdk8u] RFR: 8297804: (tz) Update Timezone Data to 2022g
In-Reply-To: <ExYVcmuR90wTnE8HkNi4iLLMFcPT2157q_Mpo9wanO4=.164b6c84-25b7-403c-8b5f-dbe10ab27385@github.com>
References: <ExYVcmuR90wTnE8HkNi4iLLMFcPT2157q_Mpo9wanO4=.164b6c84-25b7-403c-8b5f-dbe10ab27385@github.com>
Message-ID: <bxk0L6GZfMDPCYQR-WoEfNP1tFL6RZUE8IwYqow1lFM=.58528d1f-a449-4040-b2c5-e13455706b73@github.com>

On Wed, 21 Dec 2022 04:16:21 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is a mostly clean backport of the latest tzdata update.
> 
> This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato.
> 
> Changes from the {11,13,15,17,19}u and 20 versions:
> * `timezone.xml` does not exist in 8u so the addition there is omitted
> * In `metaZones.xml`, `America_Mountain` is used instead of `Mexico_Pacific`. This is consistent with [PR27](https://github.com/openjdk/jdk8u/pull/27) on top of which this PR is based (`America/Ciudad_Juarez` splits from `America/Ojinaga`). 8u does not contain definitions for `Mexico_Pacific`.
> * The tzdata updates are duplicated in `jdk/test/sun/util/calendar/zi/tzdata`, as currently required for 8u testing.
> 
> Tests in `java/util/TimeZone`, `java/time/test`, `sun/util/calendar`, `sun/util/resources` and `sun/text/resources` all pass.  The rearguard changes are identical to those for vanguard, as verified against the rearguard data generated using `make rearguard_tarballs` in the tzdata2022g distribution.
> 
> Thanks!

I see `jdk8u-critical-yes`.

-------------

PR: https://git.openjdk.org/jdk8u/pull/28

From andrew at openjdk.org  Thu Dec 22 01:11:49 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 22 Dec 2022 01:11:49 GMT
Subject: [jdk8u] RFR: 8297804: (tz) Update Timezone Data to 2022g
In-Reply-To: <bxk0L6GZfMDPCYQR-WoEfNP1tFL6RZUE8IwYqow1lFM=.58528d1f-a449-4040-b2c5-e13455706b73@github.com>
References: <ExYVcmuR90wTnE8HkNi4iLLMFcPT2157q_Mpo9wanO4=.164b6c84-25b7-403c-8b5f-dbe10ab27385@github.com>
 <bxk0L6GZfMDPCYQR-WoEfNP1tFL6RZUE8IwYqow1lFM=.58528d1f-a449-4040-b2c5-e13455706b73@github.com>
Message-ID: <1hYwc4BM6XAyRiaWNFGzWSwy2uQ96xcdcicqU6lzS8o=.1d1510ad-8be5-449f-8e9f-567646b96827@github.com>

On Thu, 22 Dec 2022 01:05:01 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> This is a mostly clean backport of the latest tzdata update.
>> 
>> This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>> 
>> The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato.
>> 
>> Changes from the {11,13,15,17,19}u and 20 versions:
>> * `timezone.xml` does not exist in 8u so the addition there is omitted
>> * In `metaZones.xml`, `America_Mountain` is used instead of `Mexico_Pacific`. This is consistent with [PR27](https://github.com/openjdk/jdk8u/pull/27) on top of which this PR is based (`America/Ciudad_Juarez` splits from `America/Ojinaga`). 8u does not contain definitions for `Mexico_Pacific`.
>> * The tzdata updates are duplicated in `jdk/test/sun/util/calendar/zi/tzdata`, as currently required for 8u testing.
>> 
>> Tests in `java/util/TimeZone`, `java/time/test`, `sun/util/calendar`, `sun/util/resources` and `sun/text/resources` all pass.  The rearguard changes are identical to those for vanguard, as verified against the rearguard data generated using `make rearguard_tarballs` in the tzdata2022g distribution.
>> 
>> Thanks!
>
> I see `jdk8u-critical-yes`.

> @gnu-andrew Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See [OpenJDK Developers? Guide](https://openjdk.org/guide/#working-with-pull-requests) for more information.

Rebasing is the right thing to do here, as Git will replace the commit from the dependent PR with the one that's been pushed. No point doing unnecessary work merging them.

-------------

PR: https://git.openjdk.org/jdk8u/pull/28

From andrew at openjdk.org  Thu Dec 22 01:11:49 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 22 Dec 2022 01:11:49 GMT
Subject: [jdk8u] Integrated: 8297804: (tz) Update Timezone Data to 2022g
In-Reply-To: <ExYVcmuR90wTnE8HkNi4iLLMFcPT2157q_Mpo9wanO4=.164b6c84-25b7-403c-8b5f-dbe10ab27385@github.com>
References: <ExYVcmuR90wTnE8HkNi4iLLMFcPT2157q_Mpo9wanO4=.164b6c84-25b7-403c-8b5f-dbe10ab27385@github.com>
Message-ID: <smz4hwZA3ezRc5A5ktx1qaYrEH4AZAjw0L-UxZqml1U=.85992181-281f-4c65-bb00-347a774a8fac@github.com>

On Wed, 21 Dec 2022 04:16:21 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is a mostly clean backport of the latest tzdata update.
> 
> This pull request contains a backport of commit [ce896731](https://github.com/openjdk/jdk/commit/ce896731d38866c2bf99cd49525062e150d94160) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato.
> 
> Changes from the {11,13,15,17,19}u and 20 versions:
> * `timezone.xml` does not exist in 8u so the addition there is omitted
> * In `metaZones.xml`, `America_Mountain` is used instead of `Mexico_Pacific`. This is consistent with [PR27](https://github.com/openjdk/jdk8u/pull/27) on top of which this PR is based (`America/Ciudad_Juarez` splits from `America/Ojinaga`). 8u does not contain definitions for `Mexico_Pacific`.
> * The tzdata updates are duplicated in `jdk/test/sun/util/calendar/zi/tzdata`, as currently required for 8u testing.
> 
> Tests in `java/util/TimeZone`, `java/time/test`, `sun/util/calendar`, `sun/util/resources` and `sun/text/resources` all pass.  The rearguard changes are identical to those for vanguard, as verified against the rearguard data generated using `make rearguard_tarballs` in the tzdata2022g distribution.
> 
> Thanks!

This pull request has now been integrated.

Changeset: c961cb9f
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u/commit/c961cb9f676cbb05e8fa28b7ca9d41b02fc83d3d
Stats:     442 lines in 34 files changed: 255 ins; 112 del; 75 mod

8297804: (tz) Update Timezone Data to 2022g

Reviewed-by: dcherepanov, sgehwolf
Backport-of: ce896731d38866c2bf99cd49525062e150d94160

-------------

PR: https://git.openjdk.org/jdk8u/pull/28

From duke at openjdk.org  Thu Dec 22 06:53:50 2022
From: duke at openjdk.org (Kurashige Taizo)
Date: Thu, 22 Dec 2022 06:53:50 GMT
Subject: [jdk8u-dev] RFR: 8284977:
 MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't
 exist [v2]
In-Reply-To: <Kt7Rt8OOSHKyEhEPMIgHrRYtpCMmlt1twsMuO_GV1HU=.e709b1db-4eae-4f79-ab85-6dc67717af98@github.com>
References: <Kt7Rt8OOSHKyEhEPMIgHrRYtpCMmlt1twsMuO_GV1HU=.e709b1db-4eae-4f79-ab85-6dc67717af98@github.com>
Message-ID: <kkN32J6dLhFdcTDKaIDppX0TjvLFiTsoqIqe2z89ppc=.e4a25104-6aff-433e-bc65-f7eae90df032@github.com>

> Hi all,
> 
> I'd like to backport this to jdk8u-dev.
> It fixes a test failure caused by cgroups virtual files (nr_periods etc) not existing in some circumstances.
> 
> Thanks.

Kurashige Taizo has updated the pull request incrementally with one additional commit since the last revision:

  Update full name

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/215/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/215/files/3bcfa1d5..4bbc576b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=215&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=215&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/215.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/215/head:pull/215

PR: https://git.openjdk.org/jdk8u-dev/pull/215

From duke at openjdk.org  Thu Dec 22 09:57:04 2022
From: duke at openjdk.org (Kurashige Taizo)
Date: Thu, 22 Dec 2022 09:57:04 GMT
Subject: [jdk8u-dev] RFR: 8284977:
 MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't
 exist
In-Reply-To: <fjGt7z4TsLxrpZ-j7kVSgJoVPDKHvoSXjir6SMgIg_4=.62de6adf-0c3c-43eb-8c78-bd06889c8a2c@github.com>
References: <Kt7Rt8OOSHKyEhEPMIgHrRYtpCMmlt1twsMuO_GV1HU=.e709b1db-4eae-4f79-ab85-6dc67717af98@github.com>
 <5rQOyonuSq4SXFelD5yv9n8230spihU_q6HLLVa5CT8=.15485209-91d8-4fc1-8e59-106346aeae8c@github.com>
 <lhE1SYdVQ66SjReYEgmNzeUbl9pijPdY1kAnHYY9auY=.db89b5c2-9955-4006-86f7-22388e586754@github.com>
 <fjGt7z4TsLxrpZ-j7kVSgJoVPDKHvoSXjir6SMgIg_4=.62de6adf-0c3c-43eb-8c78-bd06889c8a2c@github.com>
Message-ID: <jI2gZ8TpohOXF8SD359pW7S7NKC1WbWYOUKDQRP94Pw=.758c9512-c55f-44af-883e-b0f675b4ba87@github.com>

On Wed, 21 Dec 2022 09:51:02 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> @jerboaa I'm sorry for some mistakes.  I fixed PR title and enabled GHA testing. Is that all right?
>
> @kurashige23 Please proceed with applying for JDK 8u backports approval as described in `Contributing` section here:
> https://wiki.openjdk.org/display/jdk8u

@jerboaa Thank you for giving the link.
Should I add the 'jdk8u-fix-request' label? But I don't have access to the OpenJDK bug system. If possible, Could you please add a label for me?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/215

From sgehwolf at openjdk.org  Thu Dec 22 15:50:51 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 22 Dec 2022 15:50:51 GMT
Subject: [jdk8u] RFR: 8280890: Cannot use '-Djava.system.class.loader' with
 class loader in signed JAR
Message-ID: <7I8_bs2Utq2tyqZczA1kcWdvGyKMJpjQRd5n2EVHJ2E=.63eab354-c55c-47a5-9e5c-abf1a31111b4@github.com>

Please review this critical fix which fixes a regression introduced with with [JDK-8269039: Disable SHA-1 Signed JARs](https://bugs.openjdk.org/browse/JDK-8269039) which was included in `8u362` (note that `8u352` is not affected as  JDK-8269039 is not there). This should be low-risk as it mainly removes use of `java.util.Calendar` API usage in `DisabledAlgorithmConstraints` which can cause issues with applications that contain `CalendarDataProvider`s in signed jars.

Proposing as critical fix so that we don't regress in that regard in 8u362.

Please review this backport. The changes in `keytool/Main.java` didn't apply. Those aren't critical changes for this patch, so I've omitted them. In addition, the test needed some changes to make it work with JDK 8 (comparing to the 11u version). Used `IOUtils.readAllBytes()` over `InputStream.readAllBytes()` in the custom classloader class, fixed some test lib imports and declared `Throwable` to be thrown in `main` as `ProcessTools.executeProcess` throws `Throwable` over `Exception` in 8u.

Regression test fails prior (current jdk8u tree, without this patch) and passes after the product fix.

-------------

Commit messages:
 - 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR

Changes: https://git.openjdk.org/jdk8u/pull/29/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=29&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8280890
  Stats: 171 lines in 3 files changed: 140 ins; 15 del; 16 mod
  Patch: https://git.openjdk.org/jdk8u/pull/29.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u pull/29/head:pull/29

PR: https://git.openjdk.org/jdk8u/pull/29

From sgehwolf at openjdk.org  Thu Dec 22 15:50:51 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 22 Dec 2022 15:50:51 GMT
Subject: [jdk8u] RFR: 8280890: Cannot use '-Djava.system.class.loader' with
 class loader in signed JAR
In-Reply-To: <7I8_bs2Utq2tyqZczA1kcWdvGyKMJpjQRd5n2EVHJ2E=.63eab354-c55c-47a5-9e5c-abf1a31111b4@github.com>
References: <7I8_bs2Utq2tyqZczA1kcWdvGyKMJpjQRd5n2EVHJ2E=.63eab354-c55c-47a5-9e5c-abf1a31111b4@github.com>
Message-ID: <SuXmF_s1o0cWX4LeMTGQCNpMHWVC6RJy9KTg-UF6fjo=.b8d73030-afd0-4d94-9d7d-522f0aab192e@github.com>

On Thu, 22 Dec 2022 15:43:20 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this critical fix which fixes a regression introduced with with [JDK-8269039: Disable SHA-1 Signed JARs](https://bugs.openjdk.org/browse/JDK-8269039) which was included in `8u362` (note that `8u352` is not affected as  JDK-8269039 is not there). This should be low-risk as it mainly removes use of `java.util.Calendar` API usage in `DisabledAlgorithmConstraints` which can cause issues with applications that contain `CalendarDataProvider`s in signed jars.
> 
> Proposing as critical fix so that we don't regress in that regard in 8u362.
> 
> Please review this backport. The changes in `keytool/Main.java` didn't apply. Those aren't critical changes for this patch, so I've omitted them. In addition, the test needed some changes to make it work with JDK 8 (comparing to the 11u version). Used `IOUtils.readAllBytes()` over `InputStream.readAllBytes()` in the custom classloader class, fixed some test lib imports and declared `Throwable` to be thrown in `main` as `ProcessTools.executeProcess` throws `Throwable` over `Exception` in 8u.
> 
> Regression test fails prior (current jdk8u tree, without this patch) and passes after the product fix.

@gnu-andrew @martinuy Can you please help review this? Thanks!

-------------

PR: https://git.openjdk.org/jdk8u/pull/29

From sgehwolf at openjdk.org  Thu Dec 22 17:17:54 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 22 Dec 2022 17:17:54 GMT
Subject: [jdk8u-dev] RFR: 8284977:
 MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't
 exist
In-Reply-To: <jI2gZ8TpohOXF8SD359pW7S7NKC1WbWYOUKDQRP94Pw=.758c9512-c55f-44af-883e-b0f675b4ba87@github.com>
References: <Kt7Rt8OOSHKyEhEPMIgHrRYtpCMmlt1twsMuO_GV1HU=.e709b1db-4eae-4f79-ab85-6dc67717af98@github.com>
 <5rQOyonuSq4SXFelD5yv9n8230spihU_q6HLLVa5CT8=.15485209-91d8-4fc1-8e59-106346aeae8c@github.com>
 <lhE1SYdVQ66SjReYEgmNzeUbl9pijPdY1kAnHYY9auY=.db89b5c2-9955-4006-86f7-22388e586754@github.com>
 <fjGt7z4TsLxrpZ-j7kVSgJoVPDKHvoSXjir6SMgIg_4=.62de6adf-0c3c-43eb-8c78-bd06889c8a2c@github.com>
 <jI2gZ8TpohOXF8SD359pW7S7NKC1WbWYOUKDQRP94Pw=.758c9512-c55f-44af-883e-b0f675b4ba87@github.com>
Message-ID: <vcEVsgKFFr8qRc2Zy5KaZ12Vns4fTUGNVqT6WcxZALs=.a610b5e1-2c15-496a-b5fa-d859baf95c39@github.com>

On Thu, 22 Dec 2022 09:54:04 GMT, Kurashige Taizo <duke at openjdk.org> wrote:

> Should I add the 'jdk8u-fix-request' label? But I don't have access to the OpenJDK bug system. If possible, Could you please add a label for me?

Yes. I've added them for you and approved as it's a test-only bug. Feel free to integrate.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/215

From andrew at openjdk.org  Fri Dec 23 00:49:55 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 23 Dec 2022 00:49:55 GMT
Subject: [jdk8u] RFR: 8280890: Cannot use '-Djava.system.class.loader' with
 class loader in signed JAR
In-Reply-To: <7I8_bs2Utq2tyqZczA1kcWdvGyKMJpjQRd5n2EVHJ2E=.63eab354-c55c-47a5-9e5c-abf1a31111b4@github.com>
References: <7I8_bs2Utq2tyqZczA1kcWdvGyKMJpjQRd5n2EVHJ2E=.63eab354-c55c-47a5-9e5c-abf1a31111b4@github.com>
Message-ID: <sVU4XMj9La9JIfO3UlkYdHvIwDQtmMOQrx6jOq_OhMs=.db919120-e23d-40ee-b66d-d7ccbbcac05c@github.com>

On Thu, 22 Dec 2022 15:43:20 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this critical fix which fixes a regression introduced with with [JDK-8269039: Disable SHA-1 Signed JARs](https://bugs.openjdk.org/browse/JDK-8269039) which was included in `8u362` (note that `8u352` is not affected as  JDK-8269039 is not there). This should be low-risk as it mainly removes use of `java.util.Calendar` API usage in `DisabledAlgorithmConstraints` which can cause issues with applications that contain `CalendarDataProvider`s in signed jars.
> 
> Proposing as critical fix so that we don't regress in that regard in 8u362.
> 
> Please review this backport. The changes in `keytool/Main.java` didn't apply. Those aren't critical changes for this patch, so I've omitted them. In addition, the test needed some changes to make it work with JDK 8 (comparing to the 11u version). Used `IOUtils.readAllBytes()` over `InputStream.readAllBytes()` in the custom classloader class, fixed some test lib imports and declared `Throwable` to be thrown in `main` as `ProcessTools.executeProcess` throws `Throwable` over `Exception` in 8u.
> 
> Regression test fails prior (current jdk8u tree, without this patch) and passes after the product fix.

The keytool changes are from [JDK-8273236](https://bugs.openjdk.org/browse/JDK-8273236), another recent fix relating to this SHA-1 deprecation. If the SHA-1 deprecation itself had been integrated a bit earlier, it might have made 8u362.

I don't think that's critical enough to try and get in at this stage. I'll propose it for 8u-dev in the new year with the removals from this patch omitted.

The other changes look sensible. Can you enable actions so that builds & tests are run? Once they look good, I'll approve. Thanks.

-------------

PR: https://git.openjdk.org/jdk8u/pull/29

From duke at openjdk.org  Fri Dec 23 09:50:07 2022
From: duke at openjdk.org (Kurashige Taizo)
Date: Fri, 23 Dec 2022 09:50:07 GMT
Subject: [jdk8u-dev] Integrated: 8284977:
 MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't
 exist
In-Reply-To: <Kt7Rt8OOSHKyEhEPMIgHrRYtpCMmlt1twsMuO_GV1HU=.e709b1db-4eae-4f79-ab85-6dc67717af98@github.com>
References: <Kt7Rt8OOSHKyEhEPMIgHrRYtpCMmlt1twsMuO_GV1HU=.e709b1db-4eae-4f79-ab85-6dc67717af98@github.com>
Message-ID: <_uuekoEIeGXrrdrrlvtk_FsqduMnWu69q2MMdt78saA=.341f03bf-02a5-4e15-9030-31f619ad4cc7@github.com>

On Tue, 20 Dec 2022 08:07:14 GMT, Kurashige Taizo <duke at openjdk.org> wrote:

> Hi all,
> 
> I'd like to backport this to jdk8u-dev.
> It fixes a test failure caused by cgroups virtual files (nr_periods etc) not existing in some circumstances.
> 
> Thanks.

This pull request has now been integrated.

Changeset: b4a745d2
Author:    Kurashige Taizo <kurashige.taizo at fujitsu.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/b4a745d2f8b7ba78c51b4a4ec837cd636a93fa51
Stats:     5 lines in 1 file changed: 5 ins; 0 del; 0 mod

8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist

Backport-of: 444a0d98ac06ab043e3b11281234fd515abff302

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/215

From sgehwolf at openjdk.org  Fri Dec 23 09:51:58 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 23 Dec 2022 09:51:58 GMT
Subject: [jdk8u] RFR: 8280890: Cannot use '-Djava.system.class.loader' with
 class loader in signed JAR
In-Reply-To: <sVU4XMj9La9JIfO3UlkYdHvIwDQtmMOQrx6jOq_OhMs=.db919120-e23d-40ee-b66d-d7ccbbcac05c@github.com>
References: <7I8_bs2Utq2tyqZczA1kcWdvGyKMJpjQRd5n2EVHJ2E=.63eab354-c55c-47a5-9e5c-abf1a31111b4@github.com>
 <sVU4XMj9La9JIfO3UlkYdHvIwDQtmMOQrx6jOq_OhMs=.db919120-e23d-40ee-b66d-d7ccbbcac05c@github.com>
Message-ID: <6ffgsh2k-kR_D0IUt-JgKa17qyvyuN-fxQPU6vyPGmc=.068fd0ac-5b9b-4f93-af85-6a9b59319bcd@github.com>

On Fri, 23 Dec 2022 00:46:59 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> The keytool changes are from [JDK-8273236](https://bugs.openjdk.org/browse/JDK-8273236), another recent fix relating to this SHA-1 deprecation. If the SHA-1 deprecation itself had been integrated a bit earlier, it might have made 8u362.
> 
> I don't think that's critical enough to try and get in at this stage. I'll propose it for 8u-dev in the new year with the removals from this patch omitted.
> 
> The other changes look sensible. Can you enable actions so that builds & tests are run? Once they look good, I'll approve. Thanks.

OK

-------------

PR: https://git.openjdk.org/jdk8u/pull/29

From jdowland at openjdk.org  Fri Dec 23 10:07:49 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 23 Dec 2022 10:07:49 GMT
Subject: [jdk8u-dev] RFR: 8293472: Incorrect container resource limit
 detection if manual cgroup fs mounts present [v2]
In-Reply-To: <Ksj9nZH4artzUaE79STM8qFs-oa-acIIJKPbclKHAJc=.7ccf8f04-15ff-45c7-845b-bf032d722492@github.com>
References: <Ksj9nZH4artzUaE79STM8qFs-oa-acIIJKPbclKHAJc=.7ccf8f04-15ff-45c7-845b-bf032d722492@github.com>
Message-ID: <MOhm4Zk5Ptf2e7PsPwOFdt03rzi-vVIwM0mNEZAyAGM=.9b6de886-e65a-40ef-98c7-f12611cb9d57@github.com>

> This is a backport of 8293472 to 8u for cgroups v2 support. Not clean: log_debug?tty->print_cr and Files.writeString ? Files.write() needed, as well as adjustments for the lack of [8266490](https://bugs.openjdk.org/browse/JDK-8266490) (PID controller support) in 8u.

Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:

  remove testJavaVersionWithCgMounts
  
  As Severin points out, this test is not useful (in its current form)
  for 8u.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/216/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/216/files/5576837e..daae4588

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=216&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=216&range=00-01

  Stats: 14 lines in 1 file changed: 0 ins; 14 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/216.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/216/head:pull/216

PR: https://git.openjdk.org/jdk8u-dev/pull/216

From sgehwolf at openjdk.org  Fri Dec 23 12:38:00 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 23 Dec 2022 12:38:00 GMT
Subject: [jdk8u-dev] RFR: 8293472: Incorrect container resource limit
 detection if manual cgroup fs mounts present [v2]
In-Reply-To: <MOhm4Zk5Ptf2e7PsPwOFdt03rzi-vVIwM0mNEZAyAGM=.9b6de886-e65a-40ef-98c7-f12611cb9d57@github.com>
References: <Ksj9nZH4artzUaE79STM8qFs-oa-acIIJKPbclKHAJc=.7ccf8f04-15ff-45c7-845b-bf032d722492@github.com>
 <MOhm4Zk5Ptf2e7PsPwOFdt03rzi-vVIwM0mNEZAyAGM=.9b6de886-e65a-40ef-98c7-f12611cb9d57@github.com>
Message-ID: <-jKPwPOE_tI7asCBTOmaVzriQLCJ83fOYg3CUaX9mhY=.660e8dde-9019-4a22-b4f8-d5c9352f7bf5@github.com>

On Fri, 23 Dec 2022 10:07:49 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8293472 to 8u for cgroups v2 support. Not clean: log_debug?tty->print_cr and Files.writeString ? Files.write() needed, as well as adjustments for the lack of [8266490](https://bugs.openjdk.org/browse/JDK-8266490) (PID controller support) in 8u.
>
> Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove testJavaVersionWithCgMounts
>   
>   As Severin points out, this test is not useful (in its current form)
>   for 8u.

Looks good to me now.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/216

From duke at openjdk.org  Fri Dec 23 13:18:53 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Fri, 23 Dec 2022 13:18:53 GMT
Subject: [jdk8u-dev] Integrated: 8297996: [8u] generated images are broken due
 to renaming of MSVC runtime DLL's
In-Reply-To: <rBE3rNSo7kYwJuUUbJ-CPDin9z8f0urlq3SOHvG09PA=.c902b393-e0f7-4e77-8163-8dd0ce54ea52@github.com>
References: <rBE3rNSo7kYwJuUUbJ-CPDin9z8f0urlq3SOHvG09PA=.c902b393-e0f7-4e77-8163-8dd0ce54ea52@github.com>
Message-ID: <Wezmh5bNW2TzX52pJPjpz6iQmAZfAU0yhgo1dcjuqLw=.96f87b92-660c-4b45-be20-95d2d5c3713c@github.com>

On Mon, 5 Dec 2022 08:25:37 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> The patch fixes Windows image generation with proper VC runtime DLL names. The problem is that MSVS2019 uses two DLL's `vcruntime140.dll` and `vcruntime140_1.dll` and their names conflict under 8.3 limitation. For this reason the [BASIC_MAKE_WINDOWS_SPACE_SAFE_CYGWIN](https://github.com/openjdk/jdk8u-dev/blob/c9007cd44db764fbd791218c6f38491f38af70c2/common/autoconf/basics_windows.m4#L53) renames DLL's to

This pull request has now been integrated.

Changeset: 47090d6f
Author:    Alexey Pavlyutkin <apavlyutkin at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/47090d6f9572adec1f31260702ff0039a7a70ee4
Stats:     849 lines in 3 files changed: 848 ins; 0 del; 1 mod

8297996: [8u] generated images are broken due to renaming of MSVC runtime DLL's

Reviewed-by: phh

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/203

From andrew at openjdk.org  Fri Dec 23 16:27:01 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 23 Dec 2022 16:27:01 GMT
Subject: [jdk8u] RFR: 8280890: Cannot use '-Djava.system.class.loader' with
 class loader in signed JAR
In-Reply-To: <7I8_bs2Utq2tyqZczA1kcWdvGyKMJpjQRd5n2EVHJ2E=.63eab354-c55c-47a5-9e5c-abf1a31111b4@github.com>
References: <7I8_bs2Utq2tyqZczA1kcWdvGyKMJpjQRd5n2EVHJ2E=.63eab354-c55c-47a5-9e5c-abf1a31111b4@github.com>
Message-ID: <GYtt6aeWC6FHbgLIyv2Bjvo1bazLFULaXpGvbM6MZKw=.6e029439-558e-4706-9c5f-67593a0ed3cd@github.com>

On Thu, 22 Dec 2022 15:43:20 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this critical fix which fixes a regression introduced with with [JDK-8269039: Disable SHA-1 Signed JARs](https://bugs.openjdk.org/browse/JDK-8269039) which was included in `8u362` (note that `8u352` is not affected as  JDK-8269039 is not there). This should be low-risk as it mainly removes use of `java.util.Calendar` API usage in `DisabledAlgorithmConstraints` which can cause issues with applications that contain `CalendarDataProvider`s in signed jars.
> 
> Proposing as critical fix so that we don't regress in that regard in 8u362.
> 
> Please review this backport. The changes in `keytool/Main.java` didn't apply. Those aren't critical changes for this patch, so I've omitted them. In addition, the test needed some changes to make it work with JDK 8 (comparing to the 11u version). Used `IOUtils.readAllBytes()` over `InputStream.readAllBytes()` in the custom classloader class, fixed some test lib imports and declared `Throwable` to be thrown in `main` as `ProcessTools.executeProcess` throws `Throwable` over `Exception` in 8u.
> 
> Regression test fails prior (current jdk8u tree, without this patch) and passes after the product fix.

Thanks, I see tests running now at https://github.com/jerboaa/jdk8u/actions/runs/3766931919

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u/pull/29

From sgehwolf at openjdk.org  Fri Dec 23 16:33:50 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 23 Dec 2022 16:33:50 GMT
Subject: [jdk8u] RFR: 8280890: Cannot use '-Djava.system.class.loader' with
 class loader in signed JAR
In-Reply-To: <7I8_bs2Utq2tyqZczA1kcWdvGyKMJpjQRd5n2EVHJ2E=.63eab354-c55c-47a5-9e5c-abf1a31111b4@github.com>
References: <7I8_bs2Utq2tyqZczA1kcWdvGyKMJpjQRd5n2EVHJ2E=.63eab354-c55c-47a5-9e5c-abf1a31111b4@github.com>
Message-ID: <R-sneghIUCQNSCjxXPZrvPkpJsLENMx5xA-VaUlWKE0=.429b00b2-9ed2-411d-8f0c-136247c4149f@github.com>

On Thu, 22 Dec 2022 15:43:20 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this critical fix which fixes a regression introduced with with [JDK-8269039: Disable SHA-1 Signed JARs](https://bugs.openjdk.org/browse/JDK-8269039) which was included in `8u362` (note that `8u352` is not affected as  JDK-8269039 is not there). This should be low-risk as it mainly removes use of `java.util.Calendar` API usage in `DisabledAlgorithmConstraints` which can cause issues with applications that contain `CalendarDataProvider`s in signed jars.
> 
> Proposing as critical fix so that we don't regress in that regard in 8u362.
> 
> Please review this backport. The changes in `keytool/Main.java` didn't apply. Those aren't critical changes for this patch, so I've omitted them. In addition, the test needed some changes to make it work with JDK 8 (comparing to the 11u version). Used `IOUtils.readAllBytes()` over `InputStream.readAllBytes()` in the custom classloader class, fixed some test lib imports and declared `Throwable` to be thrown in `main` as `ProcessTools.executeProcess` throws `Throwable` over `Exception` in 8u.
> 
> Regression test fails prior (current jdk8u tree, without this patch) and passes after the product fix.

Thanks for the review, labelled the bug `jdk8u-critical-request` now.

-------------

PR: https://git.openjdk.org/jdk8u/pull/29

From andrew at openjdk.org  Fri Dec 23 16:33:51 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 23 Dec 2022 16:33:51 GMT
Subject: [jdk8u] RFR: 8280890: Cannot use '-Djava.system.class.loader' with
 class loader in signed JAR
In-Reply-To: <7I8_bs2Utq2tyqZczA1kcWdvGyKMJpjQRd5n2EVHJ2E=.63eab354-c55c-47a5-9e5c-abf1a31111b4@github.com>
References: <7I8_bs2Utq2tyqZczA1kcWdvGyKMJpjQRd5n2EVHJ2E=.63eab354-c55c-47a5-9e5c-abf1a31111b4@github.com>
Message-ID: <NSclD55ll63LNJ-WI5fWLxJaiZJJDnoofxdBeWw4Ftw=.0fc4c8dd-a69e-41b2-b592-5ea5fca26982@github.com>

On Thu, 22 Dec 2022 15:43:20 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this critical fix which fixes a regression introduced with with [JDK-8269039: Disable SHA-1 Signed JARs](https://bugs.openjdk.org/browse/JDK-8269039) which was included in `8u362` (note that `8u352` is not affected as  JDK-8269039 is not there). This should be low-risk as it mainly removes use of `java.util.Calendar` API usage in `DisabledAlgorithmConstraints` which can cause issues with applications that contain `CalendarDataProvider`s in signed jars.
> 
> Proposing as critical fix so that we don't regress in that regard in 8u362.
> 
> Please review this backport. The changes in `keytool/Main.java` didn't apply. Those aren't critical changes for this patch, so I've omitted them. In addition, the test needed some changes to make it work with JDK 8 (comparing to the 11u version). Used `IOUtils.readAllBytes()` over `InputStream.readAllBytes()` in the custom classloader class, fixed some test lib imports and declared `Throwable` to be thrown in `main` as `ProcessTools.executeProcess` throws `Throwable` over `Exception` in 8u.
> 
> Regression test fails prior (current jdk8u tree, without this patch) and passes after the product fix.

> [JDK-8273236](https://bugs.openjdk.org/browse/JDK-8273236)



> Thanks for the review, labelled the bug `jdk8u-critical-request` now.

And approved.

-------------

PR: https://git.openjdk.org/jdk8u/pull/29

From sgehwolf at openjdk.org  Fri Dec 23 17:58:06 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 23 Dec 2022 17:58:06 GMT
Subject: [jdk8u] Integrated: 8280890: Cannot use '-Djava.system.class.loader'
 with class loader in signed JAR
In-Reply-To: <7I8_bs2Utq2tyqZczA1kcWdvGyKMJpjQRd5n2EVHJ2E=.63eab354-c55c-47a5-9e5c-abf1a31111b4@github.com>
References: <7I8_bs2Utq2tyqZczA1kcWdvGyKMJpjQRd5n2EVHJ2E=.63eab354-c55c-47a5-9e5c-abf1a31111b4@github.com>
Message-ID: <I3h9R6BbH_aXthbuSBkjBnaHXuJtsUCBnRW9gXxSdso=.4fe8bf6e-ae9e-406f-880c-6b070104f0a8@github.com>

On Thu, 22 Dec 2022 15:43:20 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this critical fix which fixes a regression introduced with with [JDK-8269039: Disable SHA-1 Signed JARs](https://bugs.openjdk.org/browse/JDK-8269039) which was included in `8u362` (note that `8u352` is not affected as  JDK-8269039 is not there). This should be low-risk as it mainly removes use of `java.util.Calendar` API usage in `DisabledAlgorithmConstraints` which can cause issues with applications that contain `CalendarDataProvider`s in signed jars.
> 
> Proposing as critical fix so that we don't regress in that regard in 8u362.
> 
> Please review this backport. The changes in `keytool/Main.java` didn't apply. Those aren't critical changes for this patch, so I've omitted them. In addition, the test needed some changes to make it work with JDK 8 (comparing to the 11u version). Used `IOUtils.readAllBytes()` over `InputStream.readAllBytes()` in the custom classloader class, fixed some test lib imports and declared `Throwable` to be thrown in `main` as `ProcessTools.executeProcess` throws `Throwable` over `Exception` in 8u.
> 
> Regression test fails prior (current jdk8u tree, without this patch) and passes after the product fix.

This pull request has now been integrated.

Changeset: ebc5e190
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u/commit/ebc5e190ac7a3b0c143451105d9f9b7d9e780a4b
Stats:     171 lines in 3 files changed: 140 ins; 15 del; 16 mod

8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR

Reviewed-by: andrew
Backport-of: a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d

-------------

PR: https://git.openjdk.org/jdk8u/pull/29

From duke at openjdk.org  Mon Dec 26 12:20:59 2022
From: duke at openjdk.org (ktakakuri)
Date: Mon, 26 Dec 2022 12:20:59 GMT
Subject: [jdk8u-dev] RFR: 8074883: Tab key should move to focused button in
 a button group
In-Reply-To: <gnhicSYWG9jUWfseV-S6QgNfUZ_QPWP_AjR_qRb9ous=.f78604d4-9e95-48ff-a205-67cc74a623a9@github.com>
References: <gnhicSYWG9jUWfseV-S6QgNfUZ_QPWP_AjR_qRb9ous=.f78604d4-9e95-48ff-a205-67cc74a623a9@github.com>
Message-ID: <GIqH6IIZ8R_nEAriM2_qReeROEKNVWHqGuYZOgFQu1o=.a3723d48-c76c-4a64-a2a2-a142be4a83f0@github.com>

On Fri, 16 Dec 2022 10:30:19 GMT, ktakakuri <duke at openjdk.org> wrote:

> This is a backport of JDK-8074883: Tab key should move to focused button in a button group.
> 
> I would like to backport the patch to OpenJDK8u.
> Original patch does not apply cleanly to 8u, because the fix uses a new API published in JDK9.
> 
> * Since RequestFocusController only determines whether or not to set focus, I modified it so that requestFocus/requestFocusInWindow is called by SwingUtilities.invokeLater() and re-set focus and return false.
> Without invokeLater(), the focus returns to the first button in case of Cause.ACTIVATION.
> 
> * ToggleButton.getGroupSelection() is defined as a package private method, because it must be called by JCompoennt.focusController.
> 
> * Calling requestFocus()/requestFocusInWindow() will be processed as Cause.UNKNOWN.
> ToggleButton.getGroupSelection() returns itself, so no circular call occurs.
> 
> * I moved Component.requestFocusController.acceptRequestFocus because RequestFocusContoroller is not called when Cause.ACTIVATION.
> 
> * Only Swing components replace default RequestFocusController to JComponent.focusController.
> The focusController returns true except for Swing, so this change does not affect other components.
> 
> Testing:
>  build on Windows x86_64
>  java/awt, javax/swing and ButtonGroupFocusTest.java on Windows x86_64

Could someone please review this backport?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/212

From duke at openjdk.org  Tue Dec 27 20:32:02 2022
From: duke at openjdk.org (Dan Lutker)
Date: Tue, 27 Dec 2022 20:32:02 GMT
Subject: [jdk8u-dev] Integrated: 8229182: [TESTBUG]
 runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12
In-Reply-To: <AReidlsEscE0n7lTUuWQWewAPV30L5ZQwlBpw3cjQR4=.0c2f7a7c-3a86-4746-872f-bbe2ec22916e@github.com>
References: <AReidlsEscE0n7lTUuWQWewAPV30L5ZQwlBpw3cjQR4=.0c2f7a7c-3a86-4746-872f-bbe2ec22916e@github.com>
Message-ID: <YVlckV14LA9-uSKTrec4304SPmrB9tB_QDk_aP23t-A=.a62320bd-3582-4e26-b334-ad2a4e2e8d27@github.com>

On Fri, 18 Nov 2022 23:48:11 GMT, Dan Lutker <duke at openjdk.org> wrote:

> Backporting JDK-8229182, did not apply cleanly and had to be manually fixed up.

This pull request has now been integrated.

Changeset: c5751e60
Author:    Dan Lutker <lutkerd at amazon.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/c5751e60a8f2a9e5f959b1fbc7fb2d91cd20ece4
Stats:     29 lines in 3 files changed: 18 ins; 0 del; 11 mod

8229182: [TESTBUG] runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12

Reviewed-by: phh
Backport-of: a41b9a71acdf69b78104677a1ca899ff36293a60

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/186

From sgehwolf at openjdk.org  Tue Dec 27 20:38:19 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 27 Dec 2022 20:38:19 GMT
Subject: [jdk8u-dev] RFR: 8289695: [TESTBUG] TestMemoryAwareness.java fails
 on cgroups v2 and crun [v2]
In-Reply-To: <5998AxvGX5tMLYgxru5nLdk635a0JDOgzsX5XqPOETk=.5eb7735b-83ce-4806-8213-e33143aa87c1@github.com>
References: <5998AxvGX5tMLYgxru5nLdk635a0JDOgzsX5XqPOETk=.5eb7735b-83ce-4806-8213-e33143aa87c1@github.com>
Message-ID: <gBCdVujmWFBds3i1E8FARgWD0CAX0jPMAyC3eMfRlpE=.3c5b9a65-de44-4e9c-9099-98899c657106@github.com>

> Clean backport. Fixes a test issue on cg v2 where `--memory-swappiness` is not supported.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/217/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/217/files/07ff7966..07ff7966

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=217&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=217&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/217.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/217/head:pull/217

PR: https://git.openjdk.org/jdk8u-dev/pull/217

From serb at openjdk.org  Thu Dec 29 00:55:54 2022
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 29 Dec 2022 00:55:54 GMT
Subject: [jdk8u-dev] RFR: 8074883: Tab key should move to focused button in
 a button group
In-Reply-To: <gnhicSYWG9jUWfseV-S6QgNfUZ_QPWP_AjR_qRb9ous=.f78604d4-9e95-48ff-a205-67cc74a623a9@github.com>
References: <gnhicSYWG9jUWfseV-S6QgNfUZ_QPWP_AjR_qRb9ous=.f78604d4-9e95-48ff-a205-67cc74a623a9@github.com>
Message-ID: <ikUhFMphDo4Ua2dydgY6bZvI2J8tLQ-iiq1AHe1wFO0=.76a50ea9-faa0-4f14-a97f-cb8827db1d13@github.com>

On Fri, 16 Dec 2022 10:30:19 GMT, ktakakuri <duke at openjdk.org> wrote:

> This is a backport of JDK-8074883: Tab key should move to focused button in a button group.
> 
> I would like to backport the patch to OpenJDK8u.
> Original patch does not apply cleanly to 8u, because the fix uses a new API published in JDK9.
> 
> * Since RequestFocusController only determines whether or not to set focus, I modified it so that requestFocus/requestFocusInWindow is called by SwingUtilities.invokeLater() and re-set focus and return false.
> Without invokeLater(), the focus returns to the first button in case of Cause.ACTIVATION.
> 
> * ToggleButton.getGroupSelection() is defined as a package private method, because it must be called by JCompoennt.focusController.
> 
> * Calling requestFocus()/requestFocusInWindow() will be processed as Cause.UNKNOWN.
> ToggleButton.getGroupSelection() returns itself, so no circular call occurs.
> 
> * I moved Component.requestFocusController.acceptRequestFocus because RequestFocusContoroller is not called when Cause.ACTIVATION.
> 
> * Only Swing components replace default RequestFocusController to JComponent.focusController.
> The focusController returns true except for Swing, so this change does not affect other components.
> 
> Testing:
>  build on Windows x86_64
>  java/awt, javax/swing and ButtonGroupFocusTest.java on Windows x86_64

Looking into this fiix

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/212

From gnu.andrew at redhat.com  Fri Dec 30 01:22:55 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Fri, 30 Dec 2022 01:22:55 +0000
Subject: [FREEZE] 8u362 NOW FROZEN
Message-ID: <Y649b3EUUXsatP5m@hex.discworld.ac.uk>

The release tree:

https://github.com/openjdk/jdk8u

is now frozen in preparation for release on or after 2023-01-17.

The final pre-release tag is jdk8u362-b07 [0].

The final release tag will be no lower than jdk8u362-b08.

[0] https://github.com/openjdk/jdk8u/releases/tag/jdk8u362-b07
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20221230/f4a6ec10/signature.asc>