[jdk8u-dev] Integrated: 8297329: [8u] hotspot needs to recognise VS2019

[Alexey Pavlyutkin]

On Mon, 21 Nov 2022 10:13:25 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Please review another portion of changes to add MSVS2019 support to jdk-8. This one adds recognition of MSVS2019 compiler/linker to the hotspot build scripts and applies build rules accordingly. Before the patch the scripts didn't not know how to link precompiled headers and builds failed with the error
> 
> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
> jvm.dll : fatal error LNK1120: 1 unresolved externals
> 
> 
> Verification: MSVS2019 (32/64-bits, release/debug) builds now fail with
> 
> awt_DCHolder.cpp
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(46): error C2039: 'Do_Not_Use_calloc_Use_safe_Calloc_Instead': is not a member of '`global namespace''
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(46): error C2873: 'Do_Not_Use_calloc_Use_safe_Calloc_Instead': symbol cannot be used in a using-declaration
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(52): error C2039: 'Do_Not_Use_malloc_Use_safe_Malloc_Instead': is not a member of '`global namespace''
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(52): error C2873: 'Do_Not_Use_malloc_Use_safe_Malloc_Instead': symbol cannot be used in a using-declaration
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(58): error C2039: 'Do_Not_Use_realloc_Use_safe_Realloc_Instead': is not a member of '`global namespace''
> slowdebug/jdk/objs/libawt/awt_DCHolder.obj] Error 2
> make[2]: *** Waiting for unfinished jobs....
> 
> that will be fixed by backporting of [JDK-8241087](https://bugs.openjdk.org/browse/JDK-8241087)
> 
> Regression: MSVS2017 (32/64-bits, release/debug) build - Ok

This pull request has now been integrated.

Changeset: 7b548500
Author:    Alexey Pavlyutkin <apavlyutkin at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/7b5485004616b596e38f1205be76b91aa426ef65
Stats:     23 lines in 3 files changed: 22 ins; 0 del; 1 mod

8297329: [8u] hotspot needs to recognise VS2019

Reviewed-by: phh

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/187