[jdk8u-dev] Integrated: 8242468: VS2019 build missing vcruntime140_1.dll

[Alexey Pavlyutkin]

On Wed, 23 Nov 2022 11:03:08 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Here is another backport from MSVS2019 seria. It fixes bundling of new vcruntime140_1.dll for MSVS2019 builds. The patch https://github.com/openjdk/jdk11u-dev/commit/2548ed31aeb255a61644885c501667a74f90ebc7 is applied with the following changes:
> 
> - make/CreateJmods.gmk -> SKIPPED, cuz jdk8 does not support Jmod
> - make/hotspot/test/GtestImage.gmk -> SKIPPED, cuz jdk8 does not use GTest
> - make/autoconf/basic.m4 -> common/autoconf/basics.m4 (no conflicts)
> - make/autoconf/toolchain_windows.m4 -> common/autoconf/toolchain_windows.m4 (no conflicts)
> - make/autoconf/spec.gmk.in -> common/autoconf/spec.gmk.in (no conflicts)
> - make/lib/CoreLibraries.gmk -> jdk/make/lib/CoreLibraries.gmk (no conflicts)
> - make/devkit/createWindowsDevkit2019.sh -> make/devkit/createWindowsDevkit2019.sh (no conflicts)
> - make/copy/Copy-java.base.gmk -> jdk/make/CopyFiles.gmk: at [line#276](https://github.com/openjdk/jdk8u-dev/pull/193/files#diff-5abbf26d940be8e271c3b80169ef290847b39f577dbbf6cdfed216ca13f78d03R276) jdk11 uses `TARGETS` to hold concatenated value but jdk8 uses `COPY_FILES`
> 
> Verification: MSVS2019 32/64-bit builds populate `vcrunt~1.dll`  and `vcrunt~2.dll` to JRE images, these are `vcruntime140.dll` and `vcruntime140_1.dll` accordingly (in jdk8 `configure` script renames the DLL's to avoid 8.3 conflict. I have no idea, do we still need for this).
> Regression: MSVS2017 builds populate only vcrunt~1.dll
> 
> Note: accordingly to [JDK-8247676](https://bugs.openjdk.org/browse/JDK-8247676) 32-bit builds do not need to populate new runtime library. The backport will be done on top of this one as dependent PR

This pull request has now been integrated.

Changeset: 1ec79849
Author:    Alexey Pavlyutkin <apavlyutkin at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/1ec79849c25aed9fa7f71c6316da62d1441abbaa
Stats:     1504 lines in 8 files changed: 1475 ins; 0 del; 29 mod

8242468: VS2019 build missing vcruntime140_1.dll

Reviewed-by: phh
Backport-of: 2548ed31aeb255a61644885c501667a74f90ebc7

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/193