[jdk8u-dev] RFR: 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high [v4]

Andrew John Hughes andrew at openjdk.org
Mon Dec 5 04:04:09 UTC 2022


On Fri, 4 Nov 2022 10:23:45 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of a cgroupsv2 related change for jdk8u-dev.
>> 
>> ----
>> 
>> The early implementation of cgroups v2 support was done with crun 0.8 and it contained a bug which set memory.high over memory.low when --memory-reservation was being used as a CLI option.
>> 
>> This bug has been fixed in later crun versions, starting with crun 0.11. Use memory.low in OpenJDK as well.
>> 
>> Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
>   
>   The early implementation of cgroups v2 support was done with
>   crun 0.8 and it contained a bug which set memory.high over
>   memory.low when --memory-reservation was being used as a CLI
>   option.
>   
>   This bug has been fixed in later crun versions, starting with
>   crun 0.11. Use memory.low in OpenJDK as well.
>   
>   Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc

Confirmed clean and approved.

Not sure why it needed 23 commits in this case...  :/

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/130


More information about the jdk8u-dev mailing list