[jdk8u-dev] RFR: 8237479: 8230305 causes slowdebug build failure [v5]

[Severin Gehwolf]

On Mon, 5 Dec 2022 14:21:40 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
>> 
>>  - 8237479: 8230305 causes slowdebug build failure
>>    
>>    Declare methods as pure virtual.
>>    
>>    Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76
>>  - 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
>>    
>>    The early implementation of cgroups v2 support was done with
>>    crun 0.8 and it contained a bug which set memory.high over
>>    memory.low when --memory-reservation was being used as a CLI
>>    option.
>>    
>>    This bug has been fixed in later crun versions, starting with
>>    crun 0.11. Use memory.low in OpenJDK as well.
>>    
>>    Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
>>  - Address style nit
>>  - TestCgroupSubsystemController: rework use of Files.writeString
>>  - CgroupSubsystemController: fix library paths
>>    
>>    We need the testlibrary copy of FileUtils but the test.lib.util copy of
>>    Utils (method createTempDirectory is missing from the testlib copy)
>>  - TestCgroupSubsystemController: fix jtreg @library path
>>  - Replace Arrays.compare with Arrays.equals
>>    
>>    jdk8u does not have Arrays.compare()
>>  - incorporate (part of) 8275713: TestDockerMemoryMetrics test fails on recent runc
>>    
>>    The main hunk from 8275713 was rolled up in the changes for 8231111.
>>    This line is also necessary.
>>  - update mapfile for new JNI method name
>>  - tests for the backport
>>    
>>    two files had fairly significant merge conflicts, eyeball only to resolve
>>    
>>    haven't run any of them yet -- will depend on the rest of the patch
>>  - ... and 14 more: https://git.openjdk.org/jdk8u-dev/compare/f04ad96c...463f7511
>
> I can't see what changes are actually being made here. It should just be a couple of changes to one file, not 41. Do we need to rebase or something?
> 
> It would also be good to do that so the Windows tests run.

@gnu-andrew Please have another look for 8u approval. Thank you!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/128