[jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot [v5]

[Jonathan Dowland]

On Fri, 9 Dec 2022 11:02:29 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>>> Did you run the newly added test hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java?
>> 
>> I guess not. I began the patch series running all the touched tests, but since review wasn't going to start for a while, and also some tests are known-broken until later patches are applied, I decided to focus on the non-test hunks and watch the status of test pass/fail via GHA on the "tip" of the backport effort.
>> 
>> Now that review has started I should switch to paying attention to them!
>> 
>>> It didn't work for me and required a patch like this to actually work:
>> 
>> Thanks for fixing this one. I'll look at the rest downstream of this PR.
>
> @jmtd Please add approval requests to the bug.

@jerboaa 
> Please add approval requests to the bug.

Done  — also another rebase as GitHub was showing the previous PR commit again. I'm going to try and get ahead of this and pre-emptively rebase the rest of the chain ahead of reviews. Shall I do all the fix-request labels at this point too? It looks like we've gone past the initial set of patches under consideration.

Thanks

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/135