[jdk8u-dev] RFR: 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards
Andrew John Hughes
andrew at openjdk.org
Wed Dec 14 21:46:15 UTC 2022
On Wed, 14 Dec 2022 19:58:48 GMT, Paul Hohensee <phh at openjdk.org> wrote:
> Backport for Oracle parity from 11u is not clean.
>
> 1. Copyright date mismatch in P11SecretKeyFactory.java.
> 2. XDHKeyFactory.java does not exist in 8u.
> 3. In KeyFactoryGetKeySpecForInvalidSpec.java, class FakeX509Spec does not include a (byte[], String) constructor since in 8u, X509EncodedKeySpec does not.
Patch looks good to me.
We need to make sure we follow this up with [JDK-8263404](https://bugs.openjdk.org/browse/JDK-8263404)
-------------
Marked as reviewed by andrew (Reviewer).
PR: https://git.openjdk.org/jdk8u-dev/pull/211
More information about the jdk8u-dev
mailing list