[8u] RFR: 8076190: Customizing the generation of a PKCS12 keystore

[Martin Balao]

Good, thanks.

Webrev.04 looks good to me and I've seen that the CSR is already approved.

Please request 8u-maintainers approval for this enhancement.

Regards,
Martin.-


On Tue, Feb 8, 2022 at 12:15 PM Alexey Bakhtin <alexey at azul.com> wrote:

> Hi Martin,
>
> Yes, I’ve run sun/security/tools/keytool tests. No regression found. All
> 30 tests passed.
>
> After Webrev.02, the ParamsTest fails on the first attempt to list
> certificates in the passwordless keystore.
> There were two reasons: missed “-storetype PKCS12” argument and wrong
> security provider name. The test passed only after fixes in the both
> files:  test and sun/security/tools/keytool/Main.java
>
> Regards
> Alexey
>
> > On 8 Feb 2022, at 19:23, Martin Balao <mbalao at redhat.com> wrote:
> >
> > Hi Alexey,
> >
> > Thanks for your quick response.
> >
> > Last 2 things regarding the patch (have not looked into the CSR yet):
> >
> > 1) have you checked for regressions in sun/security/tools/keytool tests
> category?
> >
> > 2) have you tested the actual passwordless feature? There must be
> failures after Webrev.02 because of the security provider checked and I'm
> not sure at this point if there were because
> 'test/sun/security/pkcs12/ParamsTest.java' never passed for a different
> reason (explicit storetype parameter).
> >
> > Thanks,
> > Martin.-
> >
>
>