[jdk8u-dev] RFR: 8194873: right ALT key hotkeys no longer work in Swing components [v4]

[Olga Mikhaltsova]

On Sat, 28 May 2022 00:22:03 GMT, Olga Mikhaltsova <omikhaltcova at openjdk.org> wrote:

>> I'd like to backport JDK-8194873 to jdk8u. The same issue is observed there.
>> The original patch for JDK-8194873 applied not cleanly due to 2 files:   
>>>  MotifLookAndFeel.java - differences in the header and in the context;
>>>  SwingUtilities2.java - difference in the context.
>> 
>> The backport for JDK-8155742
>> 
>> 8155742: [Windows] robot.keyPress(KeyEvent.VK_ALT_GRAPH) throws java.lang.IllegalArgumentException in windows
>> 
>> was included as a part of this patch due to dependency on it of the regression test "jdk/test/javax/swing/event/RightAltKeyTest.java" included into the patch for JDK-8194873 (this test fails without the patch for JDK-8155742 as was pointed out below by Anton Litvinov).
>> The original patch For JDK-8155742 applied not cleanly due to 1 file:
>>> AltGraphModifierTest.java - differences in the header and slight in the context.
>> 
>> Tested on Windows. All regular tests passed.
>
> Olga Mikhaltsova has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Backport 08482543b496efa11dc8084a14a831799de60a93

Anton, thanks for the hint and the valuable explanation!
I reran ModifierRobotKeyTest.java and AltGraphModifierTest.java (modified by JDK-8155742) on Windows, MacOS and Linux. Before the fix they fail for all platforms. After the fix they pass only for Windows (JDK-8155742 was opened only for Windows). Your experience mentioned above does not inspire me with much optimism on this way but obviously additional investigation is needed how to fix these tests' failures on MacOS and Linux.
Concerning RightAltKeyTest.java it fails before this fix and passes after.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/60